On 15.09.2023 22:31, Kyle Swanson wrote:
Hi,

On Thu, Sep 14, 2023 at 12:10 PM Timo Rothenpieler
<t...@rothenpieler.org> wrote:
This looks more complicated than necessary to me.

My idea would have been to change, in the previous original patch,

  > libvmaf_cuda_filter_deps="libvmaf ffnvcodec"

to

  > libvmaf_cuda_filter_deps="libvmaf libvmaf_cuda ffnvcodec"


And the pkg_config check would then enable/disable libvmaf_cuda:

enabled libvmaf_cuda      && require_pkg_config libvmaf_cuda "libvmaf >= 2.0.0" 
libvmaf_cuda.h vmaf_cuda_state_init


I'm not sure this works since `libvmaf_cuda` is not a separate
library. `libvmaf_cuda` is the name of the avfilter, which requires a
`libvmaf` configured/built with cuda support.

I don't see why it wouldn't work. It doesn't matter what it is, it's just the name of the dependency.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to