Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-07-02 Thread Michael Niedermayer
On Fri, Jun 30, 2023 at 11:51:21PM +0200, Tomas Härdin wrote: > tor 2023-06-29 klockan 09:14 +0200 skrev Nicolas George: > > Tomas Härdin (12023-06-29): [...] > I am perfectly capable of writing an XML parser, potentially a formally > correct one. But more importantly I am capable of understanding

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-07-02 Thread Stefano Sabatini
On date Sunday 2023-06-25 12:49:05 +0200, Marvin Scholz wrote: > This new API allows to remove an entry and obtain ownership of the > key/value that was associated with the removed entry. > --- > > Changes since v1: > - Clarify documentation about av_free having to be used. > - Fix fate test to no

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/tee: use av_dict_pop

2023-07-02 Thread Stefano Sabatini
On date Sunday 2023-06-25 12:49:06 +0200, Marvin Scholz wrote: > This is a well-defined way to "steal" the value of the dict entry. > --- > libavformat/tee.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavformat/tee.c b/libavformat/tee.c > index cb555f52fd.

Re: [FFmpeg-devel] [PATCH v2 3/3] avutil/dict: constify av_dict_get return

2023-07-02 Thread Stefano Sabatini
On date Sunday 2023-06-25 12:49:07 +0200, Marvin Scholz wrote: > --- > doc/examples/qsv_transcode.c | 2 +- > libavcodec/libaomenc.c | 2 +- > libavcodec/libkvazaar.c| 2 +- > libavcodec/libsvtav1.c | 2 +- > libavcodec/libvpxenc.c | 2 +-

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-07-02 Thread Paul B Mahol
Will apply this soon as there are no more comments. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscrib

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Tomas Härdin (12023-07-01): > Just start a separate project or contribute to GNU Radio or osmocom or > whatever. How is this so difficult to grasp? Yeah, handling a separate project and maintaining a separate built system is the best use of the limited time of one of the best hackers in the FFmpeg

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Tomas Härdin (12023-06-30): > Factually incorrect. libxml2 provides what we need. libexpat would also > be acceptable. In fact providing that option may be useful to > packagers. Do you consider these to be system libraries? > ABI and API stability are Pretty Fucking Important. This attitude alon

Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of frames" in IVF header

2023-07-02 Thread Anton Khirnov
Quoting Ronald S. Bultje (2023-07-02 02:03:11) > I see this discussion now... > > I don't think I agree with the above. First of all, IVF has two fields > there (it seems): duration, and n_frames. Got any source for that? I only see one field in https://wiki.multimedia.cx/index.php/Duck_IVF --

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Michael Niedermayer (12023-06-30): > And if we could put it in git master then people could work together to > build the libavradio out of it as we all want. > > Such collaboration is kind of one of the reasons of having a "git master" I want you to continue writing your great code where it is th

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-07-02 Thread Tomas Härdin
sön 2023-07-02 klockan 11:34 +0200 skrev Nicolas George: > Tomas Härdin (12023-06-30): > > Factually incorrect. libxml2 provides what we need. libexpat would > > also > > be acceptable. In fact providing that option may be useful to > > packagers. > > Do you consider these to be system libraries?

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Tomas Härdin (12023-07-02): > On Debian these are provided by apt same as all other libraries > including libc, so yes. By this reasoning, xbill would be considered a system library. Try again. -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Martin Storsjo (12023-07-01): > As numerous others have said already, this is at the wrong level of > abstraction, even if it happens to work for you for the current use case. Then say what yopu think is the right level. > Even if it is disabled by default, git master isn't a playground for > per

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Paul B Mahol
On Sun, Jul 2, 2023 at 11:40 AM Nicolas George wrote: > Michael Niedermayer (12023-06-30): > > And if we could put it in git master then people could work together to > > build the libavradio out of it as we all want. > > > > Such collaboration is kind of one of the reasons of having a "git maste

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Paul B Mahol
On Sun, Jul 2, 2023 at 11:58 AM Nicolas George wrote: > Martin Storsjo (12023-07-01): > > As numerous others have said already, this is at the wrong level of > > abstraction, even if it happens to work for you for the current use case. > > Then say what yopu think is the right level. > > > Even i

[FFmpeg-devel] [PATCH] cbs_h266: fix sign for pps_xxx_qp_offset_list

2023-07-02 Thread Nuo Mi
--- libavcodec/cbs_h266.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index 9e823919af..e33d08a0f5 100644 --- a/libavcodec/cbs_h266.h +++ b/libavcodec/cbs_h266.h @@ -520,9 +520,9 @@ typedef struct H266RawPPS { uint8_t

[FFmpeg-devel] [PATCH] cbs_h266: fix typo for ols_mode_idc == 2

2023-07-02 Thread Nuo Mi
--- libavcodec/cbs_h266_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index f1cd45f815..ae44565a54 100644 --- a/libavcodec/cbs_h266_syntax_template.c +++ b/libavcodec/cbs_h266_syn

Re: [FFmpeg-devel] [PATCH 00/15] avfilter/vf_bwdif: Add aarch64 neon functions

2023-07-02 Thread John Cox
Hi >On Thu, 29 Jun 2023, John Cox wrote: > >> Also adds a filter_line3 method which on aarch64 neon yields approx 30% >> speedup over 2xfilter_line and a memcpy >> >> John Cox (15): >> avfilter/vf_bwdif: Add outline for aarch neon functions >> avfilter/vf_bwdif: Add common macros and consts for

Re: [FFmpeg-devel] [PATCH 02/15] avfilter/vf_bwdif: Add common macros and consts for aarch64 neon

2023-07-02 Thread John Cox
On Sun, 2 Jul 2023 00:35:14 +0300 (EEST), you wrote: >On Thu, 29 Jun 2023, John Cox wrote: > >> Add macros for dual scalar half->single multiply and accumulate >> Add macro for shift, saturate and shorten single to byte >> Add filter constants >> >> Signed-off-by: John Cox >> --- >> libavfilter/a

Re: [FFmpeg-devel] [PATCH 04/15] avfilter/vf_bwdif: Add neon for filter_intra

2023-07-02 Thread John Cox
On Sun, 2 Jul 2023 00:37:35 +0300 (EEST), you wrote: >On Thu, 29 Jun 2023, John Cox wrote: > >> Signed-off-by: John Cox >> --- >> libavfilter/aarch64/vf_bwdif_init_aarch64.c | 17 +++ >> libavfilter/aarch64/vf_bwdif_neon.S | 53 + >> 2 files changed, 70 insertions(+)

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Jean-Baptiste Kempf
On Sun, 2 Jul 2023, at 11:58, Nicolas George wrote: >> Even if it is disabled by default, git master isn't a playground for >> personal projects. > > Yes it is. Absolutely not. You are the only one who believes that. -- Jean-Baptiste Kempf - President +33 672 704 734 __

Re: [FFmpeg-devel] [PATCH 08/15] avfilter/vf_bwdif: Add neon for filter_edge

2023-07-02 Thread John Cox
On Sun, 2 Jul 2023 00:40:09 +0300 (EEST), you wrote: >On Thu, 29 Jun 2023, John Cox wrote: > >> Signed-off-by: John Cox >> --- >> libavfilter/aarch64/vf_bwdif_init_aarch64.c | 20 >> libavfilter/aarch64/vf_bwdif_neon.S | 104 >> 2 files changed, 124 insertions(+)

Re: [FFmpeg-devel] [PATCH 11/15] avfilter/vf_bwdif: Add neon for filter_line

2023-07-02 Thread John Cox
On Sun, 2 Jul 2023 00:44:10 +0300 (EEST), you wrote: >On Thu, 29 Jun 2023, John Cox wrote: > >> Signed-off-by: John Cox >> --- >> libavfilter/aarch64/vf_bwdif_init_aarch64.c | 21 ++ >> libavfilter/aarch64/vf_bwdif_neon.S | 215 >> 2 files changed, 236 insertions(+) >>

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Michael Niedermayer
On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote: > On Fri, 30 Jun 2023, at 16:08, Michael Niedermayer wrote: > > Also as said previously, If there is at least a 2nd developer working > > on this then we could & should move this to a seperate libraray (libavradio) > > Why wait f

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-07-02 Thread Marvin Scholz
On 2 Jul 2023, at 10:43, Stefano Sabatini wrote: > On date Sunday 2023-06-25 12:49:05 +0200, Marvin Scholz wrote: >> This new API allows to remove an entry and obtain ownership of the >> key/value that was associated with the removed entry. >> --- >> >> Changes since v1: >> - Clarify documentation

[FFmpeg-devel] [PATCH v2 00/15] avfilter/vf_bwdif: Add aarch64 neon functions

2023-07-02 Thread John Cox
Also adds a filter_line3 method which on aarch64 neon yields approx 30% speedup over 2xfilter_line and a memcpy Differences from v1: .align 16 corrected to .balign 16 SXTW tolower Mac ABI (hopefully) fixed V register pop/push macroed & prettified John Cox (15): avfilter/vf_bwdif: Add outline fo

[FFmpeg-devel] [PATCH v2 01/15] avfilter/vf_bwdif: Add outline for aarch neon functions

2023-07-02 Thread John Cox
Outline but no actual functions. Signed-off-by: John Cox --- libavfilter/aarch64/Makefile| 2 ++ libavfilter/aarch64/vf_bwdif_init_aarch64.c | 39 + libavfilter/aarch64/vf_bwdif_neon.S | 25 + libavfilter/bwdif.h |

[FFmpeg-devel] [PATCH v2 02/15] avfilter/vf_bwdif: Add common macros and consts for aarch64 neon

2023-07-02 Thread John Cox
Add macros for dual scalar half->single multiply and accumulate Add macro for shift, saturate and shorten single to byte Add filter constants Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_neon.S | 53 + 1 file changed, 53 insertions(+) diff --git a/libavfi

[FFmpeg-devel] [PATCH v2 03/15] avfilter/vf_bwdif: Export C filter_intra

2023-07-02 Thread John Cox
Needed for tail fixup of neon code Signed-off-by: John Cox --- libavfilter/bwdif.h| 3 +++ libavfilter/vf_bwdif.c | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavfilter/bwdif.h b/libavfilter/bwdif.h index 6a0f70487a..ae6f6ce223 100644 --- a/libavfilter/bwdif.h

[FFmpeg-devel] [PATCH v2 04/15] avfilter/vf_bwdif: Add neon for filter_intra

2023-07-02 Thread John Cox
Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 17 +++ libavfilter/aarch64/vf_bwdif_neon.S | 53 + 2 files changed, 70 insertions(+) diff --git a/libavfilter/aarch64/vf_bwdif_init_aarch64.c b/libavfilter/aarch64/vf_bwdif_init_aarch64.c

[FFmpeg-devel] [PATCH v2 08/15] avfilter/vf_bwdif: Add neon for filter_edge

2023-07-02 Thread John Cox
Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 20 libavfilter/aarch64/vf_bwdif_neon.S | 104 2 files changed, 124 insertions(+) diff --git a/libavfilter/aarch64/vf_bwdif_init_aarch64.c b/libavfilter/aarch64/vf_bwdif_init_aarch64.c i

[FFmpeg-devel] [PATCH v2 09/15] tests/checkasm: Add test for vf_bwdif filter_edge

2023-07-02 Thread John Cox
Signed-off-by: John Cox --- tests/checkasm/vf_bwdif.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/tests/checkasm/vf_bwdif.c b/tests/checkasm/vf_bwdif.c index 034bbabb4c..5fdba09fdc 100644 --- a/tests/checkasm/vf_bwdif.c +++ b/tests/checkasm/vf_bwdi

[FFmpeg-devel] [PATCH v2 05/15] tests/checkasm: Add test for vf_bwdif filter_intra

2023-07-02 Thread John Cox
Signed-off-by: John Cox --- tests/checkasm/vf_bwdif.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/checkasm/vf_bwdif.c b/tests/checkasm/vf_bwdif.c index 46224bb575..034bbabb4c 100644 --- a/tests/checkasm/vf_bwdif.c +++ b/tests/checkasm/vf_bwdif.

[FFmpeg-devel] [PATCH v2 06/15] avfilter/vf_bwdif: Add clip and spatial macros for aarch64 neon

2023-07-02 Thread John Cox
Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_neon.S | 73 + 1 file changed, 73 insertions(+) diff --git a/libavfilter/aarch64/vf_bwdif_neon.S b/libavfilter/aarch64/vf_bwdif_neon.S index 6a614f8d6e..48dc7bcd9d 100644 --- a/libavfilter/aarch64/vf_bwdif_neon

[FFmpeg-devel] [PATCH v2 10/15] avfilter/vf_bwdif: Export C filter_line

2023-07-02 Thread John Cox
Needed for tail fixup of neon code Signed-off-by: John Cox --- libavfilter/bwdif.h| 5 + libavfilter/vf_bwdif.c | 10 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/libavfilter/bwdif.h b/libavfilter/bwdif.h index ae1616d366..cce99953f3 100644 --- a/libavfilte

[FFmpeg-devel] [PATCH v2 07/15] avfilter/vf_bwdif: Export C filter_edge

2023-07-02 Thread John Cox
Needed for tail fixup of neon code Signed-off-by: John Cox --- libavfilter/bwdif.h| 4 libavfilter/vf_bwdif.c | 8 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libavfilter/bwdif.h b/libavfilter/bwdif.h index ae6f6ce223..ae1616d366 100644 --- a/libavfilter/bwdi

[FFmpeg-devel] [PATCH v2 11/15] avfilter/vf_bwdif: Add neon for filter_line

2023-07-02 Thread John Cox
Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 21 ++ libavfilter/aarch64/vf_bwdif_neon.S | 208 2 files changed, 229 insertions(+) diff --git a/libavfilter/aarch64/vf_bwdif_init_aarch64.c b/libavfilter/aarch64/vf_bwdif_init_aarch64.c ind

[FFmpeg-devel] [PATCH v2 12/15] avfilter/vf_bwdif: Add a filter_line3 method for optimisation

2023-07-02 Thread John Cox
Add an optional filter_line3 to the available optimisations. filter_line3 is equivalent to filter_line, memcpy, filter_line filter_line shares quite a number of loads and some calculations in common with its next iteration and testing shows that using aarch64 neon filter_line3s performance is 30%

[FFmpeg-devel] [PATCH v2 13/15] avfilter/vf_bwdif: Add neon for filter_line3

2023-07-02 Thread John Cox
Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 28 ++ libavfilter/aarch64/vf_bwdif_neon.S | 272 2 files changed, 300 insertions(+) diff --git a/libavfilter/aarch64/vf_bwdif_init_aarch64.c b/libavfilter/aarch64/vf_bwdif_init_aarch64.c ind

[FFmpeg-devel] [PATCH v2 14/15] tests/checkasm: Add test for vf_bwdif filter_line3

2023-07-02 Thread John Cox
Signed-off-by: John Cox --- tests/checkasm/vf_bwdif.c | 81 +++ 1 file changed, 81 insertions(+) diff --git a/tests/checkasm/vf_bwdif.c b/tests/checkasm/vf_bwdif.c index 5fdba09fdc..3399cacdf7 100644 --- a/tests/checkasm/vf_bwdif.c +++ b/tests/checkasm/vf_bwdi

[FFmpeg-devel] [PATCH v2 15/15] avfilter/vf_bwdif: Block filter slices into a multiple of 4 lines

2023-07-02 Thread John Cox
Round job start lines down to a multiple of 4. This means that if filter_line3 exists then filter_line will not sometimes be called once at the end of a slice depending on thread count. The final slice may do up to 3 extra lines but filter_edge is faster than filter_line so it is unlikely to create

Re: [FFmpeg-devel] [PATCH] cbs_h266: fix sign for pps_xxx_qp_offset_list

2023-07-02 Thread James Almer
On 7/2/2023 7:15 AM, Nuo Mi wrote: --- libavcodec/cbs_h266.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index 9e823919af..e33d08a0f5 100644 --- a/libavcodec/cbs_h266.h +++ b/libavcodec/cbs_h266.h @@ -520,9 +520,9 @@ t

Re: [FFmpeg-devel] [PATCH] cbs_h266: fix typo for ols_mode_idc == 2

2023-07-02 Thread James Almer
On 7/2/2023 7:15 AM, Nuo Mi wrote: --- libavcodec/cbs_h266_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index f1cd45f815..ae44565a54 100644 --- a/libavcodec/cbs_h266_syntax_t

Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of frames" in IVF header

2023-07-02 Thread Ronald S. Bultje
Hi, On Sun, Jul 2, 2023 at 5:35 AM Anton Khirnov wrote: > Quoting Ronald S. Bultje (2023-07-02 02:03:11) > > I see this discussion now... > > > > I don't think I agree with the above. First of all, IVF has two fields > > there (it seems): duration, and n_frames. > > Got any source for that? I on

Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of frames" in IVF header

2023-07-02 Thread Anton Khirnov
Quoting Ronald S. Bultje (2023-07-02 14:44:42) > Hi, > > On Sun, Jul 2, 2023 at 5:35 AM Anton Khirnov wrote: > > > Quoting Ronald S. Bultje (2023-07-02 02:03:11) > > > I see this discussion now... > > > > > > I don't think I agree with the above. First of all, IVF has two fields > > > there (it

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/cbs_h2645: fix parsing and storing Picture Header references in the context

2023-07-02 Thread James Almer
On 7/1/2023 10:06 PM, Nuo Mi wrote: On Sun, Jul 2, 2023 at 7:32 AM James Almer wrote: On 7/1/2023 8:51 AM, Nuo Mi wrote: On Fri, Jun 30, 2023 at 6:45 AM James Almer wrote: Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 35 --- libavcodec

[FFmpeg-devel] [PATCH] avcodec/cbs_h266: don't infer derived values

2023-07-02 Thread James Almer
The macro is meant for coded values only. Signed-off-by: James Almer --- libavcodec/cbs_h266_syntax_template.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index ae44565a54..957735056f 100

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Rémi Denis-Courmont
Hi, Le 2 juillet 2023 13:08:54 GMT+03:00, Paul B Mahol a écrit : >On Sun, Jul 2, 2023 at 11:40 AM Nicolas George wrote: > >> Michael Niedermayer (12023-06-30): >> > And if we could put it in git master then people could work together to >> > build the libavradio out of it as we all want. >> > >>

Re: [FFmpeg-devel] [PATCH v2 06/15] avfilter/vf_bwdif: Add clip and spatial macros for aarch64 neon

2023-07-02 Thread Lynne
Jul 2, 2023, 14:34 by j...@kynesim.co.uk: > Signed-off-by: John Cox > --- > libavfilter/aarch64/vf_bwdif_neon.S | 73 + > 1 file changed, 73 insertions(+) > > diff --git a/libavfilter/aarch64/vf_bwdif_neon.S > b/libavfilter/aarch64/vf_bwdif_neon.S > index 6a614f8d6e.

Re: [FFmpeg-devel] [PATCH v2 06/15] avfilter/vf_bwdif: Add clip and spatial macros for aarch64 neon

2023-07-02 Thread Kieran Kunhya
On Sun, 2 Jul 2023, 16:02 Lynne wrote: > > Also, keep in mind the final spatial clip at the end should be > removable. I discovered it makes the filter look quite a lot > better. Currently, only the Vulkan version does it, but we're > looking into changing the C/asm versions too, and you're the >

Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of frames" in IVF header

2023-07-02 Thread Ronald S. Bultje
Hi, On Sun, Jul 2, 2023 at 8:59 AM Anton Khirnov wrote: > Quoting Ronald S. Bultje (2023-07-02 14:44:42) > > Hi, > > > > On Sun, Jul 2, 2023 at 5:35 AM Anton Khirnov wrote: > > > > > Quoting Ronald S. Bultje (2023-07-02 02:03:11) > > > > I see this discussion now... > > > > > > > > I don't thin

[FFmpeg-devel] [PATCH] Add SMC vsynth tests

2023-07-02 Thread Tomas Härdin
From 121890df70fe77a646527df71c5a15cb74e24543 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Sun, 2 Jul 2023 16:58:11 +0200 Subject: [PATCH] Add SMC vsynth tests --- tests/fate/vcodec.mak| 3 +++ tests/ref/vsynth/vsynth1-smc | 4 tests/ref/vsynth/vsynt

Re: [FFmpeg-devel] [PATCH] Add SMC vsynth tests

2023-07-02 Thread James Almer
On 7/2/2023 12:28 PM, Tomas Härdin wrote: --- tests/fate/vcodec.mak| 3 +++ tests/ref/vsynth/vsynth1-smc | 4 tests/ref/vsynth/vsynth2-smc | 4 tests/ref/vsynth/vsynth3-smc | 4 tests/ref/vsynth/vsynth_lena-smc | 4 5 files changed, 19 insertions(+)

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Rémi Denis-Courmont (12023-07-02): > Otherwise it's not offensive and inflammatory. Rather it's insulting and > defamatory. “Bean counter” was derogatory, but against an attitude like yours, not against a matter of lower of higher. This kind of strategy to assassinate my character is not very ho

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Jean-Baptiste Kempf (12023-07-02): > Absolutely not. > You are the only one who believes that. Except for the person who created FFmpeg in the first place. And probably other people too. Most great Libre Software projects are hackers playgrounds first. They become immensely useful as a byproduct.

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Michael Niedermayer (12023-07-02): > as libavradio so far has been the only actionable suggestion. > ill move the code to that and next revission or the one after that > will be in libavradio. Please only do that if it makes working on the code easier for you. These people will not take concessio

Re: [FFmpeg-devel] [PATCH v3 1/2] decklink: move queue_size to an argument for ff_decklink_packet_queue_init

2023-07-02 Thread Marton Balint
On Fri, 30 Jun 2023, Devin Heitmueller wrote: The existing queue initialization function would always sets it's maximum queue size to ctx->queue_size. But because we are introducing more queues we may want the sizes to differ between them. Move the specification of the queue size into an ar

Re: [FFmpeg-devel] [PATCH] Add SMC vsynth tests

2023-07-02 Thread Tomas Härdin
sön 2023-07-02 klockan 12:49 -0300 skrev James Almer: > On 7/2/2023 12:28 PM, Tomas Härdin wrote: > > > > --- > >  tests/fate/vcodec.mak    | 3 +++ > >  tests/ref/vsynth/vsynth1-smc | 4 > >  tests/ref/vsynth/vsynth2-smc | 4 > >  tests/ref/vsynth/vsynth3-smc | 4 >

Re: [FFmpeg-devel] [PATCH] Add SMC vsynth tests

2023-07-02 Thread Tomas Härdin
sön 2023-07-02 klockan 18:36 +0200 skrev Tomas Härdin: > sön 2023-07-02 klockan 12:49 -0300 skrev James Almer: > > On 7/2/2023 12:28 PM, Tomas Härdin wrote: > > > > > > --- > > >  tests/fate/vcodec.mak    | 3 +++ > > >  tests/ref/vsynth/vsynth1-smc | 4 > > >  tests/ref/vsynth/vsyn

[FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Lynne
The issue is that clipping the interpolated temporal sample against the spatially predicted sample causes artifacts to appear. Discovered while writing the Vulkan version (where I omitted the same check). The clipping in the code is carried over from yadif. Removing the same code in yadif does no

Re: [FFmpeg-devel] [PATCH v2 06/15] avfilter/vf_bwdif: Add clip and spatial macros for aarch64 neon

2023-07-02 Thread Lynne
Jul 2, 2023, 16:09 by kier...@obe.tv: > On Sun, 2 Jul 2023, 16:02 Lynne wrote: > >> >> Also, keep in mind the final spatial clip at the end should be >> removable. I discovered it makes the filter look quite a lot >> better. Currently, only the Vulkan version does it, but we're >> looking into ch

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Lynne
Jul 2, 2023, 18:54 by d...@lynne.ee: > The issue is that clipping the interpolated temporal sample against > the spatially predicted sample causes artifacts to appear. > > Discovered while writing the Vulkan version (where I omitted the > same check). > > The clipping in the code is carried over f

Re: [FFmpeg-devel] [PATCH v3 2/2] decklink_enc: add support for SMPTE 2038 VANC packet output

2023-07-02 Thread Marton Balint
On Fri, 30 Jun 2023, Devin Heitmueller wrote: Support decoding and embedding VANC packets delivered via SMPTE 2038 into the SDI output. We leverage an intermediate queue because data packets are announced separately from video but we need to embed the data into the video frame when it is out

Re: [FFmpeg-devel] [PATCH v2 12/15] avfilter/vf_bwdif: Add a filter_line3 method for optimisation

2023-07-02 Thread Thomas Mundt
Am So., 2. Juli 2023 um 14:34 Uhr schrieb John Cox : > Add an optional filter_line3 to the available optimisations. > > filter_line3 is equivalent to filter_line, memcpy, filter_line > > filter_line shares quite a number of loads and some calculations in > common with its next iteration and testin

Re: [FFmpeg-devel] [PATCH v2 1/7] libavcodec: Preserve AFD side data when going from AVPacket to AVFrame

2023-07-02 Thread Marton Balint
On Fri, 30 Jun 2023, Devin Heitmueller wrote: This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Will apply. Thanks, Marton Signed-off-by: Devin Heitmueller --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: ignore picture start code in extradata for AVID mpeg2 files

2023-07-02 Thread Marton Balint
On Tue, 27 Jun 2023, Marton Balint wrote: AVID IMX MPEG2 files in MOV seems to have extradata like this: : 0018 4143 4c52 4143 4c52 3030 3031 ACLRACLR0001 0010: 0001 Will apply. Regards, Marton Signed-off-by: Marton Bal

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Jean-Baptiste Kempf
On Sun, 2 Jul 2023, at 18:07, Nicolas George wrote: > Jean-Baptiste Kempf (12023-07-02): >> Absolutely not. >> You are the only one who believes that. > > Except for the person who created FFmpeg in the first place. And probably > other people too. Having talked to Fabrice lately, I didn’t get th

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Jean-Baptiste Kempf (12023-07-02): > Unfortunately, for both questions, I think you are in the minority. > But if you want, we can call an AG vote. You can do so, but be sure to write the question in the way things will happen: “Do you want to continue making FFmpeg a hostile place for hackers wh

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Rémi Denis-Courmont
Le 2 juillet 2023 19:01:41 GMT+03:00, Nicolas George a écrit : >Rémi Denis-Courmont (12023-07-02): >> Otherwise it's not offensive and inflammatory. Rather it's insulting and >> defamatory. > >“Bean counter” was derogatory, So you admit to insulting not just me but a whole bunch of other peopl

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Michael Niedermayer
On Sun, Jul 02, 2023 at 08:20:03PM +0200, Nicolas George wrote: [...] > It would be 100% legal and within the rules, but stealing nonetheless. > Michael is a thousand times more FFmpeg than you. iam nothing like that and i really dont like how this thread degenerates into increasingly offensive la

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Thomas Mundt
Am So., 2. Juli 2023 um 18:57 Uhr schrieb Lynne : > Jul 2, 2023, 18:54 by d...@lynne.ee: > > > The issue is that clipping the interpolated temporal sample against > > the spatially predicted sample causes artifacts to appear. > > > > Discovered while writing the Vulkan version (where I omitted the

[FFmpeg-devel] [PATCH] avdevice/decklink_enc: use 64bit format string for BMD timebase instead of long long

2023-07-02 Thread Marton Balint
BMDTimeValue is defined as LONGLONG on Windows, but int64_t on Linux/Mac. Fixes format string warnings: libavdevice/decklink_enc.cpp: In function ‘void construct_cc(AVFormatContext*, decklink_ctx*, AVPacket*, klvanc_line_set_s*)’: libavdevice/decklink_enc.cpp:424:48: warning: format ‘%lld’ expec

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Paul B Mahol
On Sun, Jul 2, 2023 at 6:57 PM Lynne wrote: > Jul 2, 2023, 18:54 by d...@lynne.ee: > > > The issue is that clipping the interpolated temporal sample against > > the spatially predicted sample causes artifacts to appear. > > > > Discovered while writing the Vulkan version (where I omitted the > >

Re: [FFmpeg-devel] [PATCH] Add SMC vsynth tests

2023-07-02 Thread Paul B Mahol
On Sun, Jul 2, 2023 at 6:39 PM Tomas Härdin wrote: > sön 2023-07-02 klockan 18:36 +0200 skrev Tomas Härdin: > > sön 2023-07-02 klockan 12:49 -0300 skrev James Almer: > > > On 7/2/2023 12:28 PM, Tomas Härdin wrote: > > > > > > > > --- > > > > tests/fate/vcodec.mak| 3 +++ > > > > test

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Lynne
Jul 2, 2023, 18:08 by geo...@nsup.org: > Jean-Baptiste Kempf (12023-07-02): > >> Absolutely not. >> You are the only one who believes that. >> > > Except for the person who created FFmpeg in the first place. And > probably other people too. > > Most great Libre Software projects are hackers playgr

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Lynne
Jul 2, 2023, 13:01 by mich...@niedermayer.cc: > On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote: > >> On Fri, 30 Jun 2023, at 16:08, Michael Niedermayer wrote: >> > Also as said previously, If there is at least a 2nd developer working >> > on this then we could & should move th

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Lynne
Jul 2, 2023, 20:41 by tmund...@gmail.com: > Am So., 2. Juli 2023 um 18:57 Uhr schrieb Lynne : > >> Jul 2, 2023, 18:54 by d...@lynne.ee: >> >> > The issue is that clipping the interpolated temporal sample against >> > the spatially predicted sample causes artifacts to appear. >> > >> > Discovered w

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Lynne
Jul 2, 2023, 20:48 by one...@gmail.com: > On Sun, Jul 2, 2023 at 6:57 PM Lynne wrote: > >> Jul 2, 2023, 18:54 by d...@lynne.ee: >> >> > The issue is that clipping the interpolated temporal sample against >> > the spatially predicted sample causes artifacts to appear. >> > >> > Discovered while wr

Re: [FFmpeg-devel] [PATCH] Add SMC vsynth tests

2023-07-02 Thread Tomas Härdin
sön 2023-07-02 klockan 20:57 +0200 skrev Paul B Mahol: > On Sun, Jul 2, 2023 at 6:39 PM Tomas Härdin wrote: > > > sön 2023-07-02 klockan 18:36 +0200 skrev Tomas Härdin: > > > sön 2023-07-02 klockan 12:49 -0300 skrev James Almer: > > > > On 7/2/2023 12:28 PM, Tomas Härdin wrote: > > > > > > > > >

[FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-02 Thread Marton Balint
It should be OK to use av_get_random_seed() to generate the key instead of using openSSL/Gcrypt functions. This removes the hard dependancy of those libs for key generation functionality. Fixes ticket #10441. Signed-off-by: Marton Balint --- libavformat/hlsenc.c | 18 -- 1 file

[FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: remove openssl/gcrypt random key generation

2023-07-02 Thread Marton Balint
av_get_random_seed() should be sufficent and that is used everywhere in the codebase for similar cases. Signed-off-by: Marton Balint --- configure| 1 - libavformat/hlsenc.c | 13 - 2 files changed, 14 deletions(-) diff --git a/configure b/configure index 107d533b3e..b3

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Paul B Mahol
On Sun, Jul 2, 2023 at 9:13 PM Lynne wrote: > Jul 2, 2023, 20:48 by one...@gmail.com: > > > On Sun, Jul 2, 2023 at 6:57 PM Lynne wrote: > > > >> Jul 2, 2023, 18:54 by d...@lynne.ee: > >> > >> > The issue is that clipping the interpolated temporal sample against > >> > the spatially predicted sam

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Nicolas George
Lynne (12023-07-02): > git master is not a playground, but it is certainly a place for developers > to experiment with ideas they're *seriously* exploring. > > Sonic and Snow were experiments. They didn't work out, but nevertheless, > they made their mark on the status quo of compression research

Re: [FFmpeg-devel] [PATCH 02/15] avfilter/vf_bwdif: Add common macros and consts for aarch64 neon

2023-07-02 Thread Martin Storsjö
On Sun, 2 Jul 2023, John Cox wrote: On Sun, 2 Jul 2023 00:35:14 +0300 (EEST), you wrote: On Thu, 29 Jun 2023, John Cox wrote: Add macros for dual scalar half->single multiply and accumulate Add macro for shift, saturate and shorten single to byte Add filter constants Signed-off-by: John Cox

Re: [FFmpeg-devel] [PATCH 04/15] avfilter/vf_bwdif: Add neon for filter_intra

2023-07-02 Thread Martin Storsjö
On Sun, 2 Jul 2023, John Cox wrote: On Sun, 2 Jul 2023 00:37:35 +0300 (EEST), you wrote: + +uaddl v20.8h, v31.8b, v30.8b +uaddl2 v21.8h, v31.16b, v30.16b + +UMULL4K v2, v3, v4, v5, v20, v21, v0.h[6] + +uaddl v20.8h, v29.8

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Lynne
Jul 2, 2023, 21:38 by one...@gmail.com: > On Sun, Jul 2, 2023 at 9:13 PM Lynne wrote: > >> Jul 2, 2023, 20:48 by one...@gmail.com: >> >> > On Sun, Jul 2, 2023 at 6:57 PM Lynne wrote: >> > >> >> Jul 2, 2023, 18:54 by d...@lynne.ee: >> >> >> >> > The issue is that clipping the interpolated tempora

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Lynne
Jul 2, 2023, 21:52 by geo...@nsup.org: > Lynne (12023-07-02): > >> git master is not a playground, but it is certainly a place for developers >> to experiment with ideas they're *seriously* exploring. >> >> Sonic and Snow were experiments. They didn't work out, but nevertheless, >> they made their

Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping

2023-07-02 Thread Paul B Mahol
On Sun, Jul 2, 2023 at 10:25 PM Lynne wrote: > Jul 2, 2023, 21:38 by one...@gmail.com: > > > On Sun, Jul 2, 2023 at 9:13 PM Lynne wrote: > > > >> Jul 2, 2023, 20:48 by one...@gmail.com: > >> > >> > On Sun, Jul 2, 2023 at 6:57 PM Lynne wrote: > >> > > >> >> Jul 2, 2023, 18:54 by d...@lynne.ee: >

Re: [FFmpeg-devel] [PATCH 08/15] avfilter/vf_bwdif: Add neon for filter_edge

2023-07-02 Thread Martin Storsjö
On Sun, 2 Jul 2023, John Cox wrote: On Sun, 2 Jul 2023 00:40:09 +0300 (EEST), you wrote: On Thu, 29 Jun 2023, John Cox wrote: Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 20 libavfilter/aarch64/vf_bwdif_neon.S | 104 2 files cha

Re: [FFmpeg-devel] [PATCH 11/15] avfilter/vf_bwdif: Add neon for filter_line

2023-07-02 Thread Martin Storsjö
On Sun, 2 Jul 2023, John Cox wrote: On Sun, 2 Jul 2023 00:44:10 +0300 (EEST), you wrote: On Thu, 29 Jun 2023, John Cox wrote: Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 21 ++ libavfilter/aarch64/vf_bwdif_neon.S | 215 2 files chang

Re: [FFmpeg-devel] [PATCH 02/15] avfilter/vf_bwdif: Add common macros and consts for aarch64 neon

2023-07-02 Thread Martin Storsjö
On Sun, 2 Jul 2023, Martin Storsjö wrote: On Sun, 2 Jul 2023, John Cox wrote: On Sun, 2 Jul 2023 00:35:14 +0300 (EEST), you wrote: On Thu, 29 Jun 2023, John Cox wrote: Add macros for dual scalar half->single multiply and accumulate Add macro for shift, saturate and shorten single to byte A

Re: [FFmpeg-devel] [PATCH v2 02/15] avfilter/vf_bwdif: Add common macros and consts for aarch64 neon

2023-07-02 Thread Martin Storsjö
On Sun, 2 Jul 2023, John Cox wrote: Add macros for dual scalar half->single multiply and accumulate Add macro for shift, saturate and shorten single to byte Add filter constants Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_neon.S | 53 + 1 file changed, 5

Re: [FFmpeg-devel] [PATCH v2 00/15] avfilter/vf_bwdif: Add aarch64 neon functions

2023-07-02 Thread Martin Storsjö
On Sun, 2 Jul 2023, John Cox wrote: Also adds a filter_line3 method which on aarch64 neon yields approx 30% speedup over 2xfilter_line and a memcpy Differences from v1: .align 16 corrected to .balign 16 SXTW tolower Mac ABI (hopefully) fixed V register pop/push macroed & prettified John Cox (1

Re: [FFmpeg-devel] [PATCH v2 12/15] avfilter/vf_bwdif: Add a filter_line3 method for optimisation

2023-07-02 Thread Martin Storsjö
On Sun, 2 Jul 2023, Thomas Mundt wrote: Am So., 2. Juli 2023 um 14:34 Uhr schrieb John Cox : Add an optional filter_line3 to the available optimisations. filter_line3 is equivalent to filter_line, memcpy, filter_line filter_line shares quite a number of loads and some calcula

Re: [FFmpeg-devel] [PATCH v2 05/15] tests/checkasm: Add test for vf_bwdif filter_intra

2023-07-02 Thread Martin Storsjö
On Sun, 2 Jul 2023, John Cox wrote: Signed-off-by: John Cox --- tests/checkasm/vf_bwdif.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/checkasm/vf_bwdif.c b/tests/checkasm/vf_bwdif.c index 46224bb575..034bbabb4c 100644 --- a/tests/checkasm/vf_b

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Michael Niedermayer
On Sun, Jul 02, 2023 at 08:55:40PM +0200, Lynne wrote: > Jul 2, 2023, 13:01 by mich...@niedermayer.cc: > > > On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote: > > > >> On Fri, 30 Jun 2023, at 16:08, Michael Niedermayer wrote: > >> > Also as said previously, If there is at least

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: remove usage of internal AVInputFormat.read_seek field

2023-07-02 Thread Marton Balint
On Thu, 29 Jun 2023, James Almer wrote: Signed-off-by: James Almer --- fftools/ffplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM, thanks. Marton diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 15fd644974..663f61d8b2 100644 --- a/fftools/ffplay.c +++ b/fftools/ff

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Lynne
Jul 2, 2023, 23:15 by mich...@niedermayer.cc: > On Sun, Jul 02, 2023 at 08:55:40PM +0200, Lynne wrote: > >> Jul 2, 2023, 13:01 by mich...@niedermayer.cc: >> >> > On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote: >> > >> >> On Fri, 30 Jun 2023, at 16:08, Michael Niedermayer wrote

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-02 Thread Michael Niedermayer
On Mon, Jul 03, 2023 at 12:03:10AM +0200, Lynne wrote: > Jul 2, 2023, 23:15 by mich...@niedermayer.cc: > > > On Sun, Jul 02, 2023 at 08:55:40PM +0200, Lynne wrote: > > > >> Jul 2, 2023, 13:01 by mich...@niedermayer.cc: > >> > >> > On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote

[FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h266: add support for Operating point information NALU type

2023-07-02 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 18 ++ libavcodec/cbs_h266.h | 11 +++ libavcodec/cbs_h266_syntax_template.c | 27 +++ 3 files changed, 56 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/li

[FFmpeg-devel] [PATCH 2/4] avcodec/cbs_h266: add support for Decoding capability information NALU type

2023-07-02 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 18 ++ libavcodec/cbs_h266.h | 10 ++ libavcodec/cbs_h266_syntax_template.c | 24 libavcodec/vvc.h | 3 +++ 4 files changed, 55 insertions(

  1   2   >