Re: [FFmpeg-devel] [PATCH v2 3/7] avcodec/avframe: add new side data types for Bar Data

2023-07-01 Thread Anton Khirnov
Quoting Devin Heitmueller (2023-06-30 23:38:51) > Add new side data types for both AVPacket and AVFrame to support > "bar data" as defined in SMPTE 2016-1, ATSC A/53, and SCTE 128-1. > > Signed-off-by: Devin Heitmueller > --- > libavcodec/decode.c | 1 + > libavcodec/defs.h | 12

Re: [FFmpeg-devel] [PATCH v2 0/7] Misc AFD improvements and support for Bar Data

2023-07-01 Thread Anton Khirnov
IIUC the only source of bar data after this set is the new filter you're adding. Is there supposed to be some other demuxer or decoder that produces it? Also, FATE tests would be much appreciated. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-07-01 Thread Anton Khirnov
Sorry to still nag you, but I just noticed that unlike video_enc_params, you do not store AVVideoRect size in AVVideoHint. This means that no new fields can be added to AVVideoRect without an ABI break. This seems suboptimal, since I do see potential use for per-block information. -- Anton Khirno

Re: [FFmpeg-devel] [PATCH v7 00/11] Add support for H266/VVC

2023-07-01 Thread Nuo Mi
On Fri, Jun 30, 2023 at 1:39 AM James Almer wrote: > On 3/21/2023 12:01 PM, Thomas Siedel wrote: > > This patch set adds H266/VVC support. > > This includes parsing, muxing, demuxing, decoding and encoding. > > Decoding is done using the external library VVdeC > > (https://github.com/fraunhoferhh

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/cbs_h2645: fix parsing and storing Picture Header references in the context

2023-07-01 Thread Nuo Mi
On Fri, Jun 30, 2023 at 6:45 AM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_h2645.c| 35 --- > libavcodec/cbs_h266.h | 17 +++-- > libavcodec/cbs_h266_syntax_template.c | 17 ++--- > libavcodec/h2

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

2023-07-01 Thread Rémi Denis-Courmont
Le 29 juin 2023 22:42:17 GMT+03:00, Paul B Mahol a écrit : >On Thu, Jun 29, 2023 at 9:35 PM Andreas Rheinhardt < >andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >> > On Thu, Jun 29, 2023 at 8:18 PM Andreas Rheinhardt < >> > andreas.rheinha...@outlook.com> wrote: >> > >> >> The discrep

[FFmpeg-devel] [PATCH] Adapted to the latest JPEG XL library version 0.9.0

2023-07-01 Thread Peter Kovář
Signed-off-by: Peter Kovář --- libavcodec/libjxldec.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c index 50417bcb02..bfff60769c 100644 --- a/libavcodec/libjxldec.c +++ b/libavcodec/libjxldec.c @@ -210,14 +210,23 @@ static

Re: [FFmpeg-devel] [PATCH] Adapted to the latest JPEG XL library version 0.9.0

2023-07-01 Thread Gyan Doshi
On 2023-07-01 06:54 pm, Peter Kovář wrote: Signed-off-by: Peter Kovář ---  libavcodec/libjxldec.c | 17 +  1 file changed, 17 insertions(+) diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c index 50417bcb02..bfff60769c 100644 --- a/libavcodec/libjxldec.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h266_syntax_template: Don't use uninitialized value

2023-07-01 Thread Nuo Mi
On Sat, Jul 1, 2023 at 5:31 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Probably a typo. Fixes a warning from Clang. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_h266_syntax_template.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/l

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h266_syntax_template: Remove set-but-unused variable

2023-07-01 Thread Nuo Mi
On Sat, Jul 1, 2023 at 5:33 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Reported by Clang. > > Signed-off-by: Andreas Rheinhardt > --- > Maybe this was meant to be used? > > libavcodec/cbs_h266_syntax_template.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > d

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h266_syntax_template: Avoid shadowing

2023-07-01 Thread Nuo Mi
On Sat, Jul 1, 2023 at 6:07 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_h266_syntax_template.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/cbs_h266_syntax_template.c > b/li

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Michael Niedermayer
Hi Martin On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsjö wrote: > On Fri, 30 Jun 2023, Michael Niedermayer wrote: > > > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: > > > If you apply this I will apply my pending libswresample commits and also > > > remove sonic decoder

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h266: store SubpicIdVal in the context

2023-07-01 Thread Nuo Mi
On Sat, Jul 1, 2023 at 9:37 AM James Almer wrote: > And use it to derive CurrSubpicIdx > > Signed-off-by: James Almer > --- > libavcodec/cbs_h266.h | 2 ++ > libavcodec/cbs_h266_syntax_template.c | 34 +-- > 2 files changed, 19 insertions(+), 17 deletion

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h266: store RowHeightVal in the context

2023-07-01 Thread Nuo Mi
On Sat, Jul 1, 2023 at 9:37 AM James Almer wrote: > Stop overwriting values from the bitstream array > pps_tile_row_height_minus1. > > Signed-off-by: James Almer > --- > libavcodec/cbs_h266_syntax_template.c | 27 ++- > 1 file changed, 14 insertions(+), 13 deletions(-) >

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Michael Niedermayer
On Fri, Jun 30, 2023 at 06:00:18PM +0100, Kieran Kunhya wrote: > On Fri, 30 Jun 2023 at 15:08, Michael Niedermayer > wrote: > > > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: > > > If you apply this I will apply my pending libswresample commits and also > > > remove sonic decoder

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Rémi Denis-Courmont
Hi, Le 30 juin 2023 21:02:36 GMT+03:00, Michael Niedermayer a écrit : >On Fri, Jun 30, 2023 at 07:40:53PM +0200, Michael Niedermayer wrote: >> On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote: >> > On Fri, 30 Jun 2023, at 16:08, Michael Niedermayer wrote: >> > > Also as said p

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Michael Niedermayer
On Sat, Jul 01, 2023 at 06:28:03PM +0300, Rémi Denis-Courmont wrote: > Hi, > > Le 30 juin 2023 21:02:36 GMT+03:00, Michael Niedermayer > a écrit : > >On Fri, Jun 30, 2023 at 07:40:53PM +0200, Michael Niedermayer wrote: > >> On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote: > >

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-07-01 Thread Brad Smith
On 2023-06-23 7:36 p.m., Brad Smith wrote: On 2023-06-23 7:35 p.m., Michael Niedermayer wrote: On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote: On 2023-06-23 6:55 p.m., Michael Niedermayer wrote: On Fri, Jun 23, 2023 at 06:41:08PM -0400, Brad Smith wrote: ping. On 2023-06-17 6:48

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Anton Khirnov
Quoting Martin Storsjö (2023-06-30 23:36:06) > I object to merging this patch. > > As numerous others have said already, this is at the wrong level of > abstraction, even if it happens to work for you for the current use case. > > Even if it is disabled by default, git master isn't a playground

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Paul B Mahol
On Sat, Jul 1, 2023 at 8:56 PM Michael Niedermayer wrote: > On Sat, Jul 01, 2023 at 06:28:03PM +0300, Rémi Denis-Courmont wrote: > > Hi, > > > > Le 30 juin 2023 21:02:36 GMT+03:00, Michael Niedermayer < > mich...@niedermayer.cc> a écrit : > > >On Fri, Jun 30, 2023 at 07:40:53PM +0200, Michael Nie

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Michael Niedermayer
On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsjö wrote: [...] > Even if it is disabled by default, git master isn't a playground for > personal projects. This is in no way intended as a "personal project" (other parts replied to already) thx [...] -- Michael GnuPG fingerprint: 9FF

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Martin Storsjö
On Sat, 1 Jul 2023, Michael Niedermayer wrote: On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsjö wrote: On Fri, 30 Jun 2023, Michael Niedermayer wrote: On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: If you apply this I will apply my pending libswresample commits and als

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Tomas Härdin
lör 2023-07-01 klockan 22:41 +0300 skrev Martin Storsjö: > On Sat, 1 Jul 2023, Michael Niedermayer wrote: > > > On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsjö wrote: > > > On Fri, 30 Jun 2023, Michael Niedermayer wrote: > > > > > > > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Maho

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Michael Niedermayer
On Sat, Jul 01, 2023 at 10:41:34PM +0300, Martin Storsjö wrote: > On Sat, 1 Jul 2023, Michael Niedermayer wrote: > > > On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsjö wrote: > > > On Fri, 30 Jun 2023, Michael Niedermayer wrote: > > > > > > > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Kieran Kunhya
> > If we look at DAB or DVB in a more fundamental way, they have no need > for mpegts. > Should this (apparently unneeded) design decission in DAB/DVB dictate > design on our side when it has not previously ? > What planet do you live on, of course they need MPEG-TS? How do you have multiple prog

Re: [FFmpeg-devel] [PATCH 1/5] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_pixels

2023-07-01 Thread Martin Storsjö
On Sun, 18 Jun 2023, Logan.Lyu wrote: Hi, Martin, I modified it according to your comments. Please review again. And here are the checkasm benchmark results of the related functions: The platform I tested is the g8y instance of Alibaba Cloud, with a chip based on armv9. Thanks for clarifyi

Re: [FFmpeg-devel] [PATCH 3/5] lavc/aarch64: new optimization for 8-bit hevc_epel_uni_w_v

2023-07-01 Thread Martin Storsjö
On Sun, 18 Jun 2023, Logan.Lyu wrote: Hi, Martin, I modified it according to your comments. Please review again. From 45508b099dc99d30e711b9e1f253068f7804e3ed Mon Sep 17 00:00:00 2001 From: Logan Lyu Date: Sat, 27 May 2023 09:42:07 +0800 Subject: [PATCH 3/5] lavc/aarch64: new optimization f

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Michael Niedermayer
On Sat, Jul 01, 2023 at 09:42:14PM +0100, Kieran Kunhya wrote: [...] > > If so, what design ? > > > > This is purely a flaw in FFmpeg that protocol/demux are joined up into the > same library. Also an assumption (coming from things like AVI and probably > reasonable at the time) that there is only

Re: [FFmpeg-devel] [PATCH 5/5] lavc/aarch64: new optimization for 8-bit hevc_epel_uni_w_hv

2023-07-01 Thread Martin Storsjö
On Sun, 18 Jun 2023, Logan.Lyu wrote: Hi, Martin, I modified it according to your comments. Please review again. From 47b7f7af634add7680b56a216fff7dbe1f08cd11 Mon Sep 17 00:00:00 2001 From: Logan Lyu Date: Sun, 28 May 2023 10:35:43 +0800 Subject: [PATCH 5/5] lavc/aarch64: new optimization f

[FFmpeg-devel] [PATCH v7 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Michael Niedermayer
Synchronous AM demodulation using Macleod based systhesized carrier better workaround for RTLSDR DC issue show soapy defaults 2 Stage station probing reduce FM bandwidth if station is partly outside range (for example with recoreded files we cannot move the range) 10% faster FM phase computation

[FFmpeg-devel] [PATCH v7] avformat: add Software Defined Radio support

2023-07-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- configure|4 + doc/demuxers.texi| 90 ++ libavdevice/Makefile |1 + libavdevice/alldevices.c |1 + libavdevice/sdrindev.c | 370 +++ libavformat/Makefile |1 + libavformat/allformats.c |1 + libavf

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-07-01 Thread Kieran Kunhya
> > You can design something starting with a filter and then define everything > a subclass of filter. > you can design things with no common class and everything different types. > > But whatever you call the class for the SDR code and the class of the > common > demuxers. Their do look very darn

Re: [FFmpeg-devel] [PATCH 00/15] avfilter/vf_bwdif: Add aarch64 neon functions

2023-07-01 Thread Martin Storsjö
On Thu, 29 Jun 2023, John Cox wrote: Also adds a filter_line3 method which on aarch64 neon yields approx 30% speedup over 2xfilter_line and a memcpy John Cox (15): avfilter/vf_bwdif: Add outline for aarch neon functions avfilter/vf_bwdif: Add common macros and consts for aarch64 neon avfilte

Re: [FFmpeg-devel] [PATCH 02/15] avfilter/vf_bwdif: Add common macros and consts for aarch64 neon

2023-07-01 Thread Martin Storsjö
On Thu, 29 Jun 2023, John Cox wrote: Add macros for dual scalar half->single multiply and accumulate Add macro for shift, saturate and shorten single to byte Add filter constants Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_neon.S | 46 + 1 file changed,

Re: [FFmpeg-devel] [PATCH 04/15] avfilter/vf_bwdif: Add neon for filter_intra

2023-07-01 Thread Martin Storsjö
On Thu, 29 Jun 2023, John Cox wrote: Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 17 +++ libavfilter/aarch64/vf_bwdif_neon.S | 53 + 2 files changed, 70 insertions(+) diff --git a/libavfilter/aarch64/vf_bwdif_init_aarch64.c b/libavfi

Re: [FFmpeg-devel] [PATCH 08/15] avfilter/vf_bwdif: Add neon for filter_edge

2023-07-01 Thread Martin Storsjö
On Thu, 29 Jun 2023, John Cox wrote: Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 20 libavfilter/aarch64/vf_bwdif_neon.S | 104 2 files changed, 124 insertions(+) diff --git a/libavfilter/aarch64/vf_bwdif_init_aarch64.c b/libavfil

Re: [FFmpeg-devel] [PATCH 11/15] avfilter/vf_bwdif: Add neon for filter_line

2023-07-01 Thread Martin Storsjö
On Thu, 29 Jun 2023, John Cox wrote: Signed-off-by: John Cox --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 21 ++ libavfilter/aarch64/vf_bwdif_neon.S | 215 2 files changed, 236 insertions(+) diff --git a/libavfilter/aarch64/vf_bwdif_init_aarch64.c b/libavfilte

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h266: store RowHeightVal in the context

2023-07-01 Thread James Almer
On 7/1/2023 12:10 PM, Nuo Mi wrote: On Sat, Jul 1, 2023 at 9:37 AM James Almer wrote: Stop overwriting values from the bitstream array pps_tile_row_height_minus1. Signed-off-by: James Almer --- libavcodec/cbs_h266_syntax_template.c | 27 ++- 1 file changed, 14 inse

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/cbs_h2645: fix parsing and storing Picture Header references in the context

2023-07-01 Thread James Almer
On 7/1/2023 8:51 AM, Nuo Mi wrote: On Fri, Jun 30, 2023 at 6:45 AM James Almer wrote: Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 35 --- libavcodec/cbs_h266.h | 17 +++-- libavcodec/cbs_h266_syntax_template.c | 17

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h266: store RowHeightVal in the context

2023-07-01 Thread James Almer
On 7/1/2023 7:33 PM, James Almer wrote: On 7/1/2023 12:10 PM, Nuo Mi wrote: On Sat, Jul 1, 2023 at 9:37 AM James Almer wrote: Stop overwriting values from the bitstream array pps_tile_row_height_minus1. Signed-off-by: James Almer ---   libavcodec/cbs_h266_syntax_template.c | 27

[FFmpeg-devel] [PATCH v2] avcodec/cbs_h266: store RowHeightVal and ColWidthVal in the context

2023-07-01 Thread James Almer
Stop overwriting values from the bitstream arrays pps_tile_column_width_minus1 and pps_tile_row_height_minus1. Signed-off-by: James Almer --- libavcodec/cbs_h266.h | 2 ++ libavcodec/cbs_h266_syntax_template.c | 37 ++- 2 files changed, 21 insertions(+),

Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of frames" in IVF header

2023-07-01 Thread Ronald S. Bultje
Hi, On Thu, Jun 29, 2023 at 5:44 AM Anton Khirnov wrote: > Quoting Dai, Jianhui J (2023-06-29 08:03:18) > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > > > Anton Khirnov > > > Sent: Wednesday, June 28, 2023 11:25 PM > > > To: ffmpeg-devel@ffmpeg.org > > > Subjec

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/cbs_h2645: fix parsing and storing Picture Header references in the context

2023-07-01 Thread Nuo Mi
On Sun, Jul 2, 2023 at 7:32 AM James Almer wrote: > On 7/1/2023 8:51 AM, Nuo Mi wrote: > > On Fri, Jun 30, 2023 at 6:45 AM James Almer wrote: > > > >> Signed-off-by: James Almer > >> --- > >> libavcodec/cbs_h2645.c| 35 --- > >> libavcodec/cbs_h266.h