On Sat, Jul 01, 2023 at 10:41:34PM +0300, Martin Storsjö wrote: > On Sat, 1 Jul 2023, Michael Niedermayer wrote: > > > On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsjö wrote: > > > On Fri, 30 Jun 2023, Michael Niedermayer wrote: > > > > > > > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: > > > > > If you apply this I will apply my pending libswresample commits and > > > > > also > > > > > remove sonic decoder from libavcodec. > > > > > > > > ok, if you plan to fix the bugs in the libswresample patches > > > > > > > > ill wait a bit, so others can object and if no objections will > > > > apply the current SDR patch with the probe function disabled. > > > > That ensures it will not be used without the user explicitly > > > > selecting it. > > > > > > I object to merging this patch. > > > > > > As numerous others have said already, this is at the wrong level of > > > abstraction, even if it happens to work for you for the current use case. > > > > > > Even if it is disabled by default, git master isn't a playground for > > > personal projects. > > > > If you belive this is implemented at the wrong level, > > can you please elaborately explain the implementation which is > > in your oppinion at the correct level ? > > As there are talks about receiving DAB/DVB from the same source, those would > definitely be on a different level than libavformat, since the output of > them would be an mpegts stream (or multiple), or whatever transport format > DAB uses.
If i search for "mpegts" in libavformat i find hls, rtp, rtsp, segment, wtv but iam sure these arent the only mixed containers. If we look at DAB or DVB in a more fundamental way, they have no need for mpegts. Should this (apparently unneeded) design decission in DAB/DVB dictate design on our side when it has not previously ? If so, what design ? > As for purely AM/FM, I'm not quire sure what the right level for > that is though. > > In any case, I disagree with the procedure of stating to push the patch if > there's no objections, when there has been numerous objections from > essentially most of the active community already. The objections have been unclear, are they against SDR, against the implementation. I took the liberty to be pushy here to get this more clear. And i will continue to do this until i get clear responses. Because otherwise iam just stuck as i dont know how to correct the design and code. Thank you for clarifying the libavformat issue. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
