Re: [FFmpeg-devel] [PATCH] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv and qpel_h

2023-05-27 Thread myais
yes, of course,   Re-add the missing mailing list... 在 2023/5/27 13:45, Martin Storsjö 写道: Hi, Thanks - can you send the new patches to the mailing list too? They need to be available publicly for review before they can be accepted. (I didn't check these yet.) // Martin On Sat, 27 May 202

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv and qpel_h

2023-05-27 Thread myais
Hi, Martin, I saw your new opinions. Do you mean that the code of my current patch should be guard as follows? C code: /if (have_i8mm(cpu_flags)) {// //}/ /asm code :/ /#if HAVE_I8MM/ /#endif/ I mean my current code base does not have those definitions, should I implement them directly

Re: [FFmpeg-devel] [PATCH 1/4] configure: aarch64: Support assembling the dotprod and i8mm arch extensions

2023-05-27 Thread Rémi Denis-Courmont
Le perjantaina 26. toukokuuta 2023, 11.03.12 EEST Martin Storsjö a écrit : > These are available since ARMv8.4-a and ARMv8.6-a respectively, > but can also be available optionally since ARMv8.2-a. > > Check if these are available for use unconditionally (e.g. if compiling > with -march=armv8.6-a),

Re: [FFmpeg-devel] [PATCH 3/4] aarch64: Add linux runtime cpu feature detection using getauxval(AT_HWCAP)

2023-05-27 Thread Rémi Denis-Courmont
Le perjantaina 26. toukokuuta 2023, 11.03.14 EEST Martin Storsjö a écrit : > Based on code by Janne Grunau. > > Using HWCAP_CPUID for user space access to the CPU feature registers. See > https://www.kernel.org/doc/html/latest/arm64/cpu-feature-registers.html. > --- > configure | 2

Re: [FFmpeg-devel] [PATCH] fate: add adpcm_ima_cunning tests

2023-05-27 Thread Anton Khirnov
Hi Zane, Quoting Zane van Iperen (2020-05-09 16:00:04) > diff --git a/tests/ref/fate/adpcm-ima-cunning-trunc-t2-track1 > b/tests/ref/fate/adpcm-ima-cunning-trunc-t2-track1 > new file mode 100644 > index 00..df9edc403d > --- /dev/null > +++ b/tests/ref/fate/adpcm-ima-cunning-trunc-t2-track1

Re: [FFmpeg-devel] [PATCH] fate: add adpcm_ima_cunning tests

2023-05-27 Thread Zane van Iperen
On 27/5/23 19:14, Anton Khirnov wrote: Hi Zane, Quoting Zane van Iperen (2020-05-09 16:00:04) diff --git a/tests/ref/fate/adpcm-ima-cunning-trunc-t2-track1 b/tests/ref/fate/adpcm-ima-cunning-trunc-t2-track1 new file mode 100644 index 00..df9edc403d --- /dev/null +++ b/tests/ref/fate/

Re: [FFmpeg-devel] [PATCH] nellymoser: user float literals for table

2023-05-27 Thread Andreas Rheinhardt
Tristan Matthews: > --- > libavcodec/nellymoser.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/libavcodec/nellymoser.c b/libavcodec/nellymoser.c > index 66c5f83a56..fa22b79909 100644 > --- a/libavcodec/nellymoser.c > +++ b/libavco

Re: [FFmpeg-devel] [PATCH] nellymoser: user float literals for table

2023-05-27 Thread Tristan Matthews
On Sat, May 27, 2023 at 8:17 AM Andreas Rheinhardt wrote: > > Tristan Matthews: > > --- > > libavcodec/nellymoser.c | 36 ++-- > > 1 file changed, 18 insertions(+), 18 deletions(-) > > > > diff --git a/libavcodec/nellymoser.c b/libavcodec/nellymoser.c > > index 66c

Re: [FFmpeg-devel] [PATCH] avfilter/af_apad: switch to activate

2023-05-27 Thread Paul B Mahol
Will apply. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v3] decklink: Convert to using avpriv_packet_list functions

2023-05-27 Thread Devin Heitmueller
Hello Marton, On Fri, May 12, 2023 at 11:09 AM Devin Heitmueller wrote: > > The existing DecklinkQueue implementation was using the PacketList > structure but wasn't using the standard avpriv_packet_list_get and > avpriv_packet_list_put functions. Convert to using them so we > eliminate the dupl

Re: [FFmpeg-devel] [PATCH] avfilter/af_apad: switch to activate

2023-05-27 Thread Anton Khirnov
Quoting Paul B Mahol (2023-05-18 19:48:47) > Attached. > > From c06d3d9f6020fdda19641637cafa6f86c77b4b73 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Wed, 17 May 2023 09:14:56 +0200 > Subject: [PATCH 21/27] avfilter/af_apad: switch to activate > > Signed-off-by: Paul B Mahol > --- > l

Re: [FFmpeg-devel] [PATCH] avfilter/af_apad: switch to activate

2023-05-27 Thread Paul B Mahol
On Sat, May 27, 2023 at 5:43 PM Anton Khirnov wrote: > Quoting Paul B Mahol (2023-05-18 19:48:47) > > Attached. > > > > From c06d3d9f6020fdda19641637cafa6f86c77b4b73 Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Wed, 17 May 2023 09:14:56 +0200 > > Subject: [PATCH 21/27] avfilter/af_a

Re: [FFmpeg-devel] [PATCH] avfilter/af_apad: switch to activate

2023-05-27 Thread Paul B Mahol
On Sat, May 27, 2023 at 5:46 PM Paul B Mahol wrote: > > > On Sat, May 27, 2023 at 5:43 PM Anton Khirnov wrote: > >> Quoting Paul B Mahol (2023-05-18 19:48:47) >> > Attached. >> > >> > From c06d3d9f6020fdda19641637cafa6f86c77b4b73 Mon Sep 17 00:00:00 2001 >> > From: Paul B Mahol >> > Date: Wed,

Re: [FFmpeg-devel] [PATCH] avfilter/af_aresample: switch to activate

2023-05-27 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv and qpel_h

2023-05-27 Thread Martin Storsjö
Hi, On Sat, 27 May 2023, myais wrote: I saw your new opinions. Do you mean that the code of my current patch should be guard as follows? C code: /if (have_i8mm(cpu_flags)) {// //}/ /asm code :/ /#if HAVE_I8MM/ /#endif/ Yes I mean my current code base does not have those definitions, sh

Re: [FFmpeg-devel] [PATCH 3/4] aarch64: Add linux runtime cpu feature detection using getauxval(AT_HWCAP)

2023-05-27 Thread Martin Storsjö
On Sat, 27 May 2023, Rémi Denis-Courmont wrote: Le perjantaina 26. toukokuuta 2023, 11.03.14 EEST Martin Storsjö a écrit : Based on code by Janne Grunau. Using HWCAP_CPUID for user space access to the CPU feature registers. See https://www.kernel.org/doc/html/latest/arm64/cpu-feature-registers

Re: [FFmpeg-devel] [PATCH 1/4] configure: aarch64: Support assembling the dotprod and i8mm arch extensions

2023-05-27 Thread Martin Storsjö
On Sat, 27 May 2023, Rémi Denis-Courmont wrote: Le perjantaina 26. toukokuuta 2023, 11.03.12 EEST Martin Storsjö a écrit : These are available since ARMv8.4-a and ARMv8.6-a respectively, but can also be available optionally since ARMv8.2-a. Check if these are available for use unconditionally

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2023-05-27 Thread James Almer
On 5/24/2023 9:32 PM, Lynne wrote: May 24, 2023, 23:24 by leo.i...@gmail.com: On 5/24/23 16:35, Lynne wrote: Patch attached. +av_log((void *)&tx_class, AV_LOG_DEBUG, "%s\n", bp.str); The type of the first argument to av_log should be AVClass **, but this only appears to be AVClass *.

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2023-05-27 Thread Lynne
May 28, 2023, 03:07 by jamr...@gmail.com: > On 5/24/2023 9:32 PM, Lynne wrote: > >> May 24, 2023, 23:24 by leo.i...@gmail.com: >> >>> On 5/24/23 16:35, Lynne wrote: >>> Patch attached. >>> >>> +av_log((void *)&tx_class, AV_LOG_DEBUG, "%s\n", bp.str); >>> >>> The type of the first arg

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv and qpel_h

2023-05-27 Thread Logan.Lyu
Hi, Martin I have finished the modification, please review again. Thanks. 在 2023/5/26 16:34, Martin Storsjö 写道: Hi, Overall these patches seem mostly ok, but I've got a few minor points to make: - The usdot instruction requires the i8mm extension (part of armv8.6-a), while udot or sdot w

Re: [FFmpeg-devel] [PATCH 1/4] configure: aarch64: Support assembling the dotprod and i8mm arch extensions

2023-05-27 Thread Rémi Denis-Courmont
Le sunnuntaina 28. toukokuuta 2023, 0.34.15 EEST Martin Storsjö a écrit : > > Someone would have to write assembler code that would fail to build under > > a toolchain with a lower target version. That sounds like a bug that > > should be spotted and fixed, rather than papered over. > > I don't se

Re: [FFmpeg-devel] [PATCH 3/4] aarch64: Add linux runtime cpu feature detection using getauxval(AT_HWCAP)

2023-05-27 Thread Rémi Denis-Courmont
Le lauantaina 27. toukokuuta 2023, 23.35.14 EEST Martin Storsjö a écrit : > > NEON detection could be added here, though I've yet to see an Armv8 > > implementation without AdvSIMD. > > I guess we could, but as it's part of the require baseline for armv8-a I > don't think there's much need for it?

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv and qpel_h

2023-05-27 Thread Logan.Lyu
在 2023/5/28 12:36, Jean-Baptiste Kempf 写道: Hello, The last interaction still has the wrong name in patchset. Thanks for reminding.  I modified the correct name in git. jb On Sun, 28 May 2023, at 12:23, Logan.Lyu wrote: Hi, Martin I have finished the modification, please review again. Tha