Hi,

On Sat, 27 May 2023, myais wrote:

I saw your new opinions. Do you mean that the code of my current patch should be guard as follows?

C code:

/if (have_i8mm(cpu_flags)) {//
//}/

/asm code :/

/#if HAVE_I8MM/

/#endif/

Yes

I mean my current code base does not have those definitions, should I implement them directly as if they already exist?

I suggest you apply my patches from the patchset I pointed you to, https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=9009 - or from the start of the branch on github I pointed you to. It's likely that the patches will change a little before they're accepted, but I believe the main interface towards your code, "#if HAVE_I8MM" and "if (have_i8mm(cpu_flags))" will remain as such.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to