[FFmpeg-devel] [PATCH v1 01/13] lavc/hevc_ps: remove profile limitation of pps_range_extensions()

2022-12-01 Thread Fei Wang
Follow spec 7.3.2.3.1. Signed-off-by: Fei Wang --- libavcodec/hevc_ps.c | 2 +- tests/ref/fate/hevc-conformance-PS_A_VIDYO_3 | 50 ++-- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index f665

[FFmpeg-devel] [PATCH v1 02/13] lavc/avcodec: Add HEVC Screen Content Coding Extensions profile

2022-12-01 Thread Fei Wang
From: Linjie Fu Described in HEVC spec A.3.7. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/avcodec.h | 1 + libavcodec/hevc_ps.c | 2 ++ libavcodec/profiles.c | 1 + 3 files changed, 4 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 3edd8e263

[FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax

2022-12-01 Thread Fei Wang
From: Linjie Fu 1. Add extension syntax according to 7.3.2.2.3/7.3.2.3.3 in T-REC-H.265-201911. 2. Keep using parsed PPS when bitstream overread for compatibility. For example, the clip PS_A_VIDYO_3.bit in FATE test has incomplete extension syntax which will be overread and un-decodable if withou

[FFmpeg-devel] [PATCH v1 04/13] lavc/hevcdec: Add slice parse support for HEVC SCC extension

2022-12-01 Thread Fei Wang
From: Linjie Fu Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/hevcdec.c | 6 ++ libavcodec/hevcdec.h | 4 2 files changed, 10 insertions(+) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index fb44d8d3f2..edf3a2b134 100644 --- a/libavcodec/hevcdec.c +++ b/

[FFmpeg-devel] [PATCH v1 05/13] lavc/hevcdec: Fix the parsing for use_integer_mv_flag

2022-12-01 Thread Fei Wang
From: Linjie Fu According to 7.3.6.1, use_integer_mv_flag should be parsed if motion_vector_resolution_control_idc equals to 2. If not present, it equals to motion_vector_resolution_control_idc. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/hevcdec.c | 8 libavcodec

[FFmpeg-devel] [PATCH v1 06/13] lavc/hevcdec: Set max_num_merge_cand to uint8_t

2022-12-01 Thread Fei Wang
From: Linjie Fu uint8_t is big enough and keep consistent with the definition in cbs_h265.h. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/hevcdec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.h b/libavcodec/hevcdec.h index a7fc669b

[FFmpeg-devel] [PATCH v1 07/13] lavc/hevc: Update reference list for SCC

2022-12-01 Thread Fei Wang
From: Linjie Fu Screen Content Coding allows non-intra slice in an IRAP frame which can reference the frame itself, and would mark the current decoded picture as "used for long-term reference", no matter TwoVersionsOfCurrDecPicFlag(8.1.3), hence some previous restricts are not suitable any more.

[FFmpeg-devel] [PATCH v1 09/13] lavc/vaapi_hevc: Add vaapi profile parse support for SCC

2022-12-01 Thread Fei Wang
From: Linjie Fu Note that Screen-Extended Main 4:4:4 and 4:4:4 10 supports chroma_format_idc from 0, 1 or 3, hence both 420 and 444 are supported. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/vaapi_decode.c | 4 +++- libavcodec/vaapi_hevc.c | 14 -- libavcode

[FFmpeg-devel] [PATCH v1 10/13] lavc/vaapi_hevc: Set correct rps type for scc

2022-12-01 Thread Fei Wang
From: Linjie Fu According to 8.1.3 and 8.3.2. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/vaapi_hevc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c index 6ce1e17fa8..005d782819 100644 --- a/libavcodec/vaapi_hevc.

[FFmpeg-devel] [PATCH v1 11/13] lavc/vaapi_hevc: Loose the restricts for SCC decoding

2022-12-01 Thread Fei Wang
From: Linjie Fu Allow current picture as the reference picture. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/vaapi_hevc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c index 005d782819..ca14052d56

[FFmpeg-devel] [PATCH v1 08/13] lavc/vaapi_hevc: Pass SCC parameters Through VA-API

2022-12-01 Thread Fei Wang
From: Linjie Fu Including sps/pps/slice parameters. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/vaapi_hevc.c | 52 + 1 file changed, 47 insertions(+), 5 deletions(-) diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c ind

[FFmpeg-devel] [PATCH v1 12/13] avcodec/hevcdec: Replace number with enum

2022-12-01 Thread Fei Wang
Keep same style with IS_IDR()/IS_BLA(). Signed-off-by: Fei Wang --- libavcodec/hevcdec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.h b/libavcodec/hevcdec.h index aab816791e..94609e4699 100644 --- a/libavcodec/hevcdec.h +++ b/libavcodec/hevcdec.h @@ -7

[FFmpeg-devel] [PATCH v1 13/13] lavc/vaapi_hevc: Remove duplicate code

2022-12-01 Thread Fei Wang
Signed-off-by: Fei Wang --- libavcodec/vaapi_hevc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c index ca14052d56..b3ff2f7344 100644 --- a/libavcodec/vaapi_hevc.c +++ b/libavcodec/vaapi_hevc.c @@ -538,12 +538,6 @@ static int vaapi_hevc

Re: [FFmpeg-devel] [PATCH] avcodec/mathops: Optimize generic mid_pred function

2022-12-01 Thread Michael Niedermayer
On Thu, Dec 01, 2022 at 02:42:20PM +0800, Junxian Zhu wrote: > From: Junxian Zhu > > Rewrite mid_pred function in generic mathops.h, reduce branch jump to improve > performance. And because nowadays new version compiler can compile enough > short asmbbely code as handwritting in these function,

Re: [FFmpeg-devel] [PATCH v2 0/3] Some small ASS conversion fixes

2022-12-01 Thread Paul B Mahol
On 12/1/22, Oneric wrote: > On Sun, Nov 20, 2022 at 01:15:33 +0100, Oneric wrote: >> On Sun, Nov 13, 2022 at 20:57:15 +0100, Oneric wrote: >> > This fixes colours and font selection for files converted to ASS >> >> Ping. Will apply if nobody is against. Please ping me directly if I do not apply

Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-12-01 Thread Paul B Mahol
On 11/25/22, Paul B Mahol wrote: > On 10/11/22, Martijn van Beurden wrote: >> Recently libFLAC gained the ability (first released in FLAC 1.4.0) >> to create FLAC files containing 32-bit int PCM samples. To >> keep complexity reasonable, the choice was made to limit residuals >> to 32-bit integer

[FFmpeg-devel] [RFC PATCH] fftools/ffmpeg: make main function actually return

2022-12-01 Thread Zhao Zhili
From: Zhao Zhili --- When working on mediacodec encoder, I test it by making fftools/ffmpeg into a lib, since JNI requires a JVM environment. There are three steps mostly: 1. Rename main() function 2. Reset global variables 3. Make main() function actuall return There is no point for this patch,

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/wavpack: Fix overflow in k=31

2022-12-01 Thread Michael Niedermayer
On Wed, Nov 30, 2022 at 09:39:44PM +0100, Paul B Mahol wrote: > On 9/11/22, Michael Niedermayer wrote: > > Untested with "non fuzzed" samples as i have no such file > > > > Then create it. the official WavPack-5.6.0 decoder has 2 alternative optimized codepathes #ifdef USE_BITMASK_TABLES ext

[FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms"

2022-12-01 Thread Chris Ribble
This reverts commit 03d81a044ad587ea83567f75dc36bc3d64278199. This change broke the ability to read mp4 files which contain a trun atom with a sample of size zero (FFmpeg exits while parsing the moof). Signed-off-by: Chris Ribble --- libavformat/mov.c | 2 -- 1 file changed, 2 deletions(-) dif

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms"

2022-12-01 Thread Marton Balint
On Thu, 1 Dec 2022, Chris Ribble wrote: This reverts commit 03d81a044ad587ea83567f75dc36bc3d64278199. This change broke the ability to read mp4 files which contain a trun atom with a sample of size zero (FFmpeg exits while parsing the moof). Can you explain why those files are considered v

[FFmpeg-devel] Developer online meeting tomorrow Dec 2 16:00

2022-12-01 Thread Jean-Baptiste Kempf
Yo, As a few of us will be in Barcelona, we'll do a short meeting to discuss about technical things at 16:00 (Barcelona/Berlin time) on Dec 2. This will happen on Jitsi, of course, and discussion on IRC. Currently, there is no specific agenda, but please bring your own topics :) C U soon jb -

Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax

2022-12-01 Thread Michael Niedermayer
On Thu, Dec 01, 2022 at 04:13:58PM +0800, Fei Wang wrote: > From: Linjie Fu > > 1. Add extension syntax according to 7.3.2.2.3/7.3.2.3.3 in > T-REC-H.265-201911. > 2. Keep using parsed PPS when bitstream overread for compatibility. For > example, the clip PS_A_VIDYO_3.bit in FATE test has incomp

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms"

2022-12-01 Thread Chris Ribble
On Thu, Dec 1, 2022 at 4:51 PM Marton Balint wrote: > > Can you explain why those files are considered valid, or why it makes > sense to generate such files? > > Thanks, > Marton > As far as I can tell, the file that a user provided with this problem was generated by an encoder (running FFmpeg 3.

Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax

2022-12-01 Thread Wang, Fei W
On Fri, 2022-12-02 at 01:21 +0100, Michael Niedermayer wrote: > On Thu, Dec 01, 2022 at 04:13:58PM +0800, Fei Wang wrote: > > From: Linjie Fu > > > > 1. Add extension syntax according to 7.3.2.2.3/7.3.2.3.3 in T-REC- > > H.265-201911. > > 2. Keep using parsed PPS when bitstream overread for compa

Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax

2022-12-01 Thread James Almer
On 12/1/2022 5:13 AM, Fei Wang wrote: +static void colour_mapping_octants(GetBitContext *gb, HEVCPPS *pps, int inp_depth, + int idx_y, int idx_cb, int idx_cr, int inp_length) +{ +uint8_t split_octant_flag, coded_res_flag; +uint16_t part_num_y, res_coeff

Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax

2022-12-01 Thread James Almer
On 12/1/2022 5:13 AM, Fei Wang wrote: +static void colour_mapping_octants(GetBitContext *gb, HEVCPPS *pps, int inp_depth, + int idx_y, int idx_cb, int idx_cr, int inp_length) +{ +uint8_t split_octant_flag, coded_res_flag; +uint16_t part_num_y, res_coeff

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms"

2022-12-01 Thread Gyan Doshi
On 2022-12-02 06:16 am, Chris Ribble wrote: On Thu, Dec 1, 2022 at 4:51 PM Marton Balint wrote: Can you explain why those files are considered valid, or why it makes sense to generate such files? Thanks, Marton As far as I can tell, the file that a user provided with this problem was gene

Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax

2022-12-01 Thread Michael Niedermayer
On Fri, Dec 02, 2022 at 12:58:48AM +, Wang, Fei W wrote: > On Fri, 2022-12-02 at 01:21 +0100, Michael Niedermayer wrote: > > On Thu, Dec 01, 2022 at 04:13:58PM +0800, Fei Wang wrote: > > > From: Linjie Fu > > > > > > 1. Add extension syntax according to 7.3.2.2.3/7.3.2.3.3 in T-REC- > > > H.2