Re: [FFmpeg-devel] [PATCH 0/5] Provide optimized neon implementation

On Thu, 8 Sep 2022, Hubert Mazur wrote: Fix minor issues in the patches. Regarding vsse16 I didn't change saba & umlal to sub & smlal. It doesn't affect the performance, so left it as it was. The majority of changes refer to nsse16: - fixed indentation (thanks for pointing out), - applied the pa

[FFmpeg-devel] [PATCH v5 2/3] swscale/la: Add yuv2rgb_lasx.c and rgb2rgb_lasx.c files

ffmpeg -i 1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -pix_fmt rgb24 -y /dev/null -an before: 178fps after: 210fps Signed-off-by: Hao Chen --- libswscale/loongarch/Makefile | 2 + libswscale/loongarch/rgb2rgb_lasx.c | 52 +++ libswscale/loongarch/swscale_init_loongarc

[FFmpeg-devel] Add LoongArch SIMD optimization in swscale lib.

v2: Some modifications were made according to the comments of the reviewers. v3: Update and run CI test again. v4: Resolve the warning for the build. v5: Re-trigger the Patchwork test. [PATCH v5 1/3] swscale/la: Optimize hscale functions with lasx. [PATCH v5 2/3] swscale/la: Add yuv2rgb_lasx.c and

[FFmpeg-devel] [PATCH v5 1/3] swscale/la: Optimize hscale functions with lasx.

ffmpeg -i 1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -s 640x480 -y /dev/null -an before: 101fps after: 138fps Signed-off-by: Hao Chen --- libswscale/loongarch/Makefile | 3 + libswscale/loongarch/input_lasx.c | 202 libswscale/loongarch/swscale_init_loongarch.c

[FFmpeg-devel] [PATCH v5 3/3] swscale/la: Add output_lasx.c file.

ffmpeg -i 1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -s 640x480 -pix_fmt rgb24 -y /dev/null -an before: 150fps after: 183fps Signed-off-by: Hao Chen --- libswscale/loongarch/Makefile |3 +- libswscale/loongarch/output_lasx.c| 1982 + libswscale/loon

[FFmpeg-devel] Fix bugs on Mips platform.

v2: Modifies the format of the Commit message. [PATCH v2 1/2] lavc/mips: Fix bugs in me_cmp_msa.c file. [PATCH v2 2/2] lavc/mips: Fix hevc decoding bugs on MIPS paltform. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/l

[FFmpeg-devel] [PATCH v2 1/2] lavc/mips: Fix bugs in me_cmp_msa.c file.

From: Lu Wang This patch fixes a bug where the fate-checkasm-motion fails when h is not a multiple of 8. --- libavcodec/mips/me_cmp_msa.c | 201 ++- 1 file changed, 173 insertions(+), 28 deletions(-) diff --git a/libavcodec/mips/me_cmp_msa.c b/libavcodec/mips/me_

Re: [FFmpeg-devel] Add LoongArch SIMD optimization in swscale lib.

> -原始邮件- > 发件人: "Hao Chen" > 发送时间:2022-09-09 17:00:23 (星期五) > 收件人: ffmpeg-devel@ffmpeg.org > 抄送: > 主题: [FFmpeg-devel] Add LoongArch SIMD optimization in swscale lib. > > v2: Some modifications were made according to the comments of the reviewers. > v3: Update and run CI test again. > v4:

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith: > > On 06/08/2022 21:44, Tomas Härdin wrote: > > fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith: > > > Some NLVEs may insert a KLV packet for EIA-608 data even though > > > the number of encapsulated ANC packets is zero. > > > --- > > >  

Re: [FFmpeg-devel] Fix bugs on Mips platform.

> 2022年9月9日 17:41，Hao Chen 写道： > > v2: Modifies the format of the Commit message. > > [PATCH v2 1/2] lavc/mips: Fix bugs in me_cmp_msa.c file. > [PATCH v2 2/2] lavc/mips: Fix hevc decoding bugs on MIPS paltform. > > LGTM. ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] swresample/swresample: fix assert failure

From: Zhao Zhili Fix #9908. Regression since 8a5896ec1f6. Signed-off-by: Zhao Zhili --- libswresample/swresample.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libswresample/swresample.c b/libswresample/swresample.c index 6f04d130d3..624309c2a0 100644 --- a/libswresample/swresample.c

Re: [FFmpeg-devel] [PATCH] swresample/swresample: fix assert failure

I sent an alternative approach last night. On 9/9/2022 3:20 PM, Zhao Zhili wrote: From: Zhao Zhili Fix #9908. Regression since 8a5896ec1f6. Signed-off-by: Zhao Zhili --- libswresample/swresample.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libswresample/swresample.c b/libswresa

[FFmpeg-devel] [PATCH 1/2] Revert "avcodec/loongarch: Add wrapper for __lsx_vldx"

This reverts commit 6c9a60ada4256cf5c388d8dc48860e24c15396c0. The loongarch headers have been fixed, so that this workaround is no longer necessary. Signed-off-by: Andreas Rheinhardt --- libavcodec/loongarch/hevc_lpf_sao_lsx.c | 52 +++--- libavcodec/loongarch/hevc_mc_bi_lsx.c | 140 +

[FFmpeg-devel] [PATCH 2/2] Revert "avcodec/loongarch/h264chroma, vc1dsp_lasx: Add wrapper for __lasx_xvldx"

This reverts commit 2c8dc7e953e532752500e8145aa1ceee908bda2f. The loongarch headers have been fixed, so that this wrapper is no longer necessary. Signed-off-by: Andreas Rheinhardt --- libavcodec/loongarch/h264chroma_lasx.c| 90 +++ libavcodec/loongarch/vc1dsp_lasx.c

Re: [FFmpeg-devel] [PATCH v1 3/3] swscale/la: Add output_lasx.c file.

Shiyou Yin: > > >> 2022年9月6日 16:12，Shiyou Yin 写道： >> >>> >>> 2022年8月29日 20:30，Andreas Rheinhardt >> > 写道： >>> >>> Hao Chen: ffmpeg -i ~/media/1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -s 640x480 -pix_fmt rgb24 -y /dev/null -an before: 15

Re: [FFmpeg-devel] [PATCH 1/2] tests/fate-run: Allow to set input options for encoding pass

Andreas Rheinhardt: > This will be useful in the next commit. > > Signed-off-by: Andreas Rheinhardt > --- > tests/fate-run.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/fate-run.sh b/tests/fate-run.sh > index 4008bcbc16..61cc59acc0 100755 > --- a/tests/fate

Re: [FFmpeg-devel] [PATCH 1/2] avutil/x86/intreadwrite: Add ability to detect whether MMX code is used

Andreas Rheinhardt: > It can be used to call emms_c() only when needed. > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/x86/intreadwrite.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/x86/intreadwrite.h b/libavutil/x86/intreadwrite.h > index 4061d19231..40f375b01

Re: [FFmpeg-devel] [PATCH] lavc/hevc_ps: fix process failed when SPS before VPS in hvcC

On 9/9/2022 10:09 AM, 1035567...@qq.com wrote: From: Wang Yaqiang In some videos, SPS will be stored before VPS in hvcC box, parse SPS does not depend on VPS, so the video is expected to be processed normally. Added "parsed_vps" parameter to indicate whether VPS have been parsed. Only VPS have

Re: [FFmpeg-devel] [PATCH 2/2] swscale/input: Avoid calls to av_pix_fmt_desc_get()

On Thu, Sep 08, 2022 at 11:44:51PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Sep 08, 2022 at 09:38:51PM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: [...] > > To me if i look at the evolution > > of isBE() / code checking BE-ness it become more messy over tim

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

On 09/09/2022 10:45, Tomas Härdin wrote: ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith: On 06/08/2022 21:44, Tomas Härdin wrote: fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith: Some NLVEs may insert a KLV packet for EIA-608 data even though the number of encapsulated ANC packets

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

On Thu, Sep 08, 2022 at 11:49:53PM +0300, etemesica...@gmail.com wrote: > From: caleb > > Rebased this patch on master branch > --- > libavcodec/Makefile|2 +- > libavcodec/j2kenc.c| 26 +- > libavcodec/jpeg2000.h | 103 ++- > libavcodec/jpeg2000dec.c | 193 ++

[FFmpeg-devel] [PATCH 01/18] doc: reference the RISC-V specification

From: Rémi Denis-Courmont --- doc/optimization.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/optimization.txt b/doc/optimization.txt index 974e2f9af2..3ed29fe38c 100644 --- a/doc/optimization.txt +++ b/doc/optimization.txt @@ -267,6 +267,11 @@ CELL/SPU: http://www-01.ibm.com

[FFmpeg-devel] [PATCH 03/18] configure/riscv: detect fast CLZ

From: Rémi Denis-Courmont RISC-V defines the CLZ instruction as part of the ratified Zbb subset of the (not yet ratified) bit mapulation extension (B). We can detect it from the __riscv_zbb predefined constant. At least GCC 12 already supports this correctly. Note that the macro will be non-zero

[FFmpeg-devel] [PATCH 02/18] lavu/riscv: AV_READ_TIME cycle counter

From: Rémi Denis-Courmont This uses the architected RISC-V 64-bit cycle counter from the RISC-V unprivileged instruction set. In 64-bit and 128-bit, this is a straightforward CSR read. In 32-bit mode, the 64-bit value is exposed as two CSRs, which cannot be read atomically, so a loop is necessar

[FFmpeg-devel] [PATCH 04/18] lavu/riscv: byte-swap operations

From: Rémi Denis-Courmont If the target supports the Basic bit-manipulation (Zbb) extension, then the REV8 instruction is available to reverse byte order. Note that this instruction only exists at the "XLEN" register size, so we need to right shift the result down to the data width. If Zbb is n

[FFmpeg-devel] [PATCH 05/18] lavu/riscv: add optimisations

From: Rémi Denis-Courmont This provides some micro-optimisations for signed integer clipping, and support for bit weight with the Zbb extension. --- libavutil/intmath.h | 5 +- libavutil/riscv/intmath.h | 103 ++ 2 files changed, 106 insertions(+), 2 d

[FFmpeg-devel] [PATCH 13/18] lavu/riscv: float vector multiplication-addition with RVV

From: Rémi Denis-Courmont --- libavutil/riscv/float_dsp_init.c | 3 +++ libavutil/riscv/float_dsp_rvv.S | 19 +++ 2 files changed, 22 insertions(+) diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c index b63da72acd..9b31ed2ed1 100644 --- a/libavu

[FFmpeg-devel] [PATCH 16/18] lavu/riscv: float vector windowed overlap/add with RVV

From: Rémi Denis-Courmont --- libavutil/riscv/float_dsp_init.c | 3 +++ libavutil/riscv/float_dsp_rvv.S | 35 2 files changed, 38 insertions(+) diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c index e6a5efbf68..99cc8afd31 100644

[FFmpeg-devel] [PATCH 14/18] lavu/riscv: float vector sum-and-difference with RVV

From: Rémi Denis-Courmont --- libavutil/riscv/float_dsp_init.c | 2 ++ libavutil/riscv/float_dsp_rvv.S | 18 ++ 2 files changed, 20 insertions(+) diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c index 9b31ed2ed1..4980214821 100644 --- a/libavuti

[FFmpeg-devel] [PATCH 15/18] lavu/riscv: float reversed vector multiplication with RVV

From: Rémi Denis-Courmont --- libavutil/riscv/float_dsp_init.c | 3 +++ libavutil/riscv/float_dsp_rvv.S | 22 ++ 2 files changed, 25 insertions(+) diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c index 4980214821..e6a5efbf68 100644 --- a/lib

[FFmpeg-devel] [PATCH 17/18] lavu/riscv: float vector dot product with RVV

From: Rémi Denis-Courmont --- libavutil/riscv/float_dsp_init.c | 2 ++ libavutil/riscv/float_dsp_rvv.S | 21 + 2 files changed, 23 insertions(+) diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c index 99cc8afd31..9c5e06bae9 100644 --- a/libav

[FFmpeg-devel] [PATCH 18/18] lavu/riscv: fixed vector sum-and-difference with RVV

From: Rémi Denis-Courmont --- libavutil/fixed_dsp.c| 4 +++- libavutil/fixed_dsp.h| 1 + libavutil/riscv/Makefile | 4 +++- libavutil/riscv/fixed_dsp_init.c | 33 +++ libavutil/riscv/fixed_dsp_rvv.S | 38

[FFmpeg-devel] [PATCH 06/18] configure: probe RISC-V Vector extension

From: Rémi Denis-Courmont --- configure| 15 +++ ffbuild/arch.mak | 2 ++ 2 files changed, 17 insertions(+) diff --git a/configure b/configure index b7dc1d8656..c5f20cc323 100755 --- a/configure +++ b/configure @@ -462,6 +462,7 @@ Optimization options (experts only): --d

[FFmpeg-devel] [PATCH 09/18] checkasm: register the RISC-V V subsets

From: Rémi Denis-Courmont --- tests/checkasm/checkasm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index e56fd3850e..a5d0503811 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -226,6 +226,11 @@ static c

[FFmpeg-devel] [PATCH 07/18] lavu/riscv: initial common header for assembler macros

From: Rémi Denis-Courmont --- libavutil/riscv/asm.S | 74 +++ 1 file changed, 74 insertions(+) create mode 100644 libavutil/riscv/asm.S diff --git a/libavutil/riscv/asm.S b/libavutil/riscv/asm.S new file mode 100644 index 00..7623c161cf --- /dev/

[FFmpeg-devel] [PATCH 10/18] lavu/riscv: float vector-scalar multiplication with RVV

From: Rémi Denis-Courmont This is based on existing code from the VLC git tree with two minor changes to account for the different function prototypes. --- libavutil/float_dsp.c| 2 ++ libavutil/float_dsp.h| 1 + libavutil/riscv/Makefile | 4 ++- libavutil/risc

[FFmpeg-devel] [PATCH 11/18] lavu/riscv: float vector-vector multiplication with RVV

From: Rémi Denis-Courmont --- libavutil/riscv/float_dsp_init.c | 9 - libavutil/riscv/float_dsp_rvv.S | 34 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c index 7c553e91

[FFmpeg-devel] [PATCH 08/18] lavu/riscv: add CPU flags for the RISC-V Vector extension

From: Rémi Denis-Courmont RVV defines a total of 12 different extensions, including: - 5 different instruction subsets: - Zve32x: 8-, 16- and 32-bit integers, - Zve32f: Zve32x plus single precision floats, - Zve64x: Zve32x plus 64-bit integers, - Zve64f: Zve32f plus Zve64x, - Zve64d: Z

[FFmpeg-devel] [PATCH 12/18] lavu/riscv: float vector multiply-accumulate with RVV

From: Rémi Denis-Courmont --- libavutil/riscv/float_dsp_init.c | 6 + libavutil/riscv/float_dsp_rvv.S | 38 2 files changed, 44 insertions(+) diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c index 49a4c95a0b..b63da72acd 1006

Re: [FFmpeg-devel] [PATCH 2/2] swscale/input: Avoid calls to av_pix_fmt_desc_get()

On Thu, Sep 08, 2022 at 11:44:51PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Sep 08, 2022 at 09:38:51PM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> Hi > >>> > >>> On Thu, Sep 08, 2022 at 04:38:11AM +0200, Andreas Rheinhardt wrote: > Up until now,

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

Will address in the next iteration On Fri, 9 Sept 2022, 18:46 Michael Niedermayer, wrote: > On Thu, Sep 08, 2022 at 11:49:53PM +0300, etemesica...@gmail.com wrote: > > From: caleb > > > > Rebased this patch on master branch > > --- > > libavcodec/Makefile|2 +- > > libavcodec/j2ken

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

> This is unneeded for the encoder > maybe a jpeg2000dec.h would be better for this > also code moving should be in a seperate patch > from functional changes This will be a circular dependence, since jpeg2000htdec.h needs the decoder context, and jpeg2000.c needs jpeg2000htdec.c. On Fri, 9 Se

[FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: Update ssim, ms_ssim options description

Update description for ssim and ms_ssim libvmaf options to specify feature=float_ssim and feature=float_ms_ssim which are used to request ssim and ms_ssim values in the latest versions of libvmaf. Signed-off-by: Yondon Fu --- libavfilter/vf_libvmaf.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [FFmpeg-devel] [PATCH 2/2] swscale/input: Avoid calls to av_pix_fmt_desc_get()

Michael Niedermayer: > On Thu, Sep 08, 2022 at 11:44:51PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Thu, Sep 08, 2022 at 09:38:51PM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: > [...] >>> To me if i look at the evolution >>> of isBE() / code checking BE-ness it

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

Caleb Etemesi: >> This is unneeded for the encoder >> maybe a jpeg2000dec.h would be better for this >> also code moving should be in a seperate patch >> from functional changes > > > This will be a circular dependence, since jpeg2000htdec.h needs the decoder > context, and jpeg2000.c needs jpeg2

[FFmpeg-devel] [PATCH] libavformat/flac_picture: Don't return AVERROR_INVALIDDATA for errors with flac picture mimetype

In the case where the FLAC picture MIME type is not understood, fail to parse the picture silently rather than return AVERROR_INVALIDDATA. This originated from a bug reported in Chromium: https://crbug.com/1052821 Signed-off-by: Will Cassella --- libavformat/flac_picture.c | 4 1 file chan

[FFmpeg-devel] [PATCH] libavformat/riffec: Zero-initialize `channels` in `ff_get_wav_header`

Clang's static analyzer complains that leaving the `channels` variable uninitialized could lead to a code path where the uninitialized value is written to `par->ch_layout.nb_channels` at the end of this function. This patch simply zero-initializes that variable to avoid that. Signed-off-by: Will C

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ralf: Move frame allocation after error checks

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ralf.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/ralf.c b/libavcodec/ralf.c > index 20c5f060d0..8f8e49f535 100644 > --- a/libavcodec/ralf.c > +++ b/libavcodec/ralf.c >

[FFmpeg-devel] [PATCH 01/18] avcodec/vp8: Disable segmentation for VP7

Segmentation is a VP8-feature. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 0e16e75faa..c00c5c975e 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @

[FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7

It is a VP8-only feature. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index c00c5c975e..04a2113cc8 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -637,7 +637,6 @@ static

[FFmpeg-devel] [PATCH 03/18] avcodec/vp8: Remove unused macros

Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 8 1 file changed, 8 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 04a2113cc8..50e879ef0b 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -44,14 +44,6 @@ # include "arm/vp8.h" #endif -#if CONFIG

[FFmpeg-devel] [PATCH 04/18] avcodec/vp8: Inline mb_layout for VP7

It is always one for VP7. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 50e879ef0b..635e45f87e 100644 --- a/libavcodec/vp8.c +++ b/l

[FFmpeg-devel] [PATCH 05/18] avcodec/vp8: Inline inner_filter for VP7

It is always true for VP7. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 635e45f87e..35d75170f1 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -2223,7 +222

[FFmpeg-devel] [PATCH 06/18] avcodec/vp8: Inline mbskip_enabled for VP7

Always zero for VP7. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 35d75170f1..c259f3588c 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -1296,7 +1296,7 @@ void decode_

[FFmpeg-devel] [PATCH 07/18] avcodec/vp8: Pass mb_y explicitly

Avoids atomic stores and loads and is a prerequisite for removing all atomic synchronizations for VP7. Notice that removing the explicit atomic_store() in vp78_decode_mb_row_sliced() does not negatively affect parallelism during slice-threading, because no check_thread_pos() ever waits for an (mb_x

[FFmpeg-devel] [PATCH 08/18] avcodec/vp8: Inline num_coeff_partitions for VP7

Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 5ecb9b07e5..f5c05cd84f 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -2398,7 +2398,7 @@ static av_always_inline int d

[FFmpeg-devel] [PATCH 09/18] avcodec/vp8: Disable slice-thread synchronization code for VP7

The VP7 decoder is not slice-threaded; by its design, VP7 only allows at most two slice threads per frame and if it were ever implemented, it would likely need custom synchronization code anyway, so disable the current code for it. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 38

[FFmpeg-devel] [PATCH 10/18] avcodec/vp8: Inline num_jobs for VP7

Always one. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index dd3d38d342..ce824cec81 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -2395,7 +2395,7 @@ static av_

[FFmpeg-devel] [PATCH 11/18] avcodec/vp8: Inline jobnr, threadnr for VP7

Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index ce824cec81..ee30fc2846 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -2518,7 +2518,7 @@ static av_always_inline int

[FFmpeg-devel] [PATCH 12/18] avcodec/vp8: Inline update_last for VP7

Always one. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index ee30fc2846..1f0deddb1a 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -2678,7 +2678,7 @@ int vp78_decode_f

[FFmpeg-devel] [PATCH 13/18] avcodec/vp8: Don't use avctx->execute2 for VP7

Our decoder does not support slice-threading at all. Signed-off-by: Andreas Rheinhardt --- vp7_decode_mb_row_sliced() btw can return errors which are currently ignored (both before and after this patch). libavcodec/vp8.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/

[FFmpeg-devel] [PATCH 14/18] avcodec/vp8: Move fade_present from context to stack

It is only an auxiliary value used for parsing the VP7 frame header. Signed-off-by: Andreas Rheinhardt --- I think that vp7_fade_frame() needs a check for whether the previous frame is writable before writing to it. Does anyone have a sample for this fading? libavcodec/vp8.c | 6 +++--- libavco

[FFmpeg-devel] [PATCH 15/18] avcodec/vp8: Disable frame-threading code for VP7

The VP7 decoder does not support frame threading. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 55 ++-- 1 file changed, 30 insertions(+), 25 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index baf9820ce6..91f3238245 100644

[FFmpeg-devel] [PATCH 16/18] avcodec/vp8dsp: Remove declarations of inexistent functions

Forgotten in d6f8476be4895c620d58e021ab880823d2fe25bf. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8dsp.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/libavcodec/vp8dsp.h b/libavcodec/vp8dsp.h index 7c6208df39..bbd7f60a4f 100644 --- a/libavcodec/vp8dsp.h +++ b/libavcodec/vp8d

[FFmpeg-devel] [PATCH 17/18] avcodec/vp8dsp: Constify src in vp8_mc_func

Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/vp8dsp.h | 2 +- libavcodec/arm/vp8dsp.h | 2 +- libavcodec/arm/vp8dsp_armv6.S | 6 +- libavcodec/loongarch/vp8_mc_lsx.c | 31 ++--- libavcodec/loongarch/vp8dsp_loongarch.h | 28 ++--- lib

[FFmpeg-devel] [PATCH 18/18] avcodec/vp8: Add const where appropriate

Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 101 --- 1 file changed, 51 insertions(+), 50 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 91f3238245..22707e2f28 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -1

Re: [FFmpeg-devel] [PATCH] libavformat/flac_picture: Don't return AVERROR_INVALIDDATA for errors with flac picture mimetype

On 9/9/2022 7:44 PM, Will Cassella wrote: In the case where the FLAC picture MIME type is not understood, fail to parse the picture silently rather than return AVERROR_INVALIDDATA. This originated from a bug reported in Chromium: https://crbug.com/1052821 Signed-off-by: Will Cassella --- lib