Re: [FFmpeg-devel] [PATCH 09/18] avcodec/hevcdec: Add stat_coeffs to HEVCABACState

2022-07-02 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-07-01 00:29:40) > The HEVC decoder has both HEVCContext and HEVCLocalContext > structures. The latter is supposed to be the structure > containing the per-slicethread state. > > Yet that is not how it is handled in practice: Each HEVCLocalContext > has a unique HEV

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: Fix audio_drift_threshold check

2022-07-02 Thread Anton Khirnov
Quoting Michael Niedermayer (2022-07-01 21:53:00) > On Thu, Jun 30, 2022 at 10:55:46AM +0200, Anton Khirnov wrote: > > Variant 2 is less bad, but the whole check seems hacky to me, since it > > seems to make assumptions about swr defaults > > > > Won't setting this unconditionally have the same ef

Re: [FFmpeg-devel] [PATCH v2 2/2] ffmpeg: add option -isync

2022-07-02 Thread Anton Khirnov
Quoting Gyan Doshi (2022-07-01 13:03:04) > > > On 2022-07-01 03:33 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-06-25 10:29:51) > >> This is a per-file input option that adjusts an input's timestamps > >> with reference to another input, so that emitted packet timestamps > >> account for

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add AVFormatContext.first_pkt_wallclock

2022-07-02 Thread Anton Khirnov
Quoting Gyan Doshi (2022-07-01 13:07:13) > > > On 2022-07-01 03:20 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-06-28 08:40:58) > >> > >> On 2022-06-28 10:43 am, Anton Khirnov wrote: > >>> Quoting Gyan Doshi (2022-06-25 10:29:50) > Stores wallclock time for the first packet received

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/hwcontext: add a function to get the AVHWDeviceType

2022-07-02 Thread Anton Khirnov
Quoting Wu, Tong1 (2022-07-01 08:51:28) > Plus, do you think adding a AV_PIX_FMT_FLAG_HWACCEL check for the > input pixel format and change the function name to > av_hwdevice_get_type_by_hwaccel_pix_fmt will help? I'd prefer not to, that name is way too long > Let users know only hardware pixel f

Re: [FFmpeg-devel] [PATCH] avdevice/lavfi: output wrapped AVFrames

2022-07-02 Thread Michael Niedermayer
On Thu, Jun 30, 2022 at 05:22:06PM +0200, Timo Rothenpieler wrote: > This avoids an extra copy of potentially quite big video frames. > Instead of copying the entire frames data into a rawvideo packet it > packs the frame into a wrapped avframe packet and passes it through > as-is. > Unfortunately,

Re: [FFmpeg-devel] [PATCH] avcodec: add PHM decoder and encoder

2022-07-02 Thread Anton Khirnov
Quoting Paul B Mahol (2022-07-01 11:23:20) > Hello, > > patch attached. > > From cec6259e75fa56a4b064f7d5a0823449d19f3b47 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Fri, 1 Jul 2022 10:06:15 +0200 > Subject: [PATCH] avcodec: add PHM decoder and encoder > > Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

2022-07-02 Thread Anton Khirnov
Quoting Vignesh Venkatasubramanian (2022-06-30 23:04:34) > Parse the alpha channel for still AVIF images and expose it as a > separate track. This is the simplest way of supporting AVIF alpha > channel in a codec independent manner (similar to how ffmpeg > supports animated AVIF with alpha channel)

Re: [FFmpeg-devel] [PATCH v3] libavcodec/qsvenc: Enable fixed QP configure in qsv CQP runtime

2022-07-02 Thread Anton Khirnov
Quoting Wenbin Chen (2022-06-23 07:32:42) > From: Yue Heng > > Enable dynamic QP configuration in runtime on qsv encoder. Through > AVFrame->metadata, we can set key "qsv_config_qp" to change QP > configuration when we encode video in CQP mode. > > Signed-off-by: Yue Heng > Signed-off-by: Wenbi

Re: [FFmpeg-devel] [PATCH] Make execute() and execute2() return FFMIN() of thread return codes

2022-07-02 Thread Anton Khirnov
Quoting Tomas Härdin (2022-06-30 14:42:42) > Hi > > Previous version of this patch failed fate-fic-avi with > THREAD_TYPE=slice THREADS=2 due to thread_execute() always returning 0. > Fixed in this version. > > The fic sample appears to indeed be broken. Some packets are truncated, > including on

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add AVFormatContext.first_pkt_wallclock

2022-07-02 Thread Gyan Doshi
On 2022-07-02 02:12 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-07-01 13:07:13) On 2022-07-01 03:20 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-06-28 08:40:58) On 2022-06-28 10:43 am, Anton Khirnov wrote: Quoting Gyan Doshi (2022-06-25 10:29:50) Stores wallclock time for the f

Re: [FFmpeg-devel] [PATCH v2 2/2] ffmpeg: add option -isync

2022-07-02 Thread Gyan Doshi
On 2022-07-02 02:12 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-07-01 13:03:04) On 2022-07-01 03:33 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-06-25 10:29:51) This is a per-file input option that adjusts an input's timestamps with reference to another input, so that emitted pac

[FFmpeg-devel] [PATCH] lavfi: Add cropdetect_video filter

2022-07-02 Thread Thilo Borgmann
Hi, $subject allows crop detection even if the video is embedded in non-black areas. Shares logic and purpose of lavfi/vf_cropdetect, though its edge detection is 8-bit formats only. Therefore this ends up in a separate filter. It would also benew GPL code if it shares living in lavfi/vf_cropde

Re: [FFmpeg-devel] [PATCH 09/18] avcodec/hevcdec: Add stat_coeffs to HEVCABACState

2022-07-02 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2022-07-01 00:29:40) >> The HEVC decoder has both HEVCContext and HEVCLocalContext >> structures. The latter is supposed to be the structure >> containing the per-slicethread state. >> >> Yet that is not how it is handled in practice: Each HEVCLocalConte

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-02 Thread Steven Hartland
I'm using concat to join multiple files from a GoPro camera including the three metadata streams, with the early return it fails as the metadata stream information is missing so map fails. Example of the command line is: ffmpeg \ -y \ -safe 0 \ -f concat \ -i list.t

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-02 Thread Steven Hartland
I should mention that this one of a few fixes needed to enable successful copying of GoPro metadata when using concat to join files, but wanted to start with from its size was the simplest one :) On Sat, 2 Jul 2022 at 11:44, Steven Hartland wrote: > I'm using concat to join multiple files from a

Re: [FFmpeg-devel] [PATCH 09/18] avcodec/hevcdec: Add stat_coeffs to HEVCABACState

2022-07-02 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Anton Khirnov: > c) The current state of affairs is btw weird: Given that the secondary > HEVCContexts are overwritten by the main HEVCContext in > hls_slice_data_wpp, the rice state that every HEVCContext starts with is > given by the state of the first HEVCContext. And which

Re: [FFmpeg-devel] [PATCH 09/18] avcodec/hevcdec: Add stat_coeffs to HEVCABACState

2022-07-02 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> Anton Khirnov: >> c) The current state of affairs is btw weird: Given that the secondary >> HEVCContexts are overwritten by the main HEVCContext in >> hls_slice_data_wpp, the rice state that every HEVCContext starts with is >> given by the state of the f

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aiffdec: cleanup size handling for extreem cases

2022-07-02 Thread Michael Niedermayer
On Wed, Mar 23, 2022 at 03:05:03PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/aiffdec.c | 29 - > 1 file changed, 12 insertions(+), 17 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730B

[FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: No channels cannot be accessed

2022-07-02 Thread Michael Niedermayer
Fixes: out of array access Fixes: 48145/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5054524173189120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 3 +++ 1 file c

[FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: adjust threshold for cinepak

2022-07-02 Thread Michael Niedermayer
Fixes: Timeout Fixes: 48158/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5986526573494272 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file chang

[FFmpeg-devel] [PATCH 2/3] avformat/cinedec: Check size and pos more

2022-07-02 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036848019263 + 134232320 cannot be represented in type 'long' Fixes: 48155/clusterfuzz-testcase-minimized-ffmpeg_dem_CINE_fuzzer-5751429207293952 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

Re: [FFmpeg-devel] [PATCH] lavfi: Add cropdetect_video filter

2022-07-02 Thread Paul B Mahol
Make it work >8 depth and use same filter name. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec: add PHM decoder and encoder

2022-07-02 Thread Paul B Mahol
On Sat, Jul 2, 2022 at 11:14 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2022-07-01 11:23:20) > > Hello, > > > > patch attached. > > > > From cec6259e75fa56a4b064f7d5a0823449d19f3b47 Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Fri, 1 Jul 2022 10:06:15 +0200 > > Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] avdevice/lavfi: output wrapped AVFrames

2022-07-02 Thread Paul B Mahol
On Sat, Jul 2, 2022 at 10:55 AM Michael Niedermayer wrote: > On Thu, Jun 30, 2022 at 05:22:06PM +0200, Timo Rothenpieler wrote: > > This avoids an extra copy of potentially quite big video frames. > > Instead of copying the entire frames data into a rawvideo packet it > > packs the frame into a w

Re: [FFmpeg-devel] [PATCH] avdevice/lavfi: output wrapped AVFrames

2022-07-02 Thread Michael Niedermayer
On Sat, Jul 02, 2022 at 02:34:17PM +0200, Paul B Mahol wrote: > On Sat, Jul 2, 2022 at 10:55 AM Michael Niedermayer > wrote: > > > On Thu, Jun 30, 2022 at 05:22:06PM +0200, Timo Rothenpieler wrote: > > > This avoids an extra copy of potentially quite big video frames. > > > Instead of copying the

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: Fix audio_drift_threshold check

2022-07-02 Thread Michael Niedermayer
On Sat, Jul 02, 2022 at 10:38:26AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2022-07-01 21:53:00) > > On Thu, Jun 30, 2022 at 10:55:46AM +0200, Anton Khirnov wrote: > > > Variant 2 is less bad, but the whole check seems hacky to me, since it > > > seems to make assumptions about sw

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: No channels cannot be accessed

2022-07-02 Thread Thilo Borgmann
Am 02.07.22 um 14:22 schrieb Michael Niedermayer: Fixes: out of array access Fixes: 48145/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5054524173189120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

[FFmpeg-devel] [PATCH] fate tests for some images

2022-07-02 Thread Paul B Mahol
Hello, Patches attached. From 39f7a74977feb229760b78525cf298f99ebf088d Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 2 Jul 2022 15:05:33 +0200 Subject: [PATCH 3/3] fate: add exr encoder tests Signed-off-by: Paul B Mahol --- tests/fate/lavf-image.mak | 24

Re: [FFmpeg-devel] [PATCH v3] libavcodec/qsvenc: Enable fixed QP configure in qsv CQP runtime

2022-07-02 Thread Paul B Mahol
On Sat, Jul 2, 2022 at 11:39 AM Anton Khirnov wrote: > Quoting Wenbin Chen (2022-06-23 07:32:42) > > From: Yue Heng > > > > Enable dynamic QP configuration in runtime on qsv encoder. Through > > AVFrame->metadata, we can set key "qsv_config_qp" to change QP > > configuration when we encode video

Re: [FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: av_channel_layout_describe_bprint: Check for buffer end

2022-07-02 Thread Michael Niedermayer
On Fri, Jul 01, 2022 at 04:30:57PM -0300, James Almer wrote: > On 7/1/2022 4:25 PM, Michael Niedermayer wrote: > > Fixes: Timeout printing a billion channels > > Fixes: > > 48099/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-6754782204788736 > > > > Found-by: continuous fuzzing proces

[FFmpeg-devel] [PATCH] fate: add EXR encoder tests

2022-07-02 Thread Paul B Mahol
Hello, patch attached. From 0b984afddc185bce0f9dc0314bada6fc879a629d Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 2 Jul 2022 15:05:33 +0200 Subject: [PATCH] fate: add EXR encoder tests Signed-off-by: Paul B Mahol --- tests/fate/lavf-image.mak | 24

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

2022-07-02 Thread Vignesh Venkatasubramanian
On Sat, Jul 2, 2022 at 2:35 AM Anton Khirnov wrote: > > Quoting Vignesh Venkatasubramanian (2022-06-30 23:04:34) > > Parse the alpha channel for still AVIF images and expose it as a > > separate track. This is the simplest way of supporting AVIF alpha > > channel in a codec independent manner (sim

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Paul B Mahol
On Sat, Jun 25, 2022 at 11:58 AM ffmpegagent wrote: > > Subtitle Filtering 2022 > === > > This is a substantial update to the earlier subtitle filtering patch > series. > A primary goal has been to address others' concerns as much as possible on > one side and to provide more

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
Paul B Mahol (12022-07-02): > Can this be properly finally be fully reviewed and accepted? As long as the patch does not have a solution to have all the utility filters (setpts, trim, concat, etc.) working with subtitles too without more code duplication, the review is just "NAK". -- Nicolas G

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Paul B Mahol
On Sat, Jul 2, 2022 at 7:18 PM Nicolas George wrote: > Paul B Mahol (12022-07-02): > > Can this be properly finally be fully reviewed and accepted? > > As long as the patch does not have a solution to have all the utility > filters (setpts, trim, concat, etc.) working with subtitles too without >

Re: [FFmpeg-devel] [RFC] avdevice/lavfi: output wrapped AVFrames

2022-07-02 Thread Nicolas George
Timo Rothenpieler (12022-06-30): > It should be definitely possible to make ffmpeg.c directly use a source > filter, but it's a bigger undertaking than fixing the shortcoming of the > lavfi avdevice for now. It is already possible. But this device is not meant for ffmpeg.c alone. It has been exp

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
Paul B Mahol (12022-07-02): > Could you please mention in relevant thread of those subtitle work where > duplication in code happened? No. Currently, there is no solution, with or without code duplication. -- Nicolas George signature.asc Description: PGP signature ___

[FFmpeg-devel] [ANNOUNCEMENT] New fork

2022-07-02 Thread Paul B Mahol
Hello, We will fork FFmpeg code under new project as current situation is unbearable. Regards. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-deve

Re: [FFmpeg-devel] [ANNOUNCEMENT] New fork

2022-07-02 Thread Nicolas George
Paul B Mahol (12022-07-02): > W} will fork FFmpeg code under new project as current situation is > unbearable. Who are "we"? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ff

Re: [FFmpeg-devel] [ANNOUNCEMENT] New fork

2022-07-02 Thread Felix LeClair
On Jul 2, 2022, at 13:33, Nicolas George wrote: Paul B Mahol (12022-07-02): W} will fork FFmpeg code under new project as current situation is unbearable. Who are "we"? -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Soft Works
From: Paul B Mahol Sent: Saturday, July 2, 2022 6:39 PM To: FFmpeg development discussions and patches Cc: Michael Niedermayer ; softworkz ; Andriy Gelman ; Andreas Rheinhardt Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022 On Sat, Jun 25, 2022 at 11:58 AM ffmpegagen

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Soft Works
> -Original Message- > From: Nicolas George > Sent: Saturday, July 2, 2022 7:18 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Michael Niedermayer ; softworkz > ; Andriy Gelman ; > Andreas Rheinhardt > Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
Soft Works (12022-07-02): > The duplication has always existed already between audio and video > filters. You could have unified and eliminated that duplication for > years, but you didn't. I have been preparing for it for years. You did not help. > Even when I would follow that demand, it wouldn

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, July 2, 2022 9:17 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Michael Niedermayer ; Andriy Gelman > ; Andreas Rheinhardt > > Subject: Re: [FFmpeg-devel] [PATCH v5

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, July 2, 2022 9:17 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Michael Niedermayer ; Andriy Gelman > ; Andreas Rheinhardt > > Subject: Re: [FFmpeg-devel] [PATCH v5

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

2022-07-02 Thread Jan Ekström
On Sat, Jul 2, 2022 at 7:32 PM Vignesh Venkatasubramanian wrote: > > On Sat, Jul 2, 2022 at 2:35 AM Anton Khirnov wrote: > > > > Quoting Vignesh Venkatasubramanian (2022-06-30 23:04:34) > > > Parse the alpha channel for still AVIF images and expose it as a > > > separate track. This is the simple

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
Soft Works (12022-07-02): > This can easily be done AFTER my patchset has been merged. With exponentially more work. Out of question. This is all I have to say to you on the subject. -- Nicolas George signature.asc Description: PGP signature ___ f

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alacdsp: Make intermediates unsigned

2022-07-02 Thread Michael Niedermayer
On Fri, Apr 29, 2022 at 08:24:09PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -14914387 + -2147418648 cannot be represented > in type 'int' > Fixes: > 46464/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-474307197311385 > > Found-by: continuous fuzzing pro

Re: [FFmpeg-devel] [RFC] avdevice/lavfi: output wrapped AVFrames

2022-07-02 Thread Timo Rothenpieler
On 02.07.2022 19:26, Nicolas George wrote: It is already possible. Yeah, I noticed that shortly after. Never before thought to run ffmpeg.c without any inputs, but as long as you stick to -filter_complex instead of plain -filter, it works great. But this device is not meant for ffmpeg.c alo

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, July 2, 2022 9:36 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Michael Niedermayer ; Andriy Gelman > ; Andreas Rheinhardt > > Subject: Re: [FFmpeg-devel] [PATCH v5

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Paul B Mahol
On Sat, Jul 2, 2022 at 10:32 PM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Nicolas George > > Sent: Saturday, July 2, 2022 9:36 PM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Cc: Michael Niedermayer ; Andriy Gelman

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Saturday, July 2, 2022 10:40 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Michael Niedermayer ; Andriy Gelman > ; Andreas Rheinhardt > > Subject: Re: [FFmpeg-devel] [PATCH v5 0

Re: [FFmpeg-devel] [PATCH v2 0/6] ICC profile support in avcodec

2022-07-02 Thread Niklas Haas
On Wed, 29 Jun 2022 12:12:45 +0200 Niklas Haas wrote: > Changes in v2: > - remove unnecessary import > - fixed assignment-instead-of-equality > - fixed #ifdef -> #if Bump. Any thoughts on this? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

2022-07-02 Thread Vignesh Venkatasubramanian
On Sat, Jul 2, 2022 at 12:35 PM Jan Ekström wrote: > > On Sat, Jul 2, 2022 at 7:32 PM Vignesh Venkatasubramanian > wrote: > > > > On Sat, Jul 2, 2022 at 2:35 AM Anton Khirnov wrote: > > > > > > Quoting Vignesh Venkatasubramanian (2022-06-30 23:04:34) > > > > Parse the alpha channel for still AVI

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
Matt Zagrabelny (12022-07-02): > Nicolas' arguments seem to be "The perfect is the enemy of the good." No, my arguments are: you don't build a third floor when your foundations are shaky. I have posted on this very mailing list a long time ago simple tasks that need to be done before considering

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Paul B Mahol
On Sat, Jul 2, 2022 at 11:22 PM Nicolas George wrote: > Matt Zagrabelny (12022-07-02): > > Nicolas' arguments seem to be "The perfect is the enemy of the good." > > No, my arguments are: you don't build a third floor when your > foundations are shaky. > > I have posted on this very mailing list a

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
Matt Zagrabelny (12022-07-02): > I guess your idea of "rudely" is different from mine. I find SW to be > polite. I guess you have not read everything since the beginning. > I am a simpleton that just reads what others write. I find subtitle support > to be desirable and SW's work to be a good ste

[FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper type for NALU type

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/hevc_sei.c | 2 +- libavcodec/hevc_sei.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c index 953633f4bd..631373e06f 100644 --- a/libavcodec/hevc_sei.c +++ b/libavcodec/hevc_sei

[FFmpeg-devel] [PATCH 02/20] avcodec/h264_sei: Don't use GetBit-API for byte-aligned reads

2022-07-02 Thread Andreas Rheinhardt
SEI NALUs and several SEI messages are naturally byte-aligned, so reading them via the bytestream-API is more natural. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_sei.c | 145 -- libavcodec/h264_sei.h | 2 +- 2 files changed, 70 insertions(+),

[FFmpeg-devel] [PATCH 03/20] configure: Add (h264|hevc)_sei subsystems

2022-07-02 Thread Andreas Rheinhardt
Currently, several components select atsc_a53, despite not using anything from it themselves. They only select it because parsing SEI messages adds an indirect dependency. But using direct dependencies is more natural, so add dedicated subsystems for them. It already allows to remove a superfluous

[FFmpeg-devel] [PATCH 04/20] avcodec/sei: Add tag to SEI enumeration

2022-07-02 Thread Andreas Rheinhardt
This makes it a usable type. Signed-off-by: Andreas Rheinhardt --- libavcodec/sei.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/sei.h b/libavcodec/sei.h index 5513590b51..f13c37c308 100644 --- a/libavcodec/sei.h +++ b/libavcodec/sei.h @@ -26,7 +26,7 @@ // The

[FFmpeg-devel] [PATCH 05/20] fftools/ffprobe: Improve description of AFD side data

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- fftools/ffprobe.c | 4 1 file changed, 4 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 5020ba484c..4430f72239 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2361,6 +2361,8 @@ static void print_pkt_side_data(WriterCon

[FFmpeg-devel] [PATCH 07/20] avcodec/h2645_sei: Factor parsing common SEI messages out

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 4 +- libavcodec/h2645_sei.c | 391 +++ libavcodec/h2645_sei.h | 133 + libavcodec/h264_parser.c | 6 +- libavcodec/h264_sei.c| 259 ++ libavcodec/h

[FFmpeg-devel] [PATCH 08/20] avcodec/h2645_sei: Factor updating H.2645 SEIs out

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h2645_sei.c | 29 + libavcodec/h2645_sei.h | 2 ++ libavcodec/h264_sei.h | 6 ++ libavcodec/h264_slice.c | 21 + libavcodec/hevc_sei.h | 5 + libavcodec/hevcdec.c| 22 +---

[FFmpeg-devel] [PATCH 09/20] avcodec/h2645_sei: Factor out freeing common SEI parts

2022-07-02 Thread Andreas Rheinhardt
This commit only factors out freeing the common SEI parts, not whether the fields indicating whether an SEI is present shall be reset. H.264 and HEVC differ in this regard (ff_h264_sei_uninit() really resets, whereas ff_hevc_reset_sei() only uninits.) and neither actually honours the persistency as

[FFmpeg-devel] [PATCH 10/20] avcodec/h2645_sei: Factor out applying SEIs to frames

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h2645_sei.c | 57 + libavcodec/h2645_sei.h | 4 +++ libavcodec/h264_slice.c | 53 +++--- libavcodec/hevcdec.c| 51 +++- 4 files changed,

[FFmpeg-devel] [PATCH 11/20] avcodec/h264_sei, sei: Make H264_SEI_FpaType generic

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h2645_sei.h | 2 +- libavcodec/h264_sei.c | 14 +++--- libavcodec/h264_sei.h | 13 - libavcodec/h264_slice.c | 16 libavcodec/sei.h| 17 + 5 files changed, 33 insertions(+), 29 dele

[FFmpeg-devel] [PATCH 12/20] avcodec/h2645_sei: Attach AVStereo3D side data generically

2022-07-02 Thread Andreas Rheinhardt
There are only slight differences between H.264 and HEVC for this side data, so it makes sense to share the code. Signed-off-by: Andreas Rheinhardt --- libavcodec/h2645_sei.c | 64 + libavcodec/h264_slice.c | 47 -- libavcodec/

[FFmpeg-devel] [PATCH 13/20] avcodec/h2645_sei: Also support Active Format Descriptor for HEVC

2022-07-02 Thread Andreas Rheinhardt
It is valid for HEVC; in fact, the ATSC-HEVC spec [1] simply refers to the relevant H.264 spec. It is also trivial to implement now: Just move applying AFD to ff_h2645_sei_to_frame() and stop ignoring AFD when parsing a HEVC SEI containing it. A FATE-test for this has been added. [1]: https://ww

[FFmpeg-devel] [PATCH 06/20] fate/h264: Add Active Format Descriptor test

2022-07-02 Thread Andreas Rheinhardt
Some samples contain Active Format Descriptors, yet the output of no test depends upon them, so that they are de-facto untested. So add a dedicated test for them. Signed-off-by: Andreas Rheinhardt --- tests/fate/h264.mak | 2 + tests/ref/fate/h264-afd | 282

[FFmpeg-devel] [PATCH 14/20] avcodec/h264_ps: Don't error out on unknown aspect ratio

2022-07-02 Thread Andreas Rheinhardt
Values 17..254 are actually only reserved and not invalid. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index e16da68dec..55ef5ce0d3 100644 --- a/libavcodec/h264_ps.c

[FFmpeg-devel] [PATCH 15/20] avcodec/h264data: Deduplicate H.26[45] aspect ratio table

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile| 17 +-- libavcodec/h2645data.c | 39 ++ libavcodec/h2645data.h | 26 +++ libavcodec/h264_metadata_bsf.c | 17 +-- libavcodec/h264_ps.c

[FFmpeg-devel] [PATCH 16/20] avcodec/hevc_ps: Fix wrong copyright years

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/hevc_ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index 832abc0ada..25620357de 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec/hevc_ps.c @@ -1,8 +1,8 @@ /* * HEVC Par

[FFmpeg-devel] [PATCH 17/20] avcodec/h264_ps: Don't output invalid chroma location

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_ps.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index 1fd7375a13..874790a3a3 100644 --- a/libavcodec/h264_ps.c +++ b/libavcodec/h264_ps.c @@ -181,7 +181,11 @@ static inl

[FFmpeg-devel] [PATCH 18/20] avcodec/h26[45]_metadata_bsf: Fix range of chroma_sample_loc_type

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_metadata_bsf.c | 2 +- libavcodec/h265_metadata_bsf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 82b57a32fd..d318bf0cee 100644 --- a/libavcodec/h

[FFmpeg-devel] [PATCH 19/20] avcodec/(h264|hevc)_ps: Factor common VUI code out

2022-07-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 5 ++- libavcodec/h2645_vui.c | 91 + libavcodec/h2645_vui.h | 49 ++ libavcodec/h264_ps.c| 69 +++ libavcodec/h264_ps.h| 10 + li

[FFmpeg-devel] [PATCH 20/20] avcodec/h2645_sei: Factor attaching film grain side-data to frame out

2022-07-02 Thread Andreas Rheinhardt
This unfortunately involved adding some parameters to ff_h2645_sei_to_frame() that will be mostly unused. Signed-off-by: Andreas Rheinhardt --- libavcodec/h2645_sei.c | 67 - libavcodec/h2645_sei.h | 5 ++- libavcodec/h264_slice.c | 59 ++---

[FFmpeg-devel] [PATCH] avutil/channel_layout: don't error out on truncated strings

2022-07-02 Thread James Almer
The doxy for av_channel_layout_describe() states that the user should look at the return value to check if the string was truncated. Returning an error code in this scenario goes against this and is an API break. This is a better fix than the one committed in 8154cb7c2f for the timeout fuzzing iss

Re: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper type for NALU type

2022-07-02 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Sunday, July 3, 2022 12:21 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper > type for NALU type > > Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 1/6] avcodec/wnv1: Check for width =1

2022-07-02 Thread Michael Niedermayer
The decoder only outputs pixels for width >1 images, fail early Fixes: Timeout Fixes: 48298/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WNV1_fuzzer-6198626319204352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael N

[FFmpeg-devel] [PATCH 4/6] avcodec/qdrw: adjust max colors to array size

2022-07-02 Thread Michael Niedermayer
Fixes: out of array access Fixes: 48429/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDRAW_fuzzer-4608329791438848 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/qdrw.c | 2 +- 1 file ch

[FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Adjust threshold for ylc

2022-07-02 Thread Michael Niedermayer
Fixes: timeout Fixes: 48523/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_YLC_fuzzer-5779666425741312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed,

[FFmpeg-devel] [PATCH 3/6] avcodec/mss4: Check image size with av_image_check_size2()

2022-07-02 Thread Michael Niedermayer
Fixes: Timeout Fixes: 48418/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MTS2_fuzzer-4834851466903552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mss4.c | 4 1 file changed, 4 in

[FFmpeg-devel] [PATCH 6/6] tools/target_dec_fuzzer: Adjust threshold for LOCO

2022-07-02 Thread Michael Niedermayer
Fixes: Timeout Fixes: 48584/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5741269015461888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed,

[FFmpeg-devel] [PATCH 2/6] tools/target_dec_fuzzer: Adjust threshold for WCMV

2022-07-02 Thread Michael Niedermayer
Fixes: Timeout Fixes: 48377/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5053331682230272 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed,

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/wnv1: Check for width =1

2022-07-02 Thread Andreas Rheinhardt
Michael Niedermayer: > The decoder only outputs pixels for width >1 images, fail early > > Fixes: Timeout > Fixes: > 48298/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WNV1_fuzzer-6198626319204352 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pro