Re: [FFmpeg-devel] [PATCH v3 1/6] avutil/frame: Add av_frame_copy_side_data() and av_frame_remove_all_side_data()

2022-06-24 Thread Xiang, Haihao
On Wed, 2022-06-01 at 18:01 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > Signed-off-by: Anton Khirnov > --- > doc/APIchanges | 4 +++ > libavutil/frame.c | 67 +++-- > libavutil/frame.h | 32 ++ >

Re: [FFmpeg-devel] [PATCH v2] avcodec/audiotoolboxenc: return external error if encode failed

2022-06-24 Thread Steven Liu
"zhilizhao(赵志立)" 于2022年6月24日周五 14:59写道: > > > > > On Jun 24, 2022, at 1:59 PM, Steven Liu wrote: > > > > because the AudioConverterFillComplexBuffer can return 0 or 1 if > > success. > > so set the ret to 0 it AudioConverterFillComplexBuffer success and > > return ret value for success or return

Re: [FFmpeg-devel] [PATCH 01/13] lavc/jpeg2000dec: Finer granularity threading

2022-06-24 Thread Tomas Härdin
lör 2022-06-18 klockan 16:50 +0200 skrev Anton Khirnov: > Quoting Tomas Härdin (2022-06-14 16:39:00) > > Patch 12 in this series is optional since it's just me getting the > > speed up on a specific machine > > > > /Tomas > > > > From 115aa26c343419e81c1b5ba0bfdb1615cbec27e9 Mon Sep 17 00:00:00 >

Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO

2022-06-24 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2022-06-23 16:21:18) >> Anton Khirnov: >>> Quoting Carotti, Elias (2022-06-21 10:48:07) Hi, extending AVVideoEncParams was the first hypothesis I made but it didn't seem it was the proper place to add the mb_info flags. I ma

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/hcadec: Don't use GetBit-API for byte-aligned reads

2022-06-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/hcadec.c | 80 ++--- > 1 file changed, 39 insertions(+), 41 deletions(-) > > diff --git a/libavcodec/hcadec.c b/libavcodec/hcadec.c > index 4e84942bb9..73ff62139d 100644 > --- a/lib

Re: [FFmpeg-devel] [PATCH 1/6] avformat/matroskaenc: Split assembling CodecPrivate from writing it

2022-06-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This is in preparation for splitting writing and updating > extradata more thoroughly later. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskaenc.c | 74 --- > 1 file changed, 46 insertions(+), 28 deletions(-) > > diff -

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: Only trim RBSP trailing padding if it exists

2022-06-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It does not exist for NALUs for which the SODB is empty; > it also does not exist for NALUs for which not even > the complete header is present. The former category contains > end of sequence and end of bitstream units. The latter category > consists of one-byte HEVC units (th

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_sei: Fix check for SEI end

2022-06-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The intention behind the current check seems to be to check for > the rbsp_trailing_bits() syntax structure which is always 0x80 > for valid SEI messages. Yet this is wrong: These trailing bits > are not part of the GetBitContext -- they have already been > stripped in ff_h264

[FFmpeg-devel] [PATCH] avcodec/libx264: Avoid duplicating strings

2022-06-24 Thread Andreas Rheinhardt
Notice that the underlying allocations were unchecked. Signed-off-by: Andreas Rheinhardt --- libavcodec/libx264.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 616d855067..98ec030865 100644 --- a/libavcod

Re: [FFmpeg-devel] [PATCH v4 0/4] add ARIB caption decoder using libaribcaption

2022-06-24 Thread TADANO Tokumei
3rd ping! Are there any other objections to this patch set? If not, would someone push it to the repository? A comment inline: On 2022/06/17 0:30, TADANO Tokumei wrote: On 2022/06/16 22:40, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of TADANO Tokumei Sent:

Re: [FFmpeg-devel] [PATCH v8 1/2] avcodec/libjxldec: properly tag output colorspace

2022-06-24 Thread Niklas Haas
On Thu, 23 Jun 2022 16:02:08 +0200 Anton Khirnov wrote: > Quoting Leo Izen (2022-06-02 04:14:11) > > +case JXL_TRANSFER_FUNCTION_GAMMA: > > +if (jxl_color->gamma > 2.199 && jxl_color->gamma < 2.201) > > +return AVCOL_TRC_GAMMA22; > > +else if (jxl_color->gamma > 2.7

Re: [FFmpeg-devel] [PATCH 2/4] lavc: add standalone cached bitstream reader

2022-06-24 Thread Andreas Rheinhardt
Anton Khirnov: > +/** > + * Return n bits from the buffer, n has to be in the 0-32 range. > + */ > +static inline uint32_t bitstream_read(BitstreamContext *bc, unsigned int n) > +{ > +if (!n) > +return 0; > + > +if (n > bc->bits_left) { > +refill_32(bc); > +if (bc->

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: fix AV1 decoding error

2022-06-24 Thread James Almer
On 6/24/2022 1:04 AM, Zhao Zhili wrote: From: Zhao Zhili cuvidParseVideoData only supports pure OBUs, it report unknown error with AV1CodecConfigurationRecord. Check whether extradata is AV1CodecConfigurationRecord and skip the first 4 bytes to fix the issue. The bug is revealed in ffmpeg cmd

Re: [FFmpeg-devel] [PATCH 2/4] lavc: add standalone cached bitstream reader

2022-06-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Anton Khirnov: >> +/* Unwind the cache so a refill_32 can fill it again. */ >> +static inline void bitstream_unwind(BitstreamContext *bc) >> +{ >> +int unwind = 4; >> +int unwind_bits = unwind * 8; > > I'm surprised that you used signed types here. > >> + >> +if

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: correct timestamp overflow on multiple pcr loopback

2022-06-24 Thread Sébastien Rossi
The issue I tried to patch is that on ts stream that last more than 26,5h (time between pcr loopback) we had pts and dts discontinuities. In wrap_timestamp function in demux.c, I've seen there's some code to correct timestamp overflow, but when the stream last more than 26,5h, timestamps are upper

Re: [FFmpeg-devel] [PATCH 2/4] lavc: add standalone cached bitstream reader

2022-06-24 Thread Andreas Rheinhardt
Anton Khirnov: > From: Alexandra Hájková > > The cached bitstream reader was originally written by Alexandra Hájková > for Libav, with significant input from Kostya Shishkov and Luca Barbato. > It was then committed to FFmpeg in ca079b09549, by merging it with the > implementation of the current

[FFmpeg-devel] [PATCH 1/2] avcodec/cuviddec: fix null pointer dereference

2022-06-24 Thread Zhao Zhili
From: Zhao Zhili It can happened on error path of cuvid_decode_init(). --- libavcodec/cuviddec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index fc9c0515fe..2f6bbdc7d8 100644 --- a/libavcodec/cuviddec.c +++ b/libavco

[FFmpeg-devel] [PATCH 2/2] avcodec/cuviddec: reindent after previous commit

2022-06-24 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/cuviddec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 2f6bbdc7d8..3e29cde83b 100644 --- a/libavcodec/cuviddec.c +++ b/libavcodec/cuviddec.c @@ -662,15 +662,15 @@ static av_co

Re: [FFmpeg-devel] [PATCH] avformat/hls:use EXT-X-START instead of live_start_index if it's in playlist

2022-06-24 Thread Li Kai
From: Li Kai Signed-off-by: Li Kai --- libavformat/hls.c | 55 +-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 8204f55df3..bfb20f6492 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c

[FFmpeg-devel] [PATCH v9 0/2] libjxl Colorspace fixes

2022-06-24 Thread Leo Izen
Changes in v9: - Minor cosmetic changes, as requested by Anton K - More liberally commented casework, a.r.b. Haasn - Structured flow to be a bit more readable Changes in v8: - Use avutil/csp for both encoding and decoding - Handle the non-XYB case with an attached ICC Profile on decoding - clean u

[FFmpeg-devel] [PATCH v9 1/2] avcodec/libjxldec: properly tag output colorspace

2022-06-24 Thread Leo Izen
Whether an ICC profile is present or not, the decoder should now properly tag the colorspace of pixel data received by the decoder. --- libavcodec/libjxldec.c | 214 + 1 file changed, 197 insertions(+), 17 deletions(-) diff --git a/libavcodec/libjxldec.c b/

[FFmpeg-devel] [PATCH v9 2/2] avcodec/libjxlenc: properly read input colorspace

2022-06-24 Thread Leo Izen
Whether an ICC profile is present or not, the libjxl encoder wrapper should now properly read colorspace tags and forward them to libjxl appropriately, rather than just assume sRGB as before. It will also print warnings when colorimetric assumptions are made about the input data. --- libavcodec/li

Re: [FFmpeg-devel] [PATCH v9 0/2] libjxl Colorspace fixes

2022-06-24 Thread Niklas Haas
LGTM On Fri, 24 Jun 2022 12:50:54 -0400 Leo Izen wrote: > Changes in v9: > - Minor cosmetic changes, as requested by Anton K > - More liberally commented casework, a.r.b. Haasn > - Structured flow to be a bit more readable > > Changes in v8: > - Use avutil/csp for both encoding and decoding > -

[FFmpeg-devel] [PATCH] avcodec/x86/h264_qpel: Remove unused functions

2022-06-24 Thread Andreas Rheinhardt
Forgotten in 4011a76494a5ff6844312813bc753aae8e54c2f0. The reason for this is that these functtions are marked as av_always_inline and GCC does not emit warnings if such functions are unused, so this went unnoticed. Yet Clang does, so this commit removes them. Signed-off-by: Andreas Rheinhardt --

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: correct timestamp overflow on multiple pcr loopback

2022-06-24 Thread Michael Niedermayer
Hi On Fri, Jun 24, 2022 at 02:30:19PM +0200, Sébastien Rossi wrote: > The issue I tried to patch is that on ts stream that last more than 26,5h > (time between pcr loopback) we had pts and dts discontinuities. In > wrap_timestamp function in demux.c, I've seen there's some code to correct > timest

Re: [FFmpeg-devel] [PATCH] Use proper header for OpenBSD PPC CPU detection

2022-06-24 Thread Michael Niedermayer
On Wed, Mar 02, 2022 at 08:34:53PM -0500, Brad Smith wrote: > Use the proper header for PPC CPU detection code. sys/param.h includes > sys/types, but sys/types.h is the more appropriate header to be used > here. will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611E

[FFmpeg-devel] [PATCH] avformat/http: include version.h

2022-06-24 Thread James Almer
This is needed to get LIBAVFORMAT_VERSION, used as part of the user agent. Fixes a recent regression. Signed-off-by: James Almer --- I dislike the fact AV_STRINGIFY() silenced the warning that should have been printed about LIBAVFORMAT_VERSION being undefined. Before: ./ffmpeg -h protocol=http -

Re: [FFmpeg-devel] [PATCH] avformat/http: include version.h

2022-06-24 Thread Andreas Rheinhardt
James Almer: > This is needed to get LIBAVFORMAT_VERSION, used as part of the user agent. > Fixes a recent regression. > > Signed-off-by: James Almer > --- > I dislike the fact AV_STRINGIFY() silenced the warning that should have been > printed about LIBAVFORMAT_VERSION being undefined. > > Befo

Re: [FFmpeg-devel] [PATCH] avformat/http: include version.h

2022-06-24 Thread James Almer
On 6/24/2022 11:06 PM, Andreas Rheinhardt wrote: James Almer: This is needed to get LIBAVFORMAT_VERSION, used as part of the user agent. Fixes a recent regression. Signed-off-by: James Almer --- I dislike the fact AV_STRINGIFY() silenced the warning that should have been printed about LIBAVFOR

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc_hevc: Use default value from MSDK to set bf.

2022-06-24 Thread Xiang, Haihao
On Mon, 2022-06-20 at 17:06 +0800, Wenbin Chen wrote: > Change the default value of "bf" for hevc_qsv to -1. 8 isn't the best > choice so let MSDK to decide the number of b frames. > > Signed-off-by: Wenbin Chen > --- > libavcodec/qsvenc_hevc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [FFmpeg-devel] [PATCH v3] libavcodec/qsvenc: Enable fixed QP configure in qsv CQP runtime

2022-06-24 Thread Xiang, Haihao
On Thu, 2022-06-23 at 13:32 +0800, Wenbin Chen wrote: > From: Yue Heng > > Enable dynamic QP configuration in runtime on qsv encoder. Through > AVFrame->metadata, we can set key "qsv_config_qp" to change QP > configuration when we encode video in CQP mode. > > Signed-off-by: Yue Heng > Signed-o

Re: [FFmpeg-devel] [PATCH] avformat/hls:use EXT-X-START instead of live_start_index if it's in playlist

2022-06-24 Thread 少宇李
Hi Steven, Please review code. I changed code, but I still have a question. If EXT-X-START tag in playlist and users set live_start_index, the live_start_index will not work for current codes, which makes maybe users confused. Is that OK? In other hand, if make live_start_index valid when EXT-X-

Re: [FFmpeg-devel] [PATCH 1/4] get_bits: move check_marker() to mpegvideodec.h

2022-06-24 Thread Andreas Rheinhardt
Anton Khirnov: > It is only used by mpegvideo-based decoders - specifically mpeg12, intelh263, > ituh263, mpeg4video. > --- > Resending the set rebased against current master (there conflicts with > 2d764069be3b4092dc986467660607d922023332) and with patch 04 skipped, as > Andreas pointed out issues

Re: [FFmpeg-devel] [PATCH] avformat/hls:use EXT-X-START instead of live_start_index if it's in playlist

2022-06-24 Thread Steven Liu
> 在 2022年6月25日,12:32,少宇李 写道: > > Hi Steven, > > Please review code. > > I changed code, but I still have a question. > If EXT-X-START tag in playlist and users set live_start_index, the > live_start_index will not work > for current codes, which makes maybe users confused. > Is that OK? for c

Re: [FFmpeg-devel] [PATCH] avformat/hls:use EXT-X-START instead of live_start_index if it's in playlist

2022-06-24 Thread Li Kai
Ok, I add allowed_x_start option, and the option default is 0. So current users will not be affected. please review again. At last, Thanks your tips. Steven Liu 于2022年6月25日周六 12:51写道: > > > > 在 2022年6月25日,12:32,少宇李 写道: > > > > Hi Steven, > > > > Please review code. > > > > I changed code, but

Re: [FFmpeg-devel] [PATCH] avformat/hls:use EXT-X-START instead of live_start_index if it's in playlist

2022-06-24 Thread Li Kai
Ok, I add allowed_x_start option, and the option default is 0. So current users will not be affected. please review again. At last, Thanks your tips. Steven Liu 于2022年6月25日周六 12:51写道: > > > > 在 2022年6月25日,12:32,少宇李 写道: > > > > Hi Steven, > > > > Please review code. > > > > I changed code, but

[FFmpeg-devel] [PATCH] avfilter/Makefile: always make colorspace.o

2022-06-24 Thread Gyan Doshi
Unbreaks libavfilter builds when configured with a subset of filters. drawutils added ff_draw_init2 in 6c3a82f043 which calls functions defined in colorspace.c. So the latter needs to be built alongside the former. --- libavfilter/Makefile | 11 ++- 1 file changed, 6 insertions(+), 5 dele

Re: [FFmpeg-devel] [PATCH] avfilter/Makefile: always make colorspace.o

2022-06-24 Thread Andreas Rheinhardt
Gyan Doshi: > Unbreaks libavfilter builds when configured with a subset of filters. > > drawutils added ff_draw_init2 in 6c3a82f043 which calls functions defined in > colorspace.c. So the latter needs to be built alongside the former. > --- And why not just build it when it's needed? > libavfil

Re: [FFmpeg-devel] [PATCH] avfilter/Makefile: always make colorspace.o

2022-06-24 Thread Gyan Doshi
On 2022-06-25 12:16 pm, Andreas Rheinhardt wrote: Gyan Doshi: Unbreaks libavfilter builds when configured with a subset of filters. drawutils added ff_draw_init2 in 6c3a82f043 which calls functions defined in colorspace.c. So the latter needs to be built alongside the former. --- And why no