James Almer: > This is needed to get LIBAVFORMAT_VERSION, used as part of the user agent. > Fixes a recent regression. > > Signed-off-by: James Almer <jamr...@gmail.com> > --- > I dislike the fact AV_STRINGIFY() silenced the warning that should have been > printed about LIBAVFORMAT_VERSION being undefined. > > Before: > ./ffmpeg -h protocol=http > -user_agent <string> .D......... override User-Agent header > (default "Lavf/LIBAVFORMAT_VERSION") > > After: > ./ffmpeg -h protocol=http > -user_agent <string> .D......... override User-Agent header > (default "Lavf/59.25.100") > > I suppose this is a regression since the recent work to split the library > version defines into separate headers. > > libavformat/http.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/http.c b/libavformat/http.c > index f80ea7bf35..c5c48c7900 100644 > --- a/libavformat/http.c > +++ b/libavformat/http.c > @@ -41,6 +41,7 @@ > #include "network.h" > #include "os_support.h" > #include "url.h" > +#include "version.h" > > /* XXX: POST protocol is not completely implemented because ffmpeg uses > * only a subset of it. */
LGTM. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".