tor 2022-06-02 klockan 21:19 +0200 skrev Michael Niedermayer:
> On Thu, Jun 02, 2022 at 11:54:39AM +0200, Tomas Härdin wrote:
> > ons 2022-06-01 klockan 18:23 +0200 skrev Michael Niedermayer:
> > > On Wed, Jun 01, 2022 at 06:21:19PM +0200, Michael Niedermayer
> > > wrote:
> > > > On Tue, May 31, 20
> +bytestream_put_buffer(&buf, "qoif", 4);
> +bytestream_put_be32(&buf, avctx->width);
> +bytestream_put_be32(&buf, avctx->height);
> +bytestream_put_byte(&buf, channels);
> +bytestream_put_byte(&buf, 0);
bytestream_put_byte(&buf, avctx->color_trc == AVCOL_TRC_LINEAR);
Looks g
The simplified parsing currently in `mov_write_ac3_tag` trusts the content
of the packets a bit too much (the AC-3 parser returns all data fed to it,
including any possible data before the start code), while the existing E-AC-3
logic does proper header validation by utilizing the (E-)AC-3 parser.
From: Jan Ekström
Required by MP4's AC3SpecificBox and MPEG-TS AC-3 audio_descriptor,
of which the former is implemented in our MP4 writer.
Signed-off-by: Jan Ekström
---
libavcodec/ac3_parser.c | 3 +++
libavcodec/ac3_parser_internal.h | 1 +
2 files changed, 4 insertions(+)
diff --
From: Jan Ekström
This simplifies the code to no longer have #ifs in a manner which
does not require handling avpriv_ac3_parse_header returning ENOSYS.
As an existing example, the MPEG-TS muxer already requires the AC-3
parser, and in order to fix existing issues with the current AC-3
movenc cod
From: Jan Ekström
Add the AC-3 frame type, as well as early exit from additional packet
parsing in case of AC-3, as only a single packet is required to get
the required information.
Additionally, expose ac3_bit_rate_code via the eac3_info struct as
it is required for AC3SpecificBox.
Signed-off-
From: Jan Ekström
Signed-off-by: Jan Ekström
---
libavformat/movenc.c | 66 ++--
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 2589f2f4bb..5bc1f4c7a4 100644
--- a/libavformat/movenc.c
+++
From: Jan Ekström
Signed-off-by: Jan Ekström
---
libavformat/movenc.c | 46 +---
1 file changed, 18 insertions(+), 28 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 5bc1f4c7a4..a1daf3598b 100644
--- a/libavformat/movenc.c
+++
From: Jan Ekström
Signed-off-by: Jan Ekström
---
libavformat/movenc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index a1daf3598b..0f92f0e04e 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -415,7 +415,10 @
The afconvert utility shipped with MacOS supports muxing of FLAC
in CAF, see afconvert help output on a recent Mac here:
https://hydrogenaud.io/index.php?topic=122509.0 A file created
with afconvert free of copyright (licensed CC0) can be found here:
http://www.audiograaf.nl/misc_stuff/afconvert-FL
On Fri, Jun 3, 2022 at 3:12 PM Martijn van Beurden wrote:
> The afconvert utility shipped with MacOS supports muxing of FLAC
> in CAF, see afconvert help output on a recent Mac here:
> https://hydrogenaud.io/index.php?topic=122509.0 A file created
> with afconvert free of copyright (licensed CC0)
On Fri, Jun 03, 2022 at 11:17:54AM +0200, Tomas Härdin wrote:
> tor 2022-06-02 klockan 21:19 +0200 skrev Michael Niedermayer:
> > On Thu, Jun 02, 2022 at 11:54:39AM +0200, Tomas Härdin wrote:
> > > ons 2022-06-01 klockan 18:23 +0200 skrev Michael Niedermayer:
> > > > On Wed, Jun 01, 2022 at 06:21:1
Hi all,
We are Qt (www.qt.io), a global software company with a strong presence in more
than 70 industries and is the leading independent technology behind 1+ billion
devices and applications.
Now we are working on integrating the FFmpeg library into our Multimedia module
as one of the possibl
Paul B Mahol:
>
> +
> +packet_size = avctx->width * avctx->height * 16LL;
> +if ((ret = ff_alloc_packet(avctx, pkt, packet_size)) < 0)
> +return ret;
> +
Where does 16 come from? Looking at the code, the factor should be
channels + 1 per pixel (and 14 + 8 byte for header + footer)
On Fri, Jun 3, 2022 at 6:17 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Paul B Mahol:
> >
> > +
> > +packet_size = avctx->width * avctx->height * 16LL;
> > +if ((ret = ff_alloc_packet(avctx, pkt, packet_size)) < 0)
> > +return ret;
> > +
>
> Where does 16 come
Paul B Mahol:
> On Fri, Jun 3, 2022 at 6:17 PM Andreas Rheinhardt <
> andreas.rheinha...@outlook.com> wrote:
>
>> Paul B Mahol:
>>>
>>> +
>>> +packet_size = avctx->width * avctx->height * 16LL;
>>> +if ((ret = ff_alloc_packet(avctx, pkt, packet_size)) < 0)
>>> +return ret;
>>> +
>>
On Fri, Jun 3, 2022 at 6:21 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Paul B Mahol:
> > On Fri, Jun 3, 2022 at 6:17 PM Andreas Rheinhardt <
> > andreas.rheinha...@outlook.com> wrote:
> >
> >> Paul B Mahol:
> >>>
> >>> +
> >>> +packet_size = avctx->width * avctx->height *
Martijn van Beurden:
> The afconvert utility shipped with MacOS supports muxing of FLAC
> in CAF, see afconvert help output on a recent Mac here:
> https://hydrogenaud.io/index.php?topic=122509.0 A file created
> with afconvert free of copyright (licensed CC0) can be found here:
> http://www.audiog
On Fri, Jun 3, 2022 at 8:11 PM Andreas Rheinhardt
wrote:
>
> Martijn van Beurden:
> > The afconvert utility shipped with MacOS supports muxing of FLAC
> > in CAF, see afconvert help output on a recent Mac here:
> > https://hydrogenaud.io/index.php?topic=122509.0 A file created
> > with afconvert f
Op vr 3 jun. 2022 om 19:11 schreef Andreas Rheinhardt
:
>
> You are not checking this; this could lead to uninitialized values being
> used in flac_parse_block_header() below.
>
Yes, indeed, thank you. Interestingly enough, I copied this bit
directly from mov_read_dfla in mov.c, so I'll send a pat
20 matches
Mail list logo
