On Monday, 11 April 2022 at 05:15, "zhilizhao(赵志立)" wrote:
> > On Apr 11, 2022, at 5:31 AM, Dominik 'Rathann' Mierzejewski
> > wrote:
> >
> > Dear Developers!
> > I'm curious about the warning about configuration mismatch between
> > ff* binaries and the libraries introduced in:
> >
> > https://
On 2022-04-11 12:16 pm, Paul B Mahol wrote:
On Tue, Mar 22, 2022 at 6:47 PM Andreas Unterweger
wrote:
The last encoded frame is now fetched on EOF. It was previously left in
the encoder and caused a "1 frame left in queue" warning.
Signed-off-by: Andreas Unterweger
---
doc/examples/tra
Quoting zhilizhao(赵志立) (2022-04-11 05:15:59)
>
>
> > On Apr 11, 2022, at 5:31 AM, Dominik 'Rathann' Mierzejewski
> > wrote:
> >
> > Dear Developers!
> > I'm curious about the warning about configuration mismatch between ff*
> > binaries and the libraries introduced in:
> >
> > https://git.ffm
Quoting Marton Balint (2022-04-10 20:11:59)
> 60 fps content have "Number of Frames" set to 30 in the tmcd atom, but the
> frame duration / timescale reflects the original video frame rate.
>
> Therefore we multiply the frame count with the quotient of the rounded
> timecode
> frame rate and the
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 32
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_feedback.c | 306 ++
4 files changed, 340 insertions(+)
create mode 100644 libavfilter/vf_feedback.c
dif
Quoting Soft Works (2022-04-08 17:27:10)
> > Furthermore, remember that this is just the first step. There will be
> > further patchsets converting the other components. I intend to
> > upstream
> > them gradually one after the other. Your suggestion would require me
> > to
> > instead write the wh
It is not used in the encoder.
---
Does this fix the crash?
---
libavcodec/snow.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/libavcodec/snow.c b/libavcodec/snow.c
index 0a500695ce..97b0448dbf 100644
--- a/libavcodec/snow.c
+++ b/libavcodec/snow.c
@@ -513,16 +5
It has only a single member.
---
libavcodec/avcodec.c | 4 ++--
libavcodec/encode.c | 7 +++
libavcodec/internal.h | 12 +++-
3 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c
index c7daa385e7..e0f38ac42a 100644
--- a/liba
Several encoders (roqvideo, svq1, snow, and the mpegvideo family)
currently call ff_get_buffer(). However this function is written
assuming it is called by a decoder. Though nothing has been obviously
broken by this until now, this may change in the future.
To avoid potential future issues, introd
Ping. The same kind of issue like `doc/examples/transcode_aac: Don't ignore
last encoded frame.
https://patchwork.ffmpeg.org/project/ffmpeg/patch/8fd28808-07f8-9458-b032-8792c67a3...@gmail.com/
> On Jul 14, 2021, at 11:02 AM, Zhao Zhili wrote:
>
> ---
> v4: break when error occured in fread, f
lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
I was just prevented from pushing this patch[1] because of a trailing
whitespace in a .texi file. This seems to be a new git hook as it wasn't
in place before April 1.
Doc files should be excluded from whitespace checks as they may be
required for formatting.
Regards,
Gyan
[1]:
https://
On 2022-04-11 03:49 pm, Gyan Doshi wrote:
I was just prevented from pushing this patch[1] because of a trailing
whitespace in a .texi file. This seems to be a new git hook as it
wasn't in place before April 1.
Doc files should be excluded from whitespace checks as they may be
required fo
From: Jan Ekström
Additionally, they should not be probed, as this is essentially
various types of binary data.
Signed-off-by: Jan Ekström
---
libavformat/mpegts.c| 53 +
tests/fate/mpegts.mak | 3 ++
tests/ref/fate/mpegts-prob
Anton Khirnov (12022-04-11):
> I would prefer to not show all that noise in the banner, which would
> also resolve the confusion. Build information should be reduced to
> loglevel verbose IMO.
The people who do actual support on the users mailing-list and tracker
do not want that.
Regards,
--
On 4/9/22 09:17, Anton Khirnov wrote:
Quoting Leo Izen (2022-04-05 18:55:03)
+
+/* check for negative zero, our default */
+if (1.0f / ctx->distance == 1.0f / -0.0f) {
IIRC division by zero is UB. Why not make the default -1.0 and then just
check whether the number is negative?
The l
Quoting Leo Izen (2022-04-11 13:16:21)
>
> On 4/9/22 09:17, Anton Khirnov wrote:
> > Quoting Leo Izen (2022-04-05 18:55:03)
> >> +
> >> +/* check for negative zero, our default */
> >> +if (1.0f / ctx->distance == 1.0f / -0.0f) {
> > IIRC division by zero is UB. Why not make the default -1
Quoting Hendrik Leppkes (2022-04-09 17:44:45)
> > >
> > > Also, pointers from av_malloc() cannot be passed to av_realloc(). You
> > > need to allocate it with av_realloc() in the first place.
> >
> > Is this documented? afaik realloc() can be used with malloc'd pointers.
> > It will, i assume, also
Fixes: issues with non trivial linesize
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_frei0r.c | 40
1 file changed, 32 insertions(+), 8 deletions(-)
diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c
index 9cd0098e73..c9b698897f 1006
On Mon, Apr 11, 2022 at 1:50 PM Jan Ekström wrote:
>
> From: Jan Ekström
>
> Additionally, they should not be probed, as this is essentially
> various types of binary data.
>
> Signed-off-by: Jan Ekström
Changes from v1:
- checking the length of descriptor to at least be 3 bytes before
reading
On Sun, Apr 10, 2022 at 4:41 PM Michael Niedermayer
wrote:
> On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote:
> [...]
>
> > +if (stat_ret < 0) {
>
> > +av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. We
> tried:\n");
> > +av_log(h, AV_LOG_INFO, "- $
Merged as e254af31549ce6b4964936b3fe2124c3a18e69f8
On Sun, 10 Apr 2022 22:47:21 +0200 Niklas Haas wrote:
> Merging this tomorrow if there's no further feedback.
>
> On Tue, 05 Apr 2022 13:31:35 +0200 Niklas Haas wrote:
> > From: Niklas Haas
> >
> > This is mostly straightforward. The major co
From: Niklas Haas
These are needed beyond just vf_colorspace, so give them a new home in
colorspace.h.
In addition to moving code around, also merge the white point and
primary coefficients into a single struct to slightly increase the
convenience and shrink the size of the new API by avoiding t
From: Niklas Haas
Related to #9673, this helper exists to facilitate "guessing" the right
primary tags from a given set of raw primary coefficients.
The cutoff value of 0.001 was chosen by experimentation. The smallest
"false negative" delta observed in practice was 0.023329, while the
largest "
From: Niklas Haas
This introduces an optional dependency on lcms2 into FFmpeg. lcms2 is a
widely used library for ICC profile handling, which apart from being
used in almost all major image processing programs and video players,
has also been deployed in browsers. As such, it's both widely availa
From: Niklas Haas
This filter is designed to specifically cover the task of generating ICC
profiles (and attaching them to output frames) on demand. Other tasks,
such as ICC profile loading/stripping, or ICC profile application, are
better left to separate filters (or included into e.g. vf_setpar
From: Niklas Haas
This filter is designed to parse embedded ICC profiles and attempt
extracting colorspace tags from them, updating the AVFrame metadata
accordingly.
This is intentionally made a separate filter, rather than being part of
libavcodec itself, so that it's an opt-in behavior for the
On Sat, Apr 9, 2022 at 2:45 PM Marton Balint wrote:
>
>
> On Wed, 6 Apr 2022, Tristan Matthews wrote:
>
> > This is basically a cosmetic change (no functional difference).
> >
> > ---
> > libavformat/librtmp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavform
This avoids having to do one pass to calculate the full length to allocate
followed by a second pass to actually append values.
---
libavformat/librtmp.c | 123 +++---
1 file changed, 32 insertions(+), 91 deletions(-)
diff --git a/libavformat/librtmp.c b/libavf
James Almer:
> Old GCC and Clang apparently don't like it.
>
> Signed-off-by: James Almer
> ---
> Untested since i don't have old compilers.
>
> See
>
> http://fate.ffmpeg.org/report.cgi?time=20220409194302&slot=x86_64-netbsd-clang-noopt
> http://fate.ffmpeg.org/report.cgi?time=20220409194413&s
On 4/11/2022 5:39 AM, Anton Khirnov wrote:
It has only a single member.
---
libavcodec/avcodec.c | 4 ++--
libavcodec/encode.c | 7 +++
libavcodec/internal.h | 12 +++-
3 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec
Paul B Mahol:
> Signed-off-by: Paul B Mahol
> ---
> doc/filters.texi | 32
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/vf_feedback.c | 306 ++
> 4 files changed, 340 insertions(+)
> create mode 100644
On Sun, Apr 10, 2022 at 11:46:24AM -0300, James Almer wrote:
>
>
> On 4/10/2022 11:14 AM, Michael Niedermayer wrote:
> > On Sat, Apr 09, 2022 at 08:56:05PM +0200, Marton Balint wrote:
> > >
> > >
> > > On Wed, 30 Mar 2022, Michael Niedermayer wrote:
> > >
> > > > On Tue, Mar 29, 2022 at 06:33:
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 38 +
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_feedback.c | 312 ++
4 files changed, 352 insertions(+)
create mode 100644 libavfilter/vf_feedback.c
di
On Mon, Apr 11, 2022 at 3:32 PM Michael Niedermayer
wrote:
> Fixes: issues with non trivial linesize
>
> Signed-off-by: Michael Niedermayer
> ---
> libavfilter/vf_frei0r.c | 40
> 1 file changed, 32 insertions(+), 8 deletions(-)
>
> diff --git a/libavfil
James Almer:
>
>
> On 4/10/2022 11:14 AM, Michael Niedermayer wrote:
>> On Sat, Apr 09, 2022 at 08:56:05PM +0200, Marton Balint wrote:
>>>
>>>
>>> On Wed, 30 Mar 2022, Michael Niedermayer wrote:
>>>
On Tue, Mar 29, 2022 at 06:33:06PM -0300, James Almer wrote:
> On 3/29/2022 6:24 PM, Mich
On 4/11/2022 10:31 AM, Michael Niedermayer wrote:
Fixes: issues with non trivial linesize
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_frei0r.c | 40
1 file changed, 32 insertions(+), 8 deletions(-)
diff --git a/libavfilter/vf_frei0r.c b/
On Sat, Apr 9, 2022 at 9:21 PM Paul B Mahol wrote:
>
> will apply soon
>
Forgot to apply, will apply in next 24h.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above,
On Mon, Apr 11, 2022 at 10:49:34AM +0200, Anton Khirnov wrote:
> It is not used in the encoder.
> ---
> Does this fix the crash?
> ---
> libavcodec/snow.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
This patch alone works fine
i havnt tested it in conjunction with other
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Monday, April 11, 2022 9:47 AM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] warning about configuration mismatch
> between ff* binaries and libraries
>
> Q
On Mon, Apr 11, 2022 at 07:34:40PM +0200, Paul B Mahol wrote:
> On Mon, Apr 11, 2022 at 3:32 PM Michael Niedermayer
> wrote:
>
> > Fixes: issues with non trivial linesize
> >
> > Signed-off-by: Michael Niedermayer
> > ---
> > libavfilter/vf_frei0r.c | 40
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Monday, April 11, 2022 10:29 AM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [RFC] Switching ffmpeg.c to a threaded
> architecture
>
> Quoting Soft Works
On Mon, Apr 11, 2022 at 03:01:57PM -0300, James Almer wrote:
>
>
> On 4/11/2022 10:31 AM, Michael Niedermayer wrote:
> > Fixes: issues with non trivial linesize
> >
> > Signed-off-by: Michael Niedermayer
> > ---
> > libavfilter/vf_frei0r.c | 40
> > 1
On Mon, Apr 11, 2022 at 10:10 PM Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Anton Khirnov
> > Sent: Monday, April 11, 2022 10:29 AM
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [RFC] Swit
On Mon, 11 Apr 2022, Anton Khirnov wrote:
Quoting Marton Balint (2022-04-10 20:11:59)
60 fps content have "Number of Frames" set to 30 in the tmcd atom, but the
frame duration / timescale reflects the original video frame rate.
Therefore we multiply the frame count with the quotient of the
> -Original Message-
> From: ffmpeg-devel On Behalf Of Paul
> B Mahol
> Sent: Monday, April 11, 2022 10:52 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [RFC] Switching ffmpeg.c to a threaded
> architecture
>
> On Mon, Apr 11, 2022
On Sat, Apr 9, 2022 at 5:35 AM Paul B Mahol wrote:
> On Fri, Apr 8, 2022 at 10:41 PM Wang Cao >
> wrote:
>
> > On Fri, Apr 8, 2022 at 11:40 AM Paul B Mahol wrote:
> >
> > > On Thu, Apr 7, 2022 at 11:56 PM Wang Cao <
> > wangcao-at-google@ffmpeg.org
> > > >
> > > wrote:
> > >
> > > > On Thu,
Fixes: signed integer overflow: 9223371898743775808 - -13811100 cannot be
represented in type 'long'
Fixes:
46245/clusterfuzz-testcase-minimized-ffmpeg_dem_OGG_fuzzer-5075129786302464
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-
Fixes: issues with non trivial linesize
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_frei0r.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c
index 9cd0098e73..f11ae6e55c 100644
--- a/libavfilt
Signed-off-by: Michael Niedermayer
---
libavfilter/video.c | 8 ++--
libavfilter/video.h | 1 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavfilter/video.c b/libavfilter/video.c
index b2f0cdf88a..e9eb110ff4 100644
--- a/libavfilter/video.c
+++ b/libavfilter/video.c
@@ -
Fixes: signed integer overflow: -2515507630940093440 * 4 cannot be represented
in type 'long'
Fixes:
46318/clusterfuzz-testcase-minimized-ffmpeg_dem_GENH_fuzzer-5009637474172928
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Mi
MJPEG is the only mpegvideo-based encoder making use of it.
Fixes linking failures in case mpegvideo_enc.c is compiled
with AMV, LJPEG and MJPEG encoders disabled.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_enc.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
If one encodes MJPEG with a single slice and uses input with
AV_FRAME_DATA_ICC_PROFILE side data, the current allocation code
in ff_mpv_encode_picture() will always increase the size of the
temporary buffer used for allocating packets by the size needed
for to write the ICC chunk even when the curr
It is a remnant of the old way for user-supplied buffers;
it is always-true since 93016f5d1d280f9cb7856883af287fa66affc04c.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_enc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec
The size of the ICC chunk has already been accounted for when
the packet's buffer was initially set in ff_mpv_encode_picture()
and the header (including the ICC chunk) has already been written
at this point.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mjpegenc.c | 1 -
1 file changed, 1 del
Tests using the transcode and stream_remux functions have some common
requirements (namely the file and pipe protocols as well as the framecrc
muxer) and also other commonalities: The create a file and read it
immediately afterwards, so that they typically rely on a corresponding
muxer+demuxer pair
This also adds previously forgotten requirements. E.g. fate-jpg-icc
actually depends on the png decoder, so that it should not be run
when e.g. zlib is disabled, yet it happens, see
http://fate.ffmpeg.org/report.cgi?time=20220411182746&slot=x86_64-archlinux-gcc-disablezlib
Signed-off-by: Andreas R
It also adds the missing depenencies on the file and pipe protocols
and the framecrc muxer.
Signed-off-by: Andreas Rheinhardt
---
tests/fate/subtitles.mak | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/fate/subtitles.mak b/tests/fate/subtitles.mak
index 8375cf2898..bc4
Simplifies the checks.
Signed-off-by: Andreas Rheinhardt
---
tests/fate/oma.mak | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/tests/fate/oma.mak b/tests/fate/oma.mak
index a088feff21..7e2020b7d0 100644
--- a/tests/fate/oma.mak
+++ b/tests/fate/oma.mak
@@ -8,14 +8
Changes:
v14:
- Make changes requested by Anton from v13
-- make encoder return refcounted packet
-- use av_realloc for realloc loop
-- use -1 as default instead of -0.0
- Remove unnecessary JXL_DEC_FRAME subscribe event from decoder
- Update FFCodec declarations to use the new macros, reb
This commit adds support to libavcodec to read
encoded Jpeg XL images. Jpeg XL is intended to be an
extended-life replacement to legacy mjpeg.
---
MAINTAINERS | 1 +
libavcodec/codec_desc.c | 9 +
libavcodec/codec_id.h | 1 +
3 files changed, 11 insertions(+)
diff --git a/MA
This commit adds decoding support to libavcodec
for Jpeg XL images via the external library libjxl.
---
MAINTAINERS | 1 +
configure | 5 +
doc/general_contents.texi | 7 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c| 1 +
libavcodec/libjxl.c
This commit adds encoding support to libavcodec
for Jpeg XL images via the external library libjxl.
---
configure | 3 +-
libavcodec/Makefile| 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/libjxlenc.c | 382 +
4 files changed, 386 inse
This commit adds support to libavformat for muxing
and demuxing Jpeg XL images as image2 streams.
---
MAINTAINERS| 1 +
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/img2.c | 1 +
libavformat/img2dec.c | 18 ++
libavformat/img
64 matches
Mail list logo
