Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2022-03-28 Thread Thilo Borgmann
Am 22.03.22 um 09:36 schrieb Thilo Borgmann: Am 18.03.22 um 15:04 schrieb Paul B Mahol: On 3/18/22, Thilo Borgmann wrote: On 12 Mar 2022, at 10:06, Thilo Borgmann wrote: Am 09.03.22 um 18:31 schrieb Paul B Mahol: On 3/8/22, Thilo Borgmann wrote: Am 07.03.22 um 20:06 schrieb Paul B Mahol

[FFmpeg-devel] [PATCH 1/2] avcodec/apedec: fix a integer overflow in long_filter_high_3800()

2022-03-28 Thread Michael Niedermayer
Fixes: signed integer overflow: -2146549696 - 3923884 cannot be represented in type 'int' Fixes: 45907/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5992380584558592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/2] avcodec/takdsp: Fix integer overflow in decorrelate_sf()

2022-03-28 Thread Michael Niedermayer
Fixes: signed integer overflow: -101 * 71041254 cannot be represented in type 'int' Fixes: 45938/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-4687974320701440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data

2022-03-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavutil/frame.c | 1 + libavutil/frame.h | 6 + libavutil/mastering_display_metadata.c | 23 + libavutil/mastering_display_metadata.h | 45 ++ 4 files

[FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message

2022-03-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevc_sei.c | 19 +++ libavcodec/hevc_sei.h | 8 libavcodec/hevcdec.c | 10 ++ tests/ref/fate/hevc-dv-rpu | 6 ++ 4 files changed, 43 insertions(+) diff --git a/libavcodec/hevc_sei.c

[FFmpeg-devel] [PATCH v2 3/4] avfilter/vf_showinfo: add support for ambient viewing environment metadata

2022-03-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_showinfo.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 12d3931..f11b3d9 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -651,

[FFmpeg-devel] [PATCH v2 4/4] fftools/ffprobe: add support for ambient viewing environment metadata

2022-03-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- fftools/ffprobe.c | 5 + tests/ref/fate/hevc-dv-rpu | 6 ++ 2 files changed, 11 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 05c167e..39773c4 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -260

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration

2022-03-28 Thread Danil Chapovalov
On Thu, Mar 24, 2022 at 7:27 PM James Zern wrote: > > On Thu, Mar 24, 2022 at 6:12 AM Danil Chapovalov > wrote: > > > > --- > > libavcodec/libvpxenc.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index dff1d06b0e..463a65

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message

2022-03-28 Thread Michael Niedermayer
On Mon, Mar 28, 2022 at 08:41:09PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/hevc_sei.c | 19 +++ > libavcodec/hevc_sei.h | 8 > libavcodec/hevcdec.c | 10 ++ > tests/ref/fate/hevc-d

[FFmpeg-devel] [PATCH v7 2/2] avcodec/mjpegenc: support writing ICC profiles

2022-03-28 Thread Niklas Haas
From: Niklas Haas This is mostly straightforward. The major complication is that, as a result of the 16-bit chunk size limitation, ICC profiles may need to be split up into multiple chunks. We also need to make sure to allocate enough extra space in the packet to fit the ICC profile, so modify b

[FFmpeg-devel] [PATCH v7 1/2] avcodec/pngenc: support writing iCCP chunks

2022-03-28 Thread Niklas Haas
From: Niklas Haas We re-use the PNGEncContext.zstream for deflate-related operations. Other than that, the code is pretty straightforward. Special care needs to be taken to avoid writing more than 79 characters of the profile description (the maximum supported). To write the (dynamically sized)

[FFmpeg-devel] [PATCH] libavformat/rtmp: Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2022-03-28 Thread jb
Hello, this patch was originally from William Martin, I just adapt it to the newest ffmpeg version. Regards Jonathan From 89b441ce47614035a545da1a7ce46c53ccf165e5 Mon Sep 17 00:00:00 2001 From: jb-alvarado Date: Mon, 28 Mar 2022 17:07:57 +0200 Subject: [PATCH] Adding a flag to give user the

[FFmpeg-devel] [PATCH] libavformat/rtmp: Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2022-03-28 Thread jb
Hello, this patch was originally from William Martin, I just adapt it to the newest ffmpeg version. Regards Jonathan From 89b441ce47614035a545da1a7ce46c53ccf165e5 Mon Sep 17 00:00:00 2001 From: jb-alvarado Date: Mon, 28 Mar 2022 17:07:57 +0200 Subject: [PATCH] Adding a flag to give user the

Re: [FFmpeg-devel] [PATCH v9 1/1] avformat: Add IPFS protocol support.

2022-03-28 Thread Michael Niedermayer
On Fri, Mar 18, 2022 at 03:50:05PM +0100, Mark Gaiser wrote: > This patch adds support for: > - ffplay ipfs:// > - ffplay ipns:// > > IPFS data can be played from so called "ipfs gateways". > A gateway is essentially a webserver that gives access to the > distributed IPFS network. > > This protoc

Re: [FFmpeg-devel] [PATCH v9 1/1] avformat: Add IPFS protocol support.

2022-03-28 Thread Mark Gaiser
On Mon, Mar 28, 2022 at 6:19 PM Michael Niedermayer wrote: > On Fri, Mar 18, 2022 at 03:50:05PM +0100, Mark Gaiser wrote: > > This patch adds support for: > > - ffplay ipfs:// > > - ffplay ipns:// > > > > IPFS data can be played from so called "ipfs gateways". > > A gateway is essentially a webse

Re: [FFmpeg-devel] [PATCH v9 1/1] avformat: Add IPFS protocol support.

2022-03-28 Thread Michael Niedermayer
On Mon, Mar 28, 2022 at 06:34:33PM +0200, Mark Gaiser wrote: > On Mon, Mar 28, 2022 at 6:19 PM Michael Niedermayer > wrote: > > > On Fri, Mar 18, 2022 at 03:50:05PM +0100, Mark Gaiser wrote: > > > This patch adds support for: > > > - ffplay ipfs:// > > > - ffplay ipns:// > > > > > > IPFS data can

Re: [FFmpeg-devel] [PATCH v9 1/1] avformat: Add IPFS protocol support.

2022-03-28 Thread Mark Gaiser
On Mon, Mar 28, 2022 at 6:44 PM Michael Niedermayer wrote: > On Mon, Mar 28, 2022 at 06:34:33PM +0200, Mark Gaiser wrote: > > On Mon, Mar 28, 2022 at 6:19 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Fri, Mar 18, 2022 at 03:50:05PM +0100, Mark Gaiser wrote: > > > > T

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-28 Thread Vignesh Venkatasubramanian
On Tue, Mar 22, 2022 at 9:46 AM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif > > Sa

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-28 Thread Vignesh Venkatasubramanian
On Tue, Mar 22, 2022 at 2:56 PM Vignesh Venkatasubramanian wrote: > > On Wed, Mar 16, 2022 at 10:02 AM Vignesh Venkatasubramanian > wrote: > > > > Add support for parsing AVIF still images. This patches supports > > AVIF still images that have exactly 1 item (i.e.) no alpha channel. > > Essential

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-28 Thread Paul B Mahol
On Mon, Mar 28, 2022 at 7:07 PM Vignesh Venkatasubramanian < vigneshv-at-google@ffmpeg.org> wrote: > On Tue, Mar 22, 2022 at 2:56 PM Vignesh Venkatasubramanian > wrote: > > > > On Wed, Mar 16, 2022 at 10:02 AM Vignesh Venkatasubramanian > > wrote: > > > > > > Add support for parsing AVIF sti

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/vmdaudio: Fix channels count bug

2022-03-28 Thread Michael Niedermayer
On Mon, Mar 21, 2022 at 09:19:44PM +0100, Michael Niedermayer wrote: > Fixes: division by zero > Fixes: > 45811/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VMDAUDIO_fuzzer-6412592581574656 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ff

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-28 Thread Vignesh Venkatasubramanian
On Mon, Mar 28, 2022 at 10:11 AM Paul B Mahol wrote: > > On Mon, Mar 28, 2022 at 7:07 PM Vignesh Venkatasubramanian < > vigneshv-at-google@ffmpeg.org> wrote: > > > On Tue, Mar 22, 2022 at 2:56 PM Vignesh Venkatasubramanian > > wrote: > > > > > > On Wed, Mar 16, 2022 at 10:02 AM Vignesh Venkat

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-28 Thread Vignesh Venkatasubramanian
Add support for parsing AVIF still images. This patches supports AVIF still images that have exactly 1 item (i.e.) no alpha channel. Essentially, we will have to parse the "iloc" box and populate the mov index. With this patch, we can decode still AVIF images like so: ffmpeg -i image.avif image.pn

Re: [FFmpeg-devel] [PATCH 01/10] checkasm: Add vc1dsp in-loop deblocking filter tests

2022-03-28 Thread Ben Avison
On 25/03/2022 22:53, Martin Storsjö wrote: On Fri, 25 Mar 2022, Ben Avison wrote: +#define CHECK_LOOP_FILTER(func) \ +    do {    \ +    if (check_func(h.func, "vc1dsp." #func)) {  

[FFmpeg-devel] [PATCH] MAINTAINERS: add Niklas Haas for vf_libplacebo.c

2022-03-28 Thread Niklas Haas
From: Niklas Haas So I can merge my own changes to this filter after they pass peer review, as well as keeping it in sync with upstream API changes / new features. Signed-off-by: Niklas Haas --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-28 Thread Vignesh Venkatasubramanian
Add support for parsing AVIF still images. This patches supports AVIF still images that have exactly 1 item (i.e.) no alpha channel. Essentially, we will have to parse the "iloc" box and populate the mov index. With this patch, we can decode still AVIF images like so: ffmpeg -i image.avif image.pn

[FFmpeg-devel] [PATCH] avcodec/binkaudio: reset ch_offset on errors

2022-03-28 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: 45955/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_DCT_fuzzer-4842044192849920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/binkaudio.c

Re: [FFmpeg-devel] [PATCH] avcodec/binkaudio: reset ch_offset on errors

2022-03-28 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add Niklas Haas for vf_libplacebo.c

2022-03-28 Thread James Almer
On 3/28/2022 3:33 PM, Niklas Haas wrote: From: Niklas Haas So I can merge my own changes to this filter after they pass peer review, as well as keeping it in sync with upstream API changes / new features. Signed-off-by: Niklas Haas --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) d

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add Niklas Haas for vf_libplacebo.c

2022-03-28 Thread Lynne
28 Mar 2022, 22:14 by jamr...@gmail.com: > On 3/28/2022 3:33 PM, Niklas Haas wrote: > >> From: Niklas Haas >> >> So I can merge my own changes to this filter after they pass peer >> review, as well as keeping it in sync with upstream API changes / new >> features. >> >> Signed-off-by: Niklas Haas

[FFmpeg-devel] [PATCH v8 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-03-28 Thread Nil Admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c remove MAX_PATH limit. --- libavutil/wchar_filename.h | 51 ++ 1 file changed, 51 insertions(+) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index 90f0

[FFmpeg-devel] [PATCH v8 2/6] libavformat/avisynth.c: Remove MAX_PATH limit

2022-03-28 Thread Nil Admirari
--- libavformat/avisynth.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 8ba2bde..f7bea8c 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -34,6 +34,7 @@ /* Platform-specific directives. */

[FFmpeg-devel] [PATCH v8 3/6] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-03-28 Thread Nil Admirari
--- compat/w32dlfcn.h | 78 ++- 1 file changed, 64 insertions(+), 14 deletions(-) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index 52a94ef..0f41f50 100644 --- a/compat/w32dlfcn.h +++ b/compat/w32dlfcn.h @@ -25,6 +25,30 @@ #if (_WIN32_WINNT < 0x

[FFmpeg-devel] [PATCH v8 4/6] fftools/cmdutils.c: Remove MAX_PATH limit and replace fopen with av_fopen_utf8

2022-03-28 Thread Nil Admirari
--- fftools/cmdutils.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 5d7cdc3..a66dbb2 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -37,6 +37,7 @@ #include "libswresample/swre

[FFmpeg-devel] [PATCH v8 5/6] fftools: Enable long path support on Windows (fixes #8885)

2022-03-28 Thread Nil Admirari
--- fftools/Makefile | 5 + fftools/fftools.manifest | 10 ++ fftools/manifest.rc | 3 +++ 3 files changed, 18 insertions(+) create mode 100644 fftools/fftools.manifest create mode 100644 fftools/manifest.rc diff --git a/fftools/Makefile b/fftools/Makefile index 5ebf5

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add Niklas Haas for vf_libplacebo.c

2022-03-28 Thread Hendrik Leppkes
On Mon, Mar 28, 2022 at 10:31 PM Lynne wrote: > > 28 Mar 2022, 22:14 by jamr...@gmail.com: > > > On 3/28/2022 3:33 PM, Niklas Haas wrote: > > > >> From: Niklas Haas > >> > >> So I can merge my own changes to this filter after they pass peer > >> review, as well as keeping it in sync with upstream

[FFmpeg-devel] [PATCH v8 6/6] fftools: Use UTF-8 on Windows

2022-03-28 Thread Nil Admirari
--- fftools/fftools.manifest | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/fftools.manifest b/fftools/fftools.manifest index 30b7d8f..d1ac1e4 100644 --- a/fftools/fftools.manifest +++ b/fftools/fftools.manifest @@ -3,8 +3,10 @@ -http://schemas.microso

[FFmpeg-devel] [PATCH 1/3] avcodec/libaomenc: Add parameter for avif single image encoding

2022-03-28 Thread Vignesh Venkatasubramanian
Add a parameter to libaom-av1 encoder to enforce some of the single image constraints in the AV1 encoder. Setting this flag will limit the encoder to producing exactly one frame and the sequence header that is produced by the encoder will be conformant to the AVIF specification [1]. Part of Fixing

[FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-03-28 Thread Vignesh Venkatasubramanian
Add a parameter to omit seq header when generating the av1C atom. For now, this does not change any behavior. This will be used by a follow-up patch to add AVIF support. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/av1.c | 7 +-- libavformat/av1.h | 4 +++- liba

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-28 Thread Vignesh Venkatasubramanian
Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specifiation: https://aomediacodec.github.io/av1-avif Sample usage for still image: ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif Sample usage for animated AVIF image: ffmpeg -i video.mp4 animated.avif We can re-u

Re: [FFmpeg-devel] [PATCH v9 4/5] avformat/image2: add Jpeg XL as image2 format

2022-03-28 Thread Leo Izen
On 3/24/22 14:38, Michael Niedermayer wrote: make -j32 tools/probetest && tools/probetest 256 4096 testing size=1 testing size=2 testing size=4 Assertion n>=0 && n<=32 failed at libavcodec/get_bits.h:549 Aborted (core dumped) Not sure where this failure is coming from as I cannot reproduce it.

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add Niklas Haas for vf_libplacebo.c

2022-03-28 Thread Niklas Haas
On Mon, 28 Mar 2022 22:31:36 +0200 Lynne wrote: > I'm not okay with this. I don't mind anyone pushing approved patches, > but I still want to review and have final say on all Vulkan code. Could you > change that? The contents of vf_libplacebo is not "Vulkan code". The only thing Vulkan about it i

Re: [FFmpeg-devel] [PATCH v9 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

2022-03-28 Thread Leo Izen
On 3/23/22 11:08, Andreas Rheinhardt wrote: +temp = av_realloc(ctx->buffer, ctx->buffer_size); +if (!temp) { +av_freep(&ctx->buffer); If you free this, you will be in a scenario where ctx->buffer is NULL, yet ctx->buffer_size is > 0. This is inconsistent a

Re: [FFmpeg-devel] [PATCH v7 4/6] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones, and fopen with av_fopen_utf8

2022-03-28 Thread nil-admirari
Fails to apply to current master. New version of these patches can be found at: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-March/294654.html. Please review. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH v9 1/5] avcodec/jpegxl: add Jpeg XL image codec and parser

2022-03-28 Thread Leo Izen
On 3/23/22 10:45, Andreas Rheinhardt wrote: Leo Izen: + /* any other box is skipped at this point */ +AV_WB32(tag_str, tag); +av_log(avctx, AV_LOG_VERBOSE, "skipping jxl container box: %s\n", tag_str); 1. tag_str is potentially not-zero terminated. 2. If tag_str contains a \0,

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message

2022-03-28 Thread lance . lmwang
On Mon, Mar 28, 2022 at 04:30:49PM +0200, Michael Niedermayer wrote: > On Mon, Mar 28, 2022 at 08:41:09PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/hevc_sei.c | 19 +++ > > libavcodec/hevc_sei.h |

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add Niklas Haas for vf_libplacebo.c

2022-03-28 Thread Lynne
28 Mar 2022, 23:13 by ffm...@haasn.xyz: > On Mon, 28 Mar 2022 22:31:36 +0200 Lynne wrote: > >> I'm not okay with this. I don't mind anyone pushing approved patches, >> but I still want to review and have final say on all Vulkan code. Could you >> change that? >> > > The contents of vf_libplacebo

[FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: rename mov_get_channel_label() to better reflect its purpose

2022-03-28 Thread James Almer
This function turns a mov channel label into a lavf native bitmask. Signed-off-by: James Almer --- libavformat/mov_chan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index f52239d347..4607540297 100644 --- a/libavformat/

[FFmpeg-devel] [PATCH 2/7] avformat/mov_chan: add a few missing channel label mappings

2022-03-28 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov_chan.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index 4607540297..98773bb460 100644 --- a/libavformat/mov_chan.c +++ b/libavformat/mov_chan.c @@ -485,12 +485,1

[FFmpeg-devel] [PATCH 3/7] avformat/mov_chan: use a higher log level for a debug message

2022-03-28 Thread James Almer
Trace is too noisy and this line is useful enough to get it printed at debug level. Signed-off-by: James Almer --- libavformat/mov_chan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index 98773bb460..3c23142f35 100644 --- a/

[FFmpeg-devel] [PATCH 4/7] avformat/movenc: write channel descriptions when a known layout or a bitmap can't be used

2022-03-28 Thread James Almer
Fixes part of ticket #2865 Signed-off-by: James Almer --- libavformat/mov_chan.c | 75 -- libavformat/mov_chan.h | 8 +++-- libavformat/movenc.c | 37 +++-- 3 files changed, 90 insertions(+), 30 deletions(-) diff --git a/libavformat/mov

[FFmpeg-devel] [PATCH 5/7] avformat/mov_chan: move the definition of MovChannelLayoutTag to the header

2022-03-28 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov_chan.c | 104 - libavformat/mov_chan.h | 104 + 2 files changed, 104 insertions(+), 104 deletions(-) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index 4

[FFmpeg-devel] [PATCH 6/7] avformat/movenc: don't use mono layout when a front center label is expected

2022-03-28 Thread James Almer
On output streams where a multichannel stream needs to be stored as one track per channel, each track will have a channel layout describing the position of the channel they contain. For the track with front center, the mov muxer was using the mov layout "mono" instead of the label for the front cen

[FFmpeg-devel] [PATCH 7/7] fate: add a test for writing channel descriptions in mov

2022-03-28 Thread James Almer
Signed-off-by: James Almer --- tests/fate/mov.mak | 11 ++- tests/ref/fate/mov-channel-description | 42 ++ 2 files changed, 52 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/mov-channel-description diff --git a/tests/fate/mov.mak

[FFmpeg-devel] FFmpeg 5.0.1

2022-03-28 Thread Michael Niedermayer
Hi all I intend to do a 5.0.1 release from the release/5.0 branch in the next days as its high time to make a new release with all the bugfixes so if you want to backport something please do so thx -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the l

Re: [FFmpeg-devel] FFmpeg 5.0.1

2022-03-28 Thread Diederick C. Niehorster
Hi Michael, On Tue, Mar 29, 2022 at 1:31 AM Michael Niedermayer wrote: > > Hi all > > I intend to do a 5.0.1 release from the release/5.0 branch in the next days > as its high time to make a new release with all the bugfixes > so if you want to backport something please do so Could you include t

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: use a larger buffer for find_info_tag

2022-03-28 Thread zhilizhao(赵志立)
Ping. > On Aug 14, 2021, at 6:43 PM, Zhao Zhili wrote: > > The upper limit of strlen(streamid) is 512. Use a larger buffer for > future proof, for example, deal with percent-encoding. > --- > libavformat/libsrt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavforma

Re: [FFmpeg-devel] [PATCH v4 00/22] avdevice (mostly dshow) enhancements

2022-03-28 Thread Roger Pack
The dshow patches LGTM. I think I'm in favor of the realtime behavior changes as well. Cheers! On Fri, Mar 25, 2022 at 8:11 AM Diederick Niehorster wrote: > > This patch series implements a series of features, mostly enhancing the > dshow avdevice, but also adding new functionality to avformat.

[FFmpeg-devel] [PATCH v3 1/2] avformat/mov: log the right variable

2022-03-28 Thread Zhao Zhili
--- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 6c847de164..54a92e3486 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -5023,7 +5023,7 @@ static int mov_read_trun(MOVContext *c, AVIOContext *pb, MOVAto

[FFmpeg-devel] [PATCH v3 2/2] avformat/movenc: sidx earliest_presentation_time is applied after editlist

2022-03-28 Thread Zhao Zhili
Fix #8334 --- libavformat/movenc.c | 6 +- tests/ref/fate/movenc | 10 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 46d66c29c2..079fc70d4a 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -4753,7 +

Re: [FFmpeg-devel] [PATCH v3 1/4] avformat/movenc: fix assert failure in get_cluster_duration()

2022-03-28 Thread zhilizhao(赵志立)
> On Mar 1, 2022, at 9:32 PM, zhilizhao(赵志立) wrote: > > >> On Feb 27, 2022, at 2:49 PM, Gyan Doshi wrote: >> >> >> >> On 2022-02-27 12:04 pm, "zhilizhao(赵志立)" wrote: >>> Ping. >>> On Dec 31, 2021, at 7:36 PM, Zhao Zhili wrote: When editlist is disabled, the workaournd met

Re: [FFmpeg-devel] [PATCH 1/5] avformat/movenc: remove unused argument from get_sample_flags()

2022-03-28 Thread zhilizhao(赵志立)
Ping for patch 1-3. > On Dec 3, 2021, at 1:06 PM, Zhao Zhili wrote: > > --- > libavformat/movenc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 38ff90833a..634a829f28 100644 > --- a/libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: use a larger buffer for find_info_tag

2022-03-28 Thread myp...@gmail.com
On Tue, Mar 29, 2022 at 10:21 AM "zhilizhao(赵志立)" wrote: > > Ping. > > > On Aug 14, 2021, at 6:43 PM, Zhao Zhili wrote: > > > > The upper limit of strlen(streamid) is 512. Use a larger buffer for > > future proof, for example, deal with percent-encoding. > > --- > > libavformat/libsrt.c | 2 +- >

Re: [FFmpeg-devel] [EXT] [PATCH v5 7/7] avcodec/v4l2_m2m_dec: setup capture queue before enqueue the first frame

2022-03-28 Thread Ming Qian
> From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > Sent: Saturday, March 26, 2022 11:43 PM > To: FFmpeg development discussions and patches > Cc: Ming Qian > Subject: Re: [FFmpeg-devel] [EXT] [PATCH v5 7/7] avcodec/v4l2_m2m_dec: > setup capture queue before enqueue the first frame > > Caut