Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-19 Thread Hendrik Leppkes
On Sat, Mar 19, 2022 at 4:04 AM James Almer wrote: > > The function is not meant to clear codec parameters, and the lavf demux code > relies on this behavior. > Regression since 327efa66331ebdc0087c6b656059a8df2f404019. > > Signed-off-by: James Almer > --- > libavcodec/avcodec.c | 6 ++ > 1

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()

2022-03-19 Thread Anton Khirnov
Quoting James Almer (2022-03-19 04:04:07) > The function is not meant to clear codec parameters, and the lavf demux code > relies on this behavior. Maybe it shouldn't? Which code is it exactly? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH 1/3] avformat/slndec: add support to set channel layout

2022-03-19 Thread Anton Khirnov
Quoting James Almer (2022-03-18 23:19:05) > Signed-off-by: James Almer > --- > libavformat/pcmdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c > index dcd13787d5..a2bcfc2814 100644 > --- a/libavformat/pcmdec.c > +++ b/li

Re: [FFmpeg-devel] [PATCH] Allow to modify max qp configuration parameter in libvpx without reseting the encoder

2022-03-19 Thread Anton Khirnov
Quoting Lynne (2022-03-16 13:37:55) > 16 Mar 2022, 13:13 by danilchap-at-google@ffmpeg.org: > > > On Mon, Mar 14, 2022 at 4:28 PM Jan Ekström wrote: > > > >> > >> On Mon, Mar 14, 2022 at 3:05 PM Danil Chapovalov > >> wrote: > >> > > >> > --- > >> > >> Probably something a la > >> > >> avcode

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/codec_internal: Add FFCodec, hide internal part of AVCodec

2022-03-19 Thread Anton Khirnov
Very nice. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] lavf/mpegenc: fix memory leak in the fifo since the new API

2022-03-19 Thread Anton Khirnov
Quoting Nicolas Gaullier (2022-03-18 14:15:04) > The older av_fifo_realloc2 implemented an auto grow that should be ported as > such. > > This introduces a limitation in the buffer size. > AUTO_GROW_DEFAULT_BYTES is currently 1MB which seems reasonable here. Are you sure it's enough? 1MB packets

Re: [FFmpeg-devel] [PATCH] avfilter/video: fix shadowed variable

2022-03-19 Thread Anton Khirnov
Quoting Zhao Zhili (2022-03-10 07:53:38) > --- > libavfilter/video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/video.c b/libavfilter/video.c > index fa3d588044..b2f0cdf88a 100644 > --- a/libavfilter/video.c > +++ b/libavfilter/video.c > @@ -50,7 +50,7 @@

[FFmpeg-devel] [PATCH v7 1/5] avcodec/jpegxl: add Jpeg XL image codec and parser

2022-03-19 Thread Leo Izen
This commit adds support to libavcodec to read and parse encoded Jpeg XL images. Jpeg XL is intended to be an extended-life replacement to legacy mjpeg. --- MAINTAINERS|2 + libavcodec/Makefile|1 + libavcodec/codec_desc.c|9 + libavcodec/codec_id.h |

[FFmpeg-devel] [PATCH v7 2/5] avcodec/libjxl: add Jpeg XL decoding via libjxl

2022-03-19 Thread Leo Izen
This commit adds decoding support to libavcodec for Jpeg XL images via the external library libjxl. --- MAINTAINERS | 1 + configure | 5 + doc/general_contents.texi | 7 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/libjxl.c

[FFmpeg-devel] [PATCH v7 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

2022-03-19 Thread Leo Izen
This commit adds encoding support to libavcodec for Jpeg XL images via the external library libjxl. --- configure | 3 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/libjxlenc.c | 386 + 4 files changed, 390 inse

[FFmpeg-devel] [PATCH v7 4/5] avformat/image2: add Jpeg XL as image2 format

2022-03-19 Thread Leo Izen
This commit adds support to libavformat for muxing and demuxing Jpeg XL images as image2 streams. --- libavformat/allformats.c | 1 + libavformat/img2.c | 1 + libavformat/img2dec.c| 21 + libavformat/img2enc.c| 6 +++--- libavformat/mov.c| 1 + libavf

[FFmpeg-devel] [PATCH v7 5/5] fate/jpegxl: add JPEG XL demux and parse FATE test

2022-03-19 Thread Leo Izen
Add a fate test for the JPEG XL parser in libavcodec and its image2 wrapper inside libavformat. --- tests/fate/image.mak| 10 ++ tests/ref/fate/jxl-parse-codestream | 6 ++ tests/ref/fate/jxl-parse-container | 6 ++ 3 files changed, 22 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_superframe_split_bsf: Check in size

2022-03-19 Thread Michael Niedermayer
On Fri, Mar 18, 2022 at 06:56:19PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: Out of array read > > Fixes: > > 45137/clusterfuzz-testcase-minimized-ffmpeg_BSF_VP9_SUPERFRAME_SPLIT_fuzzer-4984270639202304 > > > > Found-by: continuous fuzzing process > > https://github.com/

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: Check channel mask against num channels

2022-03-19 Thread Michael Niedermayer
On Fri, Mar 18, 2022 at 08:38:28AM -0300, James Almer wrote: > > > On 3/18/2022 8:27 AM, Michael Niedermayer wrote: > > On Thu, Mar 17, 2022 at 10:00:18PM -0300, James Almer wrote: > > > > > > > > > On 3/17/2022 9:07 PM, James Almer wrote: > > > > > > > > > > > > On 3/17/2022 8:52 PM, James A

Re: [FFmpeg-devel] [PATCH 4/4] ffmpeg: replace custom channel_layout code with an SpecifierOpt based one

2022-03-19 Thread Michael Niedermayer
On Fri, Mar 18, 2022 at 07:47:48PM -0300, James Almer wrote: > This is cleaner and allows fine tuning which stream the option is applied to. > > Signed-off-by: James Almer > --- > fftools/ffmpeg.h | 2 ++ > fftools/ffmpeg_opt.c | 84 ++-- > 2 files ch

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxfdec: Check count in mxf_read_strong_ref_array()

2022-03-19 Thread Michael Niedermayer
On Mon, Mar 14, 2022 at 08:19:51PM +0100, Tomas Härdin wrote: > sön 2022-03-13 klockan 00:52 +0100 skrev Michael Niedermayer: > > Signed-off-by: Michael Niedermayer > > --- > >  libavformat/mxfdec.c | 8 +++- > >  1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfdec: Check for avio_read() failure in mxf_read_strong_ref_array()

2022-03-19 Thread Michael Niedermayer
On Mon, Mar 14, 2022 at 08:21:04PM +0100, Tomas Härdin wrote: > sön 2022-03-13 klockan 00:52 +0100 skrev Michael Niedermayer: > > Signed-off-by: Michael Niedermayer > > --- > >  libavformat/mxfdec.c | 8 +++- > >  1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/

Re: [FFmpeg-devel] [PATCH 0/6] avcodec/vc1: Arm optimisations

2022-03-19 Thread Martin Storsjö
Hi Ben, On Thu, 17 Mar 2022, Ben Avison wrote: The VC1 decoder was missing lots of important fast paths for Arm, especially for 64-bit Arm. This submission fills in implementations for all functions where a fast path already existed and the fallback C implementation was taking 1% or more of the

Re: [FFmpeg-devel] [PATCH 0/6] avcodec/vc1: Arm optimisations

2022-03-19 Thread Martin Storsjö
On Sun, 20 Mar 2022, Martin Storsjö wrote: The other main issue I'd like to request is to indent the assembly similarly to the rest of the existing assembly. For the 32 bit assembly, your patches do match the surrounding code, but for the 64 bit assembly, your patches align the operands column

Re: [FFmpeg-devel] [PATCH] avcodec/binkaudio: add support for >2 channels dct codec

2022-03-19 Thread Peter Ross
On Fri, Mar 18, 2022 at 04:21:44PM +0100, Paul B Mahol wrote: > On 3/18/22, Andreas Rheinhardt wrote: > > Paul B Mahol: > >> As presented in .binka files. > >> > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/binkaudio.c | 50 +++--- > >> 1 file chang