On Sun, 20 Mar 2022, Martin Storsjö wrote:
The other main issue I'd like to request is to indent the assembly similarly to the rest of the existing assembly. For the 32 bit assembly, your patches do match the surrounding code, but for the 64 bit assembly, your patches align the operands column differently than the rest. (I think your code aligns the operands with 16 chars to the left of the operands, while our code aligns it with 24 chars to the left, both in 32 and 64 bit arm assembly.)
Oh, sidenote - I do see that the last patch in the set uses much more inconsistent indentation, with varying indentation between lines. Is this intentional to signify some structure in the code, or just accidental? I think it'd be preferrable to have it use normal straight indentation all the way throughout.
// Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
