[FFmpeg-devel] [PATCH] avfilter/framepool: fix adjustment that can crash filtering

2022-02-18 Thread Paul B Mahol
Fixes #9551. Signed-off-by: Paul B Mahol --- libavfilter/framepool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c index 7c63807df3..aab408d355 100644 --- a/libavfilter/framepool.c +++ b/libavfilter/framepool.c @@ -96,7 +96,

Re: [FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x

2022-02-18 Thread Paul B Mahol
On Thu, Feb 10, 2022 at 01:08:04PM +0300, Victoria Zhislina wrote: > By ffmpeg threading support implementation via frame slicing and doing > zimg_filter_graph_build that used to take 30-60% of each frame processig > only if necessary (some parameters changed) > the performance increase vs original

[FFmpeg-devel] [PATCH] avcodec/openh264: return (DE|EN)CODER_NOT_FOUND if version check fails

2022-02-18 Thread Andreas Schneider
Signed-off-by: Andreas Schneider --- libavcodec/libopenh264dec.c | 2 +- libavcodec/libopenh264enc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libopenh264dec.c b/libavcodec/libopenh264dec.c index 7f5e85402a..97d3630df6 100644 --- a/libavcodec/libopenh264dec

Re: [FFmpeg-devel] [PATCH 275/281] avfilter: convert to new channel layout API

2022-02-18 Thread James Almer
On 2/16/2022 3:15 PM, Anton Khirnov wrote: diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index b89a680883..3ebd279df7 100644 --- a/libavfilter/src_movie.c +++ b/libavfilter/src_movie.c @@ -189,23 +189,24 @@ static int guess_channel_layout(MovieStream *st, int st_index, void *

[FFmpeg-devel] [PATCH] swscale: Take the destination range into account for yuv->rgb->yuv conversions

2022-02-18 Thread Martin Storsjö
The range parameters need to be set up before calling sws_init_context (which selects which fastpaths can be used; this gets called by sws_getContext); solely passing them via sws_setColorspaceDetails isn't enough. This fixes producing full range YUV range output when doing YUV->YUV conversions be

[FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x

2022-02-18 Thread Victoria Zhislina
By ffmpeg threading support implementation via frame slicing and doing zimg_filter_graph_build that used to take 30-60% of each frame processig only if necessary (some parameters changed) the performance increase vs original version in video downscale and color conversion >4x is seen on 64 cores I

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_gblur_vulkan: add sizeV option

2022-02-18 Thread Wu Jianhua
> 29 Jan 2022, 13:34 by toqsxw at outlook.com: >> Ping. >> >>> From: Wu, Jianhua >>> Sent: 2022年1月21日 19:42 >>> To: ffmpeg-devel at ffmpeg.org >>> Cc: Wu, Jianhua >>> Subject: [FFmpeg-d

Re: [FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x

2022-02-18 Thread James Almer
On 2/18/2022 12:24 PM, Victoria Zhislina wrote: By ffmpeg threading support implementation via frame slicing and doing zimg_filter_graph_build that used to take 30-60% of each frame processig only if necessary (some parameters changed) the performance increase vs original version in video down

Re: [FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x

2022-02-18 Thread Paul B Mahol
On Fri, Feb 18, 2022 at 12:48:10PM -0300, James Almer wrote: > > > On 2/18/2022 12:24 PM, Victoria Zhislina wrote: > > By ffmpeg threading support implementation via frame slicing and doing > > zimg_filter_graph_build that used to take 30-60% of each frame processig > > only if necessary (some pa

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2022-02-18 Thread Paul B Mahol
On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann wrote: > Am 31.01.22 um 12:55 schrieb James Almer: > > > > > > On 1/31/2022 8:53 AM, Anton Khirnov wrote: > >> Quoting Thilo Borgmann (2022-01-18 14:58:07) > > Violations of code style. > >>> > >>> Enhanced. > >> > >> Not enough. There are still

[FFmpeg-devel] [PATCH v5 3/6] compat/w32dlfcn.h: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-18 Thread nihil-admirari
Also replaces a call to LoadLibraryExA with LoadLibraryExW since ANSI functions do not support long paths. --- compat/w32dlfcn.h | 74 ++- 1 file changed, 61 insertions(+), 13 deletions(-) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index 52a94ef

[FFmpeg-devel] [PATCH v5 4/6] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-18 Thread nihil-admirari
--- fftools/cmdutils.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 4b50e15..ea78897 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -62,6 +62,7 @@ #endif #ifdef _WIN32 #include +#

[FFmpeg-devel] [PATCH v5 5/6] fftools: Enable long path support on Windows (fixes #8885)

2022-02-18 Thread nihil-admirari
--- fftools/Makefile | 5 + fftools/fftools.manifest | 10 ++ fftools/manifest.rc | 3 +++ 3 files changed, 18 insertions(+) create mode 100644 fftools/fftools.manifest create mode 100644 fftools/manifest.rc diff --git a/fftools/Makefile b/fftools/Makefile index da420

[FFmpeg-devel] [PATCH v5 1/6] libavutil/wchar_filename.h: Add wchartoansi and utf8toansi

2022-02-18 Thread nihil-admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c when replacing MAX_PATH-sized buffers with dynamically sized ones. --- libavutil/wchar_filename.h | 37 + 1 file changed, 37 insertions(+) diff --git a/libavutil/wchar_filenam

[FFmpeg-devel] [PATCH v5 2/6] libavformat/avisynth.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-18 Thread nihil-admirari
--- libavformat/avisynth.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 8bc3986..219f307 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -36,6 +36,7 @@ /* Platform-specific directives. */

[FFmpeg-devel] [PATCH v5 6/6] fftools: Use UTF-8 on Windows

2022-02-18 Thread nihil-admirari
--- fftools/fftools.manifest | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/fftools.manifest b/fftools/fftools.manifest index 30b7d8f..d1ac1e4 100644 --- a/fftools/fftools.manifest +++ b/fftools/fftools.manifest @@ -3,8 +3,10 @@ -http://schemas.microso

Re: [FFmpeg-devel] [PATCH v3 5/5] fftools: Enable long path support on Windows (fixes #8885)

2022-02-18 Thread nil-admirari
> Generally UTF-8 codepage should not be needed, because unicode windows functions should be used everywhere, right? No. FFmpeg does not seem to use WinAPI ANSI functions explicitly, but it still uses ordinary stdlib functions (fopen etc.) instead of their wide equivalents. See https://ffmpeg.o

[FFmpeg-devel] [PATCH v6 1/6] libavutil/wchar_filename.h: Add wchartoansi and utf8toansi

2022-02-18 Thread nihil-admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c when replacing MAX_PATH-sized buffers with dynamically sized ones. --- libavutil/wchar_filename.h | 37 + 1 file changed, 37 insertions(+) diff --git a/libavutil/wchar_filenam

[FFmpeg-devel] [PATCH v6 5/6] fftools: Enable long path support on Windows (fixes #8885)

2022-02-18 Thread nihil-admirari
--- fftools/Makefile | 5 + fftools/fftools.manifest | 10 ++ fftools/manifest.rc | 3 +++ 3 files changed, 18 insertions(+) create mode 100644 fftools/fftools.manifest create mode 100644 fftools/manifest.rc diff --git a/fftools/Makefile b/fftools/Makefile index da420

[FFmpeg-devel] [PATCH v6 2/6] libavformat/avisynth.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-18 Thread nihil-admirari
--- libavformat/avisynth.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 8bc3986..219f307 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -36,6 +36,7 @@ /* Platform-specific directives. */

[FFmpeg-devel] [PATCH v6 3/6] compat/w32dlfcn.h: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-18 Thread nihil-admirari
Also replaces a call to LoadLibraryExA with LoadLibraryExW since ANSI functions do not support long paths. --- compat/w32dlfcn.h | 74 ++- 1 file changed, 61 insertions(+), 13 deletions(-) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index 52a94ef

[FFmpeg-devel] [PATCH v6 4/6] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-18 Thread nihil-admirari
--- fftools/cmdutils.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 4b50e15..ea78897 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -62,6 +62,7 @@ #endif #ifdef _WIN32 #include +#

[FFmpeg-devel] [PATCH v6 6/6] fftools: Use UTF-8 on Windows

2022-02-18 Thread nihil-admirari
--- fftools/fftools.manifest | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/fftools.manifest b/fftools/fftools.manifest index 30b7d8f..d1ac1e4 100644 --- a/fftools/fftools.manifest +++ b/fftools/fftools.manifest @@ -3,8 +3,10 @@ -http://schemas.microso

Re: [FFmpeg-devel] [PATCH v3 4/5] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-18 Thread Martin Storsjö
On Thu, 17 Feb 2022, nil-admir...@mailo.com wrote: if the path later is going to end up in a codepath that expects it to be UTF8 (please do check!), then we should go that way instead I checked. datadir ends up in (cmdutils.c:2104) base[2] = datadir; and base[*] are later used in (cmduti

Re: [FFmpeg-devel] [PATCH] avformat/avisynth: fix frameprop version check

2022-02-18 Thread Stephen Hutchinson
On 2/16/22 7:49 PM, Stephen Hutchinson wrote: Trying to be clever about determining between interface version 8 and 8.1 ended up with pre-8.1 versions of AviSynth+ segfaulting. The amount of time between interface version 8.1 and 9 is small, so just restrict the frameprop awareness to version 9

[FFmpeg-devel] HEVC open GOP support in MOV/MP4

2022-02-18 Thread Clément Bœsch
Motivated by glitchy seeking issues with iPhone encoded files. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subjec

[FFmpeg-devel] [PATCH 1/5] avformat/mov: prepare sbgp parsing for other grouping types

2022-02-18 Thread Clément Bœsch
--- libavformat/mov.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 5e26267810..aade052b7a 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3137,6 +3137,8 @@ static int mov_read_sbgp(MOVCon

[FFmpeg-devel] [PATCH 2/5] avformat/mov: add support for sync group in sbgp box

2022-02-18 Thread Clément Bœsch
--- libavformat/isom.h | 2 ++ libavformat/mov.c | 5 + 2 files changed, 7 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index 625dea8421..e326f4f27f 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h @@ -218,6 +218,8 @@ typedef struct MOVStreamContext { int s

[FFmpeg-devel] [PATCH 3/5] avformat/mov: add parsing for the sgpd sync box

2022-02-18 Thread Clément Bœsch
sgpd means Sample Group Description Box. For now, only the sync grouping type is parsed, but the function can easily be adjusted to support other flavours. The sbgp (Sample to Group Box) sync_group table built in previous commit contains references to this table through the group_description_inde

[FFmpeg-devel] [PATCH 4/5] avformat/mov: fix seeking with HEVC open GOP files

2022-02-18 Thread Clément Bœsch
This was tested with medias recorded from an iPhone XR and an iPhone 13. Here is how a typical stream looks like in coding order: ┌┬─┬─┬──┐ │ sample | PTS | DTS | keyframe | ├┼─┼─┼──┤ ┊┊ ┊ ┊ ┊ │ 53 │

[FFmpeg-devel] [PATCH 5/5] avformat/mov: reindent after previous commit

2022-02-18 Thread Clément Bœsch
--- libavformat/mov.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 919dd940c0..09cc4e8ad7 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8570,12 +8570,12 @@ static int mov_seek_stream(AVFormatContext *s, AV

[FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output

2022-02-18 Thread Paul B Mahol
Fixes OOM in #9081. Signed-off-by: Paul B Mahol --- libavfilter/vf_fps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_fps.c b/libavfilter/vf_fps.c index 99e679441e..1a68d519fb 100644 --- a/libavfilter/vf_fps.c +++ b/libavfilter/vf_fps.c @@ -351,7 +351,7 @@ s

[FFmpeg-devel] [PATCH] avfilter: add filmgrain filter

2022-02-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_filmgrain.c | 489 + 3 files changed, 491 insertions(+) create mode 100644 libavfilter/vf_filmgrain.c diff --git a/libavfilter/Makefile b/li