On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann <thilo.borgm...@mail.de> wrote:
> Am 31.01.22 um 12:55 schrieb James Almer: > > > > > > On 1/31/2022 8:53 AM, Anton Khirnov wrote: > >> Quoting Thilo Borgmann (2022-01-18 14:58:07) > >>>>> Violations of code style. > >>> > >>> Enhanced. > >> > >> Not enough. There are still many remaining, e.g. > >> * opening brace of a function definition should be on its own line > >> * the context should generally be the first argument > >> * unsigned char* should be uint8_t* > >> * mixed declarations and code (the compiler should warn about that) > > > > I think someone said that clang (or some versions) is apparently not > warning about this, hence why so many of these end up being missed in > reviews or even by the patch author. > > This and all of Anton's comments in v3. Also removed some more obviously > useless doubles. > Why it uses doubles in so many places? Is there any real benefit in that, except extra slowdown? > > Thanks, > Thilo_______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
