[FFmpeg-devel] [PATCH 6/8] avcodec/internal.h: create avpriv_start_code_is_valid()

2022-02-01 Thread Scott Theisen
--- libavcodec/cavsdec.c | 2 +- libavcodec/cbs_mpeg2.c | 4 ++-- libavcodec/extract_extradata_bsf.c | 2 +- libavcodec/internal.h | 14 ++ libavcodec/mpeg12.c| 2 +- libavcodec/mpeg12dec.c | 2 +- libavcodec/mpegv

[FFmpeg-devel] [PATCH 7/8] cbs_mpeg2.c: use a while loop with a loop condition instead of an infinite loop

2022-02-01 Thread Scott Theisen
This enhances the clarity of the code. --- libavcodec/cbs_mpeg2.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c index 648b270f44..2b80266910 100644 --- a/libavcodec/cbs_mpeg2.c +++ b/libavcodec/cbs_mpeg2.c @@ -148,7 +148

[FFmpeg-devel] [PATCH 8/8] avpriv_find_start_code(): reduce the number of iterations

2022-02-01 Thread Scott Theisen
by correctly starting with three new bytes on the next iteration, instead of keeping byte p[-3] which is invalid, i.e. known to be 01 when it must be 00. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index b4c5fa5

[FFmpeg-devel] [PATCH v2 0/1] Add IPFS protocol support.

2022-02-01 Thread Mark Gaiser
Hi, This patch series adds support for IPFS. This is v2. Everything changed and it's now 1 commit. The following is a short summary. In the IPFS ecosystem you access it's content by a "Content IDentifier" (CID). This CID is, in simplified terms, a hash of the content. IPFS itself is a distribute

[FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Mark Gaiser
This patch adds support for: - ffplay ipfs:// - ffplay ipns:// IPFS data can be played from so called "ipfs gateways". A gateway is essentially a webserver that gives access to the distributed IPFS network. This protocol support (ipfs and ipns) therefore translates ipfs:// and ipns:// to a http:/

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: use VkPhysicalDeviceTimelineSemaphoreFeatures to check for timeline semaphore supporting

2022-02-01 Thread Lynne
27 Jan 2022, 04:39 by quinkbl...@foxmail.com: > VkPhysicalDeviceVulkan12Features isn't implemented on MoltenVK yet. > VkPhysicalDeviceTimelineSemaphoreFeatures is less versatile but > simple. None of device_features_1_1 nor device_features_1_2 has real > usage yet, keep the code for future. > ---

[FFmpeg-devel] [PATCH] lavu: make av_get_media_type_string() never return NULL

2022-02-01 Thread Scott Theisen
printf %s with a null pointer is undefined behavior --- libavutil/avutil.h | 3 +-- libavutil/utils.c | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/avutil.h b/libavutil/avutil.h index 4d633156d1..4bd468d72f 100644 --- a/libavutil/avutil.h +++ b/libavutil/avutil

Re: [FFmpeg-devel] [PATCH] lavu: make av_get_media_type_string() never return NULL

2022-02-01 Thread James Almer
On 2/1/2022 7:30 PM, Scott Theisen wrote: printf %s with a null pointer is undefined behavior --- libavutil/avutil.h | 3 +-- libavutil/utils.c | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/avutil.h b/libavutil/avutil.h index 4d633156d1..4bd468d72f 100644

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes

2022-02-01 Thread Oneric
On Tue, Feb 01, 2022 at 20:41:37 +, Soft Works wrote: > > On Tue, Feb 01, 2022 at 19:44:24 +, Soft Works wrote: > > > > On Sun, Jan 16, 2022 at 19:16:54 +0100, Oneric wrote: > > > > > > > > In case anyone is wondering why patchwork fails to apply the second > > > > patch, > > > > this is p

[FFmpeg-devel] [PATCH v2 1/4] avformat/imf: open resources only when first needed

2022-02-01 Thread pal
From: Pierre-Anthony Lemieux IMF CPLs can reference thousands of files, which can result in system limits for the number of open files to be exceeded. The following patch opens and closes files as needed. Addresses https://trac.ffmpeg.org/ticket/9623 --- libavformat/imfdec.c | 15 -

[FFmpeg-devel] [PATCH v2 2/4] avformat/imf: fix missing error reporting when opening resources

2022-02-01 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/imfdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index e6a1020ecc..658ddc40f2 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c @@ -550,7 +550,9 @@ static int set_co

[FFmpeg-devel] [PATCH v2 3/4] avformat/imf: fix packet pts, dts and muxing

2022-02-01 Thread pal
From: Pierre-Anthony Lemieux The IMF demuxer does not set the DTS and PTS of packets accurately in all scenarios. Moreover, audio packets are not trimmed when they exceed the duration of the underlying resource. Addresses https://trac.ffmpeg.org/ticket/9611 --- libavformat/imfdec.c | 263 +

[FFmpeg-devel] [PATCH v2 4/4] avformat/imf: document IMFVirtualTrackResourcePlaybackCtx

2022-02-01 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/imfdec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index 5be4411cb1..02e7bcc33f 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c @@ -96,12 +96,12 @@ typedef

Re: [FFmpeg-devel] [PATCH 3/8] avpriv_find_start_code(): make the state parameter output only

2022-02-01 Thread Andreas Rheinhardt
Scott Theisen: > --- > libavcodec/cbs_mpeg2.c| 8 > libavcodec/mpeg12dec.c| 5 ++--- > libavcodec/mpeg4_unpack_bframes_bsf.c | 1 - > libavcodec/mpegvideo_parser.c | 3 +-- > libavcodec/utils.c| 1 + > libavformat/rtpenc_mpv.c

Re: [FFmpeg-devel] [PATCH v1 3/4] avformat/imf: fix packet pts, dts and muxing

2022-02-01 Thread Pierre-Anthony Lemieux
On Mon, Jan 31, 2022 at 8:51 PM Andreas Rheinhardt wrote: > > Pierre-Anthony Lemieux: > > On Sun, Jan 30, 2022 at 2:16 PM Andreas Rheinhardt > > wrote: > >> > >> p...@sandflow.com: > >>> From: Pierre-Anthony Lemieux > >>> > >>> The IMF demuxer does not set the DTS and PTS of packets accurately i

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Timo Rothenpieler
On 01.02.2022 22:58, Mark Gaiser wrote: +static int translate_ipfs_to_http(URLContext *h, const char *uri, int flags, AVDictionary **options) +{ +const char *ipfs_cid; +const char *protocol_path_suffix = "ipfs/"; +char *fulluri; +int ret; +Context *c = h->priv_data; +int

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Mark Gaiser
On Wed, Feb 2, 2022 at 1:27 AM Timo Rothenpieler wrote: > On 01.02.2022 22:58, Mark Gaiser wrote: > > +static int translate_ipfs_to_http(URLContext *h, const char *uri, int > flags, AVDictionary **options) > > +{ > > +const char *ipfs_cid; > > +const char *protocol_path_suffix = "ipfs/";

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Mark Gaiser
On Wed, Feb 2, 2022 at 1:33 AM Mark Gaiser wrote: > On Wed, Feb 2, 2022 at 1:27 AM Timo Rothenpieler > wrote: > >> On 01.02.2022 22:58, Mark Gaiser wrote: >> > +static int translate_ipfs_to_http(URLContext *h, const char *uri, int >> flags, AVDictionary **options) >> > +{ >> > +const char *i

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Timo Rothenpieler
On 02.02.2022 01:33, Mark Gaiser wrote: On Wed, Feb 2, 2022 at 1:27 AM Timo Rothenpieler wrote: On 01.02.2022 22:58, Mark Gaiser wrote: +static int translate_ipfs_to_http(URLContext *h, const char *uri, int flags, AVDictionary **options) +{ +const char *ipfs_cid; +const char *protoc

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Andreas Rheinhardt
Timo Rothenpieler: > On 02.02.2022 01:33, Mark Gaiser wrote: >> On Wed, Feb 2, 2022 at 1:27 AM Timo Rothenpieler >> wrote: >> >>> On 01.02.2022 22:58, Mark Gaiser wrote: +static int translate_ipfs_to_http(URLContext *h, const char *uri, int >>> flags, AVDictionary **options) +{ +   

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Timo Rothenpieler
On 02.02.2022 01:44, Andreas Rheinhardt wrote: Timo Rothenpieler: On 02.02.2022 01:33, Mark Gaiser wrote: On Wed, Feb 2, 2022 at 1:27 AM Timo Rothenpieler wrote: On 01.02.2022 22:58, Mark Gaiser wrote: +static int translate_ipfs_to_http(URLContext *h, const char *uri, int flags, AVDictiona

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Mark Gaiser
On Wed, Feb 2, 2022 at 1:49 AM Timo Rothenpieler wrote: > On 02.02.2022 01:44, Andreas Rheinhardt wrote: > > Timo Rothenpieler: > >> On 02.02.2022 01:33, Mark Gaiser wrote: > >>> On Wed, Feb 2, 2022 at 1:27 AM Timo Rothenpieler < > t...@rothenpieler.org> > >>> wrote: > >>> > On 01.02.2022 22

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Timo Rothenpieler
On 02.02.2022 01:50, Mark Gaiser wrote: Ah, yeah. That's a very confusing side effect there. I guess it's fine, but I can't say I like using it like that. Since there's a large risk someone else might in the future think the same and break it. I'm fine changing it to someone that would feel mo

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Mark Gaiser
On Wed, Feb 2, 2022 at 1:54 AM Timo Rothenpieler wrote: > On 02.02.2022 01:50, Mark Gaiser wrote: > >> Ah, yeah. That's a very confusing side effect there. > >> I guess it's fine, but I can't say I like using it like that. > >> Since there's a large risk someone else might in the future think the

Re: [FFmpeg-devel] [PATCH] lavu: make av_get_media_type_string() never return NULL

2022-02-01 Thread Scott Theisen
On 2/1/22 17:34, James Almer wrote: This is an API breakage, so it's not ok. I'm new, so would this require a bump to the MINOR or MICRO version number? The doxy states it returns NULL if media_type is unknown, so you're expected to check the returned pointer before trying to use it. git gr

Re: [FFmpeg-devel] [PATCH] lavu: make av_get_media_type_string() never return NULL

2022-02-01 Thread James Almer
On 2/1/2022 10:58 PM, Scott Theisen wrote: On 2/1/22 17:34, James Almer wrote: This is an API breakage, so it's not ok. I'm new, so would this require a bump to the MINOR or MICRO version number? Making a behavior change like this requires a warning and a period to let library users adapt th

Re: [FFmpeg-devel] [PATCH] lavu: make av_get_media_type_string() never return NULL

2022-02-01 Thread Andreas Rheinhardt
Scott Theisen: > On 2/1/22 17:34, James Almer wrote: >> This is an API breakage, so it's not ok. > I'm new, so would this require a bump to the MINOR or MICRO version number? > That would need an announcement in doc/APIchanges; it can then be changed at the next major version bump after two year

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Lynne
1 Feb 2022, 22:58 by mark...@gmail.com: > This patch adds support for: > - ffplay ipfs:// > - ffplay ipns:// > > IPFS data can be played from so called "ipfs gateways". > A gateway is essentially a webserver that gives access to the > distributed IPFS network. > > This protocol support (ipfs and i

Re: [FFmpeg-devel] [PATCH] lavu: make av_get_media_type_string() never return NULL

2022-02-01 Thread Scott Theisen
On 2/1/22 21:06, James Almer wrote: 32/44 uses do not check for null. But do they need to? Those modules have probably ensured media type is one of the known and supported ones by the time they call this function. Why do you need this function to never return NULL, anyway? If you know any o

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

2022-02-01 Thread Mark Gaiser
On Wed, Feb 2, 2022 at 3:29 AM Lynne wrote: > 1 Feb 2022, 22:58 by mark...@gmail.com: > > > This patch adds support for: > > - ffplay ipfs:// > > - ffplay ipns:// > > > > IPFS data can be played from so called "ipfs gateways". > > A gateway is essentially a webserver that gives access to the > >

Re: [FFmpeg-devel] [PATCH 3/8] avpriv_find_start_code(): make the state parameter output only

2022-02-01 Thread Scott Theisen
On 2/1/22 19:15, Andreas Rheinhardt wrote: It seems you didn't get why the code currently is as it is: It allows to use this function with non-contiguous input (as happens in our parsers which operate on data that is not cleanly split into packets yet (it is their job to create proper packets out

Re: [FFmpeg-devel] [PATCH 3/8] avpriv_find_start_code(): make the state parameter output only

2022-02-01 Thread Andreas Rheinhardt
Scott Theisen: > On 2/1/22 19:15, Andreas Rheinhardt wrote: >> It seems you didn't get why the code currently is as it is: It allows to >> use this function with non-contiguous input (as happens in our parsers >> which operate on data that is not cleanly split into packets yet (it is >> their job t

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes

2022-02-01 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Oneric > Sent: Wednesday, February 2, 2022 12:26 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix > handling of backslashes > > On Tue, Feb 01, 2022 at 20:

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mpegts: add option max_packet_size

2022-02-01 Thread Gyan Doshi
On 2022-02-02 12:42 am, James Almer wrote: On 2/1/2022 3:47 PM, Michael Niedermayer wrote: On Sun, Jan 16, 2022 at 05:19:15AM +, Gyan Doshi wrote: ffmpeg | branch: master | Gyan Doshi | Wed Jan 12 20:57:59 2022 +0530| [bca30570d28bbaa07badadabf55ec3589201a82f] | committer: Gyan Doshi

Re: [FFmpeg-devel] [PATCH] ffprobe: allow side-data selection by element

2022-02-01 Thread Gyan Doshi
Plan to push tomorrow. On 2022-01-31 11:11 am, Gyan Doshi wrote: At present, side data printing forces display for all levels i.e. stream, packets and frames. This can bloat output and also force decode of all frames in selected streams. Now, stream_side_data[=type], packet_side_data[=type] & f

[FFmpeg-devel] [PATCH 70/72] avcodec/mpegpicture: Don't check for DELAYED_PIC_REF

2022-02-01 Thread Andreas Rheinhardt
It is not set any more by any user of mpegvideo/mpegpicture. Signed-off-by: Andreas Rheinhardt --- I think that needs_realloc could also be removed now that the buffers that this flag is all about are refcounted. libavcodec/mpegpicture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[FFmpeg-devel] [PATCH 71/72] avcodec/mpegutils.h: Move DELAYED_PIC_REF macro to h264dec.h

2022-02-01 Thread Andreas Rheinhardt
It is only used by the H.264 decoder (as well as the dirac decoder, which already uses a local copy). Signed-off-by: Andreas Rheinhardt --- libavcodec/h264dec.h | 5 + libavcodec/mpegutils.h | 6 -- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/h264dec.h b/l

[FFmpeg-devel] [PATCH 72/72] avcodec/mpegvideo: Make new_picture an ordinary AVFrame

2022-02-01 Thread Andreas Rheinhardt
It is currently a "Picture", an mpegvideo-specific type that has a lot of baggage, all of which is unnecessary for new_picture, because only its embedded AVFrame is ever used. So just use an ordinary AVFrame. Signed-off-by: Andreas Rheinhardt --- libavcodec/motion_est.c| 12 - libavc

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: fix logic error in GEM Raster file probe

2022-02-01 Thread Peter Ross
On Fri, Jan 21, 2022 at 09:14:05AM +1100, Peter Ross wrote: > Use correct logic to express limits of the planes and pattern_size fields. > > Fix ticket# 9605 > > Signed-off-by: Peter Ross > --- > libavformat/img2dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: increase probe score for fourcc variants

2022-02-01 Thread Peter Ross
On Tue, Jan 25, 2022 at 06:26:23PM +1100, Peter Ross wrote: > Signed-off-by: Peter Ross > --- > libavformat/img2dec.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > index 2583ca2465..8608252d83 100644 > --- a/libavf

<    1   2