Re: [FFmpeg-devel] [PATCH 000/279 v2] New channel layout API

2021-12-19 Thread Marton Balint
On Sat, 18 Dec 2021, Michael Niedermayer wrote: On Sat, Dec 18, 2021 at 02:36:12PM +0100, Michael Niedermayer wrote: On Fri, Dec 17, 2021 at 07:04:08PM +0100, Marton Balint wrote: On Fri, 17 Dec 2021, Michael Niedermayer wrote: On Fri, Dec 17, 2021 at 01:04:19AM +0100, Marton Balint wro

Re: [FFmpeg-devel] [PATCH 000/279 v2] New channel layout API

2021-12-19 Thread Michael Niedermayer
On Sun, Dec 19, 2021 at 12:35:11PM +0100, Marton Balint wrote: > > > On Sat, 18 Dec 2021, Michael Niedermayer wrote: > > > On Sat, Dec 18, 2021 at 02:36:12PM +0100, Michael Niedermayer wrote: > > > On Fri, Dec 17, 2021 at 07:04:08PM +0100, Marton Balint wrote: > > > > > > > > > > > > On Fri, 1

Re: [FFmpeg-devel] Politics

2021-12-19 Thread Michael Niedermayer
On Sat, Dec 18, 2021 at 08:41:09PM +, Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Daniel > > Cantarín > > Sent: Saturday, December 18, 2021 9:05 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] Politics > > > > > > > > Then yo

Re: [FFmpeg-devel] [PATCH] qsvenc_hevc: Enable look ahead with ExtBRC

2021-12-19 Thread Zhong Li
Xiang, Haihao 于2021年12月6日周一 11:09写道: > > --- a/libavcodec/qsvenc_hevc.c > > +++ b/libavcodec/qsvenc_hevc.c > > @@ -248,6 +248,7 @@ static const AVOption options[] = { > > { "tile_rows", "Number of rows for tiled > > encoding", OFFSET(qsv.tile_rows),AV_OPT_TYPE_INT, { .i64 = 0 }, 0,

Re: [FFmpeg-devel] [PATCH 04/10] lavc/videotoolboxenc: fix RGB support

2021-12-19 Thread Rick Kern
On Thu, Dec 16, 2021 at 7:13 PM rcombs wrote: > --- > libavcodec/videotoolboxenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index fa8f717a6c..e10373dded 100644 > --- a/libavcodec/videotoolboxenc.c > +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH 06/10] lavc/videotoolboxenc: vastly simplify get_cv_pixel_info

2021-12-19 Thread Rick Kern
On Thu, Dec 16, 2021 at 7:13 PM rcombs wrote: > No longer requires per-format switch cases. > > The frame==0 path was unused (and would've crashed anyway). > --- > libavcodec/videotoolboxenc.c | 69 +++- > 1 file changed, 13 insertions(+), 56 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH] configure: fix metal detection and respect explicit disable

2021-12-19 Thread Aman Karmani
On Sat, Dec 18, 2021 at 9:35 PM Aman Karmani wrote: > From: Aman Karmani > > Signed-off-by: Aman Karmani > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index d8b07c8e00..d9d41b2273 100755 > --- a/configure > +++ b/configure

Re: [FFmpeg-devel] [PATCH 2/2] lavc/videotoolboxenc: explicitly set realtime=false

2021-12-19 Thread Aman Karmani
On Sat, Dec 18, 2021 at 1:53 PM rcombs wrote: > On some encoders, this defaults to true, which can result in encode speed > being _limited_ to only slightly above realtime (as a power-saving > measure), > so we need a way to disable it. > --- > libavcodec/videotoolboxenc.c | 6 +++--- > 1 file c

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/videotoolboxenc: use the correct types for options

2021-12-19 Thread Aman Karmani
On Sat, Dec 18, 2021 at 1:53 PM rcombs wrote: > These are all set by AV_OPT_TYPE_INT or AV_OPT_TYPE_BOOL; the only reason > they worked before was that this is only used on little-endian. > --- > libavcodec/videotoolboxenc.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-

Re: [FFmpeg-devel] [PATCH 07/10] lavc/videotoolboxenc: add handling for non-NAL-based codecs

2021-12-19 Thread Rick Kern
On Thu, Dec 16, 2021 at 7:13 PM rcombs wrote: > --- > libavcodec/videotoolboxenc.c | 149 +-- > 1 file changed, 92 insertions(+), 57 deletions(-) > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index 82e01fbe29..67bb563639 100644 > -

Re: [FFmpeg-devel] [PATCH v4 3/5] avutil: add obj-c helpers into header-only include

2021-12-19 Thread James Almer
On 12/17/2021 5:04 PM, Aman Karmani wrote: From: Aman Karmani Reviewed-by: Ridley Combs Signed-off-by: Aman Karmani --- libavutil/objc.h | 32 1 file changed, 32 insertions(+) create mode 100644 libavutil/objc.h diff --git a/libavutil/objc.h b/libavutil/

Re: [FFmpeg-devel] lavc/videotoolboxenc: add ProRes support

2021-12-19 Thread Rick Kern
On Thu, Dec 16, 2021 at 7:12 PM rcombs wrote: > This patchset includes several infrastructural improvements to > videotoolboxenc, > an added group of output formats for swscale, and a ProRes encoder wrapper. > > Also available as a GitHub PR here: > https://github.com/FFmpeg/FFmpeg/pull/378 > > R

Re: [FFmpeg-devel] [PATCH v4 3/5] avutil: add obj-c helpers into header-only include

2021-12-19 Thread Aman Karmani
On Sun, Dec 19, 2021 at 9:09 AM James Almer wrote: > On 12/17/2021 5:04 PM, Aman Karmani wrote: > > From: Aman Karmani > > > > Reviewed-by: Ridley Combs > > Signed-off-by: Aman Karmani > > --- > > libavutil/objc.h | 32 > > 1 file changed, 32 insertions(+) >

[FFmpeg-devel] [PATCH] avutil: add objc.h to SKIPHEADERS

2021-12-19 Thread Aman Karmani
From: Aman Karmani Signed-off-by: Aman Karmani --- libavutil/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/Makefile b/libavutil/Makefile index 529046dbc8..d17876df1a 100644 --- a/libavutil/Makefile +++ b/libavutil/Makefile @@ -195,6 +195,7 @@ OBJS += $(COMPAT_OBJS:%=../

Re: [FFmpeg-devel] [PATCH v4 3/5] avutil: add obj-c helpers into header-only include

2021-12-19 Thread Marvin Scholz
On 19 Dec 2021, at 18:35, Aman Karmani wrote: > On Sun, Dec 19, 2021 at 9:09 AM James Almer wrote: > >> On 12/17/2021 5:04 PM, Aman Karmani wrote: >>> From: Aman Karmani >>> >>> Reviewed-by: Ridley Combs >>> Signed-off-by: Aman Karmani >>> --- >>> libavutil/objc.h | 32 +++

Re: [FFmpeg-devel] Politics

2021-12-19 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Sunday, December 19, 2021 4:16 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Politics > > On Sat, Dec 18, 2021 at 08:41:09PM +, Soft Works wrote: > > > > > > > -

Re: [FFmpeg-devel] Politics

2021-12-19 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Soft Works > Sent: Sunday, December 19, 2021 7:23 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Politics > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Michael > > N

[FFmpeg-devel] [PATCH] checkasm: store and associate contexts with functions and use it for av_tx

2021-12-19 Thread Lynne
checkasm: store and associate contexts with functions and use it for av_tx The issue is the following: - checkasm/av_tx.c initializes a context and a function - check_func() receives the function only and returns NULL - checkasm/av_tx.c runs again with a different CPU flag and creates a new funct

[FFmpeg-devel] [PATCH v5 00/13] dshow enhancements

2021-12-19 Thread Diederick Niehorster
This series solves some outstanding bugs in the dshow device, implements get_device_list so that `ffmpeg -sources dshow` works and adds logic to select a video format with extended color information (color range, space, etc) if exposed by the device. v5 adresses a comment received offlist for patc

[FFmpeg-devel] [PATCH v5 01/13] avdevice/dshow: prevent NULL access

2021-12-19 Thread Diederick Niehorster
list_options true would crash when both a video and an audio device were specified as input. Crash would occur on line 784 because ctx->device_unique_name[otherDevType] would be NULL Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

[FFmpeg-devel] [PATCH v5 02/13] avdevice/dshow: implement option to use device video timestamps

2021-12-19 Thread Diederick Niehorster
The dshow avdevice ignores timestamps for video frames provided by the DirectShow device, instead using wallclock time, apparently because the implementer of this code had a device that provided unreliable timestamps. Me (and others) would like to use the device's timestamps. The new use_video_devi

[FFmpeg-devel] [PATCH v5 03/13] avdevice/dshow: add use_video_device_timestamps to docs

2021-12-19 Thread Diederick Niehorster
Signed-off-by: Diederick Niehorster --- doc/indevs.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/indevs.texi b/doc/indevs.texi index 5be647f70a..9d8020311a 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -625,6 +625,12 @@ Save the currently used video capture filter dev

[FFmpeg-devel] [PATCH v5 04/13] avdevice/dshow: query graph and sample time only once

2021-12-19 Thread Diederick Niehorster
No need to query twice, use value we've already unconditionally got. Improve variable names Signed-off-by: Diederick Niehorster --- libavdevice/dshow_pin.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/libavdevice/dshow_pin.c b/libavdevice/dsh

[FFmpeg-devel] [PATCH v5 05/13] avdevice/dshow: handle unknown sample time

2021-12-19 Thread Diederick Niehorster
GetTime may return an error indication that the sample has not timestamps, or may return a NULL start time. In those cases, fall back to graph time. Emit log when that happens. Improve logging in the frame receive function: now logged against correct avclass instead of NULL. Better debug message in

[FFmpeg-devel] [PATCH v5 06/13] avdevice/dshow: set no-seek flags

2021-12-19 Thread Diederick Niehorster
avdevice/dshow is a realtime device and as such does not support seeking. Therefore, its demuxer format should define the AVFMT_NOBINSEARCH, AVFMT_NOGENSEARCH and AVFMT_NO_BYTE_SEEK flags. With these flags set, attempting to seek (with, e.g., avformat_seek_file()) correctly yields -1 (operation not

[FFmpeg-devel] [PATCH v5 07/13] avdevice/dshow: implement get_device_list

2021-12-19 Thread Diederick Niehorster
Needed to enable programmatic discovery of DirectShow devices Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 80 + 1 file changed, 73 insertions(+), 7 deletions(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 0ef3b3d13e.

[FFmpeg-devel] [PATCH v5 08/13] avdevice/dshow: list_devices: show media type(s) per device

2021-12-19 Thread Diederick Niehorster
the list_devices option of dshow didn't indicate whether a specific device provides audio or video output. This patch iterates through all media formats of all pins exposed by the device to see what types it provides for capture, and prints this to the console for each device. Importantly, this now

[FFmpeg-devel] [PATCH v5 09/13] avdevice: add info about media types(s) to AVDeviceInfo

2021-12-19 Thread Diederick Niehorster
An avdevice, regardless of whether its category says its an audio or video device, may provide access to devices providing different media types, or even single devices providing multiple media types. Also, some devices may provide no media types. dshow is an example encompassing all of these cases

[FFmpeg-devel] [PATCH v5 10/13] avdevice/dshow: add media type info to get_device_list

2021-12-19 Thread Diederick Niehorster
The list returned by get_device_list now contains info about what media type(s), if any, can be provided by each device. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index f25537db

[FFmpeg-devel] [PATCH v5 11/13] fftools: provide media type info for devices

2021-12-19 Thread Diederick Niehorster
fftools now print info about what media type(s), if any, are provided by sink and source avdevices. Signed-off-by: Diederick Niehorster --- fftools/cmdutils.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmd

[FFmpeg-devel] [PATCH v5 12/13] avdevice/dshow: discover source color range/space/etc

2021-12-19 Thread Diederick Niehorster
Enabled discovering a DirectShow device's color range, space, primaries, transfer characteristics and chroma location, if the device exposes that information. Sets them in the stream's codecpars. Co-authored-by: Valerii Zapodovnikov Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c |

[FFmpeg-devel] [PATCH v5 13/13] avdevice/dshow: select format with extended color info

2021-12-19 Thread Diederick Niehorster
Some DirectShow devices (Logitech C920 webcam) expose each DirectShow format they support twice, once without and once with extended color information. During format selection, both match, this patch ensures that the format with extended color information is selected if it is available, else it fal

Re: [FFmpeg-devel] [PATCH] avutil: add objc.h to SKIPHEADERS

2021-12-19 Thread Aman Karmani
On Sun, Dec 19, 2021 at 9:41 AM Aman Karmani wrote: > From: Aman Karmani > > Signed-off-by: Aman Karmani > --- > libavutil/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/Makefile b/libavutil/Makefile > index 529046dbc8..d17876df1a 100644 > --- a/libavutil/Makefile

[FFmpeg-devel] [PATCH] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2021-12-19 Thread Martijn van Beurden
Enables creation of FLAC files with up to 32 bits-per-sample, up from the previous limit of 24 bit. This is a feature requested for RAWcooked, the archiving community has a need for storing files with 32-bit integer audio samples. See https://github.com/MediaArea/RAWcooked/issues/356 Restrictions

Re: [FFmpeg-devel] [PATCH] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2021-12-19 Thread Lynne
19 Dec 2021, 21:53 by mva...@gmail.com: > Enables creation of FLAC files with up to 32 bits-per-sample, up from the > previous limit of 24 bit. This is a feature requested for RAWcooked, the > archiving community has a need for storing files with 32-bit integer audio > samples. See https://github.

Re: [FFmpeg-devel] [PATCH] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2021-12-19 Thread Martijn van Beurden
Op zo 19 dec. 2021 om 22:11 schreef Lynne : > What happens if there's an overflow and the prediction coefficients > are lowered? Is there a loss of bits? What about if it gives up? The result remains lossless. If the prediction coefficients are lowered, the residual of the prediction increases. Th

Re: [FFmpeg-devel] [PATCH] libavcodec/flacenc: add backward-compatible 32 bit-per-sample capability

2021-12-19 Thread Lynne
19 Dec 2021, 22:41 by mva...@gmail.com: > Op zo 19 dec. 2021 om 22:11 schreef Lynne : > >> What happens if there's an overflow and the prediction coefficients >> are lowered? Is there a loss of bits? What about if it gives up? >> > > The result remains lossless. If the prediction coefficients are

[FFmpeg-devel] [PATCH 1/3] avcodec/ass: Faster ff_ass_add_rect()

2021-12-19 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ass.c | 33 +++-- libavcodec/ass.h | 7 +++ 2 files changed, 34 insertions(+), 6 deletions(-) diff --git a/libavcodec/ass.c b/libavcodec/ass.c index 725e4d42ba1..06714678722 100644 --- a/libavcodec/ass.c +++ b/lib

[FFmpeg-devel] [PATCH 2/3] avcodec/ccaption_dec: Use ff_ass_add_rect2()

2021-12-19 Thread Michael Niedermayer
Fixes: Timeout Fixes: 42258/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CCAPTION_fuzzer-5540144118104064 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ccaption_dec.c | 7 --- 1 fil

[FFmpeg-devel] [PATCH 3/3] avcodec/vqavideo: reset accounting on error

2021-12-19 Thread Michael Niedermayer
Fixes: Timeout (same growing chunk is decoded to failure repeatedly) Fixes: 42582/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQA_fuzzer-6531195591065600 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ass: Faster ff_ass_add_rect()

2021-12-19 Thread James Almer
On 12/19/2021 8:56 PM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavcodec/ass.c | 33 +++-- libavcodec/ass.h | 7 +++ 2 files changed, 34 insertions(+), 6 deletions(-) diff --git a/libavcodec/ass.c b/libavcodec/ass.c index 725e4d

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ass: Faster ff_ass_add_rect()

2021-12-19 Thread Andreas Rheinhardt
Michael Niedermayer: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ass.c | 33 +++-- > libavcodec/ass.h | 7 +++ > 2 files changed, 34 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/ass.c b/libavcodec/ass.c > index 725e4d42ba1..06714678722 10

Re: [FFmpeg-devel] [PATCH v5 03/13] avdevice/dshow: add use_video_device_timestamps to docs

2021-12-19 Thread Andreas Rheinhardt
Diederick Niehorster: > Signed-off-by: Diederick Niehorster > --- > doc/indevs.texi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/indevs.texi b/doc/indevs.texi > index 5be647f70a..9d8020311a 100644 > --- a/doc/indevs.texi > +++ b/doc/indevs.texi > @@ -625,6 +625,12 @@ Save t

Re: [FFmpeg-devel] [PATCH v5 08/13] avdevice/dshow: list_devices: show media type(s) per device

2021-12-19 Thread Andreas Rheinhardt
Diederick Niehorster: > the list_devices option of dshow didn't indicate whether a specific > device provides audio or video output. This patch iterates through all > media formats of all pins exposed by the device to see what types it > provides for capture, and prints this to the console for each

Re: [FFmpeg-devel] [PATCH v5 09/13] avdevice: add info about media types(s) to AVDeviceInfo

2021-12-19 Thread Andreas Rheinhardt
Diederick Niehorster: > An avdevice, regardless of whether its category says its an audio or > video device, may provide access to devices providing different media > types, or even single devices providing multiple media types. Also, some > devices may provide no media types. dshow is an example e

Re: [FFmpeg-devel] [PATCH v5 10/13] avdevice/dshow: add media type info to get_device_list

2021-12-19 Thread Andreas Rheinhardt
Diederick Niehorster: > The list returned by get_device_list now contains info about what media > type(s), if any, can be provided by each device. > > Signed-off-by: Diederick Niehorster > --- > libavdevice/dshow.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavdevice/dsho

Re: [FFmpeg-devel] [PATCH v5 11/13] fftools: provide media type info for devices

2021-12-19 Thread Andreas Rheinhardt
Diederick Niehorster: > fftools now print info about what media type(s), if any, are provided by > sink and source avdevices. > > Signed-off-by: Diederick Niehorster > --- > fftools/cmdutils.c | 34 -- > 1 file changed, 24 insertions(+), 10 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH v5 12/13] avdevice/dshow: discover source color range/space/etc

2021-12-19 Thread Andreas Rheinhardt
Diederick Niehorster: > Enabled discovering a DirectShow device's color range, space, primaries, > transfer characteristics and chroma location, if the device exposes that > information. Sets them in the stream's codecpars. > > Co-authored-by: Valerii Zapodovnikov > Signed-off-by: Diederick Nieho

Re: [FFmpeg-devel] [PATCH v5 13/13] avdevice/dshow: select format with extended color info

2021-12-19 Thread Andreas Rheinhardt
Diederick Niehorster: > Some DirectShow devices (Logitech C920 webcam) expose each DirectShow > format they support twice, once without and once with extended color > information. During format selection, both match, this patch ensures > that the format with extended color information is selected i

Re: [FFmpeg-devel] [PATCH] libavcodec/pthread_framec: remove duplicate pointers

2021-12-19 Thread Yy
Ping for this patch. -Yu Yang > 2021年12月15日 上午10:17,Yu Yang 写道: > > From: Yu Yang > > '*src' and '*avctx' point to the same memory. It is enough to keep one of > them. > > Signed-off-by: Yu Yang > --- > libavcodec/pthread_frame.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 delet

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for qsv

2021-12-19 Thread Xiang, Haihao
On Wed, 2021-12-15 at 16:24 +0800, Zhong Li wrote: > Eoff, Ullysses A 于2021年12月15日周三 00:52写道: > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > > index dcac46003e..39ce91b755 100644 > > > > > > --- a/MAINTAINERS > > > > > > +++ b/MAINTAINERS > > > > > > @@ -226,7 +226,7 @@ Codecs: > > >

Re: [FFmpeg-devel] [PATCH] qsvenc_hevc: Enable look ahead with ExtBRC

2021-12-19 Thread Xiang, Haihao
On Sun, 2021-12-19 at 23:55 +0800, Zhong Li wrote: > Xiang, Haihao 于2021年12月6日周一 11:09写道: > > > --- a/libavcodec/qsvenc_hevc.c > > > +++ b/libavcodec/qsvenc_hevc.c > > > @@ -248,6 +248,7 @@ static const AVOption options[] = { > > > { "tile_rows", "Number of rows for tiled > > > encoding",

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for vaapi

2021-12-19 Thread Xiang, Haihao
On Wed, 2021-12-15 at 15:32 +0100, Michael Niedermayer wrote: > On Tue, Dec 14, 2021 at 10:31:40PM +, Soft Works wrote: > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of Michael > > > Niedermayer > > > Sent: Tuesday, December 14, 2021 10:40 PM > > > To: FFmpeg de