Re: [FFmpeg-devel] [PATCH V6 5/5] libavutil/hwcontext_vulkan: specify the modifier to create VKImage

2021-12-13 Thread Chen, Wenbin
> 7 Dec 2021, 10:05 by wenbin.c...@intel.com: > > > When vulkan image exports to drm, the tilling need to be > > VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT. Now add code to > create vulkan > > image using this format. > > > > Now the following command line works: > > > > ffmpeg -hwaccel vaapi -hwacce

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_overlay_qsv: Use format of first input to set output format for overlay_qsv

2021-12-13 Thread Chen, Wenbin
> > -Original Message- > > From: ffmpeg-devel On Behalf Of > Wenbin Chen > > Sent: Friday, December 10, 2021 3:22 AM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Wenbin Chen > > Subject: [FFmpeg-devel] [PATCH] libavfilter/vf_overlay_qsv: Use format of > > first input to set output format for o

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_overlay_qsv: Use format of first input to set output format for overlay_qsv

2021-12-13 Thread Chen, Wenbin
> > -Original Message- > > From: ffmpeg-devel On Behalf Of > Wenbin Chen > > Sent: Friday, December 10, 2021 3:22 AM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Wenbin Chen > > Subject: [FFmpeg-devel] [PATCH] libavfilter/vf_overlay_qsv: Use format of > > first input to set output format for o

Re: [FFmpeg-devel] [PATCH v3 1/5] avcodec/mmaldec: use decoupled dataflow

2021-12-13 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-12-09 14:08:01) > From: Ho Ming Shun > > MMAL is an fundamentally an asynchronous decoder, which was a bad fit > for the legacy dataflow API. Often multiple packets are enqueued before > a flood of frames are returned from MMAL. > > The previous lockstep dataflow

Re: [FFmpeg-devel] [PATCH v3 4/5] avcodec/mmaldec: Avoid creating unnecessary reference, simplify code

2021-12-13 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-12-09 14:08:04) > ffmal_add_packet() basically duplicated the logic in > av_packet_make_refcounted() with the added twist that it always > created a reference even if one is already available. > This commit stops doing this. > > Signed-off-by: Andreas Rheinhardt >

[FFmpeg-devel] [PATCH 1/2] lavc/encode: improve the empty frame check

2021-12-13 Thread Anton Khirnov
Test for buf[0] rather than data[0] (which is broken for some hwaccel formats). --- libavcodec/encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index dd25cf999b..5575cf23db 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encod

[FFmpeg-devel] [PATCH 2/2] lavc/encode: set frame_number for encoders using receive_packet()

2021-12-13 Thread Anton Khirnov
It is currently set in encode_simple_internal(), which is only called for encoders using the "simple" encoding API. --- libavcodec/encode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 5575cf23db..618be0573d 100644 --- a

Re: [FFmpeg-devel] [PATCH 1/2] lavc/encode: improve the empty frame check

2021-12-13 Thread James Almer
On 12/13/2021 7:47 AM, Anton Khirnov wrote: Test for buf[0] rather than data[0] (which is broken for some hwaccel formats). --- libavcodec/encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index dd25cf999b..5575cf23db 100644

Re: [FFmpeg-devel] [PATCH v4] fftools/opts: Avoid crash when opts could not be allocated

2021-12-13 Thread Yy
Ping for patch v4: fftools/opts: Avoid crash when opts could not be allocated. > 2021年12月8日 上午10:35,Yu Yang 写道: > > If 'opts' could not be allocated, exiting the program to avoid crash when > release it. > Before setup_find_stream_info_opts(), checking 'orig_nb_streams' is > 0. > > Reported-

Re: [FFmpeg-devel] [PATCH v3 1/5] avcodec/mmaldec: use decoupled dataflow

2021-12-13 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2021-12-09 14:08:01) >> From: Ho Ming Shun >> >> MMAL is an fundamentally an asynchronous decoder, which was a bad fit >> for the legacy dataflow API. Often multiple packets are enqueued before >> a flood of frames are returned from MMAL. >> >> The prev

Re: [FFmpeg-devel] [PATCH v4] fftools/opts: Avoid crash when opts could not be allocated

2021-12-13 Thread Andreas Rheinhardt
Yu Yang: > If 'opts' could not be allocated, exiting the program to avoid crash when > release it. > Before setup_find_stream_info_opts(), checking 'orig_nb_streams' is > 0. > > Reported-by: TOTE Robot > Signed-off-by: Yu Yang > --- > fftools/cmdutils.c | 4 +--- > fftools/cmdutils.h | 4

[FFmpeg-devel] [PATCH 0/1] avformat/concatdec: copy side data (ping)

2021-12-13 Thread Nicolas Gaullier
This is just a rebased patch (updated fate results). I have not received any comment since my initial post. https://patchwork.ffmpeg.org/project/ffmpeg/patch/20211123172829.1674-1-nicolas.gaullier@cji.paris/ Thank you Nicolas Nicolas Gaullier (1): avformat/concatdec: copy side data libavforma

[FFmpeg-devel] [PATCH 1/1] avformat/concatdec: copy side data

2021-12-13 Thread Nicolas Gaullier
Fixes mpeg2video stream copy to mpeg muxer. Note: this is a following of 1ec86be79b11. Signed-off-by: Nicolas Gaullier --- libavformat/concatdec.c | 11 +++ tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +- tests/ref/fate/concat-demuxer-extended-lav

Re: [FFmpeg-devel] [PATCH] avutil/display: fix inverted doc

2021-12-13 Thread zhilizhao(赵志立)
> On Dec 12, 2021, at 7:19 PM, Andreas Rheinhardt > wrote: > > Andreas Rheinhardt: >> Zhao Zhili: >>> --- >>> libavutil/display.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/libavutil/display.h b/libavutil/display.h >>> index 515adad795..d87bf68425 100644 >>

Re: [FFmpeg-devel] [PATCH 1/2] lavc/encode: improve the empty frame check

2021-12-13 Thread Anton Khirnov
Quoting James Almer (2021-12-13 12:40:49) > On 12/13/2021 7:47 AM, Anton Khirnov wrote: > > Test for buf[0] rather than data[0] (which is broken for some hwaccel > > formats). > > --- > > libavcodec/encode.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcod

[FFmpeg-devel] [PATCH 1/3] avcodec/mpegvideo_enc: Combine some checks

2021-12-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index d33cf9477d..4adb95eca7 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@

Re: [FFmpeg-devel] [PATCH 1/2] lavc/encode: improve the empty frame check

2021-12-13 Thread James Almer
On 12/13/2021 10:30 AM, Anton Khirnov wrote: Quoting James Almer (2021-12-13 12:40:49) On 12/13/2021 7:47 AM, Anton Khirnov wrote: Test for buf[0] rather than data[0] (which is broken for some hwaccel formats). --- libavcodec/encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] [PATCH 2/3] avcodec/mpegvideo_enc: Remove some impossible branches

2021-12-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 4adb95eca7..8865e38293 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 3/3] avcodec/mpegvideo_enc: Reindent after the previous commit

2021-12-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 8865e38293..128d1a327c 100644 --- a/libavcodec/mpegvideo_enc.c

[FFmpeg-devel] [PATCH 04/24] ffmpeg: store the output file index in OutputFile

2021-12-13 Thread Anton Khirnov
Use it to simplify check_init_output_file(). Will allow further simplifications in the following commits. --- fftools/ffmpeg.c | 10 +- fftools/ffmpeg.h | 2 ++ fftools/ffmpeg_opt.c | 1 + 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/f

[FFmpeg-devel] [PATCH 01/24] ffmpeg: pass the muxer context explicitly to some functions

2021-12-13 Thread Anton Khirnov
Stop accessing OutputFile.ctx. This will be useful in the following commits, where it will become hidden. --- fftools/ffmpeg_opt.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 9c820ab73f..f638edace9 100644 --

[FFmpeg-devel] [PATCH 02/24] ffmpeg: simplify getting output file size

2021-12-13 Thread Anton Khirnov
Stop calling avio_size()/avio_tell(), which are potentially heavy operations and may interfere with muxer operation. Use the recently introduced bytes_written field instead. --- fftools/ffmpeg.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpeg.c b/fftoo

[FFmpeg-devel] [PATCH 03/24] ffmpeg: remove a redundant assignment of interrupt_callback

2021-12-13 Thread Anton Khirnov
It is already set in open_output_file(). --- fftools/ffmpeg.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index b77531cb7f..fb017a1e37 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2947,8 +2947,6 @@ static int check_init_output_file(OutputFil

[FFmpeg-devel] [PATCH 06/24] ffmpeg: move writing the trailer to ffmpeg_mux.c

2021-12-13 Thread Anton Khirnov
--- fftools/ffmpeg.c | 16 +++- fftools/ffmpeg.h | 1 + fftools/ffmpeg_mux.c | 21 + 3 files changed, 25 insertions(+), 13 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index a00fe58063..1fb10869b4 100644 --- a/fftools/ffmpeg.c +++ b/fftool

[FFmpeg-devel] [PATCH 11/24] ffmpeg: set want_sdp when initializing the muxer

2021-12-13 Thread Anton Khirnov
Allows making the variable local to ffmpeg_mux. --- fftools/ffmpeg.c | 9 + fftools/ffmpeg.h | 1 - fftools/ffmpeg_mux.c | 5 + 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 3ed1201fda..f76e5df8d2 100644 --- a/fftools/f

[FFmpeg-devel] [PATCH 05/24] ffmpeg: move some muxing-related code into a separate file

2021-12-13 Thread Anton Khirnov
This is a first step towards making muxers more independent from the rest of the code. --- fftools/Makefile | 11 +- fftools/ffmpeg.c | 273 ++-- fftools/ffmpeg.h | 10 ++ fftools/ffmpeg_mux.c | 293 +++ 4 fi

[FFmpeg-devel] [PATCH 07/24] ffmpeg: move freeing the output file to ffmpeg_mux.c

2021-12-13 Thread Anton Khirnov
--- fftools/ffmpeg.c | 14 ++ fftools/ffmpeg.h | 1 + fftools/ffmpeg_mux.c | 17 + 3 files changed, 20 insertions(+), 12 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 1fb10869b4..86f7b11654 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmp

[FFmpeg-devel] [PATCH 08/24] ffmpeg: store output format separately from the muxer context

2021-12-13 Thread Anton Khirnov
Allows accessing it without going through the muxer context. This will be useful in the following commits, where the muxer context will be hidden. --- fftools/ffmpeg.c | 18 ++ fftools/ffmpeg.h | 2 ++ fftools/ffmpeg_opt.c | 1 + 3 files changed, 13 insertions(+), 8 delet

[FFmpeg-devel] [PATCH 09/24] ffmpeg_mux: add private muxer context

2021-12-13 Thread Anton Khirnov
Move header_written into it, which is not (and should not be) used by any code outside of ffmpeg_mux. In the future this context will contain more muxer-private state that should not be visible to other code. --- fftools/ffmpeg.h | 6 -- fftools/ffmpeg_mux.c | 26 ++--

[FFmpeg-devel] [PATCH 10/24] ffmpeg: refactor limiting output file size with -fs

2021-12-13 Thread Anton Khirnov
Move the file size checking code to ffmpeg_mux. Stop calling avio_tell(), which is a potentially heavy operation - use the recently introduced bytes_written instead. --- fftools/ffmpeg.c | 4 +--- fftools/ffmpeg.h | 4 ++-- fftools/ffmpeg_mux.c | 14 +- fftools/ffmpeg_opt.c |

[FFmpeg-devel] [PATCH 17/24] ffmpeg: do not log to the muxer context

2021-12-13 Thread Anton Khirnov
All other logging goes to NULL context. --- fftools/ffmpeg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d69e4119ef..afd442ff4e 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2954,7 +2954,6 @@ static void init_encoder_t

[FFmpeg-devel] [PATCH 19/24] ffmpeg: fix initial muxing queue size

2021-12-13 Thread Anton Khirnov
It stores pointers to AVPacket, not AVPackets themselves. --- fftools/ffmpeg_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 5a12a1c899..9281e6c94c 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -411,7 +41

[FFmpeg-devel] [PATCH 20/24] ffmpeg_mux: split queuing packets into a separate function

2021-12-13 Thread Anton Khirnov
--- fftools/ffmpeg_mux.c | 72 +++- 1 file changed, 44 insertions(+), 28 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 9281e6c94c..d4b674c9e2 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -63,12 +63,50 @@ stat

[FFmpeg-devel] [PATCH 15/24] ffmpeg: refactor the code checking for bitexact output

2021-12-13 Thread Anton Khirnov
Figure out earlier whether the output stream/file should be bitexact and store this information in a flag in OutputFile/OutputStream. Stop accessing the muxer in set_encoder_id(), which will become forbidden in future commits. --- fftools/ffmpeg.c | 21 + fftools/ffmpeg.h

[FFmpeg-devel] [PATCH 24/24] ffmpeg: move output file opts into private context

2021-12-13 Thread Anton Khirnov
It is private to the muxer, no reason to access it from outside. --- fftools/ffmpeg.h | 3 +-- fftools/ffmpeg_mux.c | 9 ++--- fftools/ffmpeg_opt.c | 12 ++-- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 76c8dfa4c8..69

[FFmpeg-devel] [PATCH 12/24] ffmpeg: write the header for stream-less outputs when initializing the muxer

2021-12-13 Thread Anton Khirnov
There is no reason to delay this. --- fftools/ffmpeg.c | 11 --- fftools/ffmpeg_mux.c | 7 +++ 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index f76e5df8d2..c01ff2fa92 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -

[FFmpeg-devel] [PATCH 22/24] ffmpeg: move a comment to a more appropriate place

2021-12-13 Thread Anton Khirnov
--- fftools/ffmpeg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index bbedf867b4..538601e440 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1064,6 +1064,11 @@ static void do_video_out(OutputFile *of, }

[FFmpeg-devel] [PATCH 16/24] ffmpeg: access output file chapters through a wrapper

2021-12-13 Thread Anton Khirnov
Avoid accessing the muxer context directly, as this will become forbidden in future commits. --- fftools/ffmpeg.c | 15 +-- fftools/ffmpeg.h | 2 ++ fftools/ffmpeg_mux.c | 7 +++ 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ff

[FFmpeg-devel] [PATCH 21/24] ffmpeg_mux: split of_write_packet()

2021-12-13 Thread Anton Khirnov
It is currently called from two places: - output_packet() in ffmpeg.c, which submits the newly available output packet to the muxer - from of_check_init() in ffmpeg_mux.c after the header has been written, to flush the muxing queue Some packets will thus be processed by this function twice, so

[FFmpeg-devel] [PATCH 18/24] ffmpeg: move the mux queue into muxer private data

2021-12-13 Thread Anton Khirnov
The muxing queue currently lives in OutputStream, which is a very large struct storing the state for both encoding and muxing. The muxing queue is only used by the code in ffmpeg_mux, so it makes sense to restrict it to that file. This makes the first step towards reducing the scope of OutputStrea

[FFmpeg-devel] [PATCH 23/24] ffmpeg: simplify the use of OutputStream.frame_number

2021-12-13 Thread Anton Khirnov
It features in limiting the number of output frames (-frames option) and currently can be incremented from two places: - for video encoding (not streamcopy), in do_video_out() after each successful avcodec_send_frame() call - for all other cases, in of_submit_packet() Not only is this inconsiste

[FFmpeg-devel] [PATCH 13/24] ffmpeg: add a helper function to access output file size

2021-12-13 Thread Anton Khirnov
Stop accessing muxer internals from outside of ffmpeg_mux. --- fftools/ffmpeg.c | 6 +- fftools/ffmpeg.h | 1 + fftools/ffmpeg_mux.c | 6 ++ 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index c01ff2fa92..b7f26fe288 100644 --- a/

[FFmpeg-devel] [PATCH 14/24] ffmpeg: move closing the file into of_write_trailer()

2021-12-13 Thread Anton Khirnov
The current code postpones closing the files until after printing the final report, which accesses the output file size. Deal with this by storing the final file size before closing the file. --- fftools/ffmpeg.c | 13 - fftools/ffmpeg_mux.c | 15 ++- 2 files changed, 1

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Michael Niedermayer
On Thu, Nov 25, 2021 at 06:19:32PM +0100, Michael Niedermayer wrote: > Hi all > > just wanted to remind everyone of the plan (suggested by jb) to make the > 5.0 release in december > i dont know if that will work out but please avoid introducing > risky changes until the release branch splits off

[FFmpeg-devel] [PATCH v2 01/03] libavdevice/avfoundation.m: use AudioConvert, extend supported formats

2021-12-13 Thread Romain Beauxis
This is the first patch of a series of 3 that cleanup and enhance the avfoundation implementation for libavdevice. This patch: * Implements support for AudioConverter * Switches to AudioConverter's API to convert unsupported PCM formats (non-interleaved, non-packed) to supported formats * Minimiz

[FFmpeg-devel] [PATCH v2 02/03] libavdevice/avfoundation.m: Replace mutex-based concurrency handling in avfoundation.m by a thread-safe fifo queue with maximum length.

2021-12-13 Thread Romain Beauxis
This is the second patch of a series of 3 that cleanup and enhance the avfoundation implementation for libavdevice. This patch fixes the concurrency model. Avfoundation runs its own producing thread to send produced frames and ffmpeg runs its own thread to consume them. The existing implementati

[FFmpeg-devel] [PATCH v2 03/03] libavdevice/avfoundation.m: Allow to select devices by digest.

2021-12-13 Thread Romain Beauxis
This is the third patch of a series of 3 that cleanup and enhance the avfoundation implementation for libavdevice. This patch adds a digest to avfoundation devices, when available. This is needed because device index can change while the machine is running when devices are plugged or unplugged and

[FFmpeg-devel] [PATCH v20 02/20] avutil/frame: Prepare AVFrame\n for subtitle handling

2021-12-13 Thread Daniel Cantarín
the v23_plus set still fails: ./ffmpeg -ss 20 -i dvbsubtest.ts -filter_complex "[0:v][0:s]overlay[v]" -map '[v]' -map 0:a -acodec copy -vcodec mpeg4 -t 5 -bitexact /tmp/file.avi Input #0, mpegts, from 'dvbsubtest.ts': Duration: 00:00:34.64, start: 79677.098467, bitrate: 4842 kb/s Program

Re: [FFmpeg-devel] Politics

2021-12-13 Thread Jean-Baptiste Kempf
Hello Softworkz On Sun, 12 Dec 2021, at 07:15, Soft Works wrote: > yesterday, it happened for the 4th and 5th times that another developer > called my patchset a “hack”. > > In none of the 4 cases, anybody was able to give even a single reason. > My assessment is that when a skilled developer is u

Re: [FFmpeg-devel] Politics

2021-12-13 Thread Jean-Baptiste Kempf
On Sun, 12 Dec 2021, at 20:42, Nicolas George wrote: >> Now, if there's issues with his approach, that's fine. > > There are many issues, I pointed them at the time and was rudely > ignored. Would you care to share a link to that email? It's been difficult to follow to be honest, with the numer

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Jean-Baptiste Kempf
On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: > previous unused suggestions where: > Von Neumann, Lorentz, Poincaré, Desitter, De Broglie, Gauss, Galois, > Viterbi, Darwin I'd love a "Lorentz" release :) -- Jean-Baptiste Kempf - President +33 672 704 734 ___

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Jean-Baptiste Kempf
On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: > If you know of any major issues which need to be done before the release do > them > now. If you know of any issues which are release-blocking list them in a reply > here please. Maybe the audio channel layout would be nice to settle bef

Re: [FFmpeg-devel] [PATCH v2 03/03] libavdevice/avfoundation.m: Allow to select devices by digest.

2021-12-13 Thread Marvin Scholz
On 13 Dec 2021, at 17:40, Romain Beauxis wrote: This is the third patch of a series of 3 that cleanup and enhance the avfoundation implementation for libavdevice. This patch adds a digest to avfoundation devices, when available. This is needed because device index can change while the machine i

Re: [FFmpeg-devel] Politics

2021-12-13 Thread Soft Works
> -Original Message- > From: Jean-Baptiste Kempf > Sent: Monday, December 13, 2021 7:01 PM > To: FFmpeg development discussions and patches > Cc: Soft Works > Subject: Re: [FFmpeg-devel] Politics > > Hello Softworkz > > On Sun, 12 Dec 2021, at 07:15, Soft Works wrote: > > yesterday,

Re: [FFmpeg-devel] [PATCH v2 03/03] libavdevice/avfoundation.m: Allow to select devices by digest.

2021-12-13 Thread Romain Beauxis
> On Dec 13, 2021, at 12:25 PM, Marvin Scholz wrote: > > On 13 Dec 2021, at 17:40, Romain Beauxis wrote: > >> This is the third patch of a series of 3 that cleanup and enhance the >> avfoundation implementation for libavdevice. >> >> This patch adds a digest to avfoundation devices, when ava

Re: [FFmpeg-devel] [PATCH v2 02/03] libavdevice/avfoundation.m: Replace mutex-based concurrency handling in avfoundation.m by a thread-safe fifo queue with maximum length.

2021-12-13 Thread Marvin Scholz
On 13 Dec 2021, at 17:39, Romain Beauxis wrote: This is the second patch of a series of 3 that cleanup and enhance the avfoundation implementation for libavdevice. This patch fixes the concurrency model. Avfoundation runs its own producing thread to send produced frames and ffmpeg runs its

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread James Almer
On 12/13/2021 3:05 PM, Jean-Baptiste Kempf wrote: On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: If you know of any major issues which need to be done before the release do them now. If you know of any issues which are release-blocking list them in a reply here please. Maybe the

Re: [FFmpeg-devel] Politics

2021-12-13 Thread Calvin Walton
On Sun, 2021-12-12 at 06:15 +, Soft Works wrote: > Good Morning, > > yesterday, it happened for the 4th and 5th times that another > developer > called my patchset a “hack”. This might be partially a language problem. Ffrom familiarity with the usage in several primarily-English development

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Lynne
13 Dec 2021, 20:04 by jamr...@gmail.com: > > > On 12/13/2021 3:05 PM, Jean-Baptiste Kempf wrote: > >> On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: >> >>> If you know of any major issues which need to be done before the release do >>> them >>> now. If you know of any issues which are

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Anton Khirnov
Quoting James Almer (2021-12-13 20:04:34) > > > On 12/13/2021 3:05 PM, Jean-Baptiste Kempf wrote: > > On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: > >> If you know of any major issues which need to be done before the release > >> do them > >> now. If you know of any issues which are

Re: [FFmpeg-devel] Politics

2021-12-13 Thread Lynne
13 Dec 2021, 19:26 by softwo...@hotmail.com: > > >> -Original Message- >> From: Jean-Baptiste Kempf >> Sent: Monday, December 13, 2021 7:01 PM >> To: FFmpeg development discussions and patches >> Cc: Soft Works >> Subject: Re: [FFmpeg-devel] Politics >> >> Hello Softworkz >> >> On Sun,

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread James Almer
On 12/13/2021 4:47 PM, Anton Khirnov wrote: Quoting James Almer (2021-12-13 20:04:34) On 12/13/2021 3:05 PM, Jean-Baptiste Kempf wrote: On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: If you know of any major issues which need to be done before the release do them now. If you kn

Re: [FFmpeg-devel] Politics

2021-12-13 Thread Calvin Walton
On Mon, 2021-12-13 at 14:32 -0500, Calvin Walton wrote: > like, for example, I rewrote the "fps" filter to use the activate > callback to handle filling in large timestamp gaps a frame at a time > rather than buffering a ton of frames all at once and causing OOM. But > that only fixed the situation

Re: [FFmpeg-devel] Politics

2021-12-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Calvin > Walton > Sent: Monday, December 13, 2021 8:32 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Politics > > On Sun, 2021-12-12 at 06:15 +, Soft Works wrote: > > Good Morning, > > > > ye

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Anton Khirnov
Quoting James Almer (2021-12-13 20:51:05) > > > On 12/13/2021 4:47 PM, Anton Khirnov wrote: > > Quoting James Almer (2021-12-13 20:04:34) > >> > >> > >> On 12/13/2021 3:05 PM, Jean-Baptiste Kempf wrote: > >>> On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: > If you know of any majo

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread James Almer
On 12/13/2021 5:01 PM, Anton Khirnov wrote: Quoting James Almer (2021-12-13 20:51:05) On 12/13/2021 4:47 PM, Anton Khirnov wrote: Quoting James Almer (2021-12-13 20:04:34) On 12/13/2021 3:05 PM, Jean-Baptiste Kempf wrote: On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: If yo

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Anton Khirnov
Quoting James Almer (2021-12-13 21:05:30) > > > On 12/13/2021 5:01 PM, Anton Khirnov wrote: > > Quoting James Almer (2021-12-13 20:51:05) > >> > >> > >> On 12/13/2021 4:47 PM, Anton Khirnov wrote: > >>> Quoting James Almer (2021-12-13 20:04:34) > > > On 12/13/2021 3:05 PM, Jean-Bap

Re: [FFmpeg-devel] [PATCH v2 02/03] libavdevice/avfoundation.m: Replace mutex-based concurrency handling in avfoundation.m by a thread-safe fifo queue with maximum length.

2021-12-13 Thread Romain Beauxis
> On Dec 13, 2021, at 12:56 PM, Marvin Scholz wrote: > > > > On 13 Dec 2021, at 17:39, Romain Beauxis wrote: > >> This is the second patch of a series of 3 that cleanup and enhance the >> avfoundation implementation for libavdevice. >> >> This patch fixes the concurrency model. Avfoundation

Re: [FFmpeg-devel] Politics

2021-12-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: Monday, December 13, 2021 8:49 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Politics > > 13 Dec 2021, 19:26 by softwo...@hotmail.com: > > > > > > >> -Original Message- > >

[FFmpeg-devel] [PATCH] lavf/tls_mbedtls: fix handling of tls_verify=0

2021-12-13 Thread sfan5
If ca_file was set, setting tls_verify=0 would not actually disable verification. From 2677353187c4e3c20b50a3f9aab53130e3ead99b Mon Sep 17 00:00:00 2001 From: sfan5 Date: Mon, 13 Dec 2021 21:35:40 +0100 Subject: [PATCH] lavf/tls_mbedtls: fix handling of tls_verify=0 If ca_file was set, setting t

[FFmpeg-devel] [PATCH] lavc/mediacodecdec: set codec profile and level from extradata for H264+HEVC

2021-12-13 Thread sfan5
This value is later passed to MediaCodec and checked at decoder init. Notably decoding of 10-bit streams before this commit would "work" without returning errors but only return garbage output (on most Android devices). From 304d1bd55e72212c1e907922547d40da240b Mon Sep 17 00:00:00 2001 From: s

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Nicolas George
Lynne (12021-12-13): > Consensus was reached. A 16-bit opaque identifier, which users can > simply use as an index into their own frame opaque structure, if they > want, and a 16-bit channel identifier, which would result in a 32-bit > structure, which is pretty acceptable. No, consensus was not r

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Nicolas George
James Almer (12021-12-13): > I wholly agree. Hence me suggesting using AVBPrint in the meantime. It > certainly beats a uint8_t* + size_t combination, and it's trivial to do. There are a few misunderstanding here. For the per-channel label, I insist on at least a string, but a plain C string, eve

Re: [FFmpeg-devel] [PATCH v2 02/03] libavdevice/avfoundation.m: Replace mutex-based concurrency handling in avfoundation.m by a thread-safe fifo queue with maximum length.

2021-12-13 Thread Marvin Scholz
On 13 Dec 2021, at 21:29, Romain Beauxis wrote: On Dec 13, 2021, at 12:56 PM, Marvin Scholz wrote: On 13 Dec 2021, at 17:39, Romain Beauxis wrote: This is the second patch of a series of 3 that cleanup and enhance the avfoundation implementation for libavdevice. This patch fixes the c

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Diederick C. Niehorster
Hi Michael, On Mon, Dec 13, 2021 at 4:26 PM Michael Niedermayer wrote: > > If you know of any major issues which need to be done before the release do > them > now. If you know of any issues which are release-blocking list them in a reply > here please. Not major, but https://ffmpeg.org/piperm

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Marton Balint
On Mon, 13 Dec 2021, Jean-Baptiste Kempf wrote: On Mon, 13 Dec 2021, at 16:25, Michael Niedermayer wrote: If you know of any major issues which need to be done before the release do them now. If you know of any issues which are release-blocking list them in a reply here please. Maybe the a

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Hendrik Leppkes
On Mon, Dec 13, 2021 at 8:48 PM Anton Khirnov wrote: > > > - The request to wait for a new string handling API to land and be used > > for the relevant functions in this set. This has not seen opposition > > from anyone yet, but it's not very feasible if said new API is not yet > > in a state beyo

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-13 Thread Marton Balint
On Sun, 12 Dec 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-12-10 01:04:57) On Thu, 9 Dec 2021, Anton Khirnov wrote: Quoting Nicolas George (2021-12-09 11:31:54) Anton Khirnov (12021-12-09): I disagree. Technical limitations that were overcome 10 years ago should not guide ne

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-13 Thread James Almer
On 12/12/2021 5:00 PM, Nicolas George wrote: Anton Khirnov (12021-12-12): So what are you proposing? In my view, such higher level information should live at a higher level - e.g. in the side data. You can then have a filter that reads this side data and gets you the group you want. So, wha

[FFmpeg-devel] [PATCH] mov_read_mvhd: Expose Quicktime poster_time value as metadata TAG.

2021-12-13 Thread Bryce Newman
I need the ability to derive the poster time found in the mvhd, so I can use that value to create a thumbnail from ffmpeg. More details can be found here https://www.mail-archive.com/ffmpeg-user@ffmpeg.org/msg30003.html. Signed-off-by: Bryce Chester Newman mailto:bryce.new...@gettyimages.com>> --

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-13 Thread Nicolas George
James Almer (12021-12-13): > To achieve this you don't need the same AVChannel value to appear several > times in the same layout. You have INT_MAX values available, so just assign > one to each of these you mentioned. No need for an abstract value "user > defined" that would then show up several t

[FFmpeg-devel] [PATCH v24 00/21] Subtitle Filtering

2021-12-13 Thread Soft Works
New in V24 - Fixes bugs as reported by Michal - graphicsub2video: use 1x1 output frame size as long as subtitle size is unknown (0x0) and no size is not explicitly set - decode: set subtitle frame size from decoding context - ffmpeg: re-init graph when subtitle size changes - ffmpeg_filter: alway

[FFmpeg-devel] [PATCH v24 01/21] avcodec, avutil: Move enum AVSubtitleType to avutil, add new and deprecate old values

2021-12-13 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/avcodec.h | 19 + libavutil/Makefile | 1 + libavutil/subfmt.h | 68 libavutil/version.h | 1 + 4 files changed, 71 insertions(+), 18 deletions(-) create mode 100644 libavutil/subfmt.h diff -

[FFmpeg-devel] [PATCH v24 02/21] avutil/frame: Prepare AVFrame for subtitle handling

2021-12-13 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct AVSubt

[FFmpeg-devel] [PATCH v24 03/21] avcodec/subtitles: Introduce new frame-based subtitle decoding API

2021-12-13 Thread Soft Works
- Add avcodec_decode_subtitle3 which takes subtitle frames, serving as compatibility shim to legacy subtitle decoding - Add additional methods for conversion between old and new API Signed-off-by: softworkz --- libavcodec/avcodec.h| 8 +- libavcodec/codec_desc.c | 11 +++ libavcodec/cod

[FFmpeg-devel] [PATCH v24 04/21] avfilter/subtitles: Update vf_subtitles to use new decoding api

2021-12-13 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/vf_subtitles.c | 54 +- 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c index 3fc4eeb63d..66b2082894 100644 --- a/libavfilter/vf_subtitles.c +++ b/l

[FFmpeg-devel] [PATCH v24 05/21] avcodec, avutil: Move ass helper functions to avutil as avpriv_ and extend ass dialog parsing

2021-12-13 Thread Soft Works
Also add - hard_space callback (for upcoming fix) - extensible callback (for future extension) Signed-off-by: softworkz --- libavcodec/Makefile | 56 +++ libavcodec/ass.h | 147 ++ libavcodec/assdec.c

[FFmpeg-devel] [PATCH v24 06/21] avcodec/subtitles: Migrate subtitle encoders to frame-based API and provide a compatibility shim for the legacy api

2021-12-13 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/assenc.c| 90 + libavcodec/avcodec.h | 5 +- libavcodec/dvbsubenc.c | 96 +-- libavcodec/dvdsubenc.c | 100 +++-- libavcodec/encode.c| 63

[FFmpeg-devel] [PATCH v24 07/21] avcodec/subtitles: Replace deprecated enum values

2021-12-13 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/ass.h | 2 +- libavcodec/assdec.c| 2 +- libavcodec/dvbsubdec.c | 2 +- libavcodec/dvdsubdec.c | 2 +- libavcodec/dvdsubenc.c | 2 +- libavcodec/pgssubdec.c | 2 +- libavcodec/xsubdec.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) d

[FFmpeg-devel] [PATCH v24 08/21] fftools/play, probe: Adjust for subtitle changes

2021-12-13 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffplay.c | 102 +- fftools/ffprobe.c | 48 ++ 2 files changed, 78 insertions(+), 72 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index e7b20be76b..0af32888da 100644 --- a/fftoo

[FFmpeg-devel] [PATCH v24 09/21] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

2021-12-13 Thread Soft Works
Analog to avfilter/video.c and avfilter/audio.c Signed-off-by: softworkz --- libavfilter/Makefile| 1 + libavfilter/avfilter.c | 4 +++ libavfilter/internal.h | 1 + libavfilter/subtitles.c | 63 + libavfilter/subtitles.h | 44

[FFmpeg-devel] [PATCH v24 10/21] avfilter/avfilter: Handle subtitle frames

2021-12-13 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfilter.h | 11 +++ libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 22 ++ libavfilter/formats.h | 3 +++ libavfilter/internal.h | 18 +++

[FFmpeg-devel] [PATCH v24 11/21] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

2021-12-13 Thread Soft Works
Signed-off-by: softworkz --- configure| 2 +- libavfilter/allfilters.c | 2 ++ libavfilter/buffersink.c | 54 ++ libavfilter/buffersink.h | 7 libavfilter/buffersrc.c | 72 libavfilter/buffersrc.h | 1

[FFmpeg-devel] [PATCH v24 12/21] avfilter/overlaygraphicsubs: Add overlaygraphicsubs and graphicsub2video filters

2021-12-13 Thread Soft Works
- overlaygraphicsubs (VS -> V) Overlay graphic subtitles onto a video stream - graphicsub2video {S -> V) Converts graphic subtitles to video frames (with alpha) Gets auto-inserted for retaining compatibility with sub2video command lines Signed-off-by: softworkz --- doc/filters.texi

[FFmpeg-devel] [PATCH v24 13/21] fftools/ffmpeg: Replace sub2video with subtitle frame filtering and use new frame-based subtitle encoding API

2021-12-13 Thread Soft Works
This commit actually enables subtitle filtering in ffmpeg by sending and receiving subtitle frames to and from a filtergraph. The heartbeat functionality from the previous sub2video implementation is retained and applied to all subtitle frames (bitmap, text, ..). The other part of sub2video funct

[FFmpeg-devel] [PATCH v24 14/21] avfilter/avfilter: Fix hardcoded input index

2021-12-13 Thread Soft Works
This fix targets (rare) cases where multiple input pads have a .filter_frame function. ff_request_frame_to_filter needs to call ff_request_frame with the correct input pad instead of the hardcoded first one. Signed-off-by: softworkz --- libavfilter/avfilter.c | 18 +- 1 file chan

[FFmpeg-devel] [PATCH v24 15/21] avfilter/overlaytextsubs: Add overlaytextsubs and textsubs2video filters

2021-12-13 Thread Soft Works
- overlaytextsubs {VS -> V) Overlay text subtitles onto a video stream. - textsubs2video {S -> V) Converts text subtitles to video frames Signed-off-by: softworkz --- configure| 2 + doc/filters.texi | 113 ++ libavfilter/Makefile |

[FFmpeg-devel] [PATCH v24 16/21] avfilter/textmod: Add textmod, censor and show_speaker filters

2021-12-13 Thread Soft Works
s- textmod {S -> S) Modify subtitle text in a number of ways - censor {S -> S) Censor subtitles using a word list - show_speaker {S -> S) Prepend speaker names from ASS subtitles to the visible text lines Signed-off-by: softworkz --- doc/filters.texi | 206 libavfilt

[FFmpeg-devel] [PATCH v24 17/21] avfilter/stripstyles: Add stripstyles filter

2021-12-13 Thread Soft Works
- stripstyles {S -> S) Remove all inline styles from subtitle events Signed-off-by: softworkz --- doc/filters.texi | 37 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_stripstyles.c | 196 +++ 4 fi

[FFmpeg-devel] [PATCH v24 18/21] avfilter/splitcc: Add splitcc filter for closed caption handling

2021-12-13 Thread Soft Works
- splitcc {V -> VS) Extract closed-caption (A53) data from video frames as subtitle Frames ffmpeg -y -loglevel verbose -i "https://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts"; -filter_complex "[0:v]splitcc[vid1],textmod=mode=remove_chars:find='@',[vid1]overlay_textsubs" outpu

  1   2   >