Re: [FFmpeg-devel] [PATCH 05/35] avdevice/dshow: set no-seek flags

2021-06-08 Thread Valerii Zapodovnikov
Just resend them (without any -v2). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-08 Thread Dennis Fleurbaaij
Hi Carl, Thanks for the question. The four letter "r12b" format code is from the DeckLink documentation; there are other described formats there as well such as r12l, r10b, r10l and r210. I'm using DirectShow which signals the encoding to downstream components through the use of FOURCC codes and

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-08 Thread Valerii Zapodovnikov
вт, 8 июн. 2021 г., 5:28 Michael Bradshaw : > I'll just chime in and say: > > FIXME comments aren't that helpful. It would be more helpful to av_log when > you detect you've hit an unsupported situation. > How should I know what are unsupported situations? I mean sure, sYCC (BT.709 primaries with

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-08 Thread Valerii Zapodovnikov
BTW, who knows how to show warnings on make job on patchwork? Only if make fate fails you can see it, but not otherwise. Also, md5 warnings, when you are going to fix those?? https://patchwork.ffmpeg.org/project/ffmpeg/patch/CAPUCmECSxQwMtttmRqTC-JtOpcfUB9SVQ8ZPZOHULFL9=2d...@mail.gmail.com/ _

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay_cuda: support expression of x y position

2021-06-08 Thread Timo Rothenpieler
It'd probably make sense to also copy over the option for evaluating the expression per-frame or on init. Given that this is usually going to run much faster than the software overlay filter, the slight overhead from the expression could be much more severe. Looks good otherwise, and for what

[FFmpeg-devel] [PATCH v2] avfilter/vf_overlay_cuda: support expression of x y position

2021-06-08 Thread Steven Liu
and add per-frame / init mode for it. Signed-off-by: Steven Liu --- libavfilter/vf_overlay_cuda.c | 153 -- 1 file changed, 144 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_overlay_cuda.c b/libavfilter/vf_overlay_cuda.c index 8a4d2c4312..b2ed8de24e 1

Re: [FFmpeg-devel] [PATCH 21/35] avdevice: capabilities API details no longer public

2021-06-08 Thread Andreas Rheinhardt
Diederick C. Niehorster: > On Tue, Jun 8, 2021 at 1:54 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Diederick Niehorster: >>> NB: will break build, makes needed corresponding changes to avformat. >>> >> >> Then said changes should be part of this patch. Patches should be >

[FFmpeg-devel] [PATCH 02/33] avdevice/dshow: add use_video_device_timestamps to docs

2021-06-08 Thread Diederick Niehorster
Signed-off-by: Diederick Niehorster --- doc/indevs.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/indevs.texi b/doc/indevs.texi index b377924c2f..685b1357a6 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -611,6 +611,12 @@ Save the currently used video capture filter dev

[FFmpeg-devel] [PATCH 05/33] avdevice/dshow: set no-seek flags

2021-06-08 Thread Diederick Niehorster
avdevice/dshow is a realtime device and as such does not support seeking. Therefore, its demuxer format should define the AVFMT_NOBINSEARCH, AVFMT_NOGENSEARCH and AVFMT_NO_BYTE_SEEK flags. With these flags set, attempting to seek (with e.g. avformat_seek_file()) correctly yields -1 (operation no

Re: [FFmpeg-devel] [PATCH 05/35] avdevice/dshow: set no-seek flags

2021-06-08 Thread Diederick C. Niehorster
didn't have the patchst anymore and already processed comments in later patches, so 02/35 and 05/35 became out of 33. Noticed that too late. Hope that doesn't confuse anything. Else we'll get it on -v2 of this series (which there will certainly be), where i think i'll throttle sending a bit (someho

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay_cuda: support expression of x y position

2021-06-08 Thread Steven Liu
Timo Rothenpieler 于2021年6月8日周二 下午6:23写道: > > It'd probably make sense to also copy over the option for evaluating the > expression per-frame or on init. > Given that this is usually going to run much faster than the software > overlay filter, the slight overhead from the expression could be much >

Re: [FFmpeg-devel] [PATCH] videotoolboxenc: enable constant quality with -q:v on Apple Silicon Macs and use b-frames für HEVC and H264 and b-pyramid for HEVC.

2021-06-08 Thread Thilo Borgmann
Hi, Am 19.03.21 um 19:54 schrieb Rick Kern: On Fri, Jan 22, 2021 at 3:28 PM wrote: From: Simone Karin Lehmann Signed-off-by: Simone Karin Lehmann Applied --- libavcodec/videotoolboxenc.c | 54 1 file changed, 42 insertions(+), 12 deletions(-) d

Re: [FFmpeg-devel] [PATCH 10/35] fftools: provide media type info for devices

2021-06-08 Thread Nicolas George
Diederick Niehorster (12021-06-08): > fftools now print info about what media type(s), if any, are provided > by sink and source avdevices. Furthermore, printing is done with > av_log instead of printf as the latter doesn't handle characters in > some device names correctly (e.g. "Microphone Array

Re: [FFmpeg-devel] [PATCH 11/35] avformat: add control_message function to AVInputFormat

2021-06-08 Thread Nicolas George
Diederick Niehorster (12021-06-08): > Control messages are useful for programmatic control of not only outdevs but > also indevs. > Bumping avformat version. > > Signed-off-by: Diederick Niehorster > --- > libavdevice/avdevice.c | 8 +--- > libavformat/avformat.h | 6 ++ > libavformat/v

Re: [FFmpeg-devel] [PATCH 13/35] avdevice: adding control message requesting to show config dialog

2021-06-08 Thread Nicolas George
Diederick Niehorster (12021-06-08): > This control message can be used to programmatically ask a device to show its > configuration dialog. > Bumping avdevice version. > > Signed-off-by: Diederick Niehorster > --- > libavdevice/avdevice.h | 10 ++ > libavdevice/version.h | 2 +- > 2 f

Re: [FFmpeg-devel] [PATCH 20/35] avdevice/avdevice: clean up avdevice_capabilities_create

2021-06-08 Thread Nicolas George
Diederick Niehorster (12021-06-08): > Draw implementation in line with that of avdevice_list_devices > > Signed-off-by: Diederick Niehorster > --- > libavdevice/avdevice.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavdevice/avdevice.c b/libavdevice/avde

Re: [FFmpeg-devel] [PATCH]avfilter: add Intel IPP library based x86 optimized video scaling filter

2021-06-08 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Jan > Ekström > If you just go without any rhetoric and just look at what "nonfree" > (which IMHO is an awful name for the configuration option, it's just > "non-distributable") > > We can start with the history of the option - ori

Re: [FFmpeg-devel] [PATCH 26/35] avdevice: Add internal helpers for querying device capabilities

2021-06-08 Thread Michael Niedermayer
On Tue, Jun 08, 2021 at 01:04:05AM +0200, Diederick Niehorster wrote: > Signed-off-by: Diederick Niehorster > --- > libavdevice/internal.h | 31 +++ > libavdevice/utils.c| 48 ++ > libavdevice/version.h | 2 +- > 3 files change

[FFmpeg-devel] [PATCH] Fix memory allocation problem. Related to ticket #9264.

2021-06-08 Thread houlei
From: houlei Signed-off-by: houlei --- libavdevice/xv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavdevice/xv.c b/libavdevice/xv.c index 24ba3179f6..7e15c178b6 100644 --- a/libavdevice/xv.c +++ b/libavdevice/xv.c @@ -296,10 +296,11 @@ static int write_picture(A

[FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for qsv

2021-06-08 Thread Zhong Li
Signed-off-by: Zhong Li --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index dcac46003e..39ce91b755 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -226,7 +226,7 @@ Codecs: ptx.c Ivo van Poorten qce

Re: [FFmpeg-devel] [PATCH 25/35] avutil/opt: add av_opt_to_string

2021-06-08 Thread Nicolas George
Diederick Niehorster (12021-06-08): > This function allows formatting an option value stored in a double (such as > the min and max fields of an AVOption, or min_value and max_value of an > AVOptionRange) properly, e.g. 1 for a AV_OPT_TYPE_PIXEL_FMT -> yuyv422. > Useful when printing more info a

Re: [FFmpeg-devel] [PATCH 17/35] avdevice/dshow: discover source color range/space/etc

2021-06-08 Thread Michael Niedermayer
On Tue, Jun 08, 2021 at 01:03:56AM +0200, Diederick Niehorster wrote: > Enabled discovering a DirectShow device's color range, space, primaries, > transfer characteristics and chroma location, if the device exposes that > information. Sets them in the stream's codecpars. > > Signed-off-by: Diede

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-08 Thread Valerii Zapodovnikov
Wait a second. SDL_SetYUVConversionMode does not support 444? You are setting it to mode = SDL_YUV_CONVERSION_AUTOMATIC if it is 444, which I suppose works on just the size of frame? Then this cannot be fixed, I suppose? There is a workround above, as I said. ___

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/vc2enc: Check for non negative slice bounds

2021-06-08 Thread Michael Niedermayer
On Tue, Jun 01, 2021 at 09:33:15AM +0200, Michael Niedermayer wrote: > Fixes: invalid shifts > Fixes: Ticket 8221 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/vc2enc.c | 2 ++ > 1 file changed, 2 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BA

Re: [FFmpeg-devel] [PATCH] avformat/rpl: Check for EOF and zero framesize

2021-06-08 Thread Michael Niedermayer
On Sat, Jun 05, 2021 at 04:31:42PM +0200, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 34751/clusterfuzz-testcase-minimized-ffmpeg_dem_RPL_fuzzer-5439330800762880 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dpx: fix off by 1 in bits_per_color check

2021-06-08 Thread Michael Niedermayer
On Sun, May 16, 2021 at 09:38:59PM +0200, Michael Niedermayer wrote: > Fixes: CID1476303 Bad bit shift operation > > Signed-off-by: Michael Niedermayer > --- > libavcodec/dpx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF21

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/vp9dsp: rename the iszero function to is_zero

2021-06-08 Thread James Almer
On 6/7/2021 6:23 PM, Ronald S. Bultje wrote: Hi, On Sun, Jun 6, 2021 at 10:42 PM James Almer wrote: From: Matthieu Patou The function name iszero() may collide with a function in glibc. Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- tests/checkasm/vp9dsp.c | 6 +++--- 1 fil

[FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Thilo Borgmann
Hi, add %{localtime_ms} function to the drawtext filter. Same as %{localtime} but with additional millisecond part. -Thilo From f3b32f3e2b01f50b4fa41f8432ccd5a5eeea1ec1 Mon Sep 17 00:00:00 2001 From: Kirill Pugin Date: Tue, 8 Jun 2021 18:32:45 +0200 Subject: [PATCH] lavfi/drawtext: Add localti

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Valerii Zapodovnikov
Plese resend it in new thread but rename it to .txt. thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "u

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Andreas Rheinhardt
Valerii Zapodovnikov: > Plese resend it in new thread but rename it to .txt. thanks. Why should he do so? - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Valerii Zapodovnikov
Oh, so it worked on patchwork? Strnge, okay then. No need to. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Thilo Borgmann
Am 08.06.21 um 18:52 schrieb Valerii Zapodovnikov: > Oh, so it worked on patchwork? Strnge, okay then. No need to. Please read [1] and [2]. Please keep all old text and do inline-commenting. -Thilo [1] http://ffmpeg.org/developer.html [2] http://ffmpeg.org/mailing-list-faq.html _

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Valerii Zapodovnikov
вт, 8 июн. 2021 г., 19:57 Thilo Borgmann : > Am 08.06.21 um 18:52 schrieb Valerii Zapodovnikov: > > Oh, so it worked on patchwork? Strnge, okay then. No need to. > > Please read [1] and [2]. Please keep all old text and do inline-commenting. > > -Thilo > No. > > [1] http://ffmpeg.org/developer.h

[FFmpeg-devel] [PATCH] Null check of &s->internal before attempting to free dict and pkt - avoid Null pointer dereference crash

2021-06-08 Thread Robert Beyer
--- libavformat/utils.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index fe8eaa6cb3..73a7d13123 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4331,9 +4331,11 @@ void avformat_free_context(AVFormatContext *s

Re: [FFmpeg-devel] [PATCH] Rename SRT's streamid to srt_streamid to avoid a conflict with standard streamid option

2021-06-08 Thread Sergey Ilinykh
this one http://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/280949.html does a better job. please merge Best Regards, Sergey чт, 3 июн. 2021 г. в 13:37, Sergey Ilinykh : > Default streamid is some numeric value and not used by SRT code. Instead > SRT has its own string streamid. Current code h

Re: [FFmpeg-devel] [PATCH] Null check of &s->internal before attempting to free dict and pkt - avoid Null pointer dereference crash

2021-06-08 Thread Andreas Rheinhardt
Robert Beyer: > --- > libavformat/utils.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index fe8eaa6cb3..73a7d13123 100644 > --- a/libavformat/utils.c > +++ b/libavformat/utils.c > @@ -4331,9 +4331,11 @@ void avformat

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Nicolas George
Valerii Zapodovnikov (12021-06-08): > Oh, so it worked on patchwork? Strnge, okay then. No need to. Thilo's mail was very fine. If patchwork does not accept it, then patchwork needs fixing, not Thilo's mail. Valerii Zapodovnikov (12021-06-08): > No. ? Regards, -- Nicolas George signature.

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Thilo Borgmann
Am 08.06.21 um 19:00 schrieb Valerii Zapodovnikov: > вт, 8 июн. 2021 г., 19:57 Thilo Borgmann : > >> Am 08.06.21 um 18:52 schrieb Valerii Zapodovnikov: >>> Oh, so it worked on patchwork? Strnge, okay then. No need to. >> >> Please read [1] and [2]. Please keep all old text and do inline-commenting

Re: [FFmpeg-devel] [PATCH] Null check of &s->internal before attempting to free dict and pkt - avoid Null pointer dereference crash

2021-06-08 Thread Robert Beyer
Andreas Rheinhardt: In my test case: avformat_open_input(pInputContext, ...) returns an error code Attempts to free the (allocated?) context memory then causes a NULL reference exception when accessing &s->internal->id3v2_meta, etc. since &s->internal is NULL. avformat_free_context(pInputCo

Re: [FFmpeg-devel] [PATCH] Null check of &s->internal before attempting to free dict and pkt - avoid Null pointer dereference crash

2021-06-08 Thread Andreas Rheinhardt
Robert Beyer: > Andreas Rheinhardt: > > In my test case: > avformat_open_input(pInputContext, ...) returns an error code > > Attempts to free the (allocated?) context memory then causes a NULL reference exception when accessing &s->internal->id3v2_meta, etc. since &s->internal is NULL. > avfor

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-08 Thread Dennis Fleurbaaij
Thanks again for the review Andreas. I've addressed the comments: - moved back to the C90+ style which was in other decoders as well. - The buffer size check makes sense and I've added that, I'm unsure about how ffmpeg exactly handles alignment in some cases so I've opted to stay on th

Re: [FFmpeg-devel] [PATCH] Null check of &s->internal before attempting to free dict and pkt - avoid Null pointer dereference crash

2021-06-08 Thread Robert Beyer
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: June 8, 2021 1:21 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] Null check of &s->internal before > attempting to free dict and pkt - avoid Null pointer dereference crash > > Rob

Re: [FFmpeg-devel] [PATCH] Null check of &s->internal before attempting to free dict and pkt - avoid Null pointer dereference crash

2021-06-08 Thread Andreas Rheinhardt
Robert Beyer: >> -Original Message- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: June 8, 2021 1:21 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] Null check of &s->internal before >> attempting to free dict and pkt - avoid Null pointer deref

Re: [FFmpeg-devel] [PATCH v2] Revert "avformat/dashenc: Disable writing CODECS tag for HEVC streams"

2021-06-08 Thread Jeyapal, Karthick
> > >On 6/7/21, 12:01 PM, "Valerii Zapodovnikov" wrote: > >This reverts commit d6d407d2d758b404af0ce6a8ff46bf164db020a1. >Hack not needed after a2b1dd0ce301450a47c972745a6b33c4c273aa5d. >Will fix #7480 and #8904. >This will include e.g. CODECS="hvc1.2.4.L123.B0" into m3u8. Pushed. Thanks, Karthic

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-08 Thread Marton Balint
On Tue, 8 Jun 2021, Valerii Zapodovnikov wrote: Wait a second. SDL_SetYUVConversionMode does not support 444? You are setting it to mode = SDL_YUV_CONVERSION_AUTOMATIC if it is 444, which I suppose works on just the size of frame? SDL itself does not support YUV444 pixel format, by the time

[FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-08 Thread Mohammad Izadi
HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9. This CL is taking HDR10+ from AVFrame side data in libvpxenc and is passing

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-08 Thread Andreas Rheinhardt
Mohammad Izadi: > HDR10+ metadata is stored in the bit stream for HEVC. The story is different > for VP9 and cannot store the metadata in the bit stream. HDR10+ should be > passed to packet side data an stored in the container (mkv) for VP9. > > This CL is taking HDR10+ from AVFrame side data in

Re: [FFmpeg-devel] [PATCH 26/35] avdevice: Add internal helpers for querying device capabilities

2021-06-08 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 3:30 PM Michael Niedermayer wrote: > On Tue, Jun 08, 2021 at 01:04:05AM +0200, Diederick Niehorster wrote: > > brakes build > CC libavdevice/utils.o > libavdevice/utils.c:64:29: error: field ‘query_type’ has incomplete type > enum DshowCapQueryType query_type; >

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-08 Thread Mohammad Izadi
On Mon, Jun 7, 2021 at 12:59 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Michael Niedermayer: > > On Mon, Jun 07, 2021 at 10:39:19AM -0700, Mohammad Izadi wrote: > >> HDR10+ metadata is stored in the bit stream for HEVC. The story is > different for VP9 and cannot store the me

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-08 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Mohammad Izadi: >> HDR10+ metadata is stored in the bit stream for HEVC. The story is different >> for VP9 and cannot store the metadata in the bit stream. HDR10+ should be >> passed to packet side data an stored in the container (mkv) for VP9. >> >> This CL is taking HDR10+

[FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Kevin LaFlamme
When streaming mode is enabled with fMP4/CMAF for DASH output, the segment files are available to read by players as soon as the first byte is written instead of only after the file is fully written. The DASH manifest currently only gets written when the final write to the segment file occurs. This

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Timo Rothenpieler
On 08.06.2021 21:03, Kevin LaFlamme wrote: When streaming mode is enabled with fMP4/CMAF for DASH output, the segment files are available to read by players as soon as the first byte is written instead of only after the file is fully written. The DASH manifest currently only gets written when the

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Kevin LaFlamme
For streaming mode with fragmented MP4 the intention is to have the client read a partial file since it’s broken up into sequential boxes that are playable independently. This doesn’t change the segment files themselves or how they are written, it just writes a full index file ahead of time. Ev

Re: [FFmpeg-devel] [PATCH v3] lavc/aomdec: Allow RGB decoding

2021-06-08 Thread James Zern
On Sat, Jun 5, 2021 at 10:16 PM Valerii Zapodovnikov wrote: > > Yes, RGB is signalled by Identity matrix if and only if XYZ is not > in transfer. XYZ primaries are just normal primaries that can be > used for normal RGB, no problem, so I do not check for them. > No need to test for sRGB primaries

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Timo Rothenpieler
On 08.06.2021 21:24, Kevin LaFlamme wrote: For streaming mode with fragmented MP4 the intention is to have the client read a partial file since it’s broken up into sequential boxes that are playable independently. This doesn’t change the segment files themselves or how they are written, it jus

[FFmpeg-devel] [PATCH 3/3] avcodec/ttadata: Add sentinel at the end of ff_tta_shift_1

2021-06-08 Thread Michael Niedermayer
Fixes: out of array access Fixes: 34933/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5629322560929792 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ttadata.c | 3 ++- 1 file

[FFmpeg-devel] [PATCH 2/3] avformat/mov: Check for duplicate mdcv

2021-06-08 Thread Michael Niedermayer
Fixes: memleak Fixes: 34932/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5456227658235904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+),

[FFmpeg-devel] [PATCH 1/3] avformat/flvdec: Check data before casting

2021-06-08 Thread Michael Niedermayer
Fixes: -nan is outside the range of representable values of type 'long' Fixes: signed integer overflow: 1000 * -9223372036854775808 cannot be represented in type 'long' Fixes: 34890/clusterfuzz-testcase-minimized-ffmpeg_dem_FLV_fuzzer-5334208657620992 Found-by: continuous fuzzing process https:

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Kevin LaFlamme
To serve it in a truly streaming way does require some special purpose server or configuration, but the `@availabilityTimeComplete` field that is written into the manifest is supposed to indicate to the client making the request whether or not the segment file is complete at the time it becomes

Re: [FFmpeg-devel] [PATCH 10/35] fftools: provide media type info for devices

2021-06-08 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 1:57 PM Nicolas George wrote: > > The feature looks useful. But the printing must go to stdout, not to > logging, because it is meant to be readable by scripts. Done. Only problem is that now a device of mine that should be called "Microphone Array (Intel® Smart Sound Tech

Re: [FFmpeg-devel] [PATCH 11/35] avformat: add control_message function to AVInputFormat

2021-06-08 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 2:00 PM Nicolas George wrote: > Maybe wrap the commit message at 60 columns. Will do ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or emai

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-08 Thread Marton Balint
On Tue, 8 Jun 2021, Valerii Zapodovnikov wrote: Can you merge my mxfdec patch? Thank you. I'd give at least a week for the mxf maintainer to respond before pushing. Listen, it is commonly known that ffplay is broken, Carl agrees. MPV is not broken and is perfect according to reference c

Re: [FFmpeg-devel] [PATCH 13/35] avdevice: adding control message requesting to show config dialog

2021-06-08 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 2:02 PM Nicolas George wrote: > > Diederick Niehorster (12021-06-08): > > +/** > > + * Request to show configuration dialog. > > + * > > + * If device has a configuration dialog of type indicated by > > + * data, show it. > > + * > > + * data: in

Re: [FFmpeg-devel] [PATCH 20/35] avdevice/avdevice: clean up avdevice_capabilities_create

2021-06-08 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 2:09 PM Nicolas George wrote: > > Diederick Niehorster (12021-06-08): > > -*caps = av_mallocz(sizeof(**caps)); > > +*caps = av_mallocz(sizeof(AVDeviceCapabilitiesQuery)); > > var = malloc(sizeof(*var)) is preferred over var = malloc(type), because > if you change the

Re: [FFmpeg-devel] [PATCH 25/35] avutil/opt: add av_opt_to_string

2021-06-08 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 4:32 PM Nicolas George wrote: > > Diederick Niehorster (12021-06-08): > Please wrap this. Will do. > > -int av_opt_get(void *obj, const char *name, int search_flags, uint8_t > > **out_val) > > +static int print_option(void* dst, enum AVOptionType type, int > > search_fla

[FFmpeg-devel] libavcodec: r12b decoder

2021-06-08 Thread Dennis Fleurbaaij
Trying to get patchwork to pick up patch from thread. Kind regards, Dennis Fleurbaaij From f66434cd65c5590c500e49eb6338aaa3a1c71a80 Mon Sep 17 00:00:00 2001 From: Dennis Fleurbaaij Date: Tue, 8 Jun 2021 18:55:02 +0200 Subject: [PATCH] libavcodec: r12b decoder added R12B is a format used by Black

Re: [FFmpeg-devel] [PATCH v2] avformat/libsrt: log streamid in listener mode

2021-06-08 Thread Marton Balint
On Tue, 1 Jun 2021, Zhao Zhili wrote: It's useful for test client which pass streamid to ffmpeg/ffplay. For example, use ffmpeg to test streamid support in VLC: ./ffmpeg -v info -re -i foo.mp4 -c copy -f mpegts -mode listener srt://127.0.0.1:9000 ./vlc srt://127.0.0.1:9000?streamid=foobar --

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: workaround conflict with ffmpeg cmdline option

2021-06-08 Thread Marton Balint
On Fri, 4 Jun 2021, Zhao Zhili wrote: Add 'srt_streamid' option as an alias for 'streamid'. --- doc/protocols.texi | 3 +++ libavformat/libsrt.c | 1 + 2 files changed, 4 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 8371f83059..8b21ce046e 100644 --- a/doc/protocols

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/libsrt: add tsbpd option

2021-06-08 Thread Marton Balint
On Sat, 5 Jun 2021, Marton Balint wrote: On Fri, 4 Jun 2021, Zhao Zhili wrote: From: Zhao Zhili --- v2: update doc LGTM for the set. Applied, thanks. Marton doc/protocols.texi | 5 + libavformat/libsrt.c | 5 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] Fix memory allocation problem. Related to ticket #9264.

2021-06-08 Thread Marton Balint
On Tue, 8 Jun 2021, hou...@uniontech.com wrote: From: houlei Signed-off-by: houlei --- libavdevice/xv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavdevice/xv.c b/libavdevice/xv.c index 24ba3179f6..7e15c178b6 100644 --- a/libavdevice/xv.c +++ b/libavdevice/x

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-08 Thread Carl Eugen Hoyos
Am Di., 8. Juni 2021 um 11:52 Uhr schrieb Dennis Fleurbaaij : > The four letter "r12b" format code is from the DeckLink documentation; > there are other described formats there as well such as r12l, r10b, r10l > and r210. I'm using DirectShow which signals the encoding to downstream > components t

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/vf_drawtext.c: fix CID 1485003

2021-06-08 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting > Fu > Sent: 2021年6月4日 10:23 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/2] lavfi/vf_drawtext.c: fix CID 1485003 > > CID 1485003: Memory - illegal accesses (UNINIT) > Using uninitialized value "sd". > > Si

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-08 Thread Kevin LaFlamme
I just realized there’s probably a more straightforward explanation: The scenario you brought up is already happening for all segments after the first one, and this changes just makes the first one do the same thing. The following scenario happens even without this change: Say you have a stream

[FFmpeg-devel] [PATCH 2/2] Fix memory allocation problem. Related to ticket #9264.

2021-06-08 Thread houlei
From: houlei Signed-off-by: houlei --- libavdevice/xv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavdevice/xv.c b/libavdevice/xv.c index 24ba3179f6..7e15c178b6 100644 --- a/libavdevice/xv.c +++ b/libavdevice/xv.c @@ -296,10 +296,11 @@ static int write_picture(A

[FFmpeg-devel] [PATCH 2/2] Fix memory allocation problem. Related to ticket #9264.

2021-06-08 Thread houlei
From: houlei Signed-off-by: houlei --- libavdevice/xv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/xv.c b/libavdevice/xv.c index 7e15c178b6..8f9a2cb5c0 100644 --- a/libavdevice/xv.c +++ b/libavdevice/xv.c @@ -300,7 +300,7 @@ static int write_picture(AVFormat

[FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: fix pts

2021-06-08 Thread Haihao Xiang
The time base used for compressed bitstream and video frame in the SDK is { 1, 9 }. [1][2] This can avoid the error message below from the muxer. $> ffmpeg -hwaccel qsv -c:v hevc_qsv -i input.h265 -f null - ... [null @ 0x561c24f6f2f0] Application provided invalid, non monotonically increasing

[FFmpeg-devel] [PATCH 2/2] lavfi/vf_vpp_qsv: fix the time_base for outlink

2021-06-08 Thread Haihao Xiang
Since commit 89ffcd1, the pts on output pad is in the time base of the input link, not the time base of the output link when EOF is reached, so a filter after vpp_qsv might output some unexpected frames. In order to avoid this issue, use the same time base for input and ouput links The issue can b

Re: [FFmpeg-devel] [PATCH 17/35] avdevice/dshow: discover source color range/space/etc

2021-06-08 Thread Diederick C. Niehorster
On Tue, Jun 8, 2021 at 5:01 PM Michael Niedermayer wrote: > On Tue, Jun 08, 2021 at 01:03:56AM +0200, Diederick Niehorster wrote: > > Enabled discovering a DirectShow device's color range, space, primaries, > transfer characteristics and chroma location, if the device exposes that > information.