Re: [FFmpeg-devel] [PATCH 3/4] avdevice/dshow: implement capabilities API

2021-06-06 Thread Diederick C. Niehorster
On Sun, Jun 6, 2021 at 6:15 AM Andreas Rheinhardt wrote: > Diederick C. Niehorster: > > See other mails: the bit of documentation in avdevice.h (lines > > 334--402) suggest the capabilities API is supposed to be used on an > > unopened device. It would make sense: probe the device for what it can

[FFmpeg-devel] [PATCH 1/1] libavutil: Fix mips build

2021-06-06 Thread Bernd Kuhls
Check for sys/auxv.h because not all toolchains contain this header. Fixes https://trac.ffmpeg.org/ticket/9138 Signed-off-by: Bernd Kuhls --- configure| 2 ++ libavutil/mips/cpu.c | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/configure b/configure index

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: 240M matrix is not the same as BT.601

2021-06-06 Thread Marton Balint
On Sun, 6 Jun 2021, Valerii Zapodovnikov wrote: I am sorry, what? It converts to 420 always? Wow? But you are right. Yes, because ffplay uses the default SDL renderer (may it be opengl/directx or anything else), and ffplay queries the hardware acccelerated pixel formats supported by that

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: 240M matrix is not the same as BT.601

2021-06-06 Thread Valerii Zapodovnikov
AVFrame->color_range? But even if I were using full range file (I do not) that would force BT.601 full range matrix (that is JPEG matrix) and I have the opposite here, BT.709 is forced. I suppose the problem can be checked with simple printf of frame->colorspace with that sample that uses BT.601.

Re: [FFmpeg-devel] [PATCH] Stop using _explicit atomic operations where not necessary.

2021-06-06 Thread Andreas Rheinhardt
Anton Khirnov: > Memory ordering constraints other than the default (sequentially > consistent) can behave in very unintuitive and unexpected ways, and so > should be avoided unless there is a strong (typically performance) > reason for using them. This holds especially for memory_order_relaxed, >

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count

2021-06-06 Thread Thilo Borgmann
Hi, Am 05.06.21 um 16:33 schrieb Anton Khirnov: > Quoting Thilo Borgmann (2021-06-05 14:29:05) >> Hi, >> >> add an option to override auto-detection of cpu count. Defaults to >> auto-detection, of course. >> >> -Thilo >> >> From 38612f3e1339354dbaa6be4f36072320ff71c707 Mon Sep 17 00:00:00 2001 >>

Re: [FFmpeg-devel] [PATCH] Stop using _explicit atomic operations where not necessary.

2021-06-06 Thread Andreas Rheinhardt
James Almer: > On 6/5/2021 11:27 AM, Anton Khirnov wrote: >> Memory ordering constraints other than the default (sequentially >> consistent) can behave in very unintuitive and unexpected ways, and so >> should be avoided unless there is a strong (typically performance) >> reason for using them. Thi

Re: [FFmpeg-devel] [PATCH] Stop using _explicit atomic operations where not necessary.

2021-06-06 Thread James Almer
On 6/6/2021 8:39 AM, Andreas Rheinhardt wrote: James Almer: On 6/5/2021 11:27 AM, Anton Khirnov wrote: Memory ordering constraints other than the default (sequentially consistent) can behave in very unintuitive and unexpected ways, and so should be avoided unless there is a strong (typically pe

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count

2021-06-06 Thread Andreas Rheinhardt
Thilo Borgmann: > Hi, > > add an option to override auto-detection of cpu count. Defaults to > auto-detection, of course. > > -Thilo > > > doc/fftools-common-opts.texi | 7 +++ > fftools/cmdutils.c | 27 +++ > fftools/cmdutils.h | 7 +++ >

Re: [FFmpeg-devel] [PATCH] Stop using _explicit atomic operations where not necessary.

2021-06-06 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-06-06 11:13:00) > Anton Khirnov: > > Memory ordering constraints other than the default (sequentially > > consistent) can behave in very unintuitive and unexpected ways, and so > > should be avoided unless there is a strong (typically performance) > > reason for usi

[FFmpeg-devel] [PATCH] fate: fix input arguments for fate-unknown_layout-ac3

2021-06-06 Thread James Almer
The input stream is a raw 16 bit audio one, so trying to read it as a 32 bit one is incorrect. The test can and will autoinsert a resampler as needed. Use the oneline comparison for the final result as well, while at it. Signed-off-by: James Almer --- tests/fate/ffmpeg.mak | 4 +++-

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count

2021-06-06 Thread Thilo Borgmann
Am 06.06.21 um 14:35 schrieb Andreas Rheinhardt: > Thilo Borgmann: >> Hi, >> >> add an option to override auto-detection of cpu count. Defaults to >> auto-detection, of course. >> >> -Thilo >> > >> >> doc/fftools-common-opts.texi | 7 +++ >> fftools/cmdutils.c | 27 +++

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count

2021-06-06 Thread Thilo Borgmann
Am 06.06.21 um 14:35 schrieb Andreas Rheinhardt: > Thilo Borgmann: >> Hi, >> >> add an option to override auto-detection of cpu count. Defaults to >> auto-detection, of course. >> >> -Thilo >> > >> >> doc/fftools-common-opts.texi | 7 +++ >> fftools/cmdutils.c | 27 +++

[FFmpeg-devel] [PATCH 5/5] avfilter/af_drmeter: Check that there is data

2021-06-06 Thread Michael Niedermayer
Fixes: floating point division by 0 Fixes: -nan is outside the range of representable values of type 'int' Fixes: Ticket8307 Signed-off-by: Michael Niedermayer --- libavfilter/af_drmeter.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/af_drmeter.c b/libavfilter/af_drmeter.

[FFmpeg-devel] [PATCH 1/5] avfilter/vf_ciescope: Handle black as very dark neutral gray

2021-06-06 Thread Michael Niedermayer
Fixes: floating point division by 0 Fixes: undefined behavior in handling NaN Fixes: Ticket 8268 Signed-off-by: Michael Niedermayer --- libavfilter/vf_ciescope.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_ciescope.c b/libavfilter/vf_ciescope.c index b3b906f517..f8fe554

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/vf_ciescope: Handle black as very dark neutral gray

2021-06-06 Thread Valerii Zapodovnikov
I am sorry, what??? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/5] avfilter/vf_mestimate: Check b_count

2021-06-06 Thread Michael Niedermayer
Fixes: left shift of negative value -1 Fixes: Ticket8270 Signed-off-by: Michael Niedermayer --- libavfilter/vf_mestimate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_mestimate.c b/libavfilter/vf_mestimate.c index daf7fde95f..f1935244c1 100644 --- a/libavfilter/vf_mesti

[FFmpeg-devel] [PATCH 4/5] avfilter/vf_fftdnoiz: Use lrintf() in export_row8()

2021-06-06 Thread Michael Niedermayer
Fixes: 1.04064e+10 is outside the range of representable values of type 'int' Fixes: Ticket 8279 Signed-off-by: Michael Niedermayer --- libavfilter/vf_fftdnoiz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_fftdnoiz.c b/libavfilter/vf_fftdnoiz.c index 7f4a6d

[FFmpeg-devel] [PATCH 2/5] avfilter/vf_dctdnoiz: Check threads

2021-06-06 Thread Michael Niedermayer
Fixes: floating point division by 0 Fixes: Ticket 8269 Signed-off-by: Michael Niedermayer --- libavfilter/vf_dctdnoiz.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_dctdnoiz.c b/libavfilter/vf_dctdnoiz.c index 63b1b29ea2..f09ab19c4d 100644 --- a/libavfilter/vf_dctdnoiz.c

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count

2021-06-06 Thread Anton Khirnov
Quoting Thilo Borgmann (2021-06-06 12:44:41) > Hi, > > Am 05.06.21 um 16:33 schrieb Anton Khirnov: > > Quoting Thilo Borgmann (2021-06-05 14:29:05) > >> Hi, > >> > >> add an option to override auto-detection of cpu count. Defaults to > >> auto-detection, of course. > >> > >> -Thilo > >> > >> From

Re: [FFmpeg-devel] [PATCH] avcodec/libopenjpeg: Interpret cinema profiles as XYZ

2021-06-06 Thread Michael Niedermayer
On Sun, Jun 06, 2021 at 09:27:32AM +0300, Valerii Zapodovnikov wrote: > From: Rémi Achard > > Patch should be applied to decode XYZ samples with not native > decoder in ffmpeg (-c:v libopenjpeg, not -c:v jpeg2000). jpeg2000 > works already. > Now, this is AFAIK a patch that should be applied afte

Re: [FFmpeg-devel] [PATCH] avcodec/libopenjpeg: Interpret cinema profiles as XYZ

2021-06-06 Thread Valerii Zapodovnikov
Did you even read the commit message? You need to apply a patch to openjpeg itself. Sigh. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ.

Re: [FFmpeg-devel] [PATCH 2/5] avfilter/vf_dctdnoiz: Check threads

2021-06-06 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-06-06 15:47:54) > Fixes: floating point division by 0 > Fixes: Ticket 8269 > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_dctdnoiz.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavfilter/vf_dctdnoiz.c b/libavfilter/vf_dctdnoiz.c

Re: [FFmpeg-devel] [PATCH] avcodec/libopenjpeg: Interpret cinema profiles as XYZ

2021-06-06 Thread Michael Niedermayer
On Sun, Jun 06, 2021 at 05:42:54PM +0300, Valerii Zapodovnikov wrote: > Did you even read the commit message? You need to apply a patch to openjpeg > itself. Sigh. yes i read your commit message. you are changing the API/ABI of openjpeg and doing a matching change in the interface in ffmpeg to ope

Re: [FFmpeg-devel] [PATCH v2 14/22] lavfi/vpp_qsv: double the framerate for deinterlacing

2021-06-06 Thread Linjie Fu
Hi Haihao, On Mon, May 17, 2021 at 11:30 AM Haihao Xiang wrote: > > --- > libavfilter/vf_vpp_qsv.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c > index 29ba220665..ec35f85b04 100644 > --- a/libavfilter/vf_vpp

Re: [FFmpeg-devel] [PATCH] avcodec/libopenjpeg: Interpret cinema profiles as XYZ

2021-06-06 Thread Valerii Zapodovnikov
Actually it is not my patch (as should be obvious as From: is not me) and *NO* changes in API/ABI of openjpeg are happening with upsream patch. As for your ABI... There is only one correct way to manipulate openjpeg API, if you did that wrong, it is your problem. Standard thing: "unexpected that u

Re: [FFmpeg-devel] [PATCH v2 13/22] lavfi/scale_qsv: add more input / output pixel formats

2021-06-06 Thread Linjie Fu
On Mon, May 17, 2021 at 11:30 AM Haihao Xiang wrote: > > NV12 and P010 are added > > $ ffmpeg -init_hw_device qsv -c:v h264_qsv -i input.h264 -vf > "scale_qsv=format=p010" -f null - > --- > libavfilter/vf_vpp_qsv.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libav

Re: [FFmpeg-devel] [PATCH v2 13/22] lavfi/scale_qsv: add more input / output pixel formats

2021-06-06 Thread Valerii Zapodovnikov
I hope it is the case since there was a problem with Intel P010 in Intel. #8055, comment 1, sample_YUV_intel10bits(P010LE).7z I still do not know what pixel format to force to decode that sample :) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/vf_ciescope: Handle black as very dark neutral gray

2021-06-06 Thread Michael Niedermayer
On Sun, Jun 06, 2021 at 04:50:41PM +0300, Valerii Zapodovnikov wrote: > I am sorry, what??? If that is intended as a review comment, please compose a english sentance which represents what you are trying to convey. That way others know what you mean. The goal of review is to improve code Anyway

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -fpsmin to clamp output framerate

2021-06-06 Thread Valerii Zapodovnikov
So did you fix your gmail account? Also, what happened to FATE? Broken? BTW, I just logged in my nvidia account through apple id and that email was marked as spam too, but because of my filter it was not send into spam! Cool :) ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/vf_ciescope: Handle black as very dark neutral gray

2021-06-06 Thread Valerii Zapodovnikov
вс, 6 июн. 2021 г., 18:35 Michael Niedermayer : > On Sun, Jun 06, 2021 at 04:50:41PM +0300, Valerii Zapodovnikov wrote: > > I am sorry, what??? > > If that is intended as a review comment, please compose > a english sentance which represents what you are trying to convey. > That way others know wh

Re: [FFmpeg-devel] [PATCH v2 14/22] lavfi/vpp_qsv: double the framerate for deinterlacing

2021-06-06 Thread Xiang, Haihao
On Sun, 2021-06-06 at 22:56 +0800, Linjie Fu wrote: > Hi Haihao, > > On Mon, May 17, 2021 at 11:30 AM Haihao Xiang wrote: > > > > --- > > libavfilter/vf_vpp_qsv.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vp

Re: [FFmpeg-devel] [PATCH v2 13/22] lavfi/scale_qsv: add more input / output pixel formats

2021-06-06 Thread Xiang, Haihao
> I hope it is the case since there was a problem with Intel P010 in Intel. > > #8055, comment 1, sample_YUV_intel10bits(P010LE).7z The MSB 10bit is available for P010 in FFmpeg, however it is the LSB 10bit in your file. > > I still do not know what pixel format to force to decode that sampl

Re: [FFmpeg-devel] [PATCH v2 13/22] lavfi/scale_qsv: add more input / output pixel formats

2021-06-06 Thread Valerii Zapodovnikov
So there are 4 formats two for le and 2 for be? Oogh. Do you know which one is used for dshow? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-

Re: [FFmpeg-devel] [PATCH] Stop using _explicit atomic operations where not necessary.

2021-06-06 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2021-06-06 11:13:00) >> Anton Khirnov: >>> Memory ordering constraints other than the default (sequentially >>> consistent) can behave in very unintuitive and unexpected ways, and so >>> should be avoided unless there is a strong (typically performance)

Re: [FFmpeg-devel] [PATCH 2/5] avfilter/vf_dctdnoiz: Check threads

2021-06-06 Thread Michael Niedermayer
On Sun, Jun 06, 2021 at 04:52:13PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-06-06 15:47:54) > > Fixes: floating point division by 0 > > Fixes: Ticket 8269 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_dctdnoiz.c | 3 +++ > > 1 file changed, 3 insert

[FFmpeg-devel] [PATCH] avcodec/elbg: Increase some fields to 64bit

2021-06-06 Thread Michael Niedermayer
Fixes: Ticket8312 Fixes: Ticket8321 Signed-off-by: Michael Niedermayer --- libavcodec/elbg.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/elbg.c b/libavcodec/elbg.c index b6049c938b..63659dda8b 100644 --- a/libavcodec/elbg.c +++ b/libavcodec/elb

Re: [FFmpeg-devel] [PATCH v2 13/22] lavfi/scale_qsv: add more input / output pixel formats

2021-06-06 Thread Xiang, Haihao
> So there are 4 formats two for le and 2 for be? Yes, I think so. > Oogh. Do you know which one > is used for dshow? I didn't use dshow, but I think it should be the format using MSB 10bit, see https://docs.microsoft.com/en-us/windows/win32/medfound/10-bit-and-16-bit-yuv-video-formats#overv

[FFmpeg-devel] [PATCH 1/3] avutil/tests/lzo: remove timer macros

2021-06-06 Thread James Almer
Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- libavutil/tests/lzo.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavutil/tests/lzo.c b/libavutil/tests/lzo.c index 0147ab5c1d..a5655dbfc5 100644 --- a/libavutil/tests/lzo.c +++ b/libavutil/tests/lzo.c @@ -55,7 +55,6 @@ int mai

[FFmpeg-devel] [PATCH 3/3] avutil/tests/audio_fifo: explicitly include config.h

2021-06-06 Thread James Almer
From: Matthieu Patou Needed for HAVE_BIGENDIAN Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- libavutil/tests/audio_fifo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/tests/audio_fifo.c b/libavutil/tests/audio_fifo.c index e107166eb1..c9d6bfc7db 100644 --- a/libav

[FFmpeg-devel] [PATCH 2/3] checkasm/vp9dsp: rename the iszero function to is_zero

2021-06-06 Thread James Almer
From: Matthieu Patou The function name iszero() may collide with a function in glibc. Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- tests/checkasm/vp9dsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/vp9dsp.c b/tests/checkasm/vp9dsp.c i

[FFmpeg-devel] [PATCH 1/2] avutil/samplefmt: remove outdated comment

2021-06-06 Thread James Almer
av_samples_fill_arrays() has been returning the minimum required buffer size for a while now. Signed-off-by: James Almer --- libavutil/samplefmt.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavutil/samplefmt.h b/libavutil/samplefmt.h index 8cd43ae856..f270199195 1

[FFmpeg-devel] [PATCH 2/2] avutil/samplefmt: don't add offsets to NULL pointers

2021-06-06 Thread James Almer
Signed-off-by: James Almer --- libavutil/samplefmt.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavutil/samplefmt.c b/libavutil/samplefmt.c index fc077f6444..c7428940e1 100644 --- a/libavutil/samplefmt.c +++ b/libavutil/samplefmt.c @@ -160,13 +160,20 @@ i

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-06 Thread Dennis Fleurbaaij
Failed to apply, what is the exact way you want the patch? Kind regards, Dennis Fleurbaaij +31 (0) 6 54 21 5365 On Sat, Jun 5, 2021 at 6:12 PM Valerii Zapodovnikov wrote: > That did work, cool. > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/capucmebbw-rkt3mw5berkg3cqa+-akryfahclfc36mh2

[FFmpeg-devel] [PATCH v2] Revert "avformat/dashenc: Disable writing CODECS tag for HEVC streams"

2021-06-06 Thread Valerii Zapodovnikov
This reverts commit d6d407d2d758b404af0ce6a8ff46bf164db020a1. Hack not needed after a2b1dd0ce301450a47c972745a6b33c4c273aa5d. Will fix #7480 and #8904. This will include e.g. CODECS="hvc1.2.4.L123.B0" into m3u8. Signed-off-by: Valerii Zapodovnikov --- libavformat/dashenc.c | 6 +- 1 file cha

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-06 Thread Diederick C. Niehorster
>From a distance, the patch looks like its in the correct format and everything (generated by git format-patch, right?). Is it against current HEAD? There may be a conflict On Mon, Jun 7, 2021 at 8:02 AM Dennis Fleurbaaij wrote: > > Failed to apply, what is the exact way you want the patch? > > K