[FFmpeg-devel] [PATCH 1/2] avdevice/dshow: discover source color range/space/etc

2021-06-02 Thread Diederick Niehorster
Enabled discovering a DirectShow device's color range, space, primaries, transfer characteristics and chroma location, if the device exposes that information. Sets them in the stream's codecpars. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 231

[FFmpeg-devel] [PATCH 1/2] avformat/libsrt: send message in order

2021-06-02 Thread Zhao Zhili
From: Zhao Zhili There is no good use case for out of order delivery of data. For live streaming with TSBPD enabled by default, the receiver get data in order based on the timestamps. However, if TSBPD is disabled, the data can be delivered out of order. --- libavformat/libsrt.c | 2 +- 1 file c

[FFmpeg-devel] [PATCH 2/2] avformat/libsrt: add tsbpd option

2021-06-02 Thread Zhao Zhili
From: Zhao Zhili --- libavformat/libsrt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index edebb49edf..3a57ac53cb 100644 --- a/libavformat/libsrt.c +++ b/libavformat/libsrt.c @@ -90,6 +90,7 @@ typedef struct SRTContext {

Re: [FFmpeg-devel] [PATCH] avformat/http: Stop cookie_dict leaking on errors.

2021-06-02 Thread Steven Liu
Robert Bengtsson-Ölund 于2021年6月2日周三 上午1:12写道: > > This solves the memory leak reported in https://trac.ffmpeg.org/ticket/9273 > > Signed-off-by: Robert Bengtsson-Ölund > --- > libavformat/http.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavformat/http.c b/li

[FFmpeg-devel] [PATCH] avdevice/dshow: implement get_device_list

2021-06-02 Thread Diederick Niehorster
Needed to enable programmatic discovery of DirectShow devices Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 68 - 1 file changed, 61 insertions(+), 7 deletions(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 8d0a6fcc09.

[FFmpeg-devel] [PATCH] avdevice/dshow: implement option to use device video timestamps

2021-06-02 Thread Diederick Niehorster
The dshow plugin ignores timestamps for video frames provided by the DirectShow device, instead using wallclock time, apparently because the implementer of this code had a device that provided unreliable timestamps. Me (and others) would like to use the device's timestamps. The new use_video_dev

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-06-02 Thread dcnieho
I (new contributor) have been making a push to get avdevice/dshow to where it is great to use programmatically (see recent patches, more coming). One thing on my list is to be able to through the API query the capabilities of my device, as right now I'd have to ask users to run a command like ffmpe

[FFmpeg-devel] [PATCH 0/6] avdevice/dshow: control_message interface

2021-06-02 Thread Diederick Niehorster
This series of patches implements the control_message interface to enable programmatic control (through the API) of the capture state (start/stop) of a dshow device, and allows to pop up its configuration dialogs through the API. For this, the control_message needes to be implemented for a AVInputF

[FFmpeg-devel] [PATCH 1/6] avformat: add control_message function to AVInputFormat

2021-06-02 Thread Diederick Niehorster
Control messages are useful for programmatic control of not only outdevs but also indevs. Bumping avformat version. Signed-off-by: Diederick Niehorster --- libavdevice/avdevice.c | 8 +--- libavformat/avformat.h | 6 ++ libavformat/version.h | 4 ++-- 3 files changed, 13 insertions(+),

[FFmpeg-devel] [PATCH 2/6] avdevice/dshow: implement control_message interface

2021-06-02 Thread Diederick Niehorster
This allows programmatic users of avdevice to start and stop the DirectShow Capture graph (i.e. receive frames or not). This is important because now the buffer fills up and starts dropping samples when enqueued packets are not read out immediately after the demuxer is opened. Signed-off-by: Di

[FFmpeg-devel] [PATCH 3/6] avdevice: adding control message requesting to show config dialog

2021-06-02 Thread Diederick Niehorster
This control message can be used to programmatically ask a device to show its configuration dialog. Bumping avdevice version. Signed-off-by: Diederick Niehorster --- libavdevice/avdevice.h | 10 ++ libavdevice/version.h | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --

[FFmpeg-devel] [PATCH 4/6] avdevice/dshow: accept show config dialog control message

2021-06-02 Thread Diederick Niehorster
DirectShow source will pop up its configuration dialog when AV_APP_TO_DEV_CONFIG is received. Implementation for several other possible configuration dialogs is more involved and will be provided in the next commit. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 19 +

[FFmpeg-devel] [PATCH 5/6] avdevice/dshow: tv_tuner_audio_dialog cleanup missing

2021-06-02 Thread Diederick Niehorster
Cleanup in case the show_analog_tv_tuner_audio_dialog was set was missing. Signed-off-by: Diederick Niehorster --- libavdevice/dshow_crossbar.c | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/dshow_crossbar.c b/libavdevice/dshow_crossbar.c index 2438683cde..961defe690 100644

[FFmpeg-devel] [PATCH 6/6] avdevice/dshow: add config dialog command for crossbar and tv tuner

2021-06-02 Thread Diederick Niehorster
The "show config dialog" command message can now also trigger dialog boxes for the crossbar connecting pins filter the analog tuner audio / analog tuner filters. _Untested_ as I do not have either device. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 78 +++

[FFmpeg-devel] [PATCH 1/2] avdevice/dshow: query graph time only once

2021-06-02 Thread Diederick Niehorster
No need to query twice, use value we've already unconditionally got. Signed-off-by: Diederick Niehorster --- libavdevice/dshow_pin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevice/dshow_pin.c b/libavdevice/dshow_pin.c index ee0d4a1b42..8408af26da 100644 --- a

[FFmpeg-devel] [PATCH 2/2] avdevice/dshow: handle unknown sample time

2021-06-02 Thread Diederick Niehorster
GetTime may return an error indication that the sample has not timestamps, or may return a NULL start time. In those cases, fall back to graph time Signed-off-by: Diederick Niehorster --- libavdevice/dshow_pin.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavdevi

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-06-02 Thread Nicolas George
dcni...@gmail.com (12021-06-02): > I (new contributor) have been making a push to get avdevice/dshow to where > it is great to use programmatically (see recent patches, more coming). One > thing on my list is to be able to through the API query the capabilities of > my device, as right now I'd have

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-06-02 Thread Diederick C. Niehorster
On Wed, Jun 2, 2021 at 2:37 PM Nicolas George wrote: > > dcni...@gmail.com (12021-06-02): > > I (new contributor) have been making a push to get avdevice/dshow to where > > it is great to use programmatically (see recent patches, more coming). One > > thing on my list is to be able to through the

[FFmpeg-devel] [PATCH 0/3] avdevice/dshow: use video device timestamps

2021-06-02 Thread Diederick Niehorster
This patch series enables using video device instead of wallclock times for a DirectShow device. It supersedes https://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/280879.html, which i messed up. Diederick Niehorster (3): avdevice/dshow: implement option to use device video timestamps avdevic

[FFmpeg-devel] [PATCH 1/3] avdevice/dshow: implement option to use device video timestamps

2021-06-02 Thread Diederick Niehorster
The dshow plugin ignores timestamps for video frames provided by the DirectShow device, instead using wallclock time, apparently because the implementer of this code had a device that provided unreliable timestamps. Me (and others) would like to use the device's timestamps. The new use_video_dev

[FFmpeg-devel] [PATCH 2/3] avdevice/dshow: query graph time only once

2021-06-02 Thread Diederick Niehorster
No need to query twice, use value we've already unconditionally got. Signed-off-by: Diederick Niehorster --- libavdevice/dshow_pin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevice/dshow_pin.c b/libavdevice/dshow_pin.c index ee0d4a1b42..8408af26da 100644 --- a

[FFmpeg-devel] [PATCH 3/3] avdevice/dshow: handle unknown sample time

2021-06-02 Thread Diederick Niehorster
GetTime may return an error indication that the sample has not timestamps, or may return a NULL start time. In those cases, fall back to graph time better debug message in case sample dropped: could now be audio or video frame Signed-off-by: Diederick Niehorster --- libavdevice/dshow_pin.c | 12

[FFmpeg-devel] [PATCH] avdevice/dshow: set no-seek flags

2021-06-02 Thread Diederick Niehorster
avdevice/dshow is a realtime device and as such does not support seeking. Therefore, its demuxer format should define the AVFMT_NOBINSEARCH, AVFMT_NOGENSEARCH and AVFMT_NO_BYTE_SEEK flags. With these flags set, attempting to seek (with e.g. avformat_seek_file()) correctly yields -1 (operation no

[FFmpeg-devel] [PATCH] avdevice/dshow: set no-seek flags

2021-06-02 Thread Diederick Niehorster
avdevice/dshow is a realtime device and as such does not support seeking. Therefore, its demuxer format should define the AVFMT_NOBINSEARCH, AVFMT_NOGENSEARCH and AVFMT_NO_BYTE_SEEK flags. With these flags set, attempting to seek (with e.g. avformat_seek_file()) correctly yields -1 (operation no

Re: [FFmpeg-devel] [PATCH] avformat/nut: add support for P010 pixel format

2021-06-02 Thread Michael Niedermayer
On Tue, Jun 01, 2021 at 07:02:39AM +0300, Valerii Zapodovnikov wrote: > This is used for dshow, though may be swapped endianness there. > Fixes #8454. fate-pixdesc-p010le and be will have to be updated. > --- > libavcodec/raw.c | 3 +++ > libavformat/nut.c | 3 +++ > 2 files changed, 6 insertions

[FFmpeg-devel] [PATCH] swscale: fix chroma width rounding

2021-06-02 Thread lance . lmwang
From: Limin Wang fixes vertical line at the right side of video for rgb24toyv12 conversion. Please reproduce it with below command: ./ffplay -f lavfi -i "testsrc=size=529x656,ocv=filter_name=smooth,format=yuv420p" Signed-off-by: Limin Wang --- libswscale/rgb2rgb_template.c | 2 +- libswsc

Re: [FFmpeg-devel] [PATCHv6] fate/integer.c: Connect test to fuzzer

2021-06-02 Thread Michael Niedermayer
On Mon, May 31, 2021 at 10:59:11AM +0530, Vedaa wrote: > Hi, > > I have added checks so that only positive numbers are passed to the > function, and limited the bits read to 24-bits. This has stopped the > fuzzer from terminating. > --- > Makefile | 2 ++ > libavutil/tests/inte

Re: [FFmpeg-devel] [PATCH v3] pixfmt: fixed wrong fix of comment

2021-06-02 Thread Michael Niedermayer
On Mon, May 31, 2021 at 07:09:02PM +0200, Reto Kromer wrote: > Valerii Zapodovnikov wrote: > > >This mostly reverts 785bfb1d7bb8de567c3aac1d9cc369b55ac9fb7b. > >But I also added some clarifications so that nobody mixes primaries > >with matrix again. SMPTE 240 and 170 primaires are the same, while

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/aacenc: Do not divide by lambda_count if it is 0

2021-06-02 Thread Michael Niedermayer
On Sat, May 29, 2021 at 05:58:17PM +0200, Michael Niedermayer wrote: > Avoids Floating point division by 0 > > Fixes: Ticket8011 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/aacenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply patchset [...] -- Michael

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/svq1enc: Do not print debug RD value before it has been computed

2021-06-02 Thread Michael Niedermayer
On Sun, May 30, 2021 at 08:02:53PM +0200, Michael Niedermayer wrote: > Avoids floating point division by 0 > > Fixes: Ticket8191 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/svq1enc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) will apply [...] -- Michael

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpegvideo_enc: Reset stuffing bits if they are not supported

2021-06-02 Thread Michael Niedermayer
On Sun, May 30, 2021 at 08:02:55PM +0200, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: Ticket8202 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo_enc.c | 1 + > 1 file changed, 1 insertion(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147E

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mpegvideo_enc: Limit bitrate tolerance to the representable

2021-06-02 Thread Michael Niedermayer
On Sun, May 30, 2021 at 03:20:06PM -0300, James Almer wrote: > On 5/30/2021 3:02 PM, Michael Niedermayer wrote: > > Fixes: error: 1.66789e+11 is outside the range of representable values of > > type 'int' > > Fixes: Ticket8201 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/m

Re: [FFmpeg-devel] [PATCH] avformat/nut: add support for P010 pixel format

2021-06-02 Thread Valerii Zapodovnikov
I don't really care about your nut container, FATE just complains that something in raw.c is not in nut.c. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

Re: [FFmpeg-devel] [PATCH 25/25] avformat/matroskaenc: Redo handling of FlagDefault

2021-06-02 Thread Nicolas George
Andreas Rheinhardt (12020-01-21): > Without a new option, one could not distinguish the case where the user > explicitly wants no dispositions at all and the case where one remuxes from > a source container that does not have the concept of default streams. > Furthermore, having an option allows to

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-02 Thread James Zern
On Tue, Jun 1, 2021 at 6:47 PM Mohammad Izadi wrote: > [...] > +static av_cold int add_hdr10_plus(AVFifoBuffer *fifo, struct FrameHDR10Plus > *data) > +{ > +int err = av_fifo_grow(fifo, sizeof(FrameHDR10Plus)); Prefer sizeof(var) for these to match the rest of the code. _

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-02 Thread James Zern
On Tue, Jun 1, 2021 at 6:23 PM Mohammad Izadi wrote: > > On Fri, May 28, 2021 at 4:49 AM Michael Niedermayer > wrote: > > > On Thu, May 27, 2021 at 09:44:10AM -0700, Mohammad Izadi wrote: > > > HDR10+ metadata is stored in the bit stream for HEVC. The story is > > different for VP9 and cannot sto

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mjpegdec: Fix order of condition for pal8

2021-06-02 Thread Michael Niedermayer
On Tue, May 11, 2021 at 01:12:05PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 33960/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THP_fuzzer-5052852809629696 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmp

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-02 Thread Valerii Zapodovnikov
HDR10+ test bitstream https://www.webmproject.org/vp9/levels/ BTW, who knows what is Profile 4 VP9 (i.e. VP9.4)? https://stackoverflow.com/questions/61413665 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] swscale: fix chroma width rounding

2021-06-02 Thread lance . lmwang
On Wed, Jun 02, 2021 at 11:02:44PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > fixes vertical line at the right side of video for rgb24toyv12 conversion. > Please reproduce it with below command: > ./ffplay -f lavfi -i > "testsrc=size=529x656,ocv=filter_name=smooth,format=yuv420p

Re: [FFmpeg-devel] [PATCH] avpacket: ABI bump additions

2021-06-02 Thread Lynne
Apr 26, 2021, 03:27 by andreas.rheinha...@outlook.com: > Lynne: > >> From 097aed2ac33dda0bb2052d8b0402711ce95079ba Mon Sep 17 00:00:00 2001 >> From: Lynne >> Date: Sat, 23 Jan 2021 19:56:18 +0100 >> Subject: [PATCH] avpacket: ABI bump additions >> >> --- >> libavcodec/avpacket.c | 5 + >> l