Re: [FFmpeg-devel] [PATCH 23/34] avcodec/zmbvenc: Simplify setting keyframe flag

2021-04-28 Thread Tomas Härdin
mån 2021-04-26 klockan 00:34 +0200 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/zmbvenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/zmbvenc.c b/libavcodec/zmbvenc.c > index 319381dd48..4b3416219b 100644 > --- a/libavco

Re: [FFmpeg-devel] [PATCH 24/34] avcodec/zmbvenc: Avoid copying packet data

2021-04-28 Thread Tomas Härdin
mån 2021-04-26 klockan 00:34 +0200 skrev Andreas Rheinhardt: > Here the packet size is known before allocating the packet because > the encoder itself works with an internal buffer, so one can pass > this information to ff_alloc_packet2() to avoid the implicit use > of another intermediate buffer f

Re: [FFmpeg-devel] [PATCH] libavutil: additional side_data accessor

2021-04-28 Thread Brad Hards
Ping. Anything more required on this patch? Brad ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscrib

Re: [FFmpeg-devel] [PATCH 2/4] avformat/rpl: Use 64bit in bitrate computation and check it

2021-04-28 Thread Michael Niedermayer
On Tue, Apr 27, 2021 at 09:31:56PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: signed integer overflow: 6 * 4 cannot be represented in type > > 'int' > > Fixes: > > 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_RPL_fuzzer-6726188921913344 > > > > Found-by: contin

[FFmpeg-devel] [PATCH] ignore additional generated tools files

2021-04-28 Thread Brad Hards
--- tools/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/.gitignore b/tools/.gitignore index c0958f40cb..61512261a7 100644 --- a/tools/.gitignore +++ b/tools/.gitignore @@ -3,6 +3,7 @@ /bisect.need /crypto_bench /cws2fws +/enum_options /fourcc2pixfmt /ffescape /ffeval

[FFmpeg-devel] [PATCH] libswscale: Make sws_init_context thread safe.

2021-04-28 Thread Peter Lundblad
Call ff_sws_rgb2rgb_init via ff_thread_once instead of checking one of the variables it updates. --- libswscale/utils.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 6bac7b658d..d673209d95 100644 --- a/libswscale/utils.c +++

Re: [FFmpeg-devel] [PATCH v3 2/5] avcodec/mips: Refine get_cabac_inline_mips.

2021-04-28 Thread 殷时友
> 2021年4月12日 下午11:59,殷时友 写道: > > >> 2021年3月31日 下午10:39,Michael Niedermayer 写道: >> >> On Tue, Mar 30, 2021 at 08:51:52PM +0800, Shiyou Yin wrote: >>> 1. Refined function get_cabac_inline_mips. >>> 2. Optimize function get_cabac_bypass and get_cabac_bypass_sign. >>> >>> Speed of decoding h264

[FFmpeg-devel] [PATCH v3 1/2] avfilter/dnn/dnn_backend_tf: simplify the code with ff_hex_to_data

2021-04-28 Thread lance . lmwang
From: Limin Wang please use tools/python/tf_sess_config.py to get the sess_config after that. note the byte order of session config is in normal order. bump the MICRO version for the config change. Signed-off-by: Limin Wang --- libavfilter/dnn/dnn_backend_tf.c | 42 +++-

[FFmpeg-devel] [PATCH v3 2/2] doc/filters: Documentation to add sess_config option for tensorflow backend

2021-04-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index e99d70a..24f2335 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -10161,6 +10161,9 @@ The label i

Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter/dnn/dnn_backend_tf: simplify the code with ff_hex_to_data

2021-04-28 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > lance.lmw...@gmail.com > Sent: 2021年4月28日 18:47 > To: ffmpeg-devel@ffmpeg.org > Cc: Limin Wang > Subject: [FFmpeg-devel] [PATCH v3 1/2] avfilter/dnn/dnn_backend_tf: > simplify the code with ff_hex_to_data > > From: Limin Wang >

Re: [FFmpeg-devel] [PATCH v3 2/2] doc/filters: Documentation to add sess_config option for tensorflow backend

2021-04-28 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > lance.lmw...@gmail.com > Sent: 2021年4月28日 18:47 > To: ffmpeg-devel@ffmpeg.org > Cc: Limin Wang > Subject: [FFmpeg-devel] [PATCH v3 2/2] doc/filters: Documentation to add > sess_config option for tensorflow backend > > From: Limin

Re: [FFmpeg-devel] [PATCH v3 2/2] doc/filters: Documentation to add sess_config option for tensorflow backend

2021-04-28 Thread lance . lmwang
On Wed, Apr 28, 2021 at 12:31:53PM +, Guo, Yejun wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > lance.lmw...@gmail.com > > Sent: 2021年4月28日 18:47 > > To: ffmpeg-devel@ffmpeg.org > > Cc: Limin Wang > > Subject: [FFmpeg-devel] [PATCH v3 2/2] doc/filters: Doc

Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter/dnn/dnn_backend_tf: simplify the code with ff_hex_to_data

2021-04-28 Thread lance . lmwang
On Wed, Apr 28, 2021 at 12:26:54PM +, Guo, Yejun wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > lance.lmw...@gmail.com > > Sent: 2021年4月28日 18:47 > > To: ffmpeg-devel@ffmpeg.org > > Cc: Limin Wang > > Subject: [FFmpeg-devel] [PATCH v3 1/2] avfilter/dnn/dnn

[FFmpeg-devel] [PATCH] fate: add adpcm_ima_ws test in a VQA v3 file

2021-04-28 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- tests/fate/adpcm.mak | 3 +++ tests/ref/fate/adpcm-ima-ws-vqa3 | 18 ++ 2 files changed, 21 insertions(+) create mode 100644 tests/ref/fate/adpcm-ima-ws-vqa3 diff --git a/tests/fate/adpcm.mak b/tests/fate/adpcm.mak index f858a808c5

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/mv30: Check available space in decode_intra() more completly

2021-04-28 Thread Michael Niedermayer
On Thu, Feb 11, 2021 at 10:29:15PM +0100, Paul B Mahol wrote: > this is hack what else do you suggest? thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New

[FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix SOF check in EOI

2021-04-28 Thread James Almer
For frames decoded with skip_frame == AVDISCARD_ALL, a picture is not allocated and got_picture is never set to 1 even if a SOF and SOS were parsed. The existing check in EOI only cares if a SOF was parsed, not if a picture allocated, so change it and add a new check to explicitly ensure a picture

[FFmpeg-devel] [PATCH 3/4] avformat/mov: Fix incorrect overflow detection in mov_read_sidx()

2021-04-28 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775807 + 1442840321 cannot be represented in type 'long' Fixes: 33670/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6644379491106816 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

[FFmpeg-devel] [PATCH 4/4] avcodec/faxcompr: Check for invalid VLC in decode_group3_1d_line()

2021-04-28 Thread Michael Niedermayer
Fixes: infinite loop Fixes: 33674/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-4816457818046464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/faxcompr.c | 2 +- 1 file chang

[FFmpeg-devel] [PATCH 2/4] avcodec/utils: do "calc from frame_bytes, channels, and block_align" in 64bit

2021-04-28 Thread Michael Niedermayer
Fixes: signed integer overflow: 104962766 * 32 cannot be represented in type 'int' Fixes: 33614/clusterfuzz-testcase-minimized-ffmpeg_dem_RSD_fuzzer-6252129036664832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

[FFmpeg-devel] [PATCH 1/4] avformat/mvdec: Check sample rate in parse_audio_var()

2021-04-28 Thread Michael Niedermayer
Fixes: signed integer overflow: -63542400238284 * 16 cannot be represented in type 'long' Fixes: 33612/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-5704741108711424 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/faxcompr: Check for invalid VLC in decode_group3_1d_line()

2021-04-28 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: infinite loop > Fixes: > 33674/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-4816457818046464 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > lib

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-28 Thread Marton Balint
On Sun, 25 Apr 2021, zheng qian wrote: On Sun, Apr 25, 2021 at 2:13 AM Marton Balint wrote: The order of the patches seems wrong. Patch/3 (or similar) should be applied first, otherwise you are checking the stream_id provided via side data, not the stream id actually used. Also note that

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: move is_dvb_subtitle/is_dvb_teletext initialization upwards

2021-04-28 Thread Marton Balint
On Sat, 24 Apr 2021, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index a357f3a6aa..8ff834be4e 100644 --- a/libavformat/mpegtse

[FFmpeg-devel] [PATCH 0/2] ARM64 HEVC QPEL/EPEL

2021-04-28 Thread Josh Dekker
This is a patch originally, submitted in 2017 (author/date info left intact). At the time, it didn't get much attention I assume due to the sheer size of it. I have split the patch into only its QPEL/EPEL parts, rebasing, and doing some cleaning of the patches as much is reasonable for a 9001 line

[FFmpeg-devel] [PATCH 1/2] lavu/checkasm: add (private) kperf timing for macOS

2021-04-28 Thread Josh Dekker
Signed-off-by: Josh Dekker --- configure | 2 + libavutil/Makefile| 1 + libavutil/macos_kperf.c | 140 ++ libavutil/macos_kperf.h | 23 +++ libavutil/timer.h | 17 - tests/checkasm/checkasm.c | 14 +++- tests/

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mvdec: Check sample rate in parse_audio_var()

2021-04-28 Thread Peter Ross
On Wed, Apr 28, 2021 at 05:06:33PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -63542400238284 * 16 cannot be > represented in type 'long' > Fixes: > 33612/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-5704741108711424 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] fate: add adpcm_ima_ws test in a VQA v3 file

2021-04-28 Thread Zane van Iperen
On 28/4/21 11:19 pm, Zane van Iperen wrote: Signed-off-by: Zane van Iperen --- tests/fate/adpcm.mak | 3 +++ tests/ref/fate/adpcm-ima-ws-vqa3 | 18 ++ 2 files changed, 21 insertions(+) create mode 100644 tests/ref/fate/adpcm-ima-ws-vqa3 Will apply soon. _

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-28 Thread zheng qian
On Thu, Apr 29, 2021 at 4:40 AM Marton Balint wrote: > > Thanks, applied the series with slightly modified/extended commit > message based on your earlier commit message. > > Regards, > Marton Thank you! Best regards, zheng ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH 2/2] lavc/aarch64: add hevc epel/qpel assembly

2021-04-28 Thread chen
inline comment with prefix [MC] At 2021-04-29 03:50:26, "Josh Dekker" wrote: >From: Rafal Dabrowa > >Benchmarked on Apple M1: > >put_hevc_epel_bi_h4_8_c: 69.9 >put_hevc_epel_bi_h4_8_neon: 15.4 >put_hevc_epel_bi_h6_8_c: 137.1 >put_hevc_epel_bi_h6_8_neon: 31.9 >put_hevc_epel_bi_h8_8_c: 124.6 >put_

[FFmpeg-devel] [PATCH 1/2] hwcontext_vulkan: dynamically load functions

2021-04-28 Thread Lynne
This patch allows for alternative loader implementations. Patch attached. >From 7ab5acd9b999b5aaa0748870c748d3ee31ea94d3 Mon Sep 17 00:00:00 2001 From: Lynne Date: Thu, 29 Apr 2021 02:44:41 +0200 Subject: [PATCH 1/2] hwcontext_vulkan: dynamically load functions This patch allows for alternativ

[FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: dlopen libvulkan

2021-04-28 Thread Lynne
While Vulkan itself went more or less the way it was expected to go, libvulkan didn't quite solve all of the opengl loader issues. It's multi-vendor, yes, but unfortunately, the code is Google/Khronos QUALITY, so suffers from big static linking issues (static linking on anything but OSX is unsuppo

Re: [FFmpeg-devel] [PATCH 1/2] hwcontext_vulkan: dynamically load functions

2021-04-28 Thread Lynne
Apr 29, 2021, 03:52 by d...@lynne.ee: > This patch allows for alternative loader implementations. > > Patch attached. > Forgot to fix a flag, v2 attached. >From a55c2c8e802cc9ab7ad5a0562198a3a1a3797d76 Mon Sep 17 00:00:00 2001 From: Lynne Date: Thu, 29 Apr 2021 02:44:41 +0200 Subject: [PATCH v

Re: [FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: dlopen libvulkan

2021-04-28 Thread Lynne
Apr 29, 2021, 03:54 by d...@lynne.ee: > While Vulkan itself went more or less the way it was expected to go, > libvulkan didn't quite solve all of the opengl loader issues. It's > multi-vendor, > yes, but unfortunately, the code is Google/Khronos QUALITY, so suffers from > big static linking iss

Re: [FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: dlopen libvulkan

2021-04-28 Thread Lynne
Apr 29, 2021, 04:35 by d...@lynne.ee: > Apr 29, 2021, 03:54 by d...@lynne.ee: > >> While Vulkan itself went more or less the way it was expected to go, >> libvulkan didn't quite solve all of the opengl loader issues. It's >> multi-vendor, >> yes, but unfortunately, the code is Google/Khronos QUA

Re: [FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: dlopen libvulkan

2021-04-28 Thread Lynne
Apr 29, 2021, 04:35 by d...@lynne.ee: > Apr 29, 2021, 03:54 by d...@lynne.ee: > >> While Vulkan itself went more or less the way it was expected to go, >> libvulkan didn't quite solve all of the opengl loader issues. It's >> multi-vendor, >> yes, but unfortunately, the code is Google/Khronos QUA

Re: [FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: dlopen libvulkan

2021-04-28 Thread Lynne
Apr 29, 2021, 04:35 by d...@lynne.ee: > Apr 29, 2021, 03:54 by d...@lynne.ee: > >> While Vulkan itself went more or less the way it was expected to go, >> libvulkan didn't quite solve all of the opengl loader issues. It's >> multi-vendor, >> yes, but unfortunately, the code is Google/Khronos QUA

[FFmpeg-devel] [PATCH] avfilter/af_afade: remove fade duration limit

2021-04-28 Thread realies
>From 8a4fe250e508932d8018adbb1af95d7c4a599a58 Mon Sep 17 00:00:00 2001 From: realies Date: Fri, 9 Apr 2021 21:57:47 +0100 Subject: [PATCH] avfilter/af_afade: remove fade duration limit Removes arbitrary filter duration to allow fades up to the limit of available memory. A docs warning has been a