On Sun, 25 Apr 2021, zheng qian wrote:
On Sun, Apr 25, 2021 at 2:13 AM Marton Balint <c...@passwd.hu> wrote:
The order of the patches seems wrong. Patch/3 (or similar) should be
applied first, otherwise you are checking the stream_id provided via side
data, not the stream id actually used.
Also note that is_dvb_teletext/is_dvb_subtitle might not be set if certain
stream_id is used, that can also cause issues.
I will send a patch series for these two issues, please check them and if
they look good then rebase your patchset on top of that.
You should add the relevant stream type constants to mpegts.h and use
those for the checks, you can spare the comments that way.
I have sent a new patchset v4 for these changes.
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3833
Notice that I re-sent the 3/4 patch file which seems to be lost,
so please pay attention to the order.
Thanks, applied the series with slightly modified/extended commit
message based on your earlier commit message.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
