Re: [FFmpeg-devel] [PATCH 1/2] avfilter/af_astats: Only print header lines when values are to be printed

2021-04-06 Thread Tobias Rapp
On 26.03.2021 13:58, Tobias Rapp wrote: Avoids empty "Channel" or "Overall" header lines added to log output when measurement is restricted to one scope using "measure_perchannel=none" or "measure_overall=none". Signed-off-by: Tobias Rapp --- libavfilter/af_astats.c | 6 -- 1 file change

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec: use the param from decodeHeader to configure surface

2021-04-06 Thread Chen, Wenbin
> -Original Message- > From: Xiang, Haihao > Sent: Tuesday, April 6, 2021 2:24 PM > To: Chen, Wenbin ; ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec: use the param from > decodeHeader to configure surface > > On Tue, 2021-03-23 at 06:45 +, Chen, Wen

Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-06 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年4月5日 17:56 > To: FFmpeg development discussions and patches > Subject: RE: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of >

[FFmpeg-devel] [PATCH v1 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-06 Thread zheng qian
The recognization of ARIB STD-B24 caption has been introduced in commit a03885b, which is used as closed caption in Japanese / Brazilian Digital Television. But whenever copying arib_caption into mpegts output, arib_caption inside the outputted stream cannot be recgonized as a arib_caption subtitl

[FFmpeg-devel] [PATCH v1 2/2] libavformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption

2021-04-06 Thread zheng qian
Stream copy for arib_caption into mpegts is not working correctly for now. This patch utilizes the data stored in codecpar->extradata to write necessary stream_identifier_descriptor and data_component_descriptor into PMT table for arib_caption remuxing. This patch fixes the copying of arib_captio

Re: [FFmpeg-devel] [PATCH] web/documentation: Added my book (FFMPEG Quick Hacks) to list of FFmpeg books

2021-04-06 Thread V Subhash [FFMPEG Quick Hacks]
> I'm talking about starting a page on the wiki and listing all books > *there*. No patch required. I will add the books to wiki but while the two old books are there at https://ffmpeg.org/documentation.html, I would like you to add the books I had submitted. _

Re: [FFmpeg-devel] [PATCH] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-04-06 Thread Nicolas George
James Almer (12021-04-01): > Yet the line has to be drawn somewhere. Otherwise public headers would be > chock full of structs and/or fields normally kept in internal headers > because "Someone may find them useful". You are right, the line has to be drawn somewhere. I posit that the best place to

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec: use the param from decodeHeader to configure surface

2021-04-06 Thread Xiang, Haihao
On Tue, 2021-04-06 at 07:54 +, Chen, Wenbin wrote: > > -Original Message- > > From: Xiang, Haihao > > Sent: Tuesday, April 6, 2021 2:24 PM > > To: Chen, Wenbin ; ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec: use the param from > > decodeHeader to co

Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-06 Thread Nicolas George
Guo, Yejun (12021-04-06): > compile error on ubuntu 18.04 with default setting: > error: ISO C90 forbids variable length array ‘boxes’ [-Werror=vla] > AVBoundingBox boxes[nb_bboxes]; This warning is explicitly added by configure it, we do not have to keep it if it hiders us. If people agree

[FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-06 Thread Vittorio Giovara
Here is the proposed patch to address samples like trac/7277. This effectively reverts an 11 year old patch (9044dd83991491309ecb76c389502e410897d7d2) but I wasn't able to identify the file mentioned in the log. If anyone knows where to look up the sample in issue 1539 that is not on trac I can s

Re: [FFmpeg-devel] [PATCH v4] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-04-06 Thread James Almer
On 4/3/2021 8:12 PM, James Almer wrote: Signed-off-by: James Almer --- Now using the avformat_ prefix as Anton requested. I forgot about it when i made v3. Will apply soon if there are no objections. libavformat/avformat.h | 39 +++ libavformat/utils.c

Re: [FFmpeg-devel] [PATCH v4] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-04-06 Thread Andreas Rheinhardt
James Almer: > On 4/3/2021 8:12 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> Now using the avformat_ prefix as Anton requested. I forgot about it >> when i >> made v3. > > Will apply soon if there are no objections. > I wonder whether the AVStream *st should be const; together

Re: [FFmpeg-devel] [PATCH v4] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-04-06 Thread James Almer
On 4/6/2021 3:46 PM, Andreas Rheinhardt wrote: James Almer: On 4/3/2021 8:12 PM, James Almer wrote: Signed-off-by: James Almer --- Now using the avformat_ prefix as Anton requested. I forgot about it when i made v3. Will apply soon if there are no objections. I wonder whether the AVStream

Re: [FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-06 Thread Vittorio Giovara
On Tue, Apr 6, 2021 at 6:51 PM Vittorio Giovara wrote: > Here is the proposed patch to address samples like trac/7277. > > This effectively reverts an 11 year old patch > (9044dd83991491309ecb76c389502e410897d7d2) but I wasn't able to identify > the file mentioned in the log. > > If anyone knows

[FFmpeg-devel] [PATCH 10/19] avcodec/mpegvideo_enc: Remove redundant time_base check

2021-04-06 Thread Andreas Rheinhardt
This check is dead as ff_encode_preinit() has an even stricter check. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index d5dd69b88f..2a0fd60cbc 100644 --- a/libavco

[FFmpeg-devel] [PATCH 12/19] avcodec/mpegvideo_enc: Don't segfault on unorthodox mpeg_quant

2021-04-06 Thread Andreas Rheinhardt
The (deprecated) field AVCodecContext.mpeg_quant has no range restriction; MpegEncContext.mpeg_quant is restricted to 0..1. If the former is set, the latter is overwritten with it without checking the range. This can trigger an av_assert2() with the MPEG-4 encoder when writing said field. Fix this

[FFmpeg-devel] [PATCH 13/19] avcodec/mpeg12enc: Perform size/level/profile checks earlier

2021-04-06 Thread Andreas Rheinhardt
This has the advantage that one does not waste some allocations if one errors out because of these checks. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 44 +- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/libavcodec/mpeg

[FFmpeg-devel] [PATCH 14/19] avcodec/mpegvideo_enc: Combine identical checks

2021-04-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 0a1d0db86d..e5411f0393 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo

[FFmpeg-devel] [PATCH 15/19] avcodec/mpegvideo: Deprecate mpeg_quant option for codecs != MPEG-4

2021-04-06 Thread Andreas Rheinhardt
mpeg_quant may only be set for MPEG-4 and MPEG-2, yet for the latter it is no option as the code acts as if it were always set. So deprecate the option for all codecs for which it makes no sense. Furthermore, given that the code already errors out if the option is set for a codec that doesn't supp

[FFmpeg-devel] [PATCH 18/19] avcodec/mpegvideo: Deprecate bframe opts for encoders not supporting them

2021-04-06 Thread Andreas Rheinhardt
MPEG-1/2/4 are the only mpegvideo based encoders that support bframes; yet even the encoders not supporting bframes have options that only make sense for an encoder that supports bframes; setting any of these options for such an encoder has no impact on the encoded outcome (but setting b_strategy t

[FFmpeg-devel] [PATCH 16/19] avcodec/mpegvideo: Deprecate a53cc option for encoders != MPEG-2

2021-04-06 Thread Andreas Rheinhardt
The MPEG-2 encoder is the only mpegvideo-based encoder that supports embedding a53 side data. Signed-off-by: Andreas Rheinhardt --- I am surprised that no one seems to have noticed this when this option has been added. libavcodec/mjpegenc.c | 1 + libavcodec/mpeg12enc.c | 2 ++ libavco

[FFmpeg-devel] [PATCH 19/19] avcodec/mpeg12dec: Remove redundant writes

2021-04-06 Thread Andreas Rheinhardt
ff_mpv_decode_init() already sets MpegEncContext.codec_id. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 92dd6a0b24..db522963c4 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavc

[FFmpeg-devel] [PATCH 17/19] avcodec/mpegvideo: Deprecate duplicate matrix opt for unsupported codecs

2021-04-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegenc.c | 1 + libavcodec/mpeg12enc.c | 2 ++ libavcodec/mpeg4videoenc.c | 1 + libavcodec/mpegvideo.h | 3 ++- libavcodec/mpegvideo_enc.c | 3 +++ 5 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/mjpegenc.c

[FFmpeg-devel] [PATCH] avcodec/msp2dec: Check available space in RLE decoder

2021-04-06 Thread Michael Niedermayer
Fixes: out of array read Fixes: 32968/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSP2_fuzzer-5315296027082752 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/msp2dec.c | 3 ++- 1 file c

[FFmpeg-devel] [PATCH 11/19] avcodec/mpeg12enc: Move MPEG-1/2 dimension checks to mpeg12enc

2021-04-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 8 libavcodec/mpegvideo_enc.c | 14 -- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index 5676caef87..b7d3d1c6b0 100644 --- a/libavcodec/mpeg

Re: [FFmpeg-devel] [PATCH] avcodec/msp2dec: Check available space in RLE decoder

2021-04-06 Thread Peter Ross
On Tue, Apr 06, 2021 at 11:50:22PM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 32968/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSP2_fuzzer-5315296027082752 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/msp2dec: Check available space in RLE decoder

2021-04-06 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: out of array read > Fixes: > 32968/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSP2_fuzzer-5315296027082752 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-06 Thread Carl Eugen Hoyos
Am Di., 6. Apr. 2021 um 21:51 Uhr schrieb Vittorio Giovara : > > without my patch the sample is shown at a 16:9 > AR (which I assume was the original fix), with my patch the sample uses an > AR of 1:1 and it is therefore square. > However I tried with a recent > Quicktime, and it displays the samp

Re: [FFmpeg-devel] [PATCH] avcodec/msp2dec: Check available space in RLE decoder

2021-04-06 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Michael Niedermayer: >> Fixes: out of array read >> Fixes: >> 32968/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSP2_fuzzer-5315296027082752 >> >> Found-by: continuous fuzzing process >> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >> Signed-off-by: M

[FFmpeg-devel] [PATCH] libavformat/id3v2: Read full null seperated list for text info frames

2021-04-06 Thread Lode Willems
All id3v2.4 text information frames are null separated lists: https://id3.org/id3v2.4.0-frames This change reads all values into the metadata dictionary without changing the outputs of ffmpeg or ffprobe Relevant ticket: https://trac.ffmpeg.org/ticket/6949 Signed-off-by: Lode Willems --- libavf

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec: use the param from decodeHeader to configure surface

2021-04-06 Thread Chen, Wenbin
> -Original Message- > From: Xiang, Haihao > Sent: Tuesday, April 6, 2021 11:08 PM > To: Chen, Wenbin ; ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec: use the param from > decodeHeader to configure surface > > On Tue, 2021-04-06 at 07:54 +, Chen, We

Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-06 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: 2021年4月7日 0:46 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Guo, Yejun (12021-04-06): > > compile erro

[FFmpeg-devel] [PATCH] web/index: add news entry for 4:3

2021-04-06 Thread Gyan Doshi
--- src/index | 85 +++ 1 file changed, 85 insertions(+) Better late than never! diff --git a/src/index b/src/index index fdde3d3..b0ca46c 100644 --- a/src/index +++ b/src/index @@ -35,6 +35,91 @@ News + June 15th, 2020, FFmpeg 4.3