Re: [FFmpeg-devel] [PATCH 15/23] dnn/dnn_backend_native_layer_conv2d: Join two arrays, avoid allocation

2021-03-12 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2021年3月12日 15:59 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 15/23] > dnn/dnn_backend_native_layer_conv2d: Join two arrays, avoid allocation > > Guo, Yejun: > > > > > >> -Origi

Re: [FFmpeg-devel] [PATCH v1] lavfi/qsvvpp: support async depth

2021-03-12 Thread Wang, Fei W
On Fri, 2021-03-12 at 06:20 +, Xiang, Haihao wrote: > On Wed, 2021-01-27 at 09:42 +0800, Fei Wang wrote: > > Async depth will allow qsv filter cache few frames, and avoid force > > switch and end filter task frame by frame. This change will improve > > performance for some multi-task case, for

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-12 Thread Jean-Baptiste Kempf
On Thu, 11 Mar 2021, at 23:09, suji.velupil...@broadcom.com wrote: > Initial commit to add VKAPI hardware accelerator implementation. > The depedency component vkil source code can be obtained from github > https://github.com/Broadcom/vkil This has no license, no readme, no description. What is t

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-12 Thread Steven Liu
> 2021年3月12日 下午5:12,Jean-Baptiste Kempf 写道: > > On Thu, 11 Mar 2021, at 23:09, suji.velupil...@broadcom.com wrote: >> Initial commit to add VKAPI hardware accelerator implementation. >> The depedency component vkil source code can be obtained from github >> https://github.com/Broadcom/vkil > >

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-12 Thread Jean-Baptiste Kempf
On Fri, 12 Mar 2021, at 11:17, Steven Liu wrote: > > 2021年3月12日 下午5:12,Jean-Baptiste Kempf 写道: > > > > On Thu, 11 Mar 2021, at 23:09, suji.velupil...@broadcom.com wrote: > >> Initial commit to add VKAPI hardware accelerator implementation. > >> The depedency component vkil source code can be obta

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-12 Thread Jean-Baptiste Kempf
On Fri, 12 Mar 2021, at 11:28, Jean-Baptiste Kempf wrote: > On Fri, 12 Mar 2021, at 11:17, Steven Liu wrote: > > > 2021年3月12日 下午5:12,Jean-Baptiste Kempf 写道: > > > > > > On Thu, 11 Mar 2021, at 23:09, suji.velupil...@broadcom.com wrote: > > >> Initial commit to add VKAPI hardware accelerator imple

[FFmpeg-devel] GSOC 2021 project Guided Filter

2021-03-12 Thread Shubham Sahoo
Hi everyone, I'm Shubham Sahoo, an undergraduate student in Electronics and Electrical Communication Engineering from India. I would like to work on the project "Guided Filter" in GSOC 2021. Can anyone please guide me with the next steps, the qualification tasks, and the project information? Than

[FFmpeg-devel] [PATCH 1/2] avformat/adp, svs: Remove redundant av_shrink_packet()

2021-03-12 Thread Andreas Rheinhardt
av_get_packet() already makes sure that the packet size is accurate and that the packet data is zero-padded even when one could not read as much as desired. Signed-off-by: Andreas Rheinhardt --- libavformat/adp.c | 8 ++-- libavformat/svs.c | 1 - 2 files changed, 2 insertions(+), 7 deletion

[FFmpeg-devel] [PATCH 2/2] avformat/utils: Fix confusing return value for ff_read_packet()

2021-03-12 Thread Andreas Rheinhardt
Currently, ff_read_packet() sometimes forwards the return value of AVInputFormat.read_packet() (which should be zero on success, but isn't for all demuxers) and sometimes it overwrites this with zero. Furthermore, it uses two variables, one for the read_packet return value and one for other errors,

Re: [FFmpeg-devel] GSOC 2021 project Guided Filter

2021-03-12 Thread Steven Liu
> 2021年3月12日 下午6:27,Shubham Sahoo 写道: > > Hi everyone, > > I'm Shubham Sahoo, an undergraduate student in Electronics and Electrical > Communication Engineering from India. I would like to work on the project > "Guided Filter" in GSOC 2021. Can anyone please guide me with the next > steps, the

Re: [FFmpeg-devel] [PATCH] avformat/mov: Properly consider if the file is self-initializing when marking sidx reading complete

2021-03-12 Thread Martin Storsjö
On Wed, 10 Mar 2021, Derek Buitenhuis wrote: Files with the "dash" major brand are guaranteed to only have a single initialization range for the whole file. We can check this and stop appropriately - which is useful, as the existing check to see if the offset reaches the end of the file is not s

[FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: Don't use wrong type of pointer

2021-03-12 Thread Andreas Rheinhardt
If one of the two results of a ternary conditional is a pointer to void, the type of the whole conditional operator is a pointer to void, even when the other possible result is not a pointer to void. This loophole in the type system has allowed mxf_read_local_tags to have a pointer of type pointer

[FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Fix leak on error

2021-03-12 Thread Andreas Rheinhardt
It was introduced in d3d9b1fc8e2dfc8b4d66c9916ab7221062ff4660; Fixes Coverity issue #733800. Signed-off-by: Andreas Rheinhardt --- I have no testcase for this; but hopefully Michael can test it with the testcase that led to d3d9b1fc8e2dfc8b4d66c9916ab7221062ff4660 in the first place? (And I alway

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-12 Thread Paul B Mahol
On Fri, Mar 12, 2021 at 12:21 AM Marton Balint wrote: > > > On Sun, 7 Mar 2021, Marton Balint wrote: > > > > > > > On Sun, 7 Mar 2021, Paul B Mahol wrote: > > > >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint wrote: > >> > >>> > >>> > >>> On Sun, 7 Mar 2021, Paul B Mahol wrote: > >>> > >>> > On

Re: [FFmpeg-devel] [PATCH 1/2] avformat/adp, svs: Remove redundant av_shrink_packet()

2021-03-12 Thread James Almer
On 3/12/2021 7:53 AM, Andreas Rheinhardt wrote: av_get_packet() already makes sure that the packet size is accurate and that the packet data is zero-padded even when one could not read as much as desired. Signed-off-by: Andreas Rheinhardt --- libavformat/adp.c | 8 ++-- libavformat/svs.c

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_uspp: Fix leak of qp-table on error

2021-03-12 Thread Andreas Rheinhardt
Fixes Coverity issue #1473500. Signed-off-by: Andreas Rheinhardt --- Why does the new qp API actually need to allocate the qp table (instead of reusing the side-data qp)? libavfilter/vf_uspp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_uspp.c b/libavfilter/vf_uspp.c in

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_uspp: Fix leak of packet side data

2021-03-12 Thread Andreas Rheinhardt
The uspp filter uses a special option ("no_bitstream") of the Snow encoder to suppress it from generating output. The filter therefore did not unref the packet after usage, believing it to be blank. But this is wrong, as the Snow encoder attaches quality stats side data to the packet. Signed-off-b

Re: [FFmpeg-devel] [PATCH] avformat/mov: Properly consider if the file is self-initializing when marking sidx reading complete

2021-03-12 Thread Derek Buitenhuis
On 12/03/2021 11:20, Martin Storsjö wrote: > LGTM, I guess the only question that remains is whether "dash" in the > compatible brands can imply the same too. (Our own muxer never sets "dash" > as the major brand, only as a compatible brand, and that only if we only > produce one global sidx.)

[FFmpeg-devel] [PATCH v2] avformat/mov: Properly consider if the file is self-initializing when marking sidx reading complete

2021-03-12 Thread Derek Buitenhuis
Files with the "dash" major brand are guaranteed to only have a single initialization range for the whole file. We can check this and stop appropriately - which is useful, as the existing check to see if the offset reaches the end of the file is not sufficient. For example, Premiere creates valid s

[FFmpeg-devel] [PATCH] CUDA - make it work for multiple GPU architectures

2021-03-12 Thread Patrick Ecord
Hello, My friend was running into issues trying to compile ffpmeg with cuda support so I tried to replicate the issue on machine with my 1070. Started by following Nvidia’s guide for compiling with CUDA support - https://docs.nvidia.com/video-technologies/video-codec-sdk/ffmpeg-with-nvidia-gpu/

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Michael Niedermayer
On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: > On 3/11/2021 1:35 PM, Michael Niedermayer wrote: > > On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: > > > On 3/10/2021 5:18 PM, Michael Niedermayer wrote: > > > > On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Andreas Rheinhardt
Michael Niedermayer: > On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: >> On 3/11/2021 1:35 PM, Michael Niedermayer wrote: >>> On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: On 3/10/2021 5:18 PM, Michael Niedermayer wrote: > On Mon, Feb 22, 2021 at 07:27:34PM -03

[FFmpeg-devel] [PATCH 1/2] avcodec/decode: Remove always-true check

2021-03-12 Thread Andreas Rheinhardt
Forgotten in 1fd76277708cf83572ba243e98f9e848c652f83d. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index c7dbf7b791..73cc3def5f 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c

[FFmpeg-devel] [PATCH 2/2] avcodec/decode: Reindentation

2021-03-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 49 ++--- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 73cc3def5f..495e9e8b23 100644 --- a/libavcodec/decode.c +++ b/libavcodec/de

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: On 3/11/2021 1:35 PM, Michael Niedermayer wrote: On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: On 3/10/2021 5:18 PM, Michael Niedermayer wrote: On Mon, Feb 22, 2021 at

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-12 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 7:40 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_pa

Re: [FFmpeg-devel] [PATCH] CUDA - make it work for multiple GPU architectures

2021-03-12 Thread Timo Rothenpieler
On 12.03.2021 16:14, Patrick Ecord wrote: Tried that and ran configure and it failed with Option '--ptx (-ptx)' is not allowed when compiling for multiple GPU architectures" So I removed the `-ptx` flag and I was able to run configure and make and make install without any errors. FFmpeg embe

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_uspp: Fix leak of packet side data

2021-03-12 Thread Michael Niedermayer
On Fri, Mar 12, 2021 at 03:24:07PM +0100, Andreas Rheinhardt wrote: > The uspp filter uses a special option ("no_bitstream") of > the Snow encoder to suppress it from generating output. > The filter therefore did not unref the packet after usage, > believing it to be blank. But this is wrong, as th

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-12 Thread James Almer
On 3/12/2021 2:09 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 7:40 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacemen

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/decode: Reindentation

2021-03-12 Thread James Almer
On 3/12/2021 1:54 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 49 ++--- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 73cc3def5f..495e9e8b23

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_uspp: Fix leak of qp-table on error

2021-03-12 Thread Michael Niedermayer
On Fri, Mar 12, 2021 at 03:24:06PM +0100, Andreas Rheinhardt wrote: > Fixes Coverity issue #1473500. > > Signed-off-by: Andreas Rheinhardt > --- should be ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once"

[FFmpeg-devel] [PATCH] Fix wrong time_base bug

2021-03-12 Thread ldm0
From: ldm0 Set time_base to inv of frame rate is only valid when input video have fixed frame rate. Signed-off-by: ldm0 --- doc/examples/transcoding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/transcoding.c b/doc/examples/transcoding.c index 5aff08c135..

[FFmpeg-devel] [PATCH] Fix wrong time_base bug

2021-03-12 Thread Donough Liu
Set time_base to inv of frame rate is only valid when input video have fixed frame rate. Signed-off-by: Donough Liu --- doc/examples/transcoding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/transcoding.c b/doc/examples/transcoding.c index 5aff08c135..d6fed6

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: Properly consider if the file is self-initializing when marking sidx reading complete

2021-03-12 Thread Martin Storsjö
On Fri, 12 Mar 2021, Derek Buitenhuis wrote: Files with the "dash" major brand are guaranteed to only have a single initialization range for the whole file. We can check this and stop appropriately - which is useful, as the existing check to see if the offset reaches the end of the file is not s

Re: [FFmpeg-devel] [PATCH] avutil/frame: ensure the frame is writable in av_frame_copy()

2021-03-12 Thread James Almer
On 3/10/2021 2:13 PM, James Almer wrote: Signed-off-by: James Almer --- libavutil/frame.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index eab51b6a32..ec79d053e1 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -800,6 +800,8 @@ int av_

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Michael Niedermayer
On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: > On 3/12/2021 1:32 PM, Michael Niedermayer wrote: > > On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: > > > On 3/11/2021 1:35 PM, Michael Niedermayer wrote: > > > > On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Michael Niedermayer
On Fri, Mar 12, 2021 at 08:30:23PM +0100, Michael Niedermayer wrote: > On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: > > On 3/12/2021 1:32 PM, Michael Niedermayer wrote: > > > On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: > > > > On 3/11/2021 1:35 PM, Michael Niedermay

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 4:30 PM, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: On 3/11/2021 1:35 PM, Michael Niedermayer wrote: On Wed, Mar 10, 2021 at

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 4:46 PM, James Almer wrote: On 3/12/2021 4:30 PM, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: On 3/11/2021 1:35 PM, Michael Ni

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 4:42 PM, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 08:30:23PM +0100, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: On 3

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Andreas Rheinhardt
James Almer: > On 3/12/2021 4:46 PM, James Almer wrote: >> On 3/12/2021 4:30 PM, Michael Niedermayer wrote: >>> On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: > On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: >

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 5:11 PM, Andreas Rheinhardt wrote: James Almer: On 3/12/2021 4:46 PM, James Almer wrote: On 3/12/2021 4:30 PM, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:3

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Michael Niedermayer: >> On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: >>> On 3/11/2021 1:35 PM, Michael Niedermayer wrote: On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: > On 3/10/2021 5:18 PM, Michael Niedermayer wrote: >> On Mon, Feb

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: Properly consider if the file is self-initializing when marking sidx reading complete

2021-03-12 Thread Derek Buitenhuis
On 12/03/2021 18:49, Martin Storsjö wrote: > LGTM. The commit message still talks only about the major brand though. It seems at some point we added an unrelated test, seek-extra-mp4, which uses an invalid dash-branded (under compatible brands) file generated by libavformat... We mux correctly no

[FFmpeg-devel] [PATCH] nvenc: Use frameIntervalP instead of max_b_frames for offsetting output dts

2021-03-12 Thread Martin Storsjö
If b-frames were enabled implicitly (if max_b_frames wasn't set by the caller at all, since a0949d0bcb0eee2f3fffcf9a4810c0295d14c0dc), we wouldn't offset dts at all, producing invalid pts/dts combinations (causing loud warnings by ffmpeg, or muxer errors if passed without an extra cleanup pass). I

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Michael Niedermayer
On Fri, Mar 12, 2021 at 04:59:16PM -0300, James Almer wrote: > On 3/12/2021 4:46 PM, James Almer wrote: > > On 3/12/2021 4:30 PM, Michael Niedermayer wrote: > > > On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: > > > > On 3/12/2021 1:32 PM, Michael Niedermayer wrote: > > > > > On Thu,

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-12 Thread Mark Thompson
On 11/03/2021 22:09, suji.velupil...@broadcom.com wrote: From: Suji Velupillai Initial commit to add VKAPI hardware accelerator implementation. The depedency component vkil source code can be obtained from github https://github.com/Broadcom/vkil Signed-off-by: Suji Velupillai --- configure

Re: [FFmpeg-devel] [PATCH] nvenc: Use frameIntervalP instead of max_b_frames for offsetting output dts

2021-03-12 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Mark Thompson
On 22/02/2021 22:27, James Almer wrote: On 2/21/2021 6:04 PM, James Almer wrote: On 2/21/2021 5:29 PM, Mark Thompson wrote: On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-12 Thread Mark Thompson
On 12/03/2021 18:29, Suji Velupillai wrote: On Fri, Mar 12, 2021 at 1:12 AM Jean-Baptiste Kempf wrote: On Thu, 11 Mar 2021, at 23:09, suji.velupil...@broadcom.com wrote: Initial commit to add VKAPI hardware accelerator implementation. The depedency component vkil source code can be obtained f

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Lynne
Mar 12, 2021, 21:00 by jamr...@gmail.com: > On 3/12/2021 4:42 PM, Michael Niedermayer wrote: > >> >> Related to this, what do the flags passed into get_encoder_buffer() mean >> exactly ? >> are they "hints" so that a new/unknown flag can be ignored by an >> implementation >> or what else shoul

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/cbs_sei: Fix leak of AVBufferRef on error

2021-03-12 Thread Mark Thompson
On 10/03/2021 01:06, Andreas Rheinhardt wrote: An AVBufferRef (and the corresponding AVBuffer and the underlying actual buffer) would leak in ff_cbs_sei_add_message() on error in case an error happened after its creation and before it has been attached to more permanent storage. Fix this by only

Re: [FFmpeg-devel] [PATCH 9/9] avcodec/cbs_h26[45]: Remove redundant enum constants

2021-03-12 Thread Mark Thompson
On 10/03/2021 10:29, Andreas Rheinhardt wrote: Unused since 8843607f495c95c1e67a3ce3d6f15dca6e252439. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h264.h | 10 -- libavcodec/cbs_h265.h | 9 - 2 files changed, 19 deletions(-) diff --git a/libavcodec/cbs_h264.h b/lib

Re: [FFmpeg-devel] [PATCH] cbs_h265: Detect more reference combinations which would overflow the DPB

2021-03-12 Thread Mark Thompson
On 21/02/2021 20:54, Michael Niedermayer wrote: On Wed, Feb 03, 2021 at 09:34:07PM +, Mark Thompson wrote: In total, the number of short term references (from the selected short term ref pic set), the number of long term references (combining both the used candidates from the SPS and those d

Re: [FFmpeg-devel] [PATCH] cbs_sei: Detect payload overflows when reading SEI messages

2021-03-12 Thread Mark Thompson
On 21/02/2021 20:58, Michael Niedermayer wrote: On Tue, Feb 02, 2021 at 08:58:11PM +, Mark Thompson wrote: The top-level GetBitContext is sized for the whole NAL unit, so it fails to detect overflows where a payload continues into the following message. To fix that, we make a new context on

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 7:10 PM, Lynne wrote: Mar 12, 2021, 21:00 by jamr...@gmail.com: On 3/12/2021 4:42 PM, Michael Niedermayer wrote: Related to this, what do the flags passed into get_encoder_buffer() mean exactly ? are they "hints" so that a new/unknown flag can be ignored by an implementation

Re: [FFmpeg-devel] [PATCH v2 02/18] cbs_h264: Add support for frame packing arrangement SEI messages

2021-03-12 Thread Mark Thompson
On 23/02/2021 16:39, James Almer wrote: On 2/21/2021 4:51 PM, Mark Thompson wrote: ---   libavcodec/cbs_h264.h | 23   libavcodec/cbs_h2645.c    |  6 +   libavcodec/cbs_h264_syntax_template.c | 39 +++   3 files changed, 68 i

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-12 Thread Suji Velupillai
On Fri, Mar 12, 2021 at 1:12 AM Jean-Baptiste Kempf wrote: > On Thu, 11 Mar 2021, at 23:09, suji.velupil...@broadcom.com wrote: > > Initial commit to add VKAPI hardware accelerator implementation. > > The depedency component vkil source code can be obtained from github > > https://github.com/Broa

Re: [FFmpeg-devel] [PATCH 2/8] avcodec/h264_cavlc: Remove redundant check

2021-03-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The only caller to ff_h264_decode_init_vlc() already uses > ff_thread_once() for the call; ergo the check via a simple int with > static storage duration in ff_h264_decode_init_vlc() is redundant. > And if it were not redundant, it would be a potential for data races. > So rem

[FFmpeg-devel] [PATCH] avcodec: add a mention about get_encode_buffer in the old encode API doxy

2021-03-12 Thread James Almer
Direct users to the callback that should be used to keep supporting user provided buffers with the new encode API. Signed-off-by: James Almer --- libavcodec/avcodec.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index fbd

Re: [FFmpeg-devel] [PATCH v2 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-03-12 Thread Marton Balint
On Wed, 10 Mar 2021, Marton Balint wrote: On Sat, 6 Mar 2021, Marton Balint wrote: On Mon, 1 Mar 2021, Marton Balint wrote: Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Ping for this and the rest of

[FFmpeg-devel] [PATCH 0/5] Initial usage of AVCodecContext.get_encode_buffer()

2021-03-12 Thread James Almer
For ffmpeg 4.4, as the last version featuring avcodec_encode_video2/audio2 and since marking an encoder as AV_CODEC_CAP_DR1 capable will make it unusable with that API, we should only port encoders using the AVCodec.receive_packet() API. The rest can be ported after either ffmpeg 4.4 is branched o

[FFmpeg-devel] [PATCH 1/5] avcodec/amfenc: use AVCodecContext.get_encode_buffer()

2021-03-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/amfenc.c | 2 +- libavcodec/amfenc_h264.c | 3 ++- libavcodec/amfenc_hevc.c | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index e234cfd354..fb23ed738c 100644 --- a/libavcodec/amfenc.

[FFmpeg-devel] [PATCH 2/5] avcodec/librav1e: use AVCodecContext.get_encode_buffer()

2021-03-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/librav1e.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index 2d5acc7d8e..276fb1b039 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -532,7 +532,7 @@ retry:

[FFmpeg-devel] [PATCH 3/5] avcodec/mfenc: use AVCodecContext.get_encode_buffer()

2021-03-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mfenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c index 7fdc7af330..d70e49351a 100644 --- a/libavcodec/mfenc.c +++ b/libavcodec/mfenc.c @@ -243,7 +243,7 @@ static int mf_sample_to_avpa

[FFmpeg-devel] [PATCH 4/5] avcodec/nvenc: use AVCodecContext.get_encode_buffer()

2021-03-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/nvenc.c | 2 +- libavcodec/nvenc_h264.c | 2 +- libavcodec/nvenc_hevc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index fbf55ebc9d..dddee8cac1 100644 --- a/libavcodec/nvenc.c +++ b/

[FFmpeg-devel] [PATCH 5/5] avcodec/vaapi_encode: use AVCodecContext.get_encode_buffer()

2021-03-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/vaapi_encode.c | 2 +- libavcodec/vaapi_encode_h264.c | 3 ++- libavcodec/vaapi_encode_h265.c | 3 ++- libavcodec/vaapi_encode_mjpeg.c | 2 +- libavcodec/vaapi_encode_mpeg2.c | 3 ++- libavcodec/vaapi_encode_vp8.c | 3 ++- libavcodec/vaapi_encod

[FFmpeg-devel] [PATCH] avcodec/decode: Remove outdated comment

2021-03-12 Thread Andreas Rheinhardt
Removing it was forgotten in 417d473bde220a1f267bc694835c129a5adc4309. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 495e9e8b23..5f7e9bda3e 100644 --- a/libavcodec/decode.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH] avcodec/decode: Remove outdated comment

2021-03-12 Thread James Almer
On 3/12/2021 9:26 PM, Andreas Rheinhardt wrote: Removing it was forgotten in 417d473bde220a1f267bc694835c129a5adc4309. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 495e9e8b23..5f7e

Re: [FFmpeg-devel] [PATCH v2 02/18] cbs_h264: Add support for frame packing arrangement SEI messages

2021-03-12 Thread Nuo Mi
On Mon, Feb 22, 2021 at 3:53 AM Mark Thompson wrote: > --- > libavcodec/cbs_h264.h | 23 > libavcodec/cbs_h2645.c| 6 + > libavcodec/cbs_h264_syntax_template.c | 39 +++ > 3 files changed, 68 insertions(+) > > diff --g

[FFmpeg-devel] [PATCH] libavutil/timer: Fix clang reserved-user-defined-literal

2021-03-12 Thread Christopher Degawa
clang errors when compiling with C++11 about needing spaces between literal and identifier Signed-off-by: Christopher Degawa --- libavutil/timer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/timer.h b/libavutil/timer.h index 0bb353cfce..737bfc160e 100644 --- a/l

Re: [FFmpeg-devel] [PATCH] avformat/httpauth: don't overwrite auth digest with unimplemented algorithm

2021-03-12 Thread Andriy Gelman
On Sun, 07. Mar 18:14, Andriy Gelman wrote: > From: Andriy Gelman > > In rtsp/http authentication the server may provide several options for > hash algorithms. This includes MD5, SHA2-256 and SHA2-512/256 (RFC 7616 > Section 3.7). Currently only support for MD5 is implemented in the auth code. >

Re: [FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-03-12 Thread Andriy Gelman
On Sun, 28. Feb 10:39, Andriy Gelman wrote: > On Sun, 28. Feb 13:57, sgerwk-at-aol@ffmpeg.org wrote: > > Hi, > > > > On Sat, 27 Feb 2021, Andriy Gelman wrote: > > > > > On Mon, 22. Feb 17:53, sgerwk-at-aol@ffmpeg.org wrote: > > > > Hi, > > > > > > > > On Sun, 21 Feb 2021, Andriy Gelman w

[FFmpeg-devel] [PATCH 2/5] lavfi/dnn_backend_openvino.c: fix mem leak for input_blob and output_blob upon error

2021-03-12 Thread Guo, Yejun
--- libavfilter/dnn/dnn_backend_openvino.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index d86fb124d5..df1631e86e 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/libavfilter/dnn/dnn_backend_ope

[FFmpeg-devel] [PATCH 1/5] lavfi/dnn_backend_openvino.c: fix mem leak for AVFrame upon error

2021-03-12 Thread Guo, Yejun
--- libavfilter/dnn/dnn_backend_openvino.c | 30 ++ 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 5be053b7f8..d86fb124d5 100644 --- a/libavfilter/dnn/dnn_backend_openvin

[FFmpeg-devel] [PATCH 3/5] lavfi/dnn_backend_openvino.c: fix typo upon error

2021-03-12 Thread Guo, Yejun
--- libavfilter/dnn/dnn_backend_openvino.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index df1631e86e..50de6a996e 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/libavfilter/dnn/dnn

[FFmpeg-devel] [PATCH 4/5] lavfi/dnn_backend_openvino.c: fix mem leak for RequestItem upon error

2021-03-12 Thread Guo, Yejun
--- libavfilter/dnn/dnn_backend_openvino.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 50de6a996e..55cb0c757e 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/li

[FFmpeg-devel] [PATCH 5/5] lavfi/dnn_backend_openvino.c: fix mem leak for TaskItem upon error

2021-03-12 Thread Guo, Yejun
--- libavfilter/dnn/dnn_backend_openvino.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 55cb0c757e..9a47d74c15 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/libavf

Re: [FFmpeg-devel] [PATCH] libavutil/timer: Fix clang reserved-user-defined-literal

2021-03-12 Thread Anton Khirnov
Quoting Christopher Degawa (2021-03-13 05:20:37) > clang errors when compiling with C++11 about needing spaces between > literal and identifier Why would you compile it with C++11? It's a private header, is it not? -- Anton Khirnov ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH] avcodec: add a mention about get_encode_buffer in the old encode API doxy

2021-03-12 Thread Anton Khirnov
Quoting James Almer (2021-03-13 00:15:37) > Direct users to the callback that should be used to keep supporting user > provided buffers with the new encode API. > > Signed-off-by: James Almer > --- > libavcodec/avcodec.h | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff -