On 3/12/2021 7:10 PM, Lynne wrote:



Mar 12, 2021, 21:00 by jamr...@gmail.com:

On 3/12/2021 4:42 PM, Michael Niedermayer wrote:


Related to this, what do the flags passed into get_encoder_buffer() mean
exactly ?
are they "hints" so that a new/unknown flag can be ignored by an implementation
or what else should an application do with a unknown flag, this should
be clarified in the documentation


They are hints, same as in get_buffer2(), like with the _REF flag. They can't 
really be requirements since the callback should be able to ignore new flags it 
doesn't understand.


If we have something, I'd rather not have a hint for alignment, but a comment
recommending "aligned data might be faster depending on the architecture and
encoder" or something along those lines.
That way in the future we can make AVPacket->data aligned without needing
to deprecate an alignment hint here.

Added a comment like that, and pushed.

Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to