Re: [FFmpeg-devel] [PATCH] vf_pseudocolor.c: fix build warning by adding braces

2021-02-08 Thread Paul B Mahol
There is already similar patch by other developer. On Mon, Feb 8, 2021 at 4:11 AM Guo, Yejun wrote: > the warning message is: > warning: missing braces around initializer [-Wmissing-braces] > > Signed-off-by: Guo, Yejun > --- > libavfilter/vf_pseudocolor.c | 4 ++-- > 1 file changed, 2 inserti

Re: [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail: add support for YUV and GBRP formats

2021-02-08 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/2] lavc/mpegvideo_enc: mark default_mv_penalty as const

2021-02-08 Thread Anton Khirnov
Nothing is ever written into it. --- libavcodec/mpegvideo_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 34dcf8c313..a27c80ca37 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -82,7

[FFmpeg-devel] [PATCH 2/2] lavc/ac3enc: rename variable to avoid shadowing

2021-02-08 Thread Anton Khirnov
Harmless, but confusing. --- libavcodec/ac3enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index bae7405fff..a007723bf3 100644 --- a/libavcodec/ac3enc.c +++ b/libavcodec/ac3enc.c @@ -2527,8 +2527,8 @@ av_cold int ff_ac3_encode

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ac3enc: rename variable to avoid shadowing

2021-02-08 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] lavc/mpegvideo_enc: mark default_mv_penalty as const

2021-02-08 Thread Andreas Rheinhardt
Anton Khirnov: > Nothing is ever written into it. > --- > libavcodec/mpegvideo_enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index 34dcf8c313..a27c80ca37 100644 > --- a/libavcodec/mpegvideo_enc.c > +++ b/li

[FFmpeg-devel] [PATCH] avfilter: add monochrome video filter

2021-02-08 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 27 libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/vf_monochrome.c | 239 4 files changed, 268 insertions(+) create mode 100644 libavfilter/vf_monochrom

[FFmpeg-devel] Re: [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-02-08 Thread Anton Khirnov
Quoting Marton Balint (2021-01-28 00:38:22) > > > On Wed, 27 Jan 2021, James Almer wrote: > > > On 1/27/2021 7:42 PM, Michael Niedermayer wrote: > >> On Tue, Jan 26, 2021 at 06:01:01PM +0100, Anton Khirnov wrote: > >>> Also drop the sections guarded by #if FF_API* > >>> These macros are private

[FFmpeg-devel] Re: [PATCH 3/4] ffprobe: stop printing deprecated fields

2021-02-08 Thread Anton Khirnov
Quoting Anton Khirnov (2021-02-08 12:21:57) > Use of AVCodecContext.time_base for decoding is deprecated, you are > supposed to read AVCodecContext.time_base instead. But that should be a ^ framerate Thanks to Andreas for

[FFmpeg-devel] [PATCH 3/5] ffprobe: drop code accessing deprecated AVStream.codec

2021-02-08 Thread Anton Khirnov
--- fftools/ffprobe.c | 5 - 1 file changed, 5 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index f7d042525e..83c036dd3f 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -3050,11 +3050,6 @@ static int open_input_file(InputFile *ifile, const char *filename,

[FFmpeg-devel] [PATCH 1/5] ffprobe: remove an unnecessary deprecation guard

2021-02-08 Thread Anton Khirnov
The code it is guarding is not accessing anything deprecated (disregarding the fact that a library caller must not use FF_API deprecation guards). --- fftools/ffprobe.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 3453aa09ff..4e5beb5710 100644 --

[FFmpeg-devel] [PATCH 2/5] ffprobe: do not use deprecated AVStream.codec for max bitrate

2021-02-08 Thread Anton Khirnov
Use the decoder context instead. --- fftools/ffprobe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 4e5beb5710..f7d042525e 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2754,10 +2754,10 @@ static int show_strea

[FFmpeg-devel] [PATCH 5/5] ffprobe: stop setting AVCodecContext.framerate

2021-02-08 Thread Anton Khirnov
That field is supposed to be exported by decoders, it makes no sense for a user to set it. --- fftools/ffprobe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 6a3dd549ec..de70c20eb4 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -3034,7 +

[FFmpeg-devel] [PATCH v3] avformat/concatdec: add support for setting input options

2021-02-08 Thread Jan Ekström
This way protocol or format related options can be set for all of the files opened during concatenation both globally as well as per-file. --- Changes from v2: 1. Added an example, although I had issues figuring out something useful that is not a hack for something. Ended up doing a disablemen

Re: [FFmpeg-devel] [PATCH 1/5] ffprobe: remove an unnecessary deprecation guard

2021-02-08 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 3/5] ffprobe: drop code accessing deprecated AVStream.codec

2021-02-08 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 5/5] ffprobe: stop setting AVCodecContext.framerate

2021-02-08 Thread Paul B Mahol
probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/5] ffprobe: do not use deprecated AVStream.codec for max bitrate

2021-02-08 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] Populate field order returned by avs script, Trac Ticket 8757

2021-02-08 Thread emcodem
Am 2021-02-01 09:44, schrieb emco...@ffastrans.com: Am 2021-01-21 19:08, schrieb emco...@ffastrans.com: On 2021-01-21 14:10, Stephen Hutchinson wrote: Yeah, never mind about that. I didn't notice that those are declared AVSC_INLINE, not AVSC_API, so they don't get used through the dynamic API

Re: [FFmpeg-devel] [PATCH 4/4] avutil/common: Move everything inside inclusion guards

2021-02-08 Thread Andreas Rheinhardt
Andreas Rheinhardt: > libavutil/common.h is a public header that provides generic math > functions whereas libavutil/intmath.h is a private header that contains > plattform-specific optimized versions of said math functions. common.h > includes intmath.h (when building the FFmpeg libraries) so that

Re: [FFmpeg-devel] [PATCH] avcodec/g722enc: Validate parameters before using them

2021-02-08 Thread Andreas Rheinhardt
Andreas Rheinhardt: > In case trellis is outside of 0..23, an invalid shift and/or a signed > integer overflow happens; furthermore, it can lead to the request to > allocate nonsense amounts of memory. So validate first. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/g722enc.c | 25 +++

[FFmpeg-devel] [PATCH 1/8] avcodec/frame_thread_encoder: Improve type safety

2021-02-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/frame_thread_encoder.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavcodec/frame_thread_encoder.c b/libavcodec/frame_thread_encoder.c index 83229f620a..ee289c90e3 100644 --- a/libavcodec/frame_thread_enc

[FFmpeg-devel] [PATCH 2/8] avcodec/frame_thread_encoder: Fix segfault on allocation error

2021-02-08 Thread Andreas Rheinhardt
Fixes a segfault from av_fifo_size(NULL) that happens in ff_frame_thread_encoder_free if the fifo couldn't be allocted; furthermore the mutexes and conditions that are destroyed in ff_frame_thread_encoder_free are not even initialized at this point, so don't call said function. Signed-off-by: Andr

[FFmpeg-devel] [PATCH 3/8] avcodec/frame_thread_encoder: Avoid allocations of AVPackets, fix deadlock

2021-02-08 Thread Andreas Rheinhardt
Up until now, when doing frame thread encoding, each worker thread tried to allocate an AVPacket for every AVFrame to be encoded; said packets would then be handed back to the main thread, where the content of said packet is copied into the packet actually destined for output; the temporary AVPacke

[FFmpeg-devel] [PATCH 5/8] avcodec/frame_thread_encoder: Avoid allocations of AVFrames

2021-02-08 Thread Andreas Rheinhardt
Up until now, when using frame threaded encoding, an AVFrame would be allocated for every frame to be encoded. These AVFrames would reach the worker threads via a FIFO of tasks, a structure which contained the AVFrame as well as an index into an array which gives the place where the worker thread s

[FFmpeg-devel] [PATCH 4/8] avcodec/frame_thread_encoder: Avoid creating reference to frame

2021-02-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/encode.c | 4 libavcodec/frame_thread_encoder.c | 11 --- libavcodec/frame_thread_encoder.h | 3 ++- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 29f41c

[FFmpeg-devel] [PATCH 6/8] avcodec/frame_thread_encoder: Avoid FIFO

2021-02-08 Thread Andreas Rheinhardt
It can be replaced by a simple counter. Signed-off-by: Andreas Rheinhardt --- Should I rename task_fifo_mutex/cond? libavcodec/frame_thread_encoder.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/libavcodec/frame_thread_encoder.c b/libavcodec/fra

[FFmpeg-devel] [PATCH 7/8] avcodec/frame_thread_encoder: Reduce amount of code guarded by mutex

2021-02-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- This is not done for speed, but for consistency (because the return statement already accessed outtask after unlocking the mutex). libavcodec/frame_thread_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/frame_thread_e

[FFmpeg-devel] [PATCH 8/8] avcodec/frame_thread_encoder: Use more natural types

2021-02-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/frame_thread_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/frame_thread_encoder.c b/libavcodec/frame_thread_encoder.c index f1f4fcb490..778317d60b 100644 --- a/libavcodec/frame_thread_encoder.c +++ b/liba

Re: [FFmpeg-devel] [PATCH 2/8] avcodec/frame_thread_encoder: Fix segfault on allocation error

2021-02-08 Thread Paul B Mahol
probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/frame_thread_encoder: Improve type safety

2021-02-08 Thread Paul B Mahol
probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/frame_thread_encoder: Use more natural types

2021-02-08 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] GSoC 2021

2021-02-08 Thread Thilo Borgmann
Hi, >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Michael Niedermayer >> Sent: 2021年2月2日 17:48 >> To: FFmpeg development discussions and patches >> Subject: [FFmpeg-devel] GSoC 2021 >> >> Hi all >> >> Most people probably already know but just to be sure everyone knows GSoC

Re: [FFmpeg-devel] GSoC 2021

2021-02-08 Thread Thilo Borgmann
Hi, > Most people probably already know but just to be sure everyone knows > GSoC 2021 is 175h not 350h > https://groups.google.com/g/google-summer-of-code-discuss/c/GgvbLrFBcUQ?pli=1 > > Some project ideas may need to be adjusted accordingly we've started registering as an Org and I put up the

Re: [FFmpeg-devel] GSoC 2021

2021-02-08 Thread Nicolas George
Steven Liu (12021-02-02): > And I saw Nicolas make some RFC maybe can split some subproject for mentor > project? As Michael pointed, they are more about design than about coding, which makes it less suited for this kind of mentor program. They require a more in depth knowledge of parts of the pr

Re: [FFmpeg-devel] [PATCH 2/8] avformat/mov: Support size = 1 and size = 0 special cases in probing

2021-02-08 Thread Michael Niedermayer
On Sat, Feb 06, 2021 at 11:33:38AM -0800, Chad Fraleigh wrote: > On 2/6/2021 9:22 AM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mov.c | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavformat/mov.c b/libavformat/mov.c > > in

[FFmpeg-devel] [PATCH 2/2] avformat/3dostr: Check sample_rate

2021-02-08 Thread Michael Niedermayer
Fixes: signed integer overflow: -1268324762623155200 * 8 cannot be represented in type 'long' Fixes: 30123/clusterfuzz-testcase-minimized-ffmpeg_dem_THREEDOSTR_fuzzer-6710765123928064 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-

[FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Check len in parse_chunks() to avoid overflow

2021-02-08 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483647 + 7 cannot be represented in type 'int' Fixes: 30084/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6192261941559296 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

Re: [FFmpeg-devel] [PATCH 2/2] avformat/3dostr: Check sample_rate

2021-02-08 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] [RFC][v3] Tech Resolution Process

2021-02-08 Thread Jean-Baptiste Kempf
--- doc/dev_community/resolution_process.md | 91 + 1 file changed, 91 insertions(+) create mode 100644 doc/dev_community/resolution_process.md diff --git a/doc/dev_community/resolution_process.md b/doc/dev_community/resolution_process.md new file mode 100644 index 0

Re: [FFmpeg-devel] [PATCH 01/50] avcodec/packet: deprecate av_init_packet()

2021-02-08 Thread James Almer
On 2/4/2021 4:09 PM, James Almer wrote: Once removed, sizeof(AVPacket) will stop being a part of the public ABI. Signed-off-by: James Almer --- libavcodec/avpacket.c | 23 +++ libavcodec/packet.h| 23 +++ libavcodec/version.h | 3 +++ libavfo

Re: [FFmpeg-devel] [PATCH 01/50] avcodec/packet: deprecate av_init_packet()

2021-02-08 Thread Andreas Rheinhardt
James Almer: > On 2/4/2021 4:09 PM, James Almer wrote: >> Once removed, sizeof(AVPacket) will stop being a part of the public ABI. >> >> Signed-off-by: James Almer >> --- >>   libavcodec/avpacket.c  | 23 +++ >>   libavcodec/packet.h    | 23 +++ >>   libavcod

Re: [FFmpeg-devel] [PATCH 01/50] avcodec/packet: deprecate av_init_packet()

2021-02-08 Thread James Almer
On 2/8/2021 11:37 AM, Andreas Rheinhardt wrote: James Almer: On 2/4/2021 4:09 PM, James Almer wrote: Once removed, sizeof(AVPacket) will stop being a part of the public ABI. Signed-off-by: James Almer ---   libavcodec/avpacket.c  | 23 +++   libavcodec/packet.h    | 23 ++

Re: [FFmpeg-devel] [PATCH 01/50] avcodec/packet: deprecate av_init_packet()

2021-02-08 Thread Andreas Rheinhardt
James Almer: > On 2/8/2021 11:37 AM, Andreas Rheinhardt wrote: >> James Almer: >>> On 2/4/2021 4:09 PM, James Almer wrote: Once removed, sizeof(AVPacket) will stop being a part of the public ABI. Signed-off-by: James Almer ---    libavcodec/avpacket.c  | 23 ++

Re: [FFmpeg-devel] [PATCH 06/50] avcodec/mpegvideo_enc: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavcodec/mpegvideo_enc.c | 23 +-- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index 34dcf8c313..411cadeae7 100644 > --- a/libavcodec/mpegvid

Re: [FFmpeg-devel] [PATCH 06/50] avcodec/mpegvideo_enc: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 11:46 AM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/mpegvideo_enc.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 34dcf8c313..411ca

Re: [FFmpeg-devel] [PATCH 06/50] avcodec/mpegvideo_enc: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > On 2/8/2021 11:46 AM, Andreas Rheinhardt wrote: >> James Almer: >>> Signed-off-by: James Almer >>> --- >>>   libavcodec/mpegvideo_enc.c | 23 +-- >>>   1 file changed, 13 insertions(+), 10 deletions(-) >>> >>> diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/m

Re: [FFmpeg-devel] [PATCH 06/50] avcodec/mpegvideo_enc: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 11:50 AM, Andreas Rheinhardt wrote: James Almer: On 2/8/2021 11:46 AM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer ---   libavcodec/mpegvideo_enc.c | 23 +--   1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavcodec/mpe

Re: [FFmpeg-devel] [PATCH 01/50] avcodec/packet: deprecate av_init_packet()

2021-02-08 Thread James Almer
On 2/8/2021 11:43 AM, Andreas Rheinhardt wrote: James Almer: On 2/8/2021 11:37 AM, Andreas Rheinhardt wrote: James Almer: On 2/4/2021 4:09 PM, James Almer wrote: Once removed, sizeof(AVPacket) will stop being a part of the public ABI. Signed-off-by: James Almer ---    libavcodec/avpacket.c

Re: [FFmpeg-devel] [PATCH 01/50] avcodec/packet: deprecate av_init_packet()

2021-02-08 Thread Andreas Rheinhardt
James Almer: > Once removed, sizeof(AVPacket) will stop being a part of the public ABI. > > Signed-off-by: James Almer > --- > libavcodec/avpacket.c | 23 +++ > libavcodec/packet.h| 23 +++ > libavcodec/version.h | 3 +++ > libavformat/avformat.h |

Re: [FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Check len in parse_chunks() to avoid overflow

2021-02-08 Thread Peter Ross
On Mon, Feb 08, 2021 at 02:29:01PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 7 cannot be represented in type > 'int' > Fixes: > 30084/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6192261941559296 > > Found-by: continuous fuzzing process > https://g

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavformat/matroskadec.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index 374831baa3..9fad78c78b 100644 > --- a/libavformat/matroskadec.c >

Re: [FFmpeg-devel] [PATCH 01/50] avcodec/packet: deprecate av_init_packet()

2021-02-08 Thread James Almer
On 2/8/2021 12:16 PM, Andreas Rheinhardt wrote: typedef struct AVPacketList { +#if FF_API_INIT_PACKET AVPacket pkt; +#else +AVPacket *pkt; +#endif struct AVPacketList *next; } AVPacketList; As long as the packet-list functions use this structure, there will be an unnecessary

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavformat/matroskadec.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 374831baa3..9fad78c78b 1006

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Signed-off-by: James Almer >>> --- >>>   libavformat/matroskadec.c | 17 - >>>   1 file changed, 12 insertions(+), 5 deletions(-) >>> >>> diff --git a/libavformat/matroskadec.c b/libavformat/matroskad

Re: [FFmpeg-devel] [PATCH 30/50] avformat/subtitles: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavformat/jacosubdec.c | 2 +- > libavformat/mpeg.c | 4 +-- > libavformat/mpsubdec.c | 4 +-- > libavformat/subtitles.c | 64 +++- > libavformat/subtitles.h | 2 +- > libavformat

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 12:32 PM, Andreas Rheinhardt wrote: James Almer: On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer ---   libavformat/matroskadec.c | 17 -   1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskade

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > On 2/8/2021 12:32 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: James Almer: > Signed-off-by: James Almer > --- >    libavformat/matroskadec.c | 17 - >    1 file changed, 12 insertions(+), 5 del

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 12:57 PM, Andreas Rheinhardt wrote: James Almer: On 2/8/2021 12:32 PM, Andreas Rheinhardt wrote: James Almer: On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer ---    libavformat/matroskadec.c | 17 -    1 file changed, 12 i

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavformat/matroskadec.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 374831baa3..9fad78c78b 1006

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > On 2/8/2021 12:57 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 2/8/2021 12:32 PM, Andreas Rheinhardt wrote: James Almer: > On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Signed-off-by: James Almer >>> --- >>>     libavformat/matr

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Signed-off-by: James Almer >>> --- >>>   libavformat/matroskadec.c | 17 - >>>   1 file changed, 12 insertions(+), 5 deletions(-) >>> >>> diff --git a/libavformat/matroskadec.c b/libavformat/matroskad

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 1:44 PM, Andreas Rheinhardt wrote: James Almer: On 2/8/2021 12:57 PM, Andreas Rheinhardt wrote: James Almer: On 2/8/2021 12:32 PM, Andreas Rheinhardt wrote: James Almer: On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer ---     libavforma

Re: [FFmpeg-devel] [PATCH 21/50] avformat/matroskadec: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > On 2/8/2021 1:44 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 2/8/2021 12:57 PM, Andreas Rheinhardt wrote: James Almer: > On 2/8/2021 12:32 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 2/8/2021 12:22 PM, Andreas Rheinhardt wrote: James Almer:

Re: [FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Check len in parse_chunks() to avoid overflow

2021-02-08 Thread Michael Niedermayer
On Tue, Feb 09, 2021 at 02:20:41AM +1100, Peter Ross wrote: > On Mon, Feb 08, 2021 at 02:29:01PM +0100, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 2147483647 + 7 cannot be represented in > > type 'int' > > Fixes: > > 30084/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6

Re: [FFmpeg-devel] [PATCH 1/8] avformat/mov: factor size out of probe code

2021-02-08 Thread Michael Niedermayer
On Sat, Feb 06, 2021 at 11:05:35PM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Observe your enemies, for they first find out your faults. -- Antisthenes signature.asc Description: PGP signature

[FFmpeg-devel] [PATCH 1/2] avcodec/fitsdec: properly initialize header->data_max

2021-02-08 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/fitsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/fitsdec.c b/libavcodec/fitsdec.c index 32a79cdd0d..802aa5b509 100644 --- a/libavcodec/fitsdec.c +++ b/libavcodec/fitsdec.c @@ -63,7 +63,7 @@ static int fill_data_min

[FFmpeg-devel] [PATCH 2/2] avformat/fitsenc: write DATAMIN/DATAMAX to encoded output

2021-02-08 Thread Paul B Mahol
There is no point in doing normalization when such files are decoded. Update fate test with new results. Signed-off-by: Paul B Mahol --- libavformat/fitsenc.c | 39 ++- tests/ref/fate/fits-demux | 10 - tests/ref/fate/fitsdec-gray | 2 +- t

Re: [FFmpeg-devel] [PATCH 15/50] avformat/avienc: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavformat/avienc.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/libavformat/avienc.c b/libavformat/avienc.c > index 1b2cb529b9..58bd081fcb 100644 > --- a/libavformat/avienc.c > +++ b/libavformat/a

Re: [FFmpeg-devel] [PATCH 23/50] avformat/mux: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavformat/internal.h | 5 + > libavformat/mux.c | 44 ++ > libavformat/options.c | 6 ++ > libavformat/utils.c| 1 + > 4 files changed, 35 insertions(+), 21 deletions(-) > > diff --gi

Re: [FFmpeg-devel] [PATCH 19/50] avformat/flacdec: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavformat/flacdec.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/libavformat/flacdec.c b/libavformat/flacdec.c > index 6aca4755a1..7852a79d39 100644 > --- a/libavformat/flacdec.c > +++ b/libavfo

Re: [FFmpeg-devel] [PATCH 23/50] avformat/mux: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 3:22 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavformat/internal.h | 5 + libavformat/mux.c | 44 ++ libavformat/options.c | 6 ++ libavformat/utils.c| 1 + 4 files changed, 35 inser

Re: [FFmpeg-devel] [PATCH 19/50] avformat/flacdec: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 3:43 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavformat/flacdec.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/libavformat/flacdec.c b/libavformat/flacdec.c index 6aca4755a1..7852a79d39 100644 --- a/l

Re: [FFmpeg-devel] [PATCH] [RFC][v3] Tech Resolution Process

2021-02-08 Thread Lynne
Feb 8, 2021, 15:23 by j...@videolan.org: > --- > doc/dev_community/resolution_process.md | 91 + > 1 file changed, 91 insertions(+) > create mode 100644 doc/dev_community/resolution_process.md > > diff --git a/doc/dev_community/resolution_process.md > b/doc/dev_community

Re: [FFmpeg-devel] [PATCH 36/50] avfilter/vf_mcdeint: use av_packet_alloc() to allocate packets

2021-02-08 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavfilter/vf_mcdeint.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/vf_mcdeint.c b/libavfilter/vf_mcdeint.c > index bc7b3230d3..26baf94adb 100644 > --- a/libavfilter/vf_mcdeint.c > +++ b/lib

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
Gentle ping :) On Thu, Feb 4, 2021 at 1:45 PM Bohan Li wrote: > Thanks for the review! Indeed the buf string does not play any role here. > I have removed it in the new patch. > > Bohan > > On Thu, Feb 4, 2021 at 1:02 PM Bohan Li wrote: > >> This key & value API can greatly help with users who

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Christopher Degawa
Quick question as a user that is not entirely related to this patch, would it be possible to add something like a `ffmpeg ... -libaom-params help -f null -` or someother way that would print out the options available in the compiled libaom? (In the case where we do not have aomenc compiled or it's

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Jan Ekström
On Mon, Feb 8, 2021 at 10:40 PM Christopher Degawa wrote: > > Quick question as a user that is not entirely related to this patch, would > it be possible to add something like a `ffmpeg ... -libaom-params help -f > null -` or someother way that would print out the options available in the > compil

Re: [FFmpeg-devel] [PATCH 2/2] lavf/libsrt: deduplicate libsrt_network_wait_fd_timeout

2021-02-08 Thread Marton Balint
On Mon, 8 Feb 2021, "zhilizhao(赵志立)" wrote: On Feb 8, 2021, at 2:36 AM, Marton Balint wrote: On Mon, 8 Feb 2021, Zhao Zhili wrote: --- libavformat/libsrt.c | 45 +--- 1 file changed, 17 insertions(+), 28 deletions(-) Hmm, it seems my latest srt

Re: [FFmpeg-devel] [PATCH 1/2] avformat/network: fix timeout inaccurate in wait_fd_timeout

2021-02-08 Thread Marton Balint
The wait_start was about POLLING_TIME larger which leads to timeout 100ms late than the option setting. --- libavformat/network.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavformat/network.c b/libavformat/network.c index 0f5a575f77..7a9a4be5bb 100644 ---

[FFmpeg-devel] [PATCH 1/2] avformat/mux: add ff_get_muxer_ts_offset()

2021-02-08 Thread James Almer
Will be useful in the next patch Signed-off-by: James Almer --- libavformat/internal.h | 1 + libavformat/mux.c | 16 2 files changed, 17 insertions(+) diff --git a/libavformat/internal.h b/libavformat/internal.h index d0db331b96..33ece6b172 100644 --- a/libavformat/inter

[FFmpeg-devel] [PATCH 2/2] avformat/mux: return a pointer to the packet in ff_interleaved_peek()

2021-02-08 Thread James Almer
And make it const, so the caller doesn't attempt to change it. ff_get_muxer_ts_offset() should be used to get the muxer timestamp offset. Signed-off-by: James Almer --- Went with Andreas' idea, but splitting off the muxer ts offset part of the process, so ff_interleaved_peek() doesn't need to use

Re: [FFmpeg-devel] [PATCH 23/50] avformat/mux: use av_packet_alloc() to allocate packets

2021-02-08 Thread James Almer
On 2/8/2021 3:50 PM, James Almer wrote: On 2/8/2021 3:22 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer ---   libavformat/internal.h |  5 +   libavformat/mux.c  | 44 ++   libavformat/options.c  |  6 ++   libavformat/util

Re: [FFmpeg-devel] [PATCH 1/2] lavc/mpegvideo_enc: mark default_mv_penalty as const

2021-02-08 Thread Michael Niedermayer
On Mon, Feb 08, 2021 at 10:53:20AM +0100, Anton Khirnov wrote: > Nothing is ever written into it. > --- > libavcodec/mpegvideo_enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index 34dcf8c313..a27c80ca37 1006

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Jan Ekström
On Thu, Feb 4, 2021 at 11:02 PM Bohan Li wrote: > > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg options. > Excellent! Thank you for moving this forward :) . I noticed various things which I will also notice here

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
Thank you very much for the reviews and the fixes, Jan! I went over the fixup commit and I do agree with the patches you proposed. It looks good to me. Just to make sure I don't misunderstand, should I submit a new patch with the modifications you mentioned, or leave the patch as is and you would

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Steven Liu
Bohan Li 于2021年2月9日周二 上午8:24写道: > > Thank you very much for the reviews and the fixes, Jan! > I went over the fixup commit and I do agree with the patches you proposed. > It looks good to me. > > Just to make sure I don't misunderstand, should I submit a new patch with > the modifications you ment

Re: [FFmpeg-devel] [PATCH 1/2] avformat/network: fix timeout inaccurate in wait_fd_timeout

2021-02-08 Thread zhilizhao(赵志立)
> On Feb 9, 2021, at 6:03 AM, Marton Balint wrote: > >> >> The wait_start was about POLLING_TIME larger which leads to timeout >> 100ms late than the option setting. >> --- >> libavformat/network.c | 13 ++--- >> 1 file changed, 6 insertions(+), 7 deletions(-) >> >> diff --git a/libavf

[FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
This key & value API can greatly help with users who wants to try libaom-av1 specific options that are not supported by ffmpeg options. As was previously discussed in this thread: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2020-October/271658. The commit that added the API to libaom: https:/

Re: [FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
Thanks for the info! Just uploaded the patch v2 as suggested. Best, Bohan On Mon, Feb 8, 2021 at 8:04 PM Bohan Li wrote: > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg options. > > As was previously discussed in