On Mon, 8 Feb 2021, "zhilizhao(赵志立)" wrote:



On Feb 8, 2021, at 2:36 AM, Marton Balint <c...@passwd.hu> wrote:



On Mon, 8 Feb 2021, Zhao Zhili wrote:

---
libavformat/libsrt.c | 45 +++++++++++++++++---------------------------
1 file changed, 17 insertions(+), 28 deletions(-)

Hmm, it seems my latest srt patches conflics with this a bit, and you will have to 
somewhat rebase this, sorry. On the bright side, now only eid is passed to 
libsrt_network_wait_fd, so maybe you can pass eid instead of fd, especially since 
it is not always the context->eid that is used for wait.

Thanks for review. Rebase is done:

https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_ff259aef9f5aab614e6c70ef2d7a9a684...@qq.com/

libsrt_network_wait_fd_timeout is implemented on top of 
ff_network_wait_fd_timeout
to keep minimum code changes. libsrt_network_wait_fd_timeout can be removed if add a NetworkWaitFdCB field to SRTContext but more code need to be changed.
What do you think?

I think it is fine as is.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to