Re: [FFmpeg-devel] [PATCH 0/5] FIFO meta muxer related improvements

2021-01-25 Thread Jan Ekström
On Mon, Jan 11, 2021 at 4:46 PM Jan Ekström wrote: > > On Mon, Dec 7, 2020 at 12:08 PM Jan Ekström wrote: > > > > The primary parts of this are patches 1,4,5. 2 and 3 were just noticed when > > poking at the recovery timestamp logic, where the stream-time comparison > > logic > > seemed somewhat

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: add support for setting input options

2021-01-25 Thread Jan Ekström
On Fri, Jan 22, 2021 at 1:00 AM Jan Ekström wrote: > > This way protocol or format related options can be set for all > of the files opened during concatenation. Ping for reviews. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg

Re: [FFmpeg-devel] [PATCH] configure: add fallback to $arch in msvc assembler check.

2021-01-25 Thread Josh Dekker
On 2021-01-23 14:14, Martin Storsjö wrote: On Sat, 23 Jan 2021, Reimar Döffinger wrote: Setting the defaults for $arch happens only later, so the current code would not set AS correctly if --arch was not specified on the command-line. Fix it by adding an explicit fallback to $arch_default. ---

Re: [FFmpeg-devel] [PATCH 4/4] checkasm: add hevc_pel tests

2021-01-25 Thread Josh Dekker
On 2021-01-07 13:10, Josh Dekker wrote: Co-authored-by: Niklas Haas Signed-off-by: Josh Dekker --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 10 + tests/checkasm/checkasm.h | 10 + tests/checkasm/hevc_pel.c | 523 ++ 4 files chan

Re: [FFmpeg-devel] Patch for FFmpeg

2021-01-25 Thread Josh Dekker
On 2021-01-13 17:06, Robin Cooksey wrote: I’ve attached a patch which makes avformat handle the 308 Permanent Redirect HTTP status code – which is more recently defined in https://tools.ietf.org/html/rfc7538 The change just treats 308 in the same way as the other 30x status codes. Thanks. Ap

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhd: Make ff_dxnhd_get_cid_table return a pointer, not index

2021-01-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > All callers only use the index into ff_dnxhd_cid_table to get a pointer > to the desired entry. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/dnxhddata.c | 46 +- > libavcodec/dnxhddata.h | 4 +--- > libavcodec/dnxhddec.c

Re: [FFmpeg-devel] [PATCH 01/10] avcodec/atrac3plus_data: Remove unused arrays

2021-01-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Forgotten in 58fc810d42fde26ed6c1f2996122e98ab7005849. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/atrac3plus_data.h | 19 --- > 1 file changed, 19 deletions(-) > > diff --git a/libavcodec/atrac3plus_data.h b/libavcodec/atrac3plus_data.h > inde

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: add support for setting input options

2021-01-25 Thread Nicolas George
Jan Ekström (12021-01-22): > This way protocol or format related options can be set for all > of the files opened during concatenation. > --- > libavformat/concatdec.c | 26 +- > 1 file changed, 25 insertions(+), 1 deletion(-) I know it is a little more work, but options n

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-01-25 Thread Nicolas George
Jan Ekström (12021-01-22): > From: Stefano Sabatini > > --- > libavutil/avstring.h | 7 --- > libavutil/bprint.c | 15 +++ > tools/ffescape.c | 7 --- > 3 files changed, 23 insertions(+), 6 deletions(-) Thanks for this new version. I think this patch and the next wo

Re: [FFmpeg-devel] [PATCH]lavfi/vflip: Support Bayer vertical flip

2021-01-25 Thread Paul B Mahol
On Mon, Jan 25, 2021 at 4:07 AM Carl Eugen Hoyos wrote: > Am Sa., 5. Sept. 2020 um 21:15 Uhr schrieb Carl Eugen Hoyos > : > > > Attached patch fixes ticket #8819. > > Paul, I believe you had an objection but I forgot what it was... > Have you benched with alternative solutions this memcpy versio

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-01-24 21:42:10) > James Almer: > > On 1/24/2021 5:16 PM, Andreas Rheinhardt wrote: > >> It has been added in 6db42a2b6b22e6f1928fafcf3faa67ed78201004, > >> yet since then none of the necessary create/free_device_capabilities > >> functions has been implemented, maki

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Nicolas Gaullier
>De : ffmpeg-devel De la part de Paul B Mahol >Envoyé : jeudi 21 janvier 2021 13:36 >À : FFmpeg development discussions and patches >Objet : Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser > >Changes looks trivial enough. If no one object, the two patches may be applied now ? I can

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Paul B Mahol
On Mon, Jan 25, 2021 at 12:04 PM Nicolas Gaullier wrote: > >De : ffmpeg-devel De la part de Paul B > Mahol > >Envoyé : jeudi 21 janvier 2021 13:36 > >À : FFmpeg development discussions and patches > >Objet : Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser > > > >Changes looks trivi

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: add support for setting input options

2021-01-25 Thread Jan Ekström
On Mon, Jan 25, 2021 at 11:52 AM Nicolas George wrote: > > Jan Ekström (12021-01-22): > > This way protocol or format related options can be set for all > > of the files opened during concatenation. > > --- > > libavformat/concatdec.c | 26 +- > > 1 file changed, 25 insert

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-01-25 Thread Jan Ekström
On Mon, Jan 25, 2021 at 11:58 AM Nicolas George wrote: > > Jan Ekström (12021-01-22): > > From: Stefano Sabatini > > > > --- > > libavutil/avstring.h | 7 --- > > libavutil/bprint.c | 15 +++ > > tools/ffescape.c | 7 --- > > 3 files changed, 23 insertions(+), 6 delet

[FFmpeg-devel] [PATCH 1/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Nicolas Gaullier
--- Changelog| 1 + libavcodec/dolby_e.c | 254 +++ libavcodec/dolby_e.h | 38 ++- libavcodec/parsers.c | 1 + libavcodec/version.h | 4 +- 5 files changed, 199 insertions(+), 99 deletions(-) diff --git a/Changelog b/Changelog index 7

[FFmpeg-devel] [PATCH 2/2] avcodec/dolby_e: Split decoder/parser files

2021-01-25 Thread Nicolas Gaullier
--- libavcodec/Makefile | 1 + libavcodec/dolby_e.c | 149 +-- libavcodec/dolby_e.h | 598 +- libavcodec/dolby_e_parser.c | 227 ++ libavcodec/dolby_e_parser.h | 41 ++ libavcodec/dolby_e_pars

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] lavc: shedule old encoding/decoding API for removal

2021-01-25 Thread Anton Khirnov
It has been deprecated for 4 years and certain new codecs do not work with it. Also include AVCodecContext.refcounted_frames, as it has no effect with the new API. --- libavcodec/avcodec.h | 6 ++ libavcodec/decode.c| 8 libavcodec/encode.c| 2 ++ libavcodec/

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-01-25 Thread Nicolas George
Jan Ekström (12021-01-25): > For now I kept them separate since one is just moving Stefano's code, > and another adds new functionality that you requested. Stefano's code was good enough for ffprobe, because it had to perform a very precise task in a very constrained context, but as is, it is not

Re: [FFmpeg-devel] [PATCH] lavc: shedule old encoding/decoding API for removal

2021-01-25 Thread James Almer
On 1/25/2021 9:40 AM, Anton Khirnov wrote: It has been deprecated for 4 years and certain new codecs do not work with it. Also include AVCodecContext.refcounted_frames, as it has no effect with the new API. LGTM, of course. ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: add support for setting input options

2021-01-25 Thread Nicolas George
Jan Ekström (12021-01-25): > I knew that would be useful, but opted out of it since: > 1. For now I didn't yet need it. That is not a good reason. > 2. I wanted to keep out of the actual playlist parsing code. I know, file parsing code is not nice. But this is what needs doing. > 3. Possible se

Re: [FFmpeg-devel] [PATCH] avfilter: add shear video filter

2021-01-25 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavf/utils: reset event_flags if extradata is not extracted correctly

2021-01-25 Thread Anton Khirnov
Quoting Linjie Fu (2021-01-25 04:49:21) > On Mon, Jan 25, 2021 at 12:49 AM Anton Khirnov wrote: > > > > Quoting Linjie Fu (2021-01-24 16:05:56) > > > Regression since 87f0c8280. > > > > > > If the extradata of a stream could not be extracted correctly, > > > codec_info_nb_frames would remain zero,

Re: [FFmpeg-devel] Issue with ogg page termination on full last page with even last segment size

2021-01-25 Thread Peter Zebühr
Ping > On 14 Jan 2021, at 18:13, Peter Zebühr wrote: > > Hi, > > I had a look at different options on how to fix the regression, though I am > not sure what I arrived at is what you had in mind. > > I tried to read up a bit on opus as well and I assume you are talking about > the frame leng

Re: [FFmpeg-devel] Issue with ogg page termination on full last page with even last segment size

2021-01-25 Thread Mark Harris
> > I am thinking that it should be safe to not mux any 0 sized packets in > > oggenc given that my understanding above is correct. Updated the patch to > > reflect that, let me know what you think. Theora in Ogg uses zero-length packets to repeat the same video frame. - Mark _

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dolby_e: Split decoder/parser files

2021-01-25 Thread James Almer
On 1/25/2021 9:11 AM, Nicolas Gaullier wrote: --- libavcodec/Makefile | 1 + libavcodec/dolby_e.c | 149 +-- libavcodec/dolby_e.h | 598 +- libavcodec/dolby_e_parser.c | 227 ++ libavcodec/dolby_

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: remove long dead debug_mv code

2021-01-25 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v4 2/9] avformat: add vvc raw demux

2021-01-25 Thread Nuo Mi
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/vvcdec.c | 61 3 files changed, 63 insertions(+) create mode 100644 libavformat/vvcdec.c diff --git a/libavformat/Makefile b/libavformat/Makefile index 3a8fbcbe5f..4a540

[FFmpeg-devel] [PATCH v4 6/9] avcodec: add vvc parser

2021-01-25 Thread Nuo Mi
--- configure | 1 + libavcodec/Makefile | 1 + libavcodec/parsers.c| 1 + libavcodec/vvc_parser.c | 299 4 files changed, 302 insertions(+) create mode 100644 libavcodec/vvc_parser.c diff --git a/configure b/configure index d5

[FFmpeg-devel] [PATCH v4 5/9] avcodec/h2645_parse: add nal header parser for h266/vvc

2021-01-25 Thread Nuo Mi
--- libavcodec/h2645_parse.c | 74 ++-- 1 file changed, 71 insertions(+), 3 deletions(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index a36ef4f5a0..35f9d035a9 100644 --- a/libavcodec/h2645_parse.c +++ b/libavcodec/h2645_parse.c @@ -1,5 +

[FFmpeg-devel] [PATCH v4 7/9] avformat: add h266/vvc muxer

2021-01-25 Thread Nuo Mi
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c | 25 + 3 files changed, 27 insertions(+) diff --git a/libavformat/Makefile b/libavformat/Makefile index 4a5406da38..0253aa7d5a 100644 --- a/libavformat/Makefile +++ b/libavforma

[FFmpeg-devel] [PATCH v4 8/9] avcodec/cbs_h2645: vvc, do not skip nals for nuh_layer_id > 0

2021-01-25 Thread Nuo Mi
--- libavcodec/cbs_h2645.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 6f3abf6b0b..da541407cf 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -494,8 +494,9 @@ static int cbs_h2645_fragment_add_nals

[FFmpeg-devel] [PATCH v4 9/9] avcodec: add vvc metadata bsf

2021-01-25 Thread Nuo Mi
use following command to test: ffmpeg -i in.bin -c:v copy -bsf vvc_metadata -f vvc out.bin 94.51%(293/310) can bit match with original clips 5.48%(17/310) are not bit match, the original clips has redundant emulation prevent bytes --- configure | 1 + libavcodec/Makefile

[FFmpeg-devel] [PATCH v4 0/9] add vvc raw demuxer, muxer, parser, metadata bsf

2021-01-25 Thread Nuo Mi
Major Changes since v3: Test 61 more new clips from VTM 11, all passed the passthrough test. Add and test VPS. Use the new SEI framework. Use the new CBSBSFContext base class Misc changes: Make h266_ceil as inline function Infer vui when it's not existed. Infer vui_chroma_sample_loc_type_frame Rem

[FFmpeg-devel] [PATCH v4 3/9] avcodec: add SEI enum for vvc

2021-01-25 Thread Nuo Mi
--- libavcodec/vvc_sei.h | 47 1 file changed, 47 insertions(+) create mode 100644 libavcodec/vvc_sei.h diff --git a/libavcodec/vvc_sei.h b/libavcodec/vvc_sei.h new file mode 100644 index 00..90724669de --- /dev/null +++ b/libavcodec/vvc_sei.h

Re: [FFmpeg-devel] [PATCH v4 8/9] avcodec/cbs_h2645: vvc, do not skip nals for nuh_layer_id > 0

2021-01-25 Thread Nuo Mi
On Mon, Jan 25, 2021 at 10:17 PM Nuo Mi wrote: > --- > libavcodec/cbs_h2645.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c > index 6f3abf6b0b..da541407cf 100644 > --- a/libavcodec/cbs_h2645.c > +++ b/libavcodec/cbs_h26

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dolby_e: Split decoder/parser files

2021-01-25 Thread James Almer
On 1/25/2021 10:24 AM, James Almer wrote: On 1/25/2021 9:11 AM, Nicolas Gaullier wrote: ---   libavcodec/Makefile  |   1 +   libavcodec/dolby_e.c | 149 +--   libavcodec/dolby_e.h | 598 +-   libavcodec/dolby_e_parser.c   

[FFmpeg-devel] [PATCH v4 1/9] avcodec/vvc: add shared header for vvc

2021-01-25 Thread Nuo Mi
--- libavcodec/vvc.h | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 libavcodec/vvc.h diff --git a/libavcodec/vvc.h b/libavcodec/vvc.h new file mode 100644 index 00..ca15297d7a --- /dev/null +++ b/libavcodec/vvc.h @@ -0,0 +1,142

[FFmpeg-devel] [PATCH] avcodec/dolby_e: split decoder and parser more thoroughly

2021-01-25 Thread James Almer
Neither module should depend on the other, so move shared functions to their own file for this purpose, and ensure source files are compiled only when the required modules are enabled. dolby_e.c/h - Decoder only functions, tables and structures. dolby_e_parser.c - Parser only functions, tables and

Re: [FFmpeg-devel] [PATCH] avcodec/dolby_e: split decoder and parser more thoroughly

2021-01-25 Thread Paul B Mahol
Probably OK idea, but wait maybe for others few hours. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubsc

Re: [FFmpeg-devel] [PATCH v4 0/9] add vvc raw demuxer, muxer, parser, metadata bsf

2021-01-25 Thread Nuo Mi
On Mon, Jan 25, 2021 at 10:16 PM Nuo Mi wrote: > Major Changes since v3: > Test 61 more new clips from VTM 11, all passed the passthrough test. > Add and test VPS. > Use the new SEI framework. > Use the new CBSBSFContext base class > One more: detect au start in vvc_metadata filter. > > Misc cha

[FFmpeg-devel] [PATCH 1/2] avformat/dashdec: Fix missing NULL check

2021-01-25 Thread sfan5
--- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 693fc7372b..dc56e89f11 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -161,7 +161,7 @@ typedef struct DASHContext { static int isht

[FFmpeg-devel] [PATCH 2/2] avformat/dashdec: Avoid segfault when URL template is unexpectedly missing

2021-01-25 Thread sfan5
This isn't supposed to happen, but unfinished support for non-templated manifests and lack of e.g. presentationTimeOffset handling can provoke such a situation even with well-formed input. --- libavformat/dashdec.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/liba

[FFmpeg-devel] [PATCH] avcodec/aac_ac3_parser: fix channel information parsing

2021-01-25 Thread Piotr Uracz
Fixes bug https://trac.ffmpeg.org/ticket/7372 Summary of the bug: When ffmpeg is compiled with ac3 decoder disabled ffmpeg is unable to extract channel information from ts file. --- libavcodec/aac_ac3_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aac_

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Lynne
Jan 25, 2021, 12:03 by nicolas.gaullier@cji.paris: > >De : ffmpeg-devel De la part de Paul B > >Mahol > >Envoyé : jeudi 21 janvier 2021 13:36 > >À : FFmpeg development discussions and patches > >Objet : Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser > >> >> > >Changes looks trivia

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread James Almer
On 1/25/2021 12:35 PM, Lynne wrote: Jan 25, 2021, 12:03 by nicolas.gaullier@cji.paris: De : ffmpeg-devel De la part de Paul B Mahol Envoyé : jeudi 21 janvier 2021 13:36 À : FFmpeg development discussions and patches Objet : Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser Cha

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-25 Thread Lynne
Jan 25, 2021, 16:39 by jamr...@gmail.com: > On 1/25/2021 12:35 PM, Lynne wrote: > >> Jan 25, 2021, 12:03 by nicolas.gaullier@cji.paris: >> De : ffmpeg-devel De la part de Paul B Mahol Envoyé : jeudi 21 janvier 2021 13:36 À : FFmpeg development discussions and patches Ob

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread Nicolas George
Anton Khirnov (12021-01-25): > My plan is currently to move the sources into a subdirectory of > libavformat/. If that is all, then no. Please spend your time in more useful manners. As somebody who maintains parts of libavdevice, I do not want tracking history made more difficult and brittle, I d

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-25 Thread Nicolas George
Anton Khirnov (12021-01-23): > But does anyone use anything else than ffmpeg.c for that? > > The question here is not whether this functionality should exist at all, > but whether libavdevice/libavformat is the right place for it. If something is useful in ffmpeg.c, then it is likely to be useful

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread James Almer
On 1/25/2021 1:18 PM, Nicolas George wrote: Anton Khirnov (12021-01-25): My plan is currently to move the sources into a subdirectory of libavformat/. If that is all, then no. Please spend your time in more useful manners. As somebody who maintains parts of libavdevice, I do not want tracking

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread Nicolas George
James Almer (12021-01-25): > Suggestions for alternatives are obviously welcome, if you dislike Anton's > current approach Simple: if you do not have plans to make it better, leave it alone and work on something useful. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread James Almer
On 1/25/2021 1:38 PM, Nicolas George wrote: James Almer (12021-01-25): Suggestions for alternatives are obviously welcome, if you dislike Anton's current approach Simple: if you do not have plans to make it better, leave it alone and work on something useful. Solving the hacky state of lavd

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread Nicolas George
James Almer (12021-01-25): > Solving the hacky state of lavd <-> lavf *is* useful. The only "hacky state" comes from the useless split of the libraries. > And it would help the > project a lot if you could be a tiny bit less aggressive and dis

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread James Almer
On 1/25/2021 1:46 PM, Nicolas George wrote: James Almer (12021-01-25): Solving the hacky state of lavd <-> lavf *is* useful. The only "hacky state" comes from the useless split of the libraries. And that's why we're trying to merge them. So again, a subdirectory is not obligatory for this p

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-25 Thread James Almer
On 1/25/2021 11:15 AM, Nuo Mi wrote: +static int FUNC(ref_pic_list_struct)(CodedBitstreamContext *ctx, RWContext *rw, + H266RefPicListStruct *current, + uint8_t list_idx, uint8_t rpls_idx, +

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: Do not abort when H264/HEVC extradata extraction fails

2021-01-25 Thread sfan5
Although rare, extradata can be present but empty and extraction will fail. However Android also supports passing codec-specific data inline and will likely play such a stream anyway. So there's no reason to abort initialization before we know for sure. --- libavcodec/mediacodecdec.c | 8

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread Nicolas George
James Almer (12021-01-25): > And that's why we're trying to merge them. So again, a subdirectory is not > obligatory for this purpose, and alternative suggestions are welcome. > Even just saying to keep them in the root folder would be more useful than That is what leaving it alone implies. > say

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-25 Thread James Almer
On 1/25/2021 2:12 PM, James Almer wrote: On 1/25/2021 11:15 AM, Nuo Mi wrote: +static int FUNC(ref_pic_list_struct)(CodedBitstreamContext *ctx, RWContext *rw, + H266RefPicListStruct *current, + uint8_t list_idx, uint8_t rpl

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-25 Thread emcodem
Am 2021-01-20 16:41, schrieb Tomas Härdin: ons 2021-01-20 klockan 00:27 +0100 skrev Marton Balint: On Tue, 19 Jan 2021, Tobias Rapp wrote: > On 18.01.2021 23:53, Tomas Härdin wrote: > > lör 2021-01-16 klockan 08:43 +0800 skrev lance.lmw...@gmail.com: > > > On Fri, Jan 15, 2021 at 09:43:58PM +0

Re: [FFmpeg-devel] [PATCH 4/6] avformat/flvdec: Check for nesting depth in amf_parse_object()

2021-01-25 Thread Michael Niedermayer
On Sun, Jan 24, 2021 at 02:14:43PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-23 23:10:54) > > Fixes: out of array access > > Fixes: > > 29202/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-5112845840809984 > > > > Found-by: continuous fuzzing process > > https://gi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h265_syntax_template: Better check for num_long_term_sps

2021-01-25 Thread Mark Thompson
On 24/01/2021 21:41, Michael Niedermayer wrote: On Sat, Nov 21, 2020 at 06:49:55PM +, Mark Thompson wrote: On 21/11/2020 17:37, Michael Niedermayer wrote: On Sun, Nov 15, 2020 at 09:37:45PM +, Mark Thompson wrote: On 14/11/2020 10:18, Michael Niedermayer wrote: Fixes: index 26 out of

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread Mark Thompson
On 25/01/2021 17:11, James Almer wrote: Mark then suggested to directly replace/extend the API with one that's more useful in the long run, instead of removing them as Anton suggested since you and some other devs stated they in fact do have users, and you agreed to that. So how about we try t

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-25 Thread James Almer
On 1/25/2021 2:12 PM, James Almer wrote: Did you add this just to set active_vps? I thought the idea was to remove all that since it's not a concept defined in h266. The following should get rid of active_*, but the actual fields can't be removed from CodedBitstreamH266Context unless we duplic

[FFmpeg-devel] [PATCH v3 1/2] vc2enc: Add missing static to local variables

2021-01-25 Thread Mark Thompson
--- libavcodec/vc2enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c index bab9d0f3d5..7bd2e4c2ab 100644 --- a/libavcodec/vc2enc.c +++ b/libavcodec/vc2enc.c @@ -423,7 +423,7 @@ static void encode_slice_params(VC2EncContext *s) }

[FFmpeg-devel] [PATCH v3 2/2] fate: Add test for namespace prefixes in libraries

2021-01-25 Thread Mark Thompson
Ensures that external symbols in the built static libraries either have correct namespace prefixes or are on a known list of exceptions. --- tests/Makefile | 1 + tests/fate/namespace.mak| 19 ++ tests/fate/namespace.sh | 15 tests/ref

Re: [FFmpeg-devel] [PATCH v3 2/2] fate: Add test for namespace prefixes in libraries

2021-01-25 Thread Andreas Rheinhardt
Mark Thompson: > Ensures that external symbols in the built static libraries either have > correct namespace prefixes or are on a known list of exceptions. > --- > tests/Makefile | 1 + > tests/fate/namespace.mak| 19 ++ > tests/fate/namespace.sh

Re: [FFmpeg-devel] [PATCH] avformat/utils: always preserve container dimensions for all streams

2021-01-25 Thread Michael Niedermayer
On Sun, Jan 24, 2021 at 11:41:13AM -0300, James Almer wrote: > If a decoder is used for probing it may change the dimensions reported by the > demuxer, either by the lowres factor or because of assorted frames reporting > different dimensions, and in a codec copy scenario, the last dimensions > arb

[FFmpeg-devel] [PATCH] libavcodec/ccaption_dec.c: Fixed indentation overwriting text in the cea608 caption decoder.

2021-01-25 Thread Levi Dooley
There was an assumption in the existing code that indentation would not occur more than once on the same row. This was a bad assumption. There are examples of 608 streams which call handle_pac multiple times on the same row with different indentation. As the code was before this change, the new ind

Re: [FFmpeg-devel] [PATCH] avformat/utils: always preserve container dimensions for all streams

2021-01-25 Thread James Almer
On 1/25/2021 7:46 PM, Michael Niedermayer wrote: On Sun, Jan 24, 2021 at 11:41:13AM -0300, James Almer wrote: If a decoder is used for probing it may change the dimensions reported by the demuxer, either by the lowres factor or because of assorted frames reporting different dimensions, and in a

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread Nicolas George
Mark Thompson (12021-01-25): > Merging the libraries (in source form, orthogonal to merging the > binaries) only makes sense if we are going to continue using the > libavformat internals, and that is exactly the thing we are trying to > get rid of. "We"? It seems to me that many people here have

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-25 Thread Marton Balint
On Mon, 25 Jan 2021, emco...@ffastrans.com wrote: Am 2021-01-20 16:41, schrieb Tomas Härdin: ons 2021-01-20 klockan 00:27 +0100 skrev Marton Balint: On Tue, 19 Jan 2021, Tobias Rapp wrote: > On 18.01.2021 23:53, Tomas Härdin wrote: > > lör 2021-01-16 klockan 08:43 +0800 skrev lance.lmw...@

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-01-25 Thread James Almer
On 1/25/2021 8:20 PM, Nicolas George wrote: Mark Thompson (12021-01-25): Merging the libraries (in source form, orthogonal to merging the binaries) only makes sense if we are going to continue using the libavformat internals, and that is exactly the thing we are trying to get rid of. "We"? It

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dashdec: Fix missing NULL check

2021-01-25 Thread Steven Liu
sfan5 于2021年1月25日周一 下午11:25写道: > > --- > libavformat/dashdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 693fc7372b..dc56e89f11 100644 > --- a/libavformat/dashdec.c > +++ b/libavformat/dashdec.c > @@ -161,7 +16

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashdec: Avoid segfault when URL template is unexpectedly missing

2021-01-25 Thread Steven Liu
sfan5 于2021年1月25日周一 下午11:25写道: > > This isn't supposed to happen, but unfinished support for non-templated > manifests and lack of e.g. presentationTimeOffset handling can provoke > such a situation even with well-formed input. > --- > libavformat/dashdec.c | 10 +- > 1 file changed, 9

[FFmpeg-devel] [PATCH 1/3] tests/dnn: enable unit test dense

2021-01-25 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- tests/dnn/Makefile | 1 + tests/dnn/dnn-layer-dense-test.c | 2 +- tests/fate/dnn.mak | 5 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/dnn/Makefile b/tests/dnn/Makefile index 8afdfab5d3..ef827520de 100644 ---

[FFmpeg-devel] [PATCH 2/3] dnn: remove type cast which is not necessary

2021-01-25 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_native.c | 10 +- .../dnn/dnn_backend_native_layer_avgpool.c | 2 +- .../dnn/dnn_backend_native_layer_conv2d.c| 4 ++-- libavfilter/dnn/dnn_backend_native_layer_dense.c | 2 +- .../dnn/dnn_backend_nativ

[FFmpeg-devel] [PATCH 3/3] dnn_backend_openvino.c: remove extra semicolon

2021-01-25 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_openvino.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 9329891c3f..beca256390 100644 --- a/libavfilter/dnn/dnn_backend_ope

[FFmpeg-devel] [PATCH 01/10] libavcodec/qsvenc.c: add max_frame_size support for hevc_qsv

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin The max_frame_size parameter is set only when codec is h264. Now I add hevc in that conditional statement. Signed-off-by: Wenbin Chen --- libavcodec/qsvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 5

[FFmpeg-devel] [PATCH 02/10] libavcodec/qsvenc: add DisableDeblockingIdc support for qsv

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin MediaSDK already has a flag to control deblocking (DisableDeblockingIdc). Add dblk_idc parameter in ffmpeg to expose this flag to user. Sigend-off-by: Wenbin Chen --- libavcodec/qsvenc.c | 6 ++ libavcodec/qsvenc.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/

[FFmpeg-devel] [PATCH 03/10] libavcodec/qsvenc: add low latency P-pyramid support for qsv

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin Add low latency P-pyramid support for qsv, and it relates to a new command line parameter "-p_strategy". To enable this flag, user also need to set "-bf" to 0. P-strategy has two modes "1-simple" and "2-pyramid". The details of the two models refer to https://github.com/Intel-Me

[FFmpeg-devel] [PATCH 04/10] libavcodec/qsvdec.c: extract frame packing arrangement data

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin Use h264_sei to parse SEI data got from MediaSDK. Extract frame packing arrangement information from SEI data and config AVStereo3D side data for decoded frame. Sigend-off-by: Wenbin Chen --- libavcodec/qsv_internal.h | 2 + libavcodec/qsvdec.c | 149 +

[FFmpeg-devel] [PATCH 05/10] libavcodec/qsvenc: Add transform skip for hevc_qsv

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin Add transform skip option for hevc_qsv. Command line option is "transform_skip". By enabling this option, the transform_skip_enabled_flag in PPS will be set to 1. This option is only supported in the platform newer than ICL. Signed-off-by Wenbin Chen --- libavcodec/qsvenc.c

[FFmpeg-devel] [PATCH 07/10] libavocdec/qsvenc_hevc: encode RGB format rawvideo

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin Add support for hevc_qsv to input RGB format frame. It will transform frame to yuv inside MediaSDK instead of using auto scale. Hevc_qsv supports directly encoding BGRA and X2RGB10Le format. X2RGB10Le is only supported in VDENC (-low_power 1). The X2RGB10Le correspond to the A2R

[FFmpeg-devel] [PATCH 06/10] libavcodec/qsvenc.c: add ROI support to qsv encoder

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin Use the mfxEncoderCtrl parameter to enable ROI. Get side data "AVRegionOfInterest" from filter "addroi" and use it to configure "mfxExtEncoderROI" which is the MediaSDK's ROI configuration. It is the first time to use encoderCtrl feature in ffmpeg-qsv, so add allocate and free

[FFmpeg-devel] [PATCH 08/10] libavcodec/qsvenc: add horizontal intra refresh and refresh cycle dist

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin Add an new intra refresh type: "horizontal", and an new param ref_cycle_dist. This param specify the distance between the beginnings of the intra-refresh cycles in frames. Signed-off-by: Wenbin Chen --- libavcodec/qsvenc.c | 13 +++-- libavcodec/qsvenc.h |

[FFmpeg-devel] [PATCH 09/10] libavcodec/qsvdec: using suggested num to set init_pool_size

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin The init_pool_size is set to be 64 and it is too many. Use IOSurfQuery to get NumFrameSuggest which is the suggested number of frame that needed to be allocated when initial the decoder Considering the hevc_qsv encoder's async is 4 (default) and max_b_frames is 8 (default) and d

[FFmpeg-devel] [PATCH 10/10] libavcodec/qsvdec: move unref before get_format

2021-01-25 Thread wenbin . chen
From: Wenbinc-Bin Qsv decoder needs to call preinit() twice to get NumFrameSuggest to config init_pool_size. The hw_frame_ctx is released at the second time calling preinit(). The hw_frame_ctx is AVBufferRef, so it release the source when the last unref is called. When the old context is released

Re: [FFmpeg-devel] EXT-X-PROGRAM-DATE-TIME value drifts behind the actual time on the start of the corresponding segment video

2021-01-25 Thread Vignesh Ravichandran
Friendly ping. Would greatly appreciate some input on this. Thanks, Vignesh On Fri, Jan 22, 2021 at 3:35 PM Vignesh Ravichandran < vignesh.ravichandra...@gmail.com> wrote: > I am trying to create a video by stitching multiple HLS segments (.ts > files) together based on a start time and end ti

[FFmpeg-devel] [PATCH] libavformat: avidec depends on dv for avpriv_dv_produce_packet

2021-01-25 Thread Peter Ross
--- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 3a8fbcbe5f..c4ce6ceb9b 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -120,7 +120,7 @@ OBJS-$(CONFIG_AST_DEMUXER) += ast.o a