Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-21 Thread Nicolas Gaullier
>De : Nicolas Gaullier >Envoyé : jeudi 14 janvier 2021 17:26 >À : ffmpeg-devel@ffmpeg.org >Cc : Nicolas Gaullier >Objet : [PATCH 0/2] avcodec/dolby_e: Add a parser > >I have limited duplicated code by making the decoder calling the parser. >An option would be to leave all common code to dolby_e.

Re: [FFmpeg-devel] [PATCH 0/2] avcodec/dolby_e: Add a parser

2021-01-21 Thread Paul B Mahol
Changes looks trivial enough. On Thu, Jan 21, 2021 at 1:30 PM Nicolas Gaullier wrote: > >De : Nicolas Gaullier > >Envoyé : jeudi 14 janvier 2021 17:26 > >À : ffmpeg-devel@ffmpeg.org > >Cc : Nicolas Gaullier > >Objet : [PATCH 0/2] avcodec/dolby_e: Add a parser > > > >I have limited duplicated c

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-21 Thread Anton Khirnov
Quoting James Almer (2021-01-09 18:47:17) > The st->codec values are updated based on the lowres factor by > avformat_find_stream_info() when it runs an instance of the decoder > internally, > and the same thing happens in ffmpeg.c when we open ist->dec_ctx with > avcodec_open2(), so these assignm

Re: [FFmpeg-devel] [PATCH] ffmpeg_opts: remove lowres check

2021-01-21 Thread James Almer
On 1/21/2021 9:59 AM, Anton Khirnov wrote: Quoting James Almer (2021-01-09 18:47:17) The st->codec values are updated based on the lowres factor by avformat_find_stream_info() when it runs an instance of the decoder internally, and the same thing happens in ffmpeg.c when we open ist->dec_ctx wit

Re: [FFmpeg-devel] [PATCH] Populate field order returned by avs script, Trac Ticket 8757

2021-01-21 Thread Stephen Hutchinson
On 1/17/21 1:23 PM, emco...@ffastrans.com wrote: On 2021-01-17 09:02, wrote Stephen Hutchinson: Comment bikeshedding aside, LGTM, but the avs_is* API usage added here needs to be reflected in the AVSC_DECLARE_FUNC and LOAD_AVS_FUNC blocks. If those parts of the API are present in 2.5, the LOAD_A

[FFmpeg-devel] [PATCH] fix for https://trac.ffmpeg.org/ticket/9057

2021-01-21 Thread konstantin
From: KM --- libavcodec/aacdec_template.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index fbe3074..3c2dbe3 100644 --- a/libavcodec/aacdec_template.c +++ b/libavcodec/aacdec_template.c @@ -639,11 +63

[FFmpeg-devel] [PATCH] avfilter/vf_atadenoise: add sigma options

2021-01-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 9 ++ libavfilter/atadenoise.h | 10 +- libavfilter/vf_atadenoise.c | 148 +-- libavfilter/x86/vf_atadenoise_init.c | 18 ++-- 4 files changed, 162 insertions(+), 23 deletions(-

Re: [FFmpeg-devel] [PATCH] Populate field order returned by avs script, Trac Ticket 8757

2021-01-21 Thread emcodem
On 2021-01-21 14:10, Stephen Hutchinson wrote: Yeah, never mind about that. I didn't notice that those are declared AVSC_INLINE, not AVSC_API, so they don't get used through the dynamic API loader. The comment formatting seems to have been messed up in the second version, though. /* The follow

Re: [FFmpeg-devel] [PATCH 2/3] avformat/paf: Do not zero allocated tables which are immedeately filled

2021-01-21 Thread Michael Niedermayer
On Wed, Jan 20, 2021 at 05:01:20PM +0100, Paul B Mahol wrote: > could make use of av_malloc_array while there. ok, will apply with av_malloc_array() thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred th

Re: [FFmpeg-devel] [PATCH v2 03/13] cbs_h2645: Merge SEI message handling in common between codecs

2021-01-21 Thread Mark Thompson
On 21/01/2021 02:08, James Almer wrote: On 1/18/2021 7:44 PM, Mark Thompson wrote: diff --git a/libavcodec/cbs_sei.h b/libavcodec/cbs_sei.h index 95beabf4d7..5ce4ad3ccd 100644 --- a/libavcodec/cbs_sei.h +++ b/libavcodec/cbs_sei.h @@ -21,8 +21,132 @@   #include   #include +   #include "libavuti

Re: [FFmpeg-devel] [PATCH 4/7] avformat/nistspheredec: Check bits_per_coded_sample and channels

2021-01-21 Thread Michael Niedermayer
On Wed, Jan 20, 2021 at 09:41:49AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-19 19:00:47) > > On Mon, Jan 18, 2021 at 09:06:10PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2021-01-17 00:07:26) > > > > Fixes: signed integer overflow: 80 * 92233009 cannot

Re: [FFmpeg-devel] [PATCH 3/7] libavformat/utils: consider avio_size() failure in ffio_limit()

2021-01-21 Thread Michael Niedermayer
On Tue, Nov 10, 2020 at 12:04:52AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (>20sec -> 3ms) > Fixes: > 26918/clusterfuzz-testcase-minimized-ffmpeg_dem_THP_fuzzer-5750425191710720 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 4/7] avformat/dhav: Break out of infinite dhav search loop

2021-01-21 Thread Michael Niedermayer
On Tue, Nov 10, 2020 at 12:04:53AM +0100, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 26922/clusterfuzz-testcase-minimized-ffmpeg_dem_DHAV_fuzzer-5794549613723648 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-o

Re: [FFmpeg-devel] [PATCH 6/7] avformat/avidec: dv does not support palettes

2021-01-21 Thread Michael Niedermayer
On Tue, Nov 10, 2020 at 12:04:55AM +0100, Michael Niedermayer wrote: > Fixes: memleak > Fixes: > 26937/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-5763003338981376 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/cri: check for available input in unpack_10bit()

2021-01-21 Thread Michael Niedermayer
On Tue, Nov 10, 2020 at 05:17:40PM +0100, Michael Niedermayer wrote: > On Tue, Nov 10, 2020 at 01:46:10AM +0100, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: Timeout (>20sec -> 56ms) > > > Fixes: > > > 26995/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CRI_fuzzer-5107217080

[FFmpeg-devel] [PATCH 1/3] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-01-21 Thread Nachiket Tarate
These will be used by HLS demuxer in case of SAMPLE-AES encryption/decryption. Signed-off-by: Nachiket Tarate --- libavcodec/adts_header.c | 1 + libavcodec/adts_header.h | 14 ++ libavcodec/adts_parser.c | 28 3 files changed, 43 insertions(+) diff --g

[FFmpeg-devel] [PATCH 2/3] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2021-01-21 Thread Nachiket Tarate
Apple HTTP Live Streaming Sample Encryption: https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption Signed-off-by: Nachiket Tarate --- libavformat/Makefile | 2 +- libavformat/hls.c| 97 ++- libavformat/hls_sample_aes.c | 486

Re: [FFmpeg-devel] [PATCH 2/3] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2021-01-21 Thread Lynne
Jan 21, 2021, 20:42 by nachiket.program...@gmail.com: > Apple HTTP Live Streaming Sample Encryption: > > https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption > > Signed-off-by: Nachiket Tarate > --- > libavformat/Makefile | 2 +- > libavform

Re: [FFmpeg-devel] [PATCH 20/39] avcodec/h261dec: Don't initialize unused part of RLTable

2021-01-21 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-12-10 12:16:38) >> The H.261 decoder only uses an RLTable's VLC table, yet it also >> initializes its index_run, max_level and max_run. This commit stops >> doing so; it will also simplify making this decoder init-threadsafe, >> as the H.261 decoder

[FFmpeg-devel] [PATCH 3/3] libavformat/hls: correct indentation

2021-01-21 Thread Nachiket Tarate
Signed-off-by: Nachiket Tarate --- libavformat/hls.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 9e7f020cea..a2efa18b07 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2028,23 +2028

[FFmpeg-devel] [PATCH 1/5] dnn: Delete unused global variable

2021-01-21 Thread Mark Thompson
--- libavfilter/dnn/dnn_backend_native_layer_mathbinary.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_native_layer_mathbinary.c b/libavfilter/dnn/dnn_backend_native_layer_mathbinary.c index 998a75245c..fc48242093 100644 --- a/libavfilter/dnn/dnn_backend_native_l

[FFmpeg-devel] [PATCH 2/5] dnn: Add missing static to local variable

2021-01-21 Thread Mark Thompson
--- libavfilter/dnn/dnn_backend_native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_native.c b/libavfilter/dnn/dnn_backend_native.c index 5e7fc0f10c..ffb79dc000 100644 --- a/libavfilter/dnn/dnn_backend_native.c +++ b/libavfilter/dnn/dnn_backend

[FFmpeg-devel] [PATCH 3/5] libavfilter/dnn: add prefix ff_ for internal functions

2021-01-21 Thread Mark Thompson
From: "Guo, Yejun" from proc_from_frame_to_dnn to ff_proc_from_frame_to_dnn, and from proc_from_dnn_to_frame to ff_proc_from_dnn_to_frame. Signed-off-by: Guo, Yejun --- This was sent a few days ago to fix some of these issues, and is included here because it is needed for the test in 5/5 to pa

[FFmpeg-devel] [PATCH 4/5] dnn: Add ff_ prefix to unnamespaced globals

2021-01-21 Thread Mark Thompson
--- libavfilter/dnn/dnn_backend_native.c | 10 +- libavfilter/dnn/dnn_backend_native.h | 4 ++-- .../dnn/dnn_backend_native_layer_avgpool.c | 8 .../dnn/dnn_backend_native_layer_avgpool.h | 6 +++--- .../dnn/dnn_backend_native_layer_conv2d.c |

[FFmpeg-devel] [PATCH 5/5] fate: Add test for namespace prefixes in libraries

2021-01-21 Thread Mark Thompson
Ensures that external symbols in the built static libraries either have correct namespace prefixes or are on a known list of exceptions. --- tests/Makefile | 1 + tests/fate/namespace.mak| 19 ++ tests/fate/namespace.sh | 15 tests/ref

Re: [FFmpeg-devel] [PATCH 3/6] libavfilter/dnn: add prefix ff_ for internal functions

2021-01-21 Thread Mark Thompson
On 18/01/2021 12:52, Guo, Yejun wrote: from proc_from_frame_to_dnn to ff_proc_from_frame_to_dnn, and from proc_from_dnn_to_frame to ff_proc_from_dnn_to_frame. Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_native.c | 4 ++-- libavfilter/dnn/dnn_backend_openvino.c | 4 ++-- liba

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/cri: check for available input in unpack_10bit()

2021-01-21 Thread Paul B Mahol
On Tue, Nov 10, 2020 at 12:15 AM Michael Niedermayer wrote: > Fixes: Timeout (>20sec -> 56ms) > Fixes: > 26995/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CRI_fuzzer-5107217080254464 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] [PATCH] vc2enc: Add missing static to local variables

2021-01-21 Thread Mark Thompson
--- Andreas noted that we should add 'R' to the set of symbol types in 5/5, which found this one as well. libavcodec/vc2enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c index bab9d0f3d5..7bd2e4c2ab 100644 --- a/libavcodec/vc2

Re: [FFmpeg-devel] [PATCH] lavd/dshow: Add namespace prefix to global functions

2021-01-21 Thread Mark Thompson
On 25/06/2018 19:47, Mark Thompson wrote: --- Not tested at all. libavdevice/dshow.c | 6 +++--- libavdevice/dshow_capture.h | 4 ++-- libavdevice/dshow_crossbar.c | 8 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.

Re: [FFmpeg-devel] [PATCH 5/5] fate: Add test for namespace prefixes in libraries

2021-01-21 Thread James Almer
On 1/21/2021 6:39 PM, Mark Thompson wrote: Ensures that external symbols in the built static libraries either have correct namespace prefixes or are on a known list of exceptions. --- tests/Makefile | 1 + tests/fate/namespace.mak| 19 ++ tests/fate/n

Re: [FFmpeg-devel] [PATCH] lavd/dshow: Add namespace prefix to global functions

2021-01-21 Thread James Almer
On 1/21/2021 7:52 PM, Mark Thompson wrote: On 25/06/2018 19:47, Mark Thompson wrote: --- Not tested at all.   libavdevice/dshow.c  | 6 +++---   libavdevice/dshow_capture.h  | 4 ++--   libavdevice/dshow_crossbar.c | 8   3 files changed, 9 insertions(+), 9 deletions(-) diff --gi

[FFmpeg-devel] [PATCH] avdevice/dshow: Add namespace prefix to the remaining global symbols

2021-01-21 Thread James Almer
Signed-off-by: James Almer --- libavdevice/dshow.c| 18 +-- libavdevice/dshow_capture.h| 226 ++--- libavdevice/dshow_enummediatypes.c | 51 +++ libavdevice/dshow_enumpins.c | 62 libavdevice/dshow_filter.c | 119 ++

[FFmpeg-devel] [PATCH] avformat/concatdec: add support for setting input options

2021-01-21 Thread Jan Ekström
This way protocol or format related options can be set for all of the files opened during concatenation. --- libavformat/concatdec.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 6d5b9914f9..3c

Re: [FFmpeg-devel] [PATCH 3/6] libavfilter/dnn: add prefix ff_ for internal functions

2021-01-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: 2021年1月22日 5:43 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 3/6] libavfilter/dnn: add prefix ff_ for > internal functions > > On 18/01/2021 12:52, Guo, Yejun wrote: > > from proc_from_f

Re: [FFmpeg-devel] [PATCH 1/5] dnn: Delete unused global variable

2021-01-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: 2021年1月22日 5:40 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/5] dnn: Delete unused global variable > > --- > libavfilter/dnn/dnn_backend_native_layer_mathbinary.c | 1 - > 1 file changed,

Re: [FFmpeg-devel] [PATCH 2/5] dnn: Add missing static to local variable

2021-01-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: 2021年1月22日 5:40 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/5] dnn: Add missing static to local variable > > --- > libavfilter/dnn/dnn_backend_native.c | 2 +- > 1 file changed, 1 insert

[FFmpeg-devel] [PATCH 1/2] dnn-layer-conv2d-test.c: remove dependency of dnn_native_class

2021-01-21 Thread Guo, Yejun
--- tests/dnn/dnn-layer-conv2d-test.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/dnn/dnn-layer-conv2d-test.c b/tests/dnn/dnn-layer-conv2d-test.c index 378a05eafc..b623ddac0d 100644 --- a/tests/dnn/dnn-layer-conv2d-test.c +++ b/tests/dnn/dnn-layer-conv2d-test.c

[FFmpeg-devel] [PATCH 2/2] dnn_backend_native.c: Add missing static to local variable

2021-01-21 Thread Guo, Yejun
From: Mark Thompson --- libavfilter/dnn/dnn_backend_native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_native.c b/libavfilter/dnn/dnn_backend_native.c index 2c0b938839..be43081170 100644 --- a/libavfilter/dnn/dnn_backend_native.c +++ b/libav

Re: [FFmpeg-devel] [PATCH] avutils/vulkan: hwmap, respect src frame resolution

2021-01-21 Thread Lynne
Jan 21, 2021, 05:35 by guangxin...@intel.com: > fixes http://trac.ffmpeg.org/ticket/9055 > > The hw decoder may allocate a large frame from AVHWFramesContext, and adjust > width and height based on bitstream. > We need to use resolution from src frame instead of AVHWFramesContext. > > test comman

Re: [FFmpeg-devel] [PATCH] avutils/vulkan: hwmap, respect src frame resolution

2021-01-21 Thread Xu, Guangxin
> -Original Message- > From: ffmpeg-devel On Behalf Of > Lynne > Sent: Friday, January 22, 2021 11:37 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avutils/vulkan: hwmap, respect src > frame resolution > > Jan 21, 2021, 05:3

Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native.c: Add missing static to local variable

2021-01-21 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年1月22日 10:55 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH 2/2] dnn_backend_native.c: Add missing static to local > variable > > From: Mark Thompson > > --- > libavfilter/dnn/dnn_backend_native.c | 2 +- > 1 file

Re: [FFmpeg-devel] [PATCH 4/5] dnn: Add ff_ prefix to unnamespaced globals

2021-01-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: 2021年1月22日 5:40 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 4/5] dnn: Add ff_ prefix to unnamespaced > globals > > --- > libavfilter/dnn/dnn_backend_native.c | 10 +- > l

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: change sequence number type to int64_t

2021-01-21 Thread zhilizhao(赵志立)
Ping for review. > On Jan 16, 2021, at 11:40 AM, Zhao Zhili wrote: > > Fix atoi() overflow for large EXT-X-MEDIA-SEQUENCE. > > The spec says the type of sequence number is uint64_t. Use int64_t > here since current implementation requires it to be signed integer, > and hlsenc use int64_t too. >