Quoting James Almer (2021-01-09 18:47:17) > The st->codec values are updated based on the lowres factor by > avformat_find_stream_info() when it runs an instance of the decoder > internally, > and the same thing happens in ffmpeg.c when we open ist->dec_ctx with > avcodec_open2(), so these assignments are redundant. > > Signed-off-by: James Almer <jamr...@gmail.com> > --- > This chunk here is not properly wrapped with the relevant pre-processor check > for AVStream->codec, and seeing it's ultimately redundant, i figured we might > as well delete it now. > > For that matter, the deprecation of lowres in avcodec.h is in a very strange > state (the field is not removed, its offset is changed instead). Once the > value > of FF_API_LOWRES is flipped, neither the field, the AVOption, or the usage > within decoders will be removed, but some code in libavformat/utils.c will be > disabled, and that may result in unexpected behavior.
IMO it should just be made a codec-private option. And lavf has no business treating it specially. Patch fine with me. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
