Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2021-01-04 Thread Matthieu Bouron
On Mon, Nov 23, 2020 at 05:43:06PM +0100, Matthieu Bouron wrote: > On Tue, Nov 17, 2020 at 02:18:46PM +0100, Matthieu Bouron wrote: > > On Mon, Nov 09, 2020 at 06:26:46PM +0100, Matthieu Bouron wrote: > > > On Mon, Nov 02, 2020 at 12:42:19PM +0100, Matthieu Bouron wrote: > > > > Currently skip_samp

Re: [FFmpeg-devel] FFmpeg buying an Apple M1 Mac Mini

2021-01-04 Thread Kieran Kunhya
On Sun, 3 Jan 2021 at 21:53, Josh Dekker wrote: > On 2021/01/03 20:18, Michael Niedermayer wrote: > > On Sun, Jan 03, 2021 at 06:32:11PM +0100, Kieran Kunhya wrote: > >> Hello, > >> > >> As it's 2021 I would like to propose FFmpeg purchase one or more (e.g > >> FATE + development) Apple M1 Mac Mi

Re: [FFmpeg-devel] [PATCH] avcodec/dolby_e: set constant frame_size

2021-01-04 Thread Nicolas Gaullier
>De : Nicolas Gaullier >Envoyé : mardi 15 décembre 2020 18:13 >À : ffmpeg-devel@ffmpeg.org >Cc : Nicolas Gaullier >Objet : [PATCH] avcodec/dolby_e: set constant frame_size > >Fixes pts generation. > >Setting frame_size in dolby_e_init() or get_audio_frame_duration() can result >in a bad duratio

Re: [FFmpeg-devel] FFmpeg buying an Apple M1 Mac Mini

2021-01-04 Thread Thilo Borgmann
Am 04.01.21 um 13:22 schrieb Kieran Kunhya: > On Sun, 3 Jan 2021 at 21:53, Josh Dekker wrote: > >> On 2021/01/03 20:18, Michael Niedermayer wrote: >>> On Sun, Jan 03, 2021 at 06:32:11PM +0100, Kieran Kunhya wrote: Hello, As it's 2021 I would like to propose FFmpeg purchase one or m

Re: [FFmpeg-devel] [RFC] Event loop

2021-01-04 Thread Nicolas George
Peter Ross (12021-01-04): > Majority of our demuxers and muxers assume a blocking model. Will they > need to be rewritten (eventually) to use event-based i/o? The way I see it, compatibility is ensured: the current API that reads on protocol should still be supported, by creating a local loop and

Re: [FFmpeg-devel] [RFC] Event loop

2021-01-04 Thread Nicolas George
Kieran Kunhya (12021-01-02): > In my opinion we should use libev as the default and make it a submodule > (possibly as part of some sort of plugin system for event loops). This > allows us to use modern things such as io_uring as they come. I can be on board with that, since I like libev very much

Re: [FFmpeg-devel] [PATCH 01/27] cbs_h2645: Merge SEI messages in common between codecs

2021-01-04 Thread Nuo Mi
On Sat, Jan 2, 2021 at 5:45 AM Mark Thompson wrote: > Make a new template file for common SEI messages - this will also apply > to H.266. > --- > libavcodec/cbs_h264.h | 37 +-- > libavcodec/cbs_h2645.c| 24 +++-- > libavcodec/cbs_h264_syntax_template.c | 10

Re: [FFmpeg-devel] [RFC] Event loop

2021-01-04 Thread Xiang Xiao
Nicolas, thank you for bringing up this topic. My team is working on similar functionality: the event loop is the central point to integrate protocol, demux/mux, decoder/encoder, avfilter and avdevice to form a complete multimedia subsystem(like DirectShow or GStreamer). Without the builtin event l

Re: [FFmpeg-devel] [PATCH 01/27] cbs_h2645: Merge SEI messages in common between codecs

2021-01-04 Thread James Almer
On 1/4/2021 11:32 AM, Nuo Mi wrote: +static int FUNC(sei_mastering_display_colour_volume) +(CodedBitstreamContext *ctx, RWContext *rw, + SEIRawMasteringDisplayColourVolume *current) +{ +int err, c; + +HEADER("Mastering Display Colour Volume"); + +for (c = 0; c < 3; c++) { +

Re: [FFmpeg-devel] [PATCH v2] fate/hevc-conformance: add clip for persistent_rice_adaptation_enabled_flag

2021-01-04 Thread Linjie Fu
On Fri, Jan 1, 2021 at 9:39 PM Linjie Fu wrote: > > On Mon, Dec 14, 2020 at 5:49 PM Guangxin Xu wrote: > > > > Hi Lingjie > > thanks for the review. > > The stream has the feature but not used. > > > > the decoded yuv's md5 is 3c94b5ebc0aed0abae4e619b9dcca9cc > > it's matched with the WPP_HIGH_TP

Re: [FFmpeg-devel] [PATCH] avcodec/libkvazaar: Set default ratecontrol algorithm for libkvazaar

2021-01-04 Thread Linjie Fu
On Fri, Jan 1, 2021 at 9:55 PM Linjie Fu wrote: > > On Thu, Dec 10, 2020 at 3:28 PM Linjie Fu wrote: > > > > On Thu, Dec 10, 2020 at 2:09 PM Joose Sainio wrote: > > > > > > The standalone version of Kvazaar sets a default ratecontrol algorithm > > > when > > > bitrate is set. Mirror this behavi

Re: [FFmpeg-devel] [PATCH 01/27] cbs_h2645: Merge SEI messages in common between codecs

2021-01-04 Thread Nuo Mi
Yeah, thanks for the reminder. On Mon, Jan 4, 2021 at 10:47 PM James Almer wrote: > On 1/4/2021 11:32 AM, Nuo Mi wrote: > >> +static int FUNC(sei_mastering_display_colour_volume) > >> +(CodedBitstreamContext *ctx, RWContext *rw, > >> + SEIRawMasteringDisplayColourVolume *current) > >> +{

Re: [FFmpeg-devel] [PATCH v2] fate/hevc-conformance: add clip for persistent_rice_adaptation_enabled_flag

2021-01-04 Thread Guangxin Xu
Awesome, thanks! On Mon, Jan 4, 2021 at 11:45 PM Linjie Fu wrote: > On Fri, Jan 1, 2021 at 9:39 PM Linjie Fu > wrote: > > > > On Mon, Dec 14, 2020 at 5:49 PM Guangxin Xu wrote: > > > > > > Hi Lingjie > > > thanks for the review. > > > The stream has the feature but not used. > > > > > > the de

Re: [FFmpeg-devel] [PATCH 03/27] cbs_h2645: Merge SEI message handling in common between codecs

2021-01-04 Thread Nuo Mi
On Sat, Jan 2, 2021 at 5:44 AM Mark Thompson wrote: > --- > libavcodec/Makefile | 4 +- > libavcodec/cbs_h264.h | 50 +--- > libavcodec/cbs_h2645.c| 300 +++-- > libavcodec/cbs_h264_syntax_template.c | 173 +--- > libav

Re: [FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

2021-01-04 Thread Nicolas George
Hi. Andreas Rheinhardt (12021-01-04): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vsrc_testsrc.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) IIRC, options tables cannot be de-duplicated, because of some enumerating code. Or am I confusing with something

Re: [FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

2021-01-04 Thread Andreas Rheinhardt
Nicolas George: > Hi. > > Andreas Rheinhardt (12021-01-04): >> Signed-off-by: Andreas Rheinhardt >> --- >> libavfilter/vsrc_testsrc.c | 15 +-- >> 1 file changed, 5 insertions(+), 10 deletions(-) > > IIRC, options tables cannot be de-duplicated, because of some > enumerating code. O

Re: [FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

2021-01-04 Thread Nicolas George
Andreas Rheinhardt (12021-01-04): > What enumerating code? It is actually commonplace that options are > shared (you can find examples in libavfilter by using 'git grep -e > define --and -e options'); pointing into other options and thereby > reusing only a part of other options is not common, but

Re: [FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

2021-01-04 Thread James Almer
On 1/4/2021 4:29 PM, Nicolas George wrote: Andreas Rheinhardt (12021-01-04): What enumerating code? It is actually commonplace that options are shared (you can find examples in libavfilter by using 'git grep -e define --and -e options'); pointing into other options and thereby reusing only a par

Re: [FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

2021-01-04 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-01-04): >> What enumerating code? It is actually commonplace that options are >> shared (you can find examples in libavfilter by using 'git grep -e >> define --and -e options'); pointing into other options and thereby >> reusing only a part of other optio

Re: [FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

2021-01-04 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-01-04): >> What enumerating code? It is actually commonplace that options are >> shared (you can find examples in libavfilter by using 'git grep -e >> define --and -e options'); pointing into other options and thereby >> reusing only a part of other optio

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2021-01-04 Thread Marton Balint
On Mon, 2 Nov 2020, Matthieu Bouron wrote: Currently skip_samples is set to start_pad if sample_time is lesser or equal to 0. This can cause issues if the stream starts with packets that have negative pts. Calling avformat_seek_file() with ts set to 0 on such streams makes the mov demuxer retu

Re: [FFmpeg-devel] [PATCH] avcodec/dolby_e: set constant frame_size

2021-01-04 Thread Marton Balint
On Mon, 4 Jan 2021, Nicolas Gaullier wrote: De : Nicolas Gaullier Envoyé : mardi 15 décembre 2020 18:13 À : ffmpeg-devel@ffmpeg.org Cc : Nicolas Gaullier Objet : [PATCH] avcodec/dolby_e: set constant frame_size Fixes pts generation. Setting frame_size in dolby_e_init() or get_audio_frame_

Re: [FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

2021-01-04 Thread Nicolas George
Andreas Rheinhardt (12021-01-04): > The examples that this command shows you do not only de-duplicate in the > source (like it is done here in vsrc_testsrc.c), but really in the > binary. And it works (for it not to work the AVOpt API would need to be > modified to e.g. store the addresses of all t

Re: [FFmpeg-devel] [PATCH 0/1] bug: test pointer to be used.

2021-01-04 Thread James Almer
On 1/4/2021 3:11 PM, AlexisWilke wrote: It looks like the if() and the following lines disagree on the pointer to be used. I would imagine that these have been tested so the: f = indev_list[i - size]; and f = outdev_list[i - size]; are most certainly right, meaning that what's is w

[FFmpeg-devel] [PATCH 0/1] bug: test pointer to be used.

2021-01-04 Thread AlexisWilke
It looks like the if() and the following lines disagree on the pointer to be used. I would imagine that these have been tested so the: f = indev_list[i - size]; and f = outdev_list[i - size]; are most certainly right, meaning that what's is wrong would be the condition on the line prio

[FFmpeg-devel] [PATCH 1/1] bug: test pointer to be used.

2021-01-04 Thread AlexisWilke
Two tests check the opposite pointer before using it. If only one of these is set to a valid pointer, one of these functions will crash, the other will ignore the pointer. --- libavformat/allformats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/allformats.c

Re: [FFmpeg-devel] [PATCH 4/6] tools/target_dem_fuzzer.c: Decrease maxblocks

2021-01-04 Thread Michael Niedermayer
On Sun, Dec 27, 2020 at 06:49:36PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 28606/clusterfuzz-testcase-minimized-ffmpeg_dem_FRM_fuzzer-5123311424110592 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/alsdec: Fix integer overflow with quant_cof

2021-01-04 Thread Michael Niedermayer
On Sun, Dec 27, 2020 at 06:49:37PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -210824 * 16384 cannot be represented in type > 'int' > Fixes: > 28670/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5682310846480384 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/6] avformat/vividas: Check number of audio channels

2021-01-04 Thread Michael Niedermayer
On Sun, Dec 27, 2020 at 06:49:34PM +0100, Michael Niedermayer wrote: > Fixes: division by 0 > Fixes: > 28597/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5752201490333696 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signe

Re: [FFmpeg-devel] [RFC] Event loop

2021-01-04 Thread Steven Liu
> 2021年1月4日 下午9:44,Nicolas George 写道: > > Kieran Kunhya (12021-01-02): >> In my opinion we should use libev as the default and make it a submodule >> (possibly as part of some sort of plugin system for event loops). This >> allows us to use modern things such as io_uring as they come. > > I ca

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/qsvdec_other: refact, use DEFINE_QSV_DECODER to remove duplicate code

2021-01-04 Thread Guangxin Xu
Hi Linjie, thanks for the review. On Sat, Jan 2, 2021 at 11:29 AM Linjie Fu wrote: > Guangxin: > > On Thu, Nov 26, 2020 at 6:21 PM Xu Guangxin wrote: > > > > --- > > libavcodec/qsvdec_other.c | 188 -- > > 1 file changed, 36 insertions(+), 152 deletions(-) >

[FFmpeg-devel] [PATCH v2 1/6] avcodec/qsv_h2645: fix memory leak for plugin load

2021-01-04 Thread Xu Guangxin
--- libavcodec/qsvdec_h2645.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c index 02c41883b6..3d6e85230f 100644 --- a/libavcodec/qsvdec_h2645.c +++ b/libavcodec/qsvdec_h2645.c @@ -69,6 +69,8 @@ static av_cold int qsv_decode_close(AVCode

[FFmpeg-devel] [PATCH v2 2/6] avcodec/qsvdec_other: refact, use DEFINE_QSV_DECODER to remove duplicate code

2021-01-04 Thread Xu Guangxin
--- libavcodec/qsvdec_other.c | 188 -- 1 file changed, 36 insertions(+), 152 deletions(-) diff --git a/libavcodec/qsvdec_other.c b/libavcodec/qsvdec_other.c index 2775e07955..266ac9f2e5 100644 --- a/libavcodec/qsvdec_other.c +++ b/libavcodec/qsvdec_other.c @@

[FFmpeg-devel] [PATCH v2 3/6] avcodec/qsvdec_h2645: refact, use DEFINE_QSV_DECODER to remove duplicate code

2021-01-04 Thread Xu Guangxin
--- libavcodec/qsvdec_h2645.c | 89 +++ 1 file changed, 33 insertions(+), 56 deletions(-) diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c index 3d6e85230f..974c1b6034 100644 --- a/libavcodec/qsvdec_h2645.c +++ b/libavcodec/qsvdec_h2645.c @@ -

[FFmpeg-devel] [PATCH v2 4/6] avcodec/qsvdec: refact, move qsvdec_h2645.c to qsvdec.c

2021-01-04 Thread Xu Guangxin
--- libavcodec/Makefile | 8 +- libavcodec/qsvdec.c | 217 - libavcodec/qsvdec_h2645.c | 250 -- 3 files changed, 219 insertions(+), 256 deletions(-) delete mode 100644 libavcodec/qsvdec_h2645.c diff --git a/libavc

[FFmpeg-devel] [PATCH v2 5/6] avcodec/qsvdec: refact, move qsvdec_other.c to qsvdec.c

2021-01-04 Thread Xu Guangxin
--- libavcodec/Makefile | 14 +-- libavcodec/qsvdec.c | 41 ++- libavcodec/qsvdec_other.c | 242 -- 3 files changed, 47 insertions(+), 250 deletions(-) delete mode 100644 libavcodec/qsvdec_other.c diff --git a/libavcodec/Makefile b/libavcodec

[FFmpeg-devel] [PATCH v2 6/6] avcodec/qsvdec: refact, remove duplicate code for plugin loading

2021-01-04 Thread Xu Guangxin
--- libavcodec/qsvdec.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index 3ca16dafae..d10f90a0db 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -682,21 +682,12 @@ static av_cold int qsv

[FFmpeg-devel] [PATCH 1/2] avcodec/dvenc: dv100_weight_shift never used

2021-01-04 Thread Peter Ross
--- libavcodec/dvenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c index 0dc290642e..233e2b68c7 100644 --- a/libavcodec/dvenc.c +++ b/libavcodec/dvenc.c @@ -318,9 +318,8 @@ static const int dv100_qstep_inv[16] = { 65536, 6

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_waveform: flat_pix_fmts never used

2021-01-04 Thread Peter Ross
--- libavfilter/vf_waveform.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/libavfilter/vf_waveform.c b/libavfilter/vf_waveform.c index 11f8c0016e..8191da2792 100644 --- a/libavfilter/vf_waveform.c +++ b/libavfilter/vf_waveform.c @@ -303,13 +303,6 @@ static const enum AVPixelFormat ou

[FFmpeg-devel] [PATCH v4 1/2] lavf/qsv: Add functions to print mfx iopattern, warning and error

2021-01-04 Thread Haihao Xiang
It is a copy of the relevant part in lavc/qsv but use different function names to avoid multiple definition when linking lavc and lavf statically. Signed-off-by: Haihao Xiang --- v4: rename the new functions to avoid multiple definition libavfilter/qsvvpp.c | 104 +++

[FFmpeg-devel] [PATCH v4 2/2] qsv: dump more info in error, debug and verbose mode

2021-01-04 Thread Haihao Xiang
Dump iopattern mode and the SDK error/warning desciptions for qsv based filters and iopattern mode for qsvenc Signed-off-by: Haihao Xiang --- libavcodec/qsvenc.c | 1 + libavfilter/qsvvpp.c | 21 +-- libavfilter/vf_deinterlace_qsv.c | 36