Re: [FFmpeg-devel] [PATCH 2/3] avformat/rtpdec_mpegts: add ff_mpegtsraw_dynamic_handler

2020-12-22 Thread Aman Karmani
On Mon, Dec 21, 2020 at 4:36 PM Aman Karmani wrote: > From: Aman Karmani > > Passthrough handler which can be used to receive MP2T stream > over RTP, and repackage it into a AV_CODEC_ID_MPEG2TS data stream. > > Signed-off-by: Aman Karmani > --- > libavformat/rtpdec_formats.h | 1 + > libavfor

[FFmpeg-devel] [PATCH] libswscale: avoid UB nullptr-with-offset.

2020-12-22 Thread jleconte
Thanks for the feedback. It's not easy to work with -Wdeclaration-after-statement. --- libswscale/slice.c| 12 libswscale/swscale_unscaled.c | 4 +--- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/libswscale/slice.c b/libswscale/slice.c index 7849b70f4d.

Re: [FFmpeg-devel] [PATCH 2/6] avcodec: add h266 codec id and profiles

2020-12-22 Thread Nuo Mi
Hi James, thanks for the review. On Mon, Dec 21, 2020 at 11:14 PM James Almer wrote: > On 12/21/2020 3:07 AM, Nuo Mi wrote: > > --- > > libavcodec/avcodec.h| 2 ++ > > libavcodec/codec_desc.c | 8 > > libavcodec/codec_id.h | 2 ++ > > libavcodec/profiles.c | 5 + > > l

Re: [FFmpeg-devel] [PATCH 5/6] avcodec: add h266 parser

2020-12-22 Thread Nuo Mi
On Mon, Dec 21, 2020 at 11:15 PM James Almer wrote: > On 12/21/2020 3:07 AM, Nuo Mi wrote: > > --- > > configure| 3 + > > libavcodec/Makefile | 1 + > > libavcodec/h2645_parse.c | 73 +- > > libavcodec/h266_parser.c | 284 +++

Re: [FFmpeg-devel] [PATCH 5/6] avcodec: add h266 parser

2020-12-22 Thread Nuo Mi
On Tue, Dec 22, 2020 at 2:43 AM James Almer wrote: > On 12/21/2020 3:07 AM, Nuo Mi wrote: > > --- > > configure| 3 + > > libavcodec/Makefile | 1 + > > libavcodec/h2645_parse.c | 73 +- > > libavcodec/h266_parser.c | 284

Re: [FFmpeg-devel] [PATCH 6/6] avcodec: add vvdec H.266/VVC decoder

2020-12-22 Thread Nuo Mi
Hi Chen, Glad you can try it. Since hevc, the interlaced encoder is not supported. Encoder always encoder a frame, use an SEI to tell the user it's top/bottom filed or it's a frame. It's named Adaptive Frame Field (SAFF). Current ffmpeg can't support this very well for even hevc, I think we can pu

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/h266: add shared header for h266

2020-12-22 Thread Nuo Mi
On Tue, Dec 22, 2020 at 4:49 AM Mark Thompson wrote: > On 21/12/2020 06:07, Nuo Mi wrote: > > --- > > libavcodec/h266.h | 121 ++ > > 1 file changed, 121 insertions(+) > > create mode 100644 libavcodec/h266.h > > > > diff --git a/libavcodec/h266.h

Re: [FFmpeg-devel] [PATCH 4/6] avcodec: add cbs for h266

2020-12-22 Thread Nuo Mi
Hi Mark, thanks for your careful review. It may need time to fix them all, but I will change them one by one. thanks On Tue, Dec 22, 2020 at 6:53 AM Mark Thompson wrote: > On 21/12/2020 06:07, Nuo Mi wrote: > > --- > > libavcodec/Makefile |1 + > > libavcodec/cbs.c

Re: [FFmpeg-devel] [PATCH 5/6] avcodec: add h266 parser

2020-12-22 Thread Nuo Mi
On Mon, Dec 21, 2020 at 11:15 PM James Almer wrote: > On 12/21/2020 3:07 AM, Nuo Mi wrote: > > --- > > configure| 3 + > > libavcodec/Makefile | 1 + > > libavcodec/h2645_parse.c | 73 +- > > libavcodec/h266_parser.c | 284 +++

Re: [FFmpeg-devel] [PATCH 6/6] avcodec: add vvdec H.266/VVC decoder

2020-12-22 Thread Lynne
Dec 21, 2020, 07:07 by nuomi2...@gmail.com: > you can download test clips here: > https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/under_test/VTM-11.0/ > Honestly, I'm not sure about this patch. Its an external library decoder, which doesn't help us very much, and its for a code

Re: [FFmpeg-devel] [PATCH 6/6] avcodec: add vvdec H.266/VVC decoder

2020-12-22 Thread Nuo Mi
Hi Lynne, Thanks for the comments. We only have a small patch for the vvdec wrapper. All other codes (raw demuxer, cbs reader, parser, and cbs writer in the future) will benefit the native decoder and the vvc ecosystem. I do not think av1 is the savior. No matter how it promised you, if we only ha

Re: [FFmpeg-devel] [PATCH 6/6] avcodec: add vvdec H.266/VVC decoder

2020-12-22 Thread James Almer
On 12/22/2020 2:02 PM, Nuo Mi wrote: Hi Lynne, Thanks for the comments. We only have a small patch for the vvdec wrapper. All other codes (raw demuxer, cbs reader, parser, and cbs writer in the future) will benefit the native decoder and the vvc ecosystem. Yes. I do not think av1 is the savi

Re: [FFmpeg-devel] [PATCH 6/6] avcodec: add vvdec H.266/VVC decoder

2020-12-22 Thread Lynne
Dec 22, 2020, 18:02 by nuomi2...@gmail.com: > Hi Lynne, > Thanks for the comments. > We only have a small patch for the vvdec wrapper. All other codes (raw > demuxer, cbs reader, parser, and cbs writer in the future) will benefit the > native decoder and the vvc ecosystem. > My problem was with t

Re: [FFmpeg-devel] [PATCH 6/6] avcodec: add vvdec H.266/VVC decoder

2020-12-22 Thread Marton Balint
On Tue, 22 Dec 2020, Lynne wrote: Dec 21, 2020, 07:07 by nuomi2...@gmail.com: you can download test clips here: https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/under_test/VTM-11.0/ Honestly, I'm not sure about this patch. Its an external library decoder, which doesn't h

[FFmpeg-devel] [PATCH] Splash encoder/decoder

2020-12-22 Thread xyzzy
Congratulations with your 20th anniversary! I was planning to submit this codec as part of the jsFractalZoom project after it has been officially announced. It felt as a fitting surprise to submit it on that day. The splash encoder/decoder is a lossy/lossless codec based on fractal zoom tech

[FFmpeg-devel] [RFC][PATCH] libavformat: add librist protocol

2020-12-22 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- TODO: What about logging messages? Return codes? File handles? Add support for password? Advanced stuff? --- configure | 5 ++ libavformat/Makefile| 1 + libavformat/librist.c | 164 libavformat/prot

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add option stats_period

2020-12-22 Thread Gyan Doshi
On 22-12-2020 09:49 am, Gyan Doshi wrote: On 22-12-2020 04:28 am, Michael Niedermayer wrote: On Mon, Dec 21, 2020 at 02:51:20PM +0530, Gyan Doshi wrote: At present, progress stats are updated at a hardcoded interval of half a second. For long processes, this can lead to bloated logs and pro

Re: [FFmpeg-devel] [PATCH 6/6] avcodec: add vvdec H.266/VVC decoder

2020-12-22 Thread Lynne
Dec 22, 2020, 19:24 by c...@passwd.hu: > > > On Tue, 22 Dec 2020, Lynne wrote: > >> Dec 21, 2020, 07:07 by nuomi2...@gmail.com: >> >>> you can download test clips here: >>> https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/under_test/VTM-11.0/ >>> >> >> Honestly, I'm not sure abou

Re: [FFmpeg-devel] [RFC][PATCH] libavformat: add librist protocol

2020-12-22 Thread Lynne
Dec 22, 2020, 19:09 by one...@gmail.com: > Signed-off-by: Paul B Mahol > + > +const URLProtocol ff_librist_protocol = { > +.name= "rist", > +.url_open= librist_open, > +.url_read= librist_read, > +.url_write = librist_write, > +

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtsp: add support for satip://

2020-12-22 Thread Andriy Gelman
On Mon, 21. Dec 16:35, Aman Karmani wrote: > From: Aman Karmani > > The SAT>IP protocol[1] is similar to RTSP. However SAT>IP servers > are assumed to speak only MP2T, so DESCRIBE is not used in the same > way. When no streams are active, DESCRIBE will return 404 according > to the spec (see sect

Re: [FFmpeg-devel] [RFC][PATCH] libavformat: add librist protocol

2020-12-22 Thread Paul B Mahol
On Tue, Dec 22, 2020 at 9:15 PM Lynne wrote: > Dec 22, 2020, 19:09 by one...@gmail.com: > > > Signed-off-by: Paul B Mahol > > + > > +const URLProtocol ff_librist_protocol = { > > +.name= "rist", > > +.url_open= librist_open, > > +.url_read= lib

Re: [FFmpeg-devel] [PATCH] Splash encoder/decoder

2020-12-22 Thread Paul B Mahol
On Tue, Dec 22, 2020 at 7:47 PM xyzzy wrote: > Congratulations with your 20th anniversary! > > I was planning to submit this codec as part of the jsFractalZoom project > after it has been officially announced. It felt as a fitting surprise to > submit it on that day. > > The splash encoder/decode

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtsp: add support for satip://

2020-12-22 Thread Aman Karmani
On Tue, Dec 22, 2020 at 12:17 PM Andriy Gelman wrote: > On Mon, 21. Dec 16:35, Aman Karmani wrote: > > From: Aman Karmani > > > > The SAT>IP protocol[1] is similar to RTSP. However SAT>IP servers > > are assumed to speak only MP2T, so DESCRIBE is not used in the same > > way. When no streams are

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cfhd: More strictly check tag order and multiplicity

2020-12-22 Thread Michael Niedermayer
On Sun, Dec 20, 2020 at 10:18:40PM +0100, Paul B Mahol wrote: > Unacceptable, please share privately sample that allows to reproduce this. shared the ones which reproduce. Please explain why this patch is unacceptable to you. the CFHD decoder decodes header elements in the order in which they ar

[FFmpeg-devel] [PATCH] avformat/hlsenc: Add dependency on avc.o

2020-12-22 Thread Derek Buitenhuis
a2b1dd0ce301450a47c972745a6b33c4c273aa5d added a dependency on ff_nal_unit_extract_rbsp. Signed-off-by: Derek Buitenhuis --- Reported on Twitter by Sam Hulick: https://twitter.com/SamHulick/status/1341218509414608897 --- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add dependency on avc.o

2020-12-22 Thread James Almer
On 12/22/2020 6:01 PM, Derek Buitenhuis wrote: a2b1dd0ce301450a47c972745a6b33c4c273aa5d added a dependency on ff_nal_unit_extract_rbsp. Signed-off-by: Derek Buitenhuis --- Reported on Twitter by Sam Hulick: https://twitter.com/SamHulick/status/1341218509414608897 --- libavformat/Makefile | 2

[FFmpeg-devel] [PATCH v2 1/3] avformat/rtsp: add support for satip://

2020-12-22 Thread Aman Karmani
From: Aman Karmani The SAT>IP protocol[1] is similar to RTSP. However SAT>IP servers are assumed to speak only MP2T, so DESCRIBE is not used in the same way. When no streams are active, DESCRIBE will return 404 according to the spec (see section 3.5.7). When streams are active, DESCRIBE will retu

[FFmpeg-devel] [PATCH v2 2/3] avformat/rtsp: add satip_raw flag to receive raw mpegts stream

2020-12-22 Thread Aman Karmani
From: Aman Karmani This can be used to receive the raw mpegts stream from a SAT>IP server, by letting avformat handle the RTSP/RTP/UDP negotiation and setup, but then simply passing the MP2T stream through instead of demuxing it further. For example, this command would demux/remux the mpegts str

[FFmpeg-devel] [PATCH v2 3/3] avcodec/codec_desc: describe AV_CODEC_ID_MPEG2TS

2020-12-22 Thread Aman Karmani
From: Aman Karmani Signed-off-by: Aman Karmani --- libavcodec/codec_desc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 404c460f8f..14757bf31b 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -3445,6 +344

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2020-12-22 Thread Josh Allmann
Hi Martin, On Sat, 19 Dec 2020 at 15:10, Martin Storsjö wrote: > > On Fri, 11 Dec 2020, Josh Allmann wrote: > > > On Fri, 11 Dec 2020 at 14:07, Martin Storsjö wrote: > >> > >> On Fri, 11 Dec 2020, Josh Allmann wrote: > >> > >> > A negative start_dts value (eg, delay from edit lists) typically yi

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add dependency on avc.o

2020-12-22 Thread Derek Buitenhuis
On 22/12/2020 21:38, James Almer wrote: > Should be ok. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wi

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: don't delay printing initial stats

2020-12-22 Thread Michael Niedermayer
On Mon, Dec 21, 2020 at 02:51:21PM +0530, Gyan Doshi wrote: > The first stats is printed after the initial stats_period has elapsed. With a > large period, > it may appear that ffmpeg has frozen at startup. > > The initial stats is now printed after the first transcode_step. > --- > fftools/ffmp

[FFmpeg-devel] [PATCH] ffmpeg: add 100ms delay for first stats

2020-12-22 Thread Gyan Doshi
Avoids breaking output file dump report. --- fftools/ffmpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 2c0820aacf..449da484d9 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1699,7 +1699,8 @@ static void print_report(i