Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

On Wed, Sep 9, 2020 at 6:59 AM James Almer wrote: > On 9/8/2020 7:42 PM, Andreas Rheinhardt wrote: > > James Almer: > >> This helper removes a side data entry from the packet, maintaining the > >> integrity and order of the remaining entries, if any. > >> > >> Signed-off-by: James Almer > >> ---

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/webp: add support for animated WebP decoding

On Tue, Sep 8, 2020 at 3:19 PM Moritz Barsnick wrote: > On Fri, Sep 04, 2020 at 00:59:46 +0200, Lynne wrote: > Missing version bumps. There is a version bump for libavformat, as new demuxer was added. I did not know that version should be increased also when there is a change in existing decode

Re: [FFmpeg-devel] [PATCH 01/15] lavc/codec_desc: add MIME type to AV_CODEC_ID_TEXT

On Wed, Sep 09, 2020 at 01:02:03AM -0500, rcombs wrote: > --- > libavcodec/codec_desc.c | 1 + > 1 file changed, 1 insertion(+) > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscrib

Re: [FFmpeg-devel] [PATCH 01/15] lavc/codec_desc: add MIME type to AV_CODEC_ID_TEXT

rcombs: > --- > libavcodec/codec_desc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > index 9e73dcba27..3dee640360 100644 > --- a/libavcodec/codec_desc.c > +++ b/libavcodec/codec_desc.c > @@ -3173,6 +3173,7 @@ static const AVCodecDesc

Re: [FFmpeg-devel] [PATCH 02/15] lavc/codec_desc: add additional JPEG and BMP MIME types

On Wed, Sep 09, 2020 at 01:02:04AM -0500, rcombs wrote: > --- > libavcodec/codec_desc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) lgtm > > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > index 3dee640360..49a00ad264 100644 > --- a/libavcodec/codec_desc.c >

Re: [FFmpeg-devel] [PATCH 02/15] lavc/codec_desc: add additional JPEG and BMP MIME types

rcombs: > --- > libavcodec/codec_desc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > index 3dee640360..49a00ad264 100644 > --- a/libavcodec/codec_desc.c > +++ b/libavcodec/codec_desc.c > @@ -82,7 +82,7 @@ static c

Re: [FFmpeg-devel] [PATCH 07/15] lavf/matroskadec: use avcodec_descriptor_get_by_mime_type

rcombs: > --- > libavformat/matroskadec.c | 40 ++- > 1 file changed, 6 insertions(+), 34 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index b1ef344aa7..71debe692a 100644 > --- a/libavformat/matroskadec.c > +++ b/libavfo

[FFmpeg-devel] [PATCH 04/15] lavc: add new font pseudo-codecs

--- libavcodec/codec_desc.c | 28 libavcodec/codec_id.h | 4 2 files changed, 32 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 72ecc1012b..ad044318c7 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -34

[FFmpeg-devel] [PATCH 02/15] lavc/codec_desc: add additional JPEG and BMP MIME types

--- libavcodec/codec_desc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 3dee640360..49a00ad264 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -82,7 +82,7 @@ static const AVCodecDescriptor cod

[FFmpeg-devel] [PATCH 05/15] lavf/matroskaenc: remove text/plain special-case

--- libavformat/matroskaenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 233c472b8f..d9caa3e728 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -1706,10 +1706,8 @@ static const char *g

[FFmpeg-devel] [PATCH 13/15] lavf/asfdec: use avcodec_descriptor_get_by_mime_type

--- libavformat/asfdec_f.c | 11 +++ libavformat/asfdec_o.c | 11 +++ 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index e9ddca7151..c35b81550b 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -21

[FFmpeg-devel] [PATCH 06/15] lavc/codec_desc: add avcodec_descriptor_get_by_mime_type

--- libavcodec/codec_desc.c | 41 + libavcodec/codec_desc.h | 12 libavcodec/version.h| 2 +- 3 files changed, 54 insertions(+), 1 deletion(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index ad044318c7..61b7f8d74f 1006

[FFmpeg-devel] [PATCH 09/15] lavf/id3v2: use avcodec_descriptor_get_by_mime_type

--- libavformat/id3v2.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index cecd9b9f6d..72a10bd1e1 100644 --- a/libavformat/id3v2.c +++ b/libavformat/id3v2.c @@ -585,7 +585,7 @@ static void read_apic(AVFormatContext *s, A

[FFmpeg-devel] [PATCH 14/15] lavf: remove ff_id3v2_mime_tags

The ID3 spec doesn't list any particular set of allowed types, it only suggests using PNG or JPEG for compatibility. --- libavformat/id3v2.c | 12 libavformat/id3v2.h | 2 -- 2 files changed, 14 deletions(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index 72a10bd1e1..34

[FFmpeg-devel] [PATCH 15/15] lavf: remove internal CodecMime type

These use the global codec descriptor registry now. --- libavformat/internal.h | 5 - 1 file changed, 5 deletions(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index 17a6ab07d3..7ae8142e5b 100644 --- a/libavformat/internal.h +++ b/libavformat/internal.h @@ -44,11 +44,6 @@ ty

[FFmpeg-devel] [PATCH 08/15] lavf/id3v2enc: use codec-desc-provided MIME types

--- libavformat/id3v2enc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/libavformat/id3v2enc.c b/libavformat/id3v2enc.c index 5d821ea4db..a7f251652f 100644 --- a/libavformat/id3v2enc.c +++ b/libavformat/id3v2enc.c @@ -352,23 +352,18 @@ int ff_id3v2_write_apic(AVF

[FFmpeg-devel] [PATCH 01/15] lavc/codec_desc: add MIME type to AV_CODEC_ID_TEXT

--- libavcodec/codec_desc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 9e73dcba27..3dee640360 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -3173,6 +3173,7 @@ static const AVCodecDescriptor codec_descriptors[]

[FFmpeg-devel] [PATCH 10/15] lavf/flac_picture: use avcodec_descriptor_get_by_mime_type

--- libavformat/flac_picture.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/libavformat/flac_picture.c b/libavformat/flac_picture.c index 53e24b28b7..3e684b58a3 100644 --- a/libavformat/flac_picture.c +++ b/libavformat/flac_picture.c @@ -31,7 +31,7 @@ int ff_f

[FFmpeg-devel] [PATCH 07/15] lavf/matroskadec: use avcodec_descriptor_get_by_mime_type

--- libavformat/matroskadec.c | 40 ++- 1 file changed, 6 insertions(+), 34 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index b1ef344aa7..71debe692a 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -7

[FFmpeg-devel] [PATCH 03/15] lavc/codec_desc: add new TTF and OTF MIME types

--- libavcodec/codec_desc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 49a00ad264..72ecc1012b 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -3343,7 +3343,7 @@ static const AVCodecDescriptor

[FFmpeg-devel] [PATCH 11/15] lavf/flacenc: use codec-desc-provided MIME types

--- libavformat/flacenc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b947a3b067..ebb0ffb967 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -80,22 +80,17 @@ static int flac_write_picture(stru

[FFmpeg-devel] [PATCH 12/15] lavf/mp3enc: use codec descs for query_codec

--- libavformat/mp3enc.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index a3586e1f86..eb8cc2e22f 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -489,12 +489,9 @@ static int mp3_write_trailer(struct AVFor

[FFmpeg-devel] [PATCH] dnn/dnn_backend_native_layer_conv2d: Fix allocation size

Found via ASAN with the dnn-layer-conv2d FATE-test. Signed-off-by: Andreas Rheinhardt --- Will apply this soon. libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.c b/libavfilter/

Re: [FFmpeg-devel] [PATCH] dnn/dnn_backend_native_layer_conv2d: Fix allocation size

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2020年9月9日 20:12 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH] dnn/dnn_backend_native_layer_conv2d: Fix > allocation size > > Found via ASAN with the dnn-layer-

[FFmpeg-devel] [PATCH] avformat/mov: make compatible brands more readable

From: Zhao Zhili Use comma as separator between multiple compatible brands. --- libavformat/mov.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 690beb10ce..8f5341f925 100644 --- a/libavformat/mov.c +++ b/

Re: [FFmpeg-devel] [PATCH 02/15] lavc/codec_desc: add additional JPEG and BMP MIME types

On Wed, Sep 09, 2020 at 01:02:04 -0500, rcombs wrote: > --- > libavcodec/codec_desc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > index 3dee640360..49a00ad264 100644 > --- a/libavcodec/codec_desc.c > +++ b/libavc

Re: [FFmpeg-devel] [PATCH 02/15] lavc/codec_desc: add additional JPEG and BMP MIME types

Oneric: > On Wed, Sep 09, 2020 at 01:02:04 -0500, rcombs wrote: >> --- >> libavcodec/codec_desc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c >> index 3dee640360..49a00ad264 100644 >> --- a/libavcodec/codec_desc.

Re: [FFmpeg-devel] [PATCH] avformat/mov: make compatible brands more readable

On 09/09/2020 14:07, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > Use comma as separator between multiple compatible brands. > --- > libavformat/mov.c | 24 +++- > 1 file changed, 15 insertions(+), 9 deletions(-) This change appears to actually be several dfferent ch

Re: [FFmpeg-devel] [PATCH 02/15] lavc/codec_desc: add additional JPEG and BMP MIME types

On Wed, Sep 09, 2020 at 15:28:05 +0200, Andreas Rheinhardt wrote: > Oneric: > > On Wed, Sep 09, 2020 at 01:02:04 -0500, rcombs wrote: > >> -.mime_types= MT("image/jpeg"), > >> +.mime_types= MT("image/jpeg", "image/jpg"), > > > > "image/jpg" doesn't seeem to be an official IANA MIME

Re: [FFmpeg-devel] [PATCH] avformat/mov: make compatible brands more readable

On 9/9/2020 10:07 AM, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > Use comma as separator between multiple compatible brands. Wont this potentially break parsing of the output of ffmpeg/ffprobe, or even of the compatible_brands key in c->fc->metadata when using the dict API? > --- > li

Re: [FFmpeg-devel] [PATCH 03/25] avfilter/af_headphone: Check for the existence of samples

Andreas Rheinhardt (12020-09-08): > Not providing any samples makes no sense at all. And if no samples > were provided for one of the HRIR streams, one would either run into > an av_assert1 in ff_inlink_consume_samples() or into a segfault in > take_samples() in avfilter.c. > > Signed-off-by: Andr

Re: [FFmpeg-devel] [PATCH] avformat/mov: make compatible brands more readable

> On Sep 9, 2020, at 9:51 PM, Derek Buitenhuis > wrote: > > On 09/09/2020 14:07, quinkbl...@foxmail.com wrote: >> From: Zhao Zhili >> >> Use comma as separator between multiple compatible brands. >> --- >> libavformat/mov.c | 24 +++- >> 1 file changed, 15 insertions(+), 9

Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: cast to uint64_t before shifting.

James Almer (12020-09-08): > It's a macro designed for this specific purpose. Figured it would be > proper, and we're using them in other parts of the code to shift the > values by more than 32 bits, like you're doing here. But yes, i should > have said could, not should. > > I don't consider it l

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: Read Mastering Display Colour Volume from MXF

> On 7 Sep 2020, at 10:40, Tomas Härdin wrote: > > mån 2020-08-31 klockan 20:07 +0100 skrev Harry Mallon: >> +static const uint8_t mxf_mastering_display_primaries[]= { >> 0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x01,0x00,0x00 >> }; >> +static const ui

Re: [FFmpeg-devel] [PATCH] avformat/mov: make compatible brands more readable

> On Sep 9, 2020, at 10:24 PM, James Almer wrote: > > On 9/9/2020 10:07 AM, quinkbl...@foxmail.com wrote: >> From: Zhao Zhili >> >> Use comma as separator between multiple compatible brands. > > Wont this potentially break parsing of the output of ffmpeg/ffprobe, or > even of the compatible_

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mxfenc: Write Mastering Display Colour Volume to MXF

> On 3 Sep 2020, at 07:31, Marton Balint wrote: > > On Mon, 31 Aug 2020, Harry Mallon wrote: > >> [..] >> }; >> +static const MXFLocalTagPair mxf_mastering_display_local_tags[] = { >> +{ 0x8201, >> {0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0e,0x04,0x20,0x04,0x01,0x01,0x01,0x00,0x00}}, >> /*

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF

> On 7 Sep 2020, at 10:46, Tomas Härdin wrote: > > mån 2020-08-31 klockan 20:07 +0100 skrev Harry Mallon: >> * As embedded by Apple Compressor > > This needs a sample since it isn't part of any official spec, so that > we can have a test for this. > >> +if (IS_KLV_KEY(uid, mxf_coll_ap

[FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

The link API provides an abstraction, where a filter sees on an input a stream of frames or samples terminated by a status change. Calling ff_outlink functions on an input bypasses this abstraction to peek inside implementation details; it may work now, but it can break at any point if the implemen

Re: [FFmpeg-devel] [PATCH 03/25] avfilter/af_headphone: Check for the existence of samples

Nicolas George: > Andreas Rheinhardt (12020-09-08): >> Not providing any samples makes no sense at all. And if no samples >> were provided for one of the HRIR streams, one would either run into >> an av_assert1 in ff_inlink_consume_samples() or into a segfault in >> take_samples() in avfilter.c. >>

Re: [FFmpeg-devel] [PATCH 03/25] avfilter/af_headphone: Check for the existence of samples

Andreas Rheinhardt (12020-09-09): > How should one then check whether an input is finished? Check for > ff_inlink_check_available_samples(ctx->inputs[i], > ff_inlink_queued_samples(ctx->inputs[i]) + 1) being 1? No, these tell you what can be obtained immediately. The test for a finished input is

[FFmpeg-devel] [PATCH v2 1/3] avformat/mxfdec: Read Mastering Display Colour Volume from MXF

Described in Annex B SMPTE ST 2067-21:2020 Signed-off-by: Harry Mallon --- libavformat/mxf.c| 11 ++ libavformat/mxf.h| 11 ++ libavformat/mxfdec.c | 48 libavformat/mxfenc.c | 5 - 4 files changed, 70 insertions(+), 5 del

[FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF

* As embedded by Apple Compressor Signed-off-by: Harry Mallon --- libavformat/mxfdec.c| 27 + tests/fate/mxf.mak | 4 + tests/ref/fate/mxf-probe-applehdr10 | 169 3 files changed, 200 insertions(+) create mode 100644 tests/ref

Re: [FFmpeg-devel] [PATCH 03/25] avfilter/af_headphone: Check for the existence of samples

Nicolas George: > Andreas Rheinhardt (12020-09-09): >> How should one then check whether an input is finished? Check for >> ff_inlink_check_available_samples(ctx->inputs[i], >> ff_inlink_queued_samples(ctx->inputs[i]) + 1) being 1? > > No, these tell you what can be obtained immediately. > The d

Re: [FFmpeg-devel] [PATCH 03/25] avfilter/af_headphone: Check for the existence of samples

Andreas Rheinhardt (12020-09-09): > The documentation of ff_inlink_check_available_samples() contains the > note "on EOF and error, min becomes 1". Which means that > ff_inlink_check_available_samples() can be used to peek into the error > code of this inlink by setting min so high that the not eno

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

On Tue, 8 Sep 2020, James Almer wrote: This helper removes a side data entry from the packet, maintaining the integrity and order of the remaining entries, if any. Signed-off-by: James Almer --- Missing APIChanges entry and version bump. Couldn't find a place in the tree where it could be u

[FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: Write Mastering Display Colour Volume to MXF

Described in Annex B SMPTE ST 2067-21:2020 Signed-off-by: Harry Mallon --- libavformat/mxfenc.c | 50 +++- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 733c747a9a..cbb0fc5a6a 100644 --- a/l

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

On 9/9/2020 12:47 PM, Marton Balint wrote: > > > On Tue, 8 Sep 2020, James Almer wrote: > >> This helper removes a side data entry from the packet, maintaining the >> integrity and order of the remaining entries, if any. >> >> Signed-off-by: James Almer >> --- >> Missing APIChanges entry and ve

Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

On Wed, Sep 09, 2020 at 04:58:35PM +0200, Nicolas George wrote: > The link API provides an abstraction, where a filter sees on an > input a stream of frames or samples terminated by a status change. > Calling ff_outlink functions on an input bypasses this abstraction > to peek inside implementation

Re: [FFmpeg-devel] [PATCH V3 1/2] avcodec: add av1 hardware acceleration decoder

On 9/9/2020 12:39 AM, Fei Wang wrote: > This av1 decoder is now only used for av1 hardware acceleration > decoder. Consider it can be extend to a local decoder like hevc > or vp9 in the future, so define its name as "av1" and put it into > external libraries codec list. > > Signed-off-by: Fei Wang

Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

Paul B Mahol (12020-09-09): > Patch rejected. There is no need to fix what is not broken. Rejection rejected. I have explained exactly why it is broken, you have not addressed it at all. -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

On Wed, Sep 09, 2020 at 06:44:44PM +0200, Nicolas George wrote: > Paul B Mahol (12020-09-09): > > Patch rejected. There is no need to fix what is not broken. > > Rejection rejected. I have explained exactly why it is broken, you have > not addressed it at all. Patch is incomplete, incorrect and d

Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

Paul B Mahol (12020-09-09): > Patch is incomplete, incorrect and defamatory thus rejected. Dealt with it. Patch is as complete as I can make it, and it is accurate, and therefore your accusation of "defamatory" are the defamatory parts in this discussion. > Rubberband filter need to know that las

[FFmpeg-devel] [PATCH] avfilter/avfilter: remove obsolete comment

Signed-off-by: Paul B Mahol --- libavfilter/avfilter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index d2ab489ac0..8ff22c71e3 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -1424,9 +1424,6 @@ static int ff_filter_act

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: remove obsolete comment

Paul B Mahol (12020-09-09): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index d2ab489ac0..8ff22c71e3 100644 > --- a/libavfilter/avfilter.c > +++ b/libavfilter/avfilter.c

Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

On Wed, Sep 09, 2020 at 07:24:43PM +0200, Nicolas George wrote: > Paul B Mahol (12020-09-09): > > Patch is incomplete, incorrect and defamatory thus rejected. Dealt with it. > > Patch is as complete as I can make it, and it is accurate, and therefore > your accusation of "defamatory" are the defam

[FFmpeg-devel] [PATCH v2 3/10] avformat/segment: Fix segfault on allocation error, avoid allocation

If the user has set none of the options specifying the segments' durations, a default value of 2s is used by duplicating a "2" string and using av_parse_time() on it. Yet duplicating the string was unchecked and if the allocation failed, one would get a segfault in av_parse_time(). This commit sol

[FFmpeg-devel] [PATCH v2 10/10] avformat/segment: Avoid duplicating string when parsing frames list

Signed-off-by: Andreas Rheinhardt --- Now no longer setting a pointer to one past the end of a string (although this is legal as long as one doesn't read from it). libavformat/segment.c | 40 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a

[FFmpeg-devel] [PATCH] avfilter/f_graphmonitor: add tiny output mode

Signed-off-by: Paul B Mahol --- doc/filters.texi | 2 +- libavfilter/f_graphmonitor.c | 119 +++ 2 files changed, 109 insertions(+), 12 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index cbb16f22b2..c1672cc7f7 100644 --- a/doc/filter

Re: [FFmpeg-devel] [PATCH 0/3] avcodec/fastaudio: Bugfixes

On Tue, Sep 08, 2020 at 10:12:07PM +, Amon Gibson Albuquerque Nunes wrote: > here are some mobiclib files for you to shake a stick at. > mobiclip_files Thanks! [...] -- Michael GnuPG fingerprint: 9FF212

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_remove_side_data()

On Wed, 9 Sep 2020, James Almer wrote: On 9/9/2020 12:47 PM, Marton Balint wrote: On Tue, 8 Sep 2020, James Almer wrote: This helper removes a side data entry from the packet, maintaining the integrity and order of the remaining entries, if any. Signed-off-by: James Almer --- Missing AP

Re: [FFmpeg-devel] [PATCH 02/15] lavc/codec_desc: add additional JPEG and BMP MIME types

> On Sep 9, 2020, at 08:23, Oneric wrote: > > On Wed, Sep 09, 2020 at 01:02:04 -0500, rcombs wrote: >> --- >> libavcodec/codec_desc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c >> index 3dee640360..49a00ad264

Re: [FFmpeg-devel] [PATCH 02/15] lavc/codec_desc: add additional JPEG and BMP MIME types

> On Sep 9, 2020, at 04:40, Andreas Rheinhardt > wrote: > > rcombs: >> --- >> libavcodec/codec_desc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c >> index 3dee640360..49a00ad264 100644 >> --- a/libavcodec/cod

[FFmpeg-devel] [PATCH] avcodec/cdgraphics: fix decoded output when seeking to start of file

Also in cdg demuxer do not skip packets data, and remove private context which is not really needed. Signed-off-by: Paul B Mahol --- libavcodec/cdgraphics.c | 10 ++ libavformat/cdg.c | 23 --- 2 files changed, 14 insertions(+), 19 deletions(-) diff --git a/lib

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: simplify writing the header

On Thu, Sep 03, 2020 at 03:55:04PM -0300, James Almer wrote: > Actually write it in yuv4_write_header() instead of with the first > packet. > > Signed-off-by: James Almer > --- > libavformat/yuv4mpegenc.c | 35 ++- > 1 file changed, 14 insertions(+), 21 deletions(

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: simplify writing the header

On 9/9/2020 7:54 PM, Michael Niedermayer wrote: > On Thu, Sep 03, 2020 at 03:55:04PM -0300, James Almer wrote: >> Actually write it in yuv4_write_header() instead of with the first >> packet. >> >> Signed-off-by: James Almer >> --- >> libavformat/yuv4mpegenc.c | 35 ++-

Re: [FFmpeg-devel] [PATCH V3 1/2] avcodec: add av1 hardware acceleration decoder

> On 9/9/2020 12:39 AM, Fei Wang wrote: > > This av1 decoder is now only used for av1 hardware acceleration > > decoder. Consider it can be extend to a local decoder like hevc or vp9 > > in the future, so define its name as "av1" and put it into external > > libraries codec list. > > > > Signed-of

[FFmpeg-devel] [PATCH 1/3] avfilter/src_movie: Remove unneeded resetting of AVPacket

av_read_frame() already returns clean packets on error. Signed-off-by: Andreas Rheinhardt --- libavfilter/src_movie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index 6e210d1df0..b9b940684d 100644 --- a/libavfilter/src_movie.c +++ b/libav

[FFmpeg-devel] [PATCH 3/3] avfilter/src_movie: Fix leak of packet upon error

If allocating the AVFrame to contain a decoded frame fails, the AVPacket containing the data intended to be decoded leaks. This commit fixes this. Signed-off-by: Andreas Rheinhardt --- libavfilter/src_movie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/src_movie.c b/libavfilt

[FFmpeg-devel] [PATCH 2/3] avfilter/src_movie: Remove unnecessary secondary AVPacket

The movie and amovie filters currently use two packets. One of the two, pkt0, is the owner of the returned packet; it is also the destination packet for av_read_frame(). The other one pkt is initially (i.e. after av_read_frame()) a copy of pkt0; copy means that the contents of both are absolutely t

[FFmpeg-devel] [PATCH v1] ffplay: remove unused code

Signed-off-by: Jun Li --- fftools/ffplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 9ff0425163..04cbcfe0e3 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -1568,7 +1568,7 @@ static double vp_duration(VideoState *is,

Re: [FFmpeg-devel] [PATCH v1] ffplay: remove unused code

> 2020年9月10日 上午9:03，Jun Li 写道： > > Signed-off-by: Jun Li > --- > fftools/ffplay.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffplay.c b/fftools/ffplay.c > index 9ff0425163..04cbcfe0e3 100644 > --- a/fftools/ffplay.c > +++ b/fftools/ffplay.c > @@ -1568,

[FFmpeg-devel] [PATCH 1/1] avfilter/vf_premultiply: add support for gbrapf32 format

From: Mark Reid --- libavfilter/vf_premultiply.c | 118 ++- 1 file changed, 115 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_premultiply.c b/libavfilter/vf_premultiply.c index 5d053b1f77..7e5b2aa97f 100644 --- a/libavfilter/vf_premultiply.c +++ b/lib

[FFmpeg-devel] [PATCH v2 1/7] lavc/avcodec: Add FF_PROFILE_HEVC_SCC for screen content coding

From: Linjie Fu Signed-off-by: Linjie Fu --- libavcodec/avcodec.h | 1 + libavcodec/hevc_ps.c | 2 ++ libavcodec/profiles.c | 1 + 3 files changed, 4 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index c91b2fd169..32e4770de2 100644 --- a/libavcodec/avcodec.h +++ b/li

[FFmpeg-devel] [PATCH v2 0/7] HEVC native support for Screen content coding

Resend Linjie's patchset with the updates. As a part of the support for VA-API HEVC SCC decoding (gen12, Tiger Lake+). The full support could be accessed in: https://github.com/intel-media-ci/ffmpeg/pull/231 The VAAPI part would be provided later once the implementations of native parsing and re

[FFmpeg-devel] [PATCH v2 2/7] lavc/hevc_ps: Add sps parse support for HEVC SCC extension syntax

From: Linjie Fu According to 7.3.2.2.3 in T-REC-H.265-201911. Signed-off-by: Linjie Fu Signed-off-by: Haihao Xiang --- v2 update: - Ignore sps_multilayer_extension_flag, sps_3d_extension_flag and sps_scc_extension_flag for non-SCC streams - Return AVERROR_PATCHWELCOME for sps_multilayer_ext

[FFmpeg-devel] [PATCH v2 7/7] lavc/hevc: Update reference list for SCC

From: Linjie Fu Screen Content Coding allows non-intra slice in an IDR frame, and would mark the current decoded picture as "used for long-term reference", no matter TwoVersionsOfCurrDecPicFlag(8.1.3), hence some previous restricts are not suitable any more. Constructe RefPicListTemp and RefPicL

[FFmpeg-devel] [PATCH v2 5/7] lavc/hevcdec: Fix the parsing for use_integer_mv_flag

From: Linjie Fu According to 7.3.6.1, use_integer_mv_flag should be parsed if motion_vector_resolution_control_idc equals to 2. Otherwise wrong parameters in the subsequent parsing procedures would be got. Signed-off-by: Linjie Fu --- libavcodec/hevcdec.c | 8 libavcodec/hevcdec.h |

[FFmpeg-devel] [PATCH v2 3/7] lavc/hevc_ps: Add pps parse support for HEVC SCC extension

From: Linjie Fu Signed-off-by: Linjie Fu Signed-off-by: Haihao Xiang --- v2 update: - Ignore pps_multilayer_extension_flag, pps_3d_extension_flag and pps_scc_extension_flag for non-SCC streams - Return AVERROR_PATCHWELCOME for pps_multilayer_extension_flag(1) and pps_3d_extension_flag(1). -

[FFmpeg-devel] [PATCH v2 6/7] lavc/hevcdec: Set max_num_merge_cand to uint8_t

From: Linjie Fu uint8_t is big enough and keep consistent with the definition in cbs_h265.h. Signed-off-by: Linjie Fu --- libavcodec/hevcdec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.h b/libavcodec/hevcdec.h index 1164af2862..464eb7cd3c 100644 ---

[FFmpeg-devel] [PATCH v2 4/7] lavc/hevc_ps: Add slice parse support for HEVC SCC extension

From: Linjie Fu Signed-off-by: Linjie Fu --- libavcodec/hevcdec.c | 6 ++ libavcodec/hevcdec.h | 4 2 files changed, 10 insertions(+) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index b77df8d89f..cbfcf492a0 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -