On Tue, Aug 25, 2020 at 09:50:04AM +0530, gautamr...@gmail.com wrote:
> From: Gautam Ramakrishnan
>
> The implementation of tag tree encoding was incorrect.
> However, this error was not visible as the current j2k
> encoder encodes only 1 layer.
> This patch fixes tag tree coding for JPEG2000 suc
On Tue, Aug 25, 2020 at 09:50:07AM +0530, gautamr...@gmail.com wrote:
> From: Gautam Ramakrishnan
>
> This patch adds documentation for the utility and usage
> of "layer_rates" option used in the JPEG2000 encoder.
> ---
> doc/encoders.texi | 16
> 1 file changed, 16 insertions(+
On Tue, Aug 25, 2020 at 09:50:06AM +0530, gautamr...@gmail.com wrote:
> From: Gautam Ramakrishnan
>
> This patch allows setting a compression ratio and to
> set multiple layers. The user has to input a compression
> ratio for each layer.
> The per layer compression ration can be set as follows:
>
On Tue, Aug 25, 2020 at 09:50:05AM +0530, gautamr...@gmail.com wrote:
> From: Gautam Ramakrishnan
>
> This patch makes the ff_jpeg2000_cleanup
> function take in an extra parameter which
> indicates whether it is called from the
> encoder or decoder.
> ---
> libavcodec/j2kenc.c | 2 +-
> li
Steps to reproduce:
1. ./configure --enable-debug=3 --disable-libx264 && make install
2. ffmpeg -i input.mp4 -profile:v baseline output.mp4 -y
you will see a crash like this:
[mpeg4 @ 0x575854c0] [Eval @ 0x7fffbf80] Undefined constant or missing
'(' in 'baseline'
[mpeg4 @ 0x575854c0]
On Tue, Aug 25, 2020 at 2:09 PM Michael Niedermayer
wrote:
>
> On Tue, Aug 25, 2020 at 09:50:06AM +0530, gautamr...@gmail.com wrote:
> > From: Gautam Ramakrishnan
> >
> > This patch allows setting a compression ratio and to
> > set multiple layers. The user has to input a compression
> > ratio fo
On Tue, Aug 25, 2020 at 2:07 PM Michael Niedermayer
wrote:
>
> On Tue, Aug 25, 2020 at 09:50:07AM +0530, gautamr...@gmail.com wrote:
> > From: Gautam Ramakrishnan
> >
> > This patch adds documentation for the utility and usage
> > of "layer_rates" option used in the JPEG2000 encoder.
> > ---
> >
On 8/25/20, Andreas Rheinhardt wrote:
> Paul B Mahol:
>> Signed-off-by: Paul B Mahol
>> ---
>> [WIP] Missing video decoder.
>> ---
>> libavformat/Makefile | 1 +
>> libavformat/allformats.c | 1 +
>> libavformat/moflex.c | 291 +++
>> 3 files chang
Paul B Mahol:
> On 8/25/20, Andreas Rheinhardt wrote:
>> Paul B Mahol:
>>> Signed-off-by: Paul B Mahol
>>> ---
>>> [WIP] Missing video decoder.
>>> ---
>>> libavformat/Makefile | 1 +
>>> libavformat/allformats.c | 1 +
>>> libavformat/moflex.c | 291 +
On Tue, Aug 25, 2020 at 1:18 PM Michael Niedermayer
wrote:
>
> On Tue, Aug 25, 2020 at 09:50:04AM +0530, gautamr...@gmail.com wrote:
> > From: Gautam Ramakrishnan
> >
> > The implementation of tag tree encoding was incorrect.
> > However, this error was not visible as the current j2k
> > encoder
From: Gautam Ramakrishnan
This patch allows setting a compression ratio and to
set multiple layers. The user has to input a compression
ratio for each layer.
The per layer compression ration can be set as follows:
-layer_rates "r1,r2,...rn"
for to create 'n' layers.
---
doc/encoders.texi
From: Gautam Ramakrishnan
This patch makes the tag_tree_zero() and tag_tree_size()
functions non static and callable from other files.
---
libavcodec/jpeg2000.c | 12 ++--
libavcodec/jpeg2000.h | 3 +++
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/libavcodec/jpeg2000.c
From: Gautam Ramakrishnan
The implementation of tag tree encoding was incorrect.
However, this error was not visible as the current j2k
encoder encodes only 1 layer.
This patch fixes tag tree coding for JPEG2000 such tag
tree coding would work for multi layer encoding.
---
libavcodec/j2kenc.c
Similar to what we do in libaomdec.c.
Signed-off-by: Derek Buitenhuis
---
libavcodec/libdav1d.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c
index fd801c6fd5..3af7ef4edc 100644
--- a/libavcodec/libdav1d.c
+++ b/libavcodec/libdav1d.c
@@ -274,6
Forgotten after fdd93eabfb2644f541f7aac9943abce26776ea73.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/avfilter.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index dd8074e462..cf3b4e461d 100644
--- a/
These names are always the same, so not using duplicates saves
allocations, checks for the allocations as well as frees.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/af_anequalizer.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/libavfilter/af_ane
These names leak because freeing them in the uninit function has been
forgotten. Instead of adding the freeing code, this commit stops
allocating these names. They are constants anyway.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_premultiply.c | 16
1 file changed, 4 in
It has been forgotten to free the name of the second outpad if attaching
the first one to the AVFilterContext fails. Fixing this is easy: Only
prepare the second outpad after (and if) the first outpad has been
successfully attached to the AVFilterContext.
Signed-off-by: Andreas Rheinhardt
---
li
These names are always the same, so not using duplicates saves
allocations, checks for the allocations as well as frees.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_fieldmatch.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/libavfilter/vf_field
These names are mostly the same, so not using duplicates saves
allocations, checks for the allocations as well as frees.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/f_ebur128.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/libavfilter/f_ebur128.c b
When creating the output video, a temporary buffer is used whose elments
are only used three times: Once to store a value in it, once more to add
the value of the preceding element of the temporary buffer to the current
element and once more to add the current i. element to the i. element of
anothe
Signed-off-by: Andreas Rheinhardt
---
libavfilter/src_movie.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c
index 64d82e9df1..eeb8609855 100644
--- a/libavfilter/src_movie.c
+++ b/libavfilter/src_movie.c
@@ -213,7 +213,6 @
These names are always the same, so not using duplicates saves
allocations, checks for the allocations as well as frees.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_bm3d.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/libavfilter/vf_bm3d.c b/li
The aiir filter adds output pads in its init function. Each of these
output pads had a name which was allocated and to be freed in the uninit
function. Given that the aiir filter has between one and two outputs,
one output pad's name was freed unconditionally and a second was freed
conditionally.
If an error happens between allocating a string intended to be used as
an inpad's name and attaching it to its input pad, the string leaks.
Fix this by inserting the inpad directly after allocating its string.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_signature.c | 9 -
1 file
These names are always the same, so not using duplicates saves
allocations, checks for the allocations as well as frees.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/avf_aphasemeter.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/libavfilter/avf_ap
If the names are always the same, they need not be duplicated; doing so
saves allocations, checks for the allocations as well as frees.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/af_afir.c | 30 +++---
1 file changed, 7 insertions(+), 23 deletions(-)
diff --git a/
The headphone filter uses a variable number of inpads and allocates them
in its init function; if all goes well, the number of inpads coincides
with a number stored in the filter's private context. Yet if allocating a
subsequent inpad fails, the uninit function nevertheless uses the number
stored i
The signature filter uses qsort, but its compare function doesn't have
the signature required of such a function; therefore it casts the function
pointer to void. Yet this is wrong:
C90 only guarantees that one can convert a pointer to any incomplete
type or object type to void* and back with the
The amerge filter uses a variable number of inpads and allocates them
in its init function; if all goes well, the number of inpads coincides
with a number stored in the filter's private context. Yet if allocating a
subsequent inpad fails, the uninit function nevertheless uses the number
stored in t
Signed-off-by: Andreas Rheinhardt
---
It is not intended for these added lines to live very long: One can add
flags to AVFilter.flags_internal that indicate that this filter wants
the inpads/outpads' names be freed generically. This will allow to
remove most of the code for freeing in/outpads. The
These names are always the same, so not using duplicates saves
allocations, checks for the allocations as well as frees.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_decimate.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/libavfilter/vf_decimate
In case the multichannel HRIR mode was enabled, an error could happen
between allocating a channel layouts list and attaching it to its target
destination. If an error happened, the list would leak. This is fixed by
attaching the list to its target directly after its allocation.
Signed-off-by: And
On 8/25/2020 10:50 AM, Derek Buitenhuis wrote:
> Similar to what we do in libaomdec.c.
>
> Signed-off-by: Derek Buitenhuis
> ---
> libavcodec/libdav1d.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c
> index fd801c6fd5..3af7ef4edc 100644
>
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_signature.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c
index 32a6405e14..1ed93051b6 100644
--- a/libavfilter/vf_signature.c
+++ b/libavfilter/vf_signature
On 8/25/2020 6:35 AM, Xu Guangxin wrote:
> Steps to reproduce:
> 1. ./configure --enable-debug=3 --disable-libx264 && make install
> 2. ffmpeg -i input.mp4 -profile:v baseline output.mp4 -y
>
> you will see a crash like this:
> [mpeg4 @ 0x575854c0] [Eval @ 0x7fffbf80] Undefined constant or
Hi James,
thanks for the review.
We can't assume s->avctx == avctx. in
https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/smvjpegdec.c, it
will be assigned to a new allocated codec context.
Currently, it's no mpeg video encoder doing this, but in the future, some
subclass maybe.
On Tue, Aug 2
Generate algorithmic music using riffs, lindenmayer systems, cellular automaton
and rhythm algorithms.
Changelog |1 +
configure |4 +
doc/filters.texi | 146
libavfilter/Makefile |1 +
libavfilte
On 8/25/2020 12:08 PM, Guangxin Xu wrote:
> Hi James,
> thanks for the review.
> We can't assume s->avctx == avctx. in
> https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/smvjpegdec.c, it
> will be assigned to a new allocated codec context.
> Currently, it's no mpeg video encoder doing this,
Am Mi., 24. Juni 2020 um 12:02 Uhr schrieb Moritz Barsnick :
>
> On Tue, Jun 23, 2020 at 20:43:34 +0200, Carl Eugen Hoyos wrote:
> > Pushed with that change, Carl Eugen
>
> I suggest backporting this to 4.3, where MediaFoundation support was
> added (and this issue is present).
Done.
Carl Eugen
_
Am Do., 25. Juni 2020 um 00:04 Uhr schrieb Carl Eugen Hoyos
:
> Attached patch fixes ticket #8638 and the only other occurrence of
> fopen() without b in doc/examples.
Patch applied.
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http
Andreas Rheinhardt (12020-08-25):
> Forgotten after fdd93eabfb2644f541f7aac9943abce26776ea73.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/avfilter.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
Of course ok.
Regards,
--
Nicolas George
___
Andreas Rheinhardt (12020-08-25):
> When creating the output video, a temporary buffer is used whose elments
> are only used three times: Once to store a value in it, once more to add
> the value of the preceding element of the temporary buffer to the current
> element and once more to add the curr
Am Fr., 22. Mai 2020 um 22:39 Uhr schrieb Michael Niedermayer
:
>
> On Thu, May 21, 2020 at 10:05:57PM +0200, Carl Eugen Hoyos wrote:
> > Hi!
> >
> > When receiving jpeg frames via rtp, libavformat currently writes a
> > wrong JFIF version (2.01 instead of 1.02), see also 85ca012ba68.
> > Attached
On 8/25/20, Andreas Rheinhardt wrote:
> When creating the output video, a temporary buffer is used whose elments
> are only used three times: Once to store a value in it, once more to add
> the value of the preceding element of the temporary buffer to the current
> element and once more to add the
On 8/24/2020 2:08 PM, James Almer wrote:
> This follows the spec and will come in handy in a following commit.
>
> Signed-off-by: James Almer
> ---
> libavcodec/cbs_av1.h | 1 +
> libavcodec/cbs_av1_syntax_template.c | 9 +
> 2 files changed, 6 insertions(+), 4 deletions(
On 8/23/2020 8:47 PM, James Almer wrote:
> Section 5.9.7 of the spec states
>
> UpscaledWidth = RefUpscaledWidth[ ref_frame_idx[ i ] ]
> FrameWidth= UpscaledWidth
> FrameHeight = RefFrameHeight[ ref_frame_idx[ i ] ]
> RenderWidth = RefRenderWidth[ ref_frame_idx[ i ] ]
>
On Tue, Aug 25, 2020 at 01:28:56AM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> [WIP] Missing video decoder.
[...]
> +static int moflex_probe(const AVProbeData *p)
> +{
> +if (p->buf[0] != 0x4C && p->buf[1] != 0x32)
> +return 0;
> +
> +return AVPROBE_SCORE_MAX
On 24/08/2020 00:47, James Almer wrote:
> Section 5.9.7 of the spec states
>
> UpscaledWidth = RefUpscaledWidth[ ref_frame_idx[ i ] ]
> FrameWidth= UpscaledWidth
> FrameHeight = RefFrameHeight[ ref_frame_idx[ i ] ]
> RenderWidth = RefRenderWidth[ ref_frame_idx[ i ] ]
>
On 8/25/2020 6:38 PM, Derek Buitenhuis wrote:
> On 24/08/2020 00:47, James Almer wrote:
>> Section 5.9.7 of the spec states
>>
>> UpscaledWidth = RefUpscaledWidth[ ref_frame_idx[ i ] ]
>> FrameWidth= UpscaledWidth
>> FrameHeight = RefFrameHeight[ ref_frame_idx[ i ] ]
>> Render
On Tue, Aug 25, 2020 at 11:37:59AM -0300, James Almer wrote:
> On 8/25/2020 6:35 AM, Xu Guangxin wrote:
> > Steps to reproduce:
> > 1. ./configure --enable-debug=3 --disable-libx264 && make install
> > 2. ffmpeg -i input.mp4 -profile:v baseline output.mp4 -y
> >
> > you will see a crash like this:
Signed-off-by: Michael Niedermayer
---
libavcodec/mpegvideo_enc.c | 56 +++---
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 09697d89c8..bcc13761ea 100644
--- a/libavcodec/mpegvideo_enc
On Tue, Aug 25, 2020 at 07:25:44PM +0530, gautamr...@gmail.com wrote:
> From: Gautam Ramakrishnan
>
> The implementation of tag tree encoding was incorrect.
> However, this error was not visible as the current j2k
> encoder encodes only 1 layer.
> This patch fixes tag tree coding for JPEG2000 suc
On Wed, Aug 26, 2020 at 4:04 AM Michael Niedermayer
wrote:
>
> On Tue, Aug 25, 2020 at 07:25:44PM +0530, gautamr...@gmail.com wrote:
> > From: Gautam Ramakrishnan
> >
> > The implementation of tag tree encoding was incorrect.
> > However, this error was not visible as the current j2k
> > encoder
Call srt_epoll_release() to avoid fd leak on libsrt_open() error.
---
libavformat/libsrt.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
index 4025b24976..6da372081e 100644
--- a/libavformat/libsrt.c
+++ b/libavform
55 matches
Mail list logo
