Re: [FFmpeg-devel] [PATCH 3/5] lavf/libkvazaar: export encoded frame stats

On Tue, Aug 18, 2020 at 10:41 AM myp...@gmail.com wrote: > > On Mon, Aug 17, 2020 at 7:08 PM Joose Sainio wrote: > > > > On 7.8.2020 5.40, myp...@gmail.com wrote: > > > On Sun, Jul 26, 2020 at 8:45 PM Jun Zhao wrote: > > >> From: Jun Zhao > > >> > > >> Export choosen pict_type and qp. > > >> >

[FFmpeg-devel] [PATCH 2/3] lavf/davs2.c: Rename as avs2dec.c for better understanding

From: hwren Signed-off-by: hwren --- libavformat/{davs2.c => avs2dec.c} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename libavformat/{davs2.c => avs2dec.c} (100%) diff --git a/libavformat/davs2.c b/libavformat/avs2dec.c similarity index 100% rename from libavformat/davs2.c rename t

[FFmpeg-devel] [PATCH 3/3] lavc/avs2_parser.c, lavf/avs2dec.c: fix code style

From: hwren Signed-off-by: hwren --- libavcodec/avs2_parser.c | 6 +++--- libavformat/avs2dec.c| 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/avs2_parser.c b/libavcodec/avs2_parser.c index 02af08f079..54f687142f 100644 --- a/libavcodec/avs2_parser.c ++

[FFmpeg-devel] [PATCH 1/3] lavc/avs2_parser.c, lavf/davs2.c: Add AVS2_* prefix

From: hwren Add AVS2_* prefix to macro definitions to avoid confusion Signed-off-by: hwren --- libavcodec/avs2_parser.c | 10 +- libavformat/davs2.c | 20 ++-- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/avs2_parser.c b/libavcodec/av

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

Ashutosh Pradhan (12020-08-20): > I think it would be a bit difficult considering we have to read SoundFont > files, read and write midi events, code for the sequencer, synth, etc. I mean precisely without doing all that. Your code produces notes at certain times: can they be made available, their

[FFmpeg-devel] [PATCH v2] Set AVSTREAM_PARSE_HEADERS flag for AV1 MP4 streams It help initialize chroma format and other info properly Chroma format wasn't correct if I use below code: avformat_find_s

--- libavformat/mov.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1532e74d67..4c8598c992 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2423,6 +2423,9 @@ static int mov_finalize_stsd_codec(MOVContext *c, AVIOContext *pb, case

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

Paul B Mahol (12020-08-19): > Disagree, beside, you have already written correct, always bitexact > synthesizer > that does not depend on external tools. So use that for testing? You mean asrc_sine? It is not enough to exercise various code paths, this is precisely the issue. -- Nicolas Georg

Re: [FFmpeg-devel] [PATCH 4/4] ffplay: do not set redundant channel count on abuffersink.

Marton Balint (12020-08-20): > Why it is better if we don't set it? It is how the API was supposed to be used from the start: these values set the formats list for buffersink. If you said you accept anything with two channels, then you do not need to say you accept stereo, it is already said. It w

Re: [FFmpeg-devel] [PATCH 4/4] ffplay: do not set redundant channel count on abuffersink.

On Thu, 20 Aug 2020, Nicolas George wrote: Marton Balint (12020-08-20): Why it is better if we don't set it? It is how the API was supposed to be used from the start: these values set the formats list for buffersink. If you said you accept anything with two channels, then you do not need to

[FFmpeg-devel] [PATCH] lavc/qsv: fix transcode with interlaced clip

1. qsvdec: set output surface info correctly. 2. qsvvpp: set output surface/frame's picture struct according to input if deinterlace option is not enabled. This fix will make interlace transcode works: ffmpeg -init_hw_device qsv=hw:/dev/dri/renderD128 -filter_hw_device \ hw -hwaccel_output_format

[FFmpeg-devel] [PATCH] avfilter: add shufflepixels video filter

Hi, patch attached. 0001-avfilter-add-shufflepixels-video-filter.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-de

[FFmpeg-devel] [PATCH 4/4] avcodec/tiff: Check jpeg context against jpeg frame parameters

Fixes: out of array access Fixes: 24825/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-6326925027704832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 5 + 1 file

[FFmpeg-devel] [PATCH 3/4] avcodec/tiff: Restrict tag order based on specification

"The entries in an IFD must be sorted in ascending order by Tag. Note that this is not the order in which the fields are described in this document." This way various dimensions, sample and bit sizes cannot be changed at arbitrary times which reduces the potential for bugs. The tag reading code

[FFmpeg-devel] [PATCH 2/4] avcodec/tiff: Avoid abort with DNG RAW TIFF with YA8

Fixes: Assertion failure Fixes: 24707/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-5179910197608448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 2 +- 1 file chang

[FFmpeg-devel] [PATCH 1/4] avcodec/tiff: Check the linearization table size

Fixes: out of array access Fixes: 24604/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-4843529818603520 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 4 +++- 1 file c

Re: [FFmpeg-devel] [PATCH 2/3] lavf/davs2.c: Rename as avs2dec.c for better understanding

Incomplete submission. Please refer to the new version patches. At 2020-08-20 15:05:14, hwr...@126.com wrote: >From: hwren > >Signed-off-by: hwren >--- > libavformat/{davs2.c => avs2dec.c} | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename libavformat/{davs2.c => avs2

[FFmpeg-devel] [PATCH v2 3/3] lavc/avs2_parser.c, lavf/avs2dec.c: fix code style

From: hwren Signed-off-by: hwren --- libavcodec/avs2_parser.c | 6 +++--- libavformat/avs2dec.c| 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/avs2_parser.c b/libavcodec/avs2_parser.c index 02af08f079..54f687142f 100644 --- a/libavcodec/avs2_parser.c ++

[FFmpeg-devel] [PATCH v2 2/3] lavf/davs2.c: Rename as avs2dec.c for better understanding

From: hwren Signed-off-by: hwren --- libavformat/Makefile | 2 +- libavformat/{davs2.c => avs2dec.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename libavformat/{davs2.c => avs2dec.c} (100%) diff --git a/libavformat/Makefile b/libavformat/Makefile index cbb33fe37c..85

[FFmpeg-devel] [PATCH v2 1/3] lavc/avs2_parser.c, lavf/davs2.c: Add AVS2_* prefix

From: hwren Add AVS2_* prefix to macro definitions to avoid confusion Signed-off-by: hwren --- libavcodec/avs2_parser.c | 10 +- libavformat/davs2.c | 20 ++-- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/avs2_parser.c b/libavcodec/av

Re: [FFmpeg-devel] [PATCH] avformat/siff: Reject audio packets without audio stream

On Wed, Aug 19, 2020 at 09:36:38PM +0200, Paul B Mahol wrote: > On 8/13/20, Michael Niedermayer wrote: > > Fixes: Assertion failure > > Fixes: > > 24612/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6600899842277376.fuzz > > > > Found-by: continuous fuzzing process > > https://github.com/go

Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

On Wed, Aug 19, 2020 at 17:51:01 +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch makes the ff_jpeg2000_cleanup > function take in an extra parameter which > indicates whether it is called from the > encoder or decoder. I fail to see an explanation why, ... > -void f

Re: [FFmpeg-devel] [PATCH] avutil/video_enc_params: fix code comment

leozhang 于2020年8月20日周四 下午1:53写道： > > zhilizhao 于2020年8月13日周四 下午12:55写道： > > > > > > > > > On Aug 13, 2020, at 11:57 AM, leozhang wrote: > > > > > > Signed-off-by: leozhang > > > --- > > > libavutil/video_enc_params.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

On Wed, Aug 19, 2020 at 17:51:02 +0530, gautamr...@gmail.com wrote: Minor nits: > +static void compute_rates(Jpeg2000EncoderContext* s) > +{ > +int i, j; > +int layno, compno; > +for (i = 0; i < s->numYtiles; i++) { > +for (j = 0; j < s->numXtiles; j++) { > +Jpeg20

Re: [FFmpeg-devel] [PATCH v4] avformat/mxfdec: Read video range from PictureDescriptor

sön 2020-08-16 klockan 11:43 +0100 skrev Harry Mallon: > > > > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket4328/01_Bad_Frame_2.24.mxf > > > > > > > > is not detected correctly for some reason. > > > > > > > > The MXF specs seems ambigous: > > > > > > > > Color Range is a Property, whose un

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Fix memleak when error happens after creating DV stream

On Wed, Aug 19, 2020 at 12:00:37AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > The memleak can be reproduced with e.g. the first 163 bytes of > https://samples.ffmpeg.org/archive/all/avi+dvvideo+pcm_s16le++ffmpeg-avidec554-crash.avi > > libavformat/avidec.c | 31

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

tis 2020-08-18 klockan 15:21 +0100 skrev Mark Himsley: > Sorry to drag up this old thread: > > On Mon, 19 Aug 2019 at 17:55, Thomas Mundt > wrote: > ... > > I can give you the parameters that I use for IMX50. Not sure if these are > > the best. Got the intra matrix values from an original imx fil

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Fix memleak when error happens after creating DV stream

Michael Niedermayer: > On Wed, Aug 19, 2020 at 12:00:37AM +0200, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> The memleak can be reproduced with e.g. the first 163 bytes of >> https://samples.ffmpeg.org/archive/all/avi+dvvideo+pcm_s16le++ffmpeg-avidec554-crash.avi >> >>

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

On Sun, Aug 16, 2020 at 18:25:12 +0200, Paul B Mahol wrote: > On 8/16/20, Paul B Mahol wrote: > > Please help porting this to linux and 64bit calling convention. > > New patch attached. > > This one does not allocate stack on x32. I wanted to benchmark on several machines (newest I have is a Hasw

Re: [FFmpeg-devel] [PATCH 3/4] lavfi/buffersink: add a summary documentation of the API.

Paul B Mahol (12020-08-19): > On 8/14/20, Nicolas George wrote: > > Signed-off-by: Nicolas George > > --- > > libavfilter/buffersink.h | 36 > > 1 file changed, 36 insertions(+) > > > > LGTM Thanks. Pushed. Regards, -- Nicolas George signature.asc De

Re: [FFmpeg-devel] [PATCH 2/4] lavfi/buffersink: clearly document that the Params struct are unused.

Paul B Mahol (12020-08-19): > On 8/14/20, Nicolas George wrote: > > Signed-off-by: Nicolas George > > --- > > libavfilter/buffersink.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > LGTM Thanks, pushed. Regards, -- Nicolas George signature.asc Description: PGP signatu

Re: [FFmpeg-devel] [PATCH 4/4] ffplay: do not set redundant channel count on abuffersink.

Marton Balint (12020-08-20): > > It is how the API was supposed to be used from the start: these values > > set the formats list for buffersink. If you said you accept anything > > with two channels, then you do not need to say you accept stereo, it is > > already said. It was already documented in

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: RtmpSampleAccess no longer breaks stream detection

On Wed, Aug 19, 2020 at 09:06:54AM +0200, Peter van der Spek wrote: > Since release 4.2, FFmpeg fails to detect the correct streams in an RTMP > stream that contains a |RtmpSampleAccess AMF object prior to the > onMetaData AMF object. In the debug log it would show "[flv] Unknown > type |RtmpSample

Re: [FFmpeg-devel] [PATCH] libavcodec/proresdec2: Setup qmat_chroma according to RDD36

On Wed, Aug 19, 2020 at 09:32:47PM +0100, Harry Mallon wrote: > Signed-off-by: Harry Mallon > --- > libavcodec/proresdec2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are to

Re: [FFmpeg-devel] [PATCH] libavformat/r3d.c: Fix Use-of-uninitialized-value in filename.

On Wed, Aug 19, 2020 at 03:51:02PM -0700, Thierry Foucu wrote: > While reading the filename tag, it mays return a EOF and we are still > copying the file with uninitialized value. > --- > libavformat/r3d.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavformat/r3

Re: [FFmpeg-devel] [PATCH v2 2/3] lavf/davs2.c: Rename as avs2dec.c for better understanding

On 8/20/2020 6:11 AM, hwr...@126.com wrote: > From: hwren > > Signed-off-by: hwren > --- > libavformat/Makefile | 2 +- > libavformat/{davs2.c => avs2dec.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename libavformat/{davs2.c => avs2dec.c} (100%) > > diff --git a/

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

On Thu, Aug 20, 2020 at 12:55 AM Andreas Rheinhardt wrote: > > Gautam Ramakrishnan: > > On Wed, Aug 19, 2020 at 5:51 PM wrote: > >> > >> From: Gautam Ramakrishnan > >> > >> This patch allows setting a compression ratio and to > >> set multiple layers. The user has to input a compression > >> rat

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

On Thu, Aug 20, 2020 at 3:36 PM Moritz Barsnick wrote: > > On Wed, Aug 19, 2020 at 17:51:02 +0530, gautamr...@gmail.com wrote: > > Minor nits: > > > +static void compute_rates(Jpeg2000EncoderContext* s) > > +{ > > +int i, j; > > +int layno, compno; > > +for (i = 0; i < s->numYtiles; i+

[FFmpeg-devel] [PATCH] libavfilter/vf_libvmaf: document log_fmt = csv

Signed-off-by: Harry Mallon --- libavfilter/vf_libvmaf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c index 14c3216b3a..4d49127efc 100644 --- a/libavfilter/vf_libvmaf.c +++ b/libavfilter/vf_libvmaf.c @@ -74,7 +74,7 @@ type

[FFmpeg-devel] [PATCH v5 2/2] libavformat/mxfenc: color_range should be inclusive

MXF CDCI color range was being set to (1

[FFmpeg-devel] [PATCH v5 1/2] avformat/mxfdec: Read video range from CDCIEssenceDescriptor

* Capture black_ref, white_ref and color_range and recognise full and narrow range. Signed-off-by: Harry Mallon --- libavformat/mxfdec.c | 37 ++ tests/ref/fate/mxf-probe-dnxhd | 2 +- tests/ref/fate/mxf-probe-dv25 | 2 +- 3 files changed, 39 insert

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

On Thu, Aug 20, 2020 at 1:10 PM Nicolas George wrote: > Ashutosh Pradhan (12020-08-20): > > I think it would be a bit difficult considering we have to read SoundFont > > files, read and write midi events, code for the sequencer, synth, etc. > > I mean precisely without doing all that. Your code p

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

On 8/20/2020 7:53 AM, Moritz Barsnick wrote: > On Sun, Aug 16, 2020 at 18:25:12 +0200, Paul B Mahol wrote: >> On 8/16/20, Paul B Mahol wrote: >>> Please help porting this to linux and 64bit calling convention. >> >> New patch attached. >> >> This one does not allocate stack on x32. > > I wanted t

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

Ashutosh Pradhan (12020-08-20): > But, for that, we need to store the frequency information of each > instrument hence would be the same as reading SoundFont files, I think. > Also, the duration output would be the same as a note-on and note-off event. Les me rephrase the question: how hard would

Re: [FFmpeg-devel] [PATCH v5 1/3] [RFC] lavc: add FLIF decoding support

Hello, On Wed, 19 Aug 2020 21:05:41 +0200 Paul B Mahol wrote: [...] > > > > > > All these corrections have been made by me locally, but I would > > like to wait for some further review (self and otherwise) before > > posting again. > > Please make use of av_clip and FFMIN/FFMAX macros. > We

Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

On Thu, Aug 20, 2020 at 3:02 PM Moritz Barsnick wrote: > > On Wed, Aug 19, 2020 at 17:51:01 +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > This patch makes the ff_jpeg2000_cleanup > > function take in an extra parameter which > > indicates whether it is called from the >

Re: [FFmpeg-devel] [PATCH v4]libavfilter/asrc_atone.c : generate algorithmic music

On Thu, Aug 20, 2020 at 7:58 PM Nicolas George wrote: > Ashutosh Pradhan (12020-08-20): > > But, for that, we need to store the frequency information of each > > instrument hence would be the same as reading SoundFont files, I think. > > Also, the duration output would be the same as a note-on an

Re: [FFmpeg-devel] [PATCH v4] avformat/libsrt: Close listen fd in listener mode

On Thu, 13 Aug 2020, Nicolas Sugino wrote: In listener mode the first fd is not closed when libsrt_close() is called because it is overwritten by the new accept fd. Added the listen_fd to the context to properly close it when libsrt_close() is called. Fixes trac ticket #8372 Thanks, applie

[FFmpeg-devel] [PATCH 3/4] lavfi: check the validity of formats lists.

Part of the code expect valid lists, in particular no duplicates. These tests allow to catch bugs in filters (unlikely but possible) and to give a clear message when the error comes from the user ((a)formats) or the application (buffersink). Signed-off-by: Nicolas George --- libavfilter/avfilter

[FFmpeg-devel] [PATCH 4/4] lavfi/buffersink: remove redundant channel layouts.

The channel_layouts and channel_counts options set what buffersink is supposed to accept. If channel_counts contains 2, then stereo is already accepted, there is no point in having it in channel_layouts too. This was not properly documented until now, so only print a warning. Signed-off-by: Nicola

[FFmpeg-devel] [PATCH 2/4] lavfi/formats: simplify a macro parameters.

Signed-off-by: Nicolas George --- libavfilter/formats.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Unchanged and trivial. diff --git a/libavfilter/formats.c b/libavfilter/formats.c index c0daf198c8..64d94a374a 100644 --- a/libavfilter/formats.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH 1/4] lavfi: regroup formats lists in a single structure.

It will allow to refernce it as a whole without clunky macros. Most of the changes have been automatically made with sed: sed -i ' s/-> *in_formats/->incfg.formats/g; s/-> *out_formats/->outcfg.formats/g; s/-> *in_channel_layouts/->incfg.channel_layouts/g; s/-> *out_channel_layouts/->outc

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

Gautam Ramakrishnan: > On Thu, Aug 20, 2020 at 12:55 AM Andreas Rheinhardt > wrote: >> >> Gautam Ramakrishnan: >>> On Wed, Aug 19, 2020 at 5:51 PM wrote: From: Gautam Ramakrishnan This patch allows setting a compression ratio and to set multiple layers. The user has to i

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

Andreas Rheinhardt (12020-08-18): > 1. Adding this struct has also another benefit besides the ones in your > two other patches: One can simplify the freeing process by adding a new > ff_formatscfg_unref() (I'm not sure on the name). This could also be > used in the uninit function of the aformat f

Re: [FFmpeg-devel] [PATCH 6/7] avfilter/formats: Always keep longer references list when merging lists

Andreas Rheinhardt (12020-08-20): > The MERGE_REF() macro is asymmetric by design: The refs of the second > argument are added to the refs of the first argument and the second > argument is freed. The list of the first argument meanwhile is/ought to > be preserved. When swapping, one therefore has

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

On Thu, Aug 20, 2020 at 8:25 PM Andreas Rheinhardt wrote: > > Gautam Ramakrishnan: > > On Thu, Aug 20, 2020 at 12:55 AM Andreas Rheinhardt > > wrote: > >> > >> Gautam Ramakrishnan: > >>> On Wed, Aug 19, 2020 at 5:51 PM wrote: > > From: Gautam Ramakrishnan > > This patch allo

Re: [FFmpeg-devel] [PATCH v2] Set AVSTREAM_PARSE_HEADERS flag for AV1 MP4 streams It help initialize chroma format and other info properly Chroma format wasn't correct if I use below code: avformat_fi

Please fix your commit log and commit title. On Thu, 20 Aug 2020, at 09:43, Vikas Agrawal (Engrg-SW) wrote: > --- > libavformat/mov.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 1532e74d67..4c8598c992 100644 > --- a/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: RtmpSampleAccess no longer breaks stream detection

I suppose that’s okay. It’s in the input stream as well after all. On 20 Aug 2020, 13:19 +0200, Michael Niedermayer , wrote: > On Wed, Aug 19, 2020 at 09:06:54AM +0200, Peter van der Spek wrote: > > Since release 4.2, FFmpeg fails to detect the correct streams in an RTMP > > stream that contains a

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_libvmaf: document log_fmt = csv

On 20-08-2020 07:08 pm, Harry Mallon wrote: Signed-off-by: Harry Mallon --- libavfilter/vf_libvmaf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c index 14c3216b3a..4d49127efc 100644 --- a/libavfilter/vf_libvmaf.c +++

Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

On Thu, Aug 20, 2020 at 20:02:32 +0530, Gautam Ramakrishnan wrote: > On Thu, Aug 20, 2020 at 3:02 PM Moritz Barsnick wrote: > > ... and what it does with this change. Looks like an NOP from the patch > > file alone. > It was done to provide functionality for the next patch in the series. I then s

[FFmpeg-devel] [PATCH v2] libavfilter/vf_libvmaf: document log_fmt = csv

Signed-off-by: Harry Mallon --- doc/filters.texi | 2 +- libavfilter/vf_libvmaf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index d8cd45066a..610cb09a8c 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -12870,7 +12870

[FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

Hi, I gave $SUBJECT a shot. It's a bit of a weird situation, as "https" has an underlying protocol "tls" which handles HTTPS specific stuff, but I guess that's the layer cake the protocols give us. So I needed to add an HTTPS specific option to the "tls" protocol, in order to hand the option thro

Re: [FFmpeg-devel] [PATCH] avcodec/proresenc: add support for PQ and HLG

On Wed, Aug 19, 2020 at 9:23 PM zhilizhao wrote: > > -static const int valid_trc[4]= { AVCOL_TRC_RESERVED0, > AVCOL_TRC_BT709, AVCOL_TRC_UNSPECIFIED, INT_MAX }; > > +static const int valid_trc[6]= { AVCOL_TRC_RESERVED0, > AVCOL_TRC_BT709, AVCOL_TRC_UNSPECIFIED, AVCOL_TRC_SMPTE2084

Re: [FFmpeg-devel] [PATCH V4] dnn_backend_openvino.c: parse options in openvino backend

On 2020-08-20 01:10 +, Guo, Yejun wrote: > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Alexander Strasser > > Sent: 2020年8月20日 4:06 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V4] dnn_backend_openvino.c: parse options >

Re: [FFmpeg-devel] [PATCH 4/4] lavfi: remove request_samples.

Paul B Mahol (12020-08-19): > On 8/12/20, Nicolas George wrote: > > Filters can use min_samples/max_samples if the number is constant > > or activate and ff_inlink_consume_samples(). > > > > LGTM Thanks. Series pushed. Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add disable_all_auto_conversion_filters option.

Alexander Strasser (12020-08-17): > I think the pendulum can swing in both direction here. So the overall > effect is not clear to me. E.g. one developer may think > > "hey what's this -> i need to fix it" > > another might think > > "hey what's this -> better just copy and not look into

Re: [FFmpeg-devel] [PATCH] configure: Add additional glslang libraries to make linking work

This patch is needed to fix compilation on windows using the git master branches of both glslang and ffmpeg, although I don't know what version or commit of glslang started to require it, the earliest record I have of this issue is july 5th. ___ ffmpeg-de

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

On Thu, Aug 20, 2020 at 12:55 AM Paul B Mahol wrote: > > On 8/19/20, Gautam Ramakrishnan wrote: > > On Wed, Aug 19, 2020 at 5:51 PM wrote: > >> > >> From: Gautam Ramakrishnan > >> > >> This patch allows setting a compression ratio and to > >> set multiple layers. The user has to input a compres

Re: [FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

On Thu, 20 Aug 2020, Moritz Barsnick wrote: Add the "http_proxy" option and its handling to the "tls" protocol, pass the option from the "https" protocol. The "https" protocol already defines the "http_proxy" command line option, like the "http" protocol does. The "http" protocol properly honor

[FFmpeg-devel] [PATCH] libavformat/ffmetadecc.c: Fix Use-of-uninitialized-value

Check the return value of sscanf as it can return -1(EOF), for example when the first char in the line is 0x00 --- libavformat/ffmetadec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/ffmetadec.c b/libavformat/ffmetadec.c index 45c92f1ff6..0ea89fe3f3 10064

Re: [FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

Hej Martin, On Thu, Aug 20, 2020 at 22:05:39 +0300, Martin Storsjö wrote: > Even if you do e.g. a plain tls socket (or rtmps, or whatever), you may > want to do the tls connection through a proxy server (be that a socks > proxy or http proxy). Actually, I forget that an HTTP proxy with CONNECT s

Re: [FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

Hej, On Thu, 20 Aug 2020, Moritz Barsnick wrote: Hej Martin, On Thu, Aug 20, 2020 at 22:05:39 +0300, Martin Storsjö wrote: Even if you do e.g. a plain tls socket (or rtmps, or whatever), you may want to do the tls connection through a proxy server (be that a socks proxy or http proxy). Act

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Fix memleak when error happens after creating DV stream

On Thu, Aug 20, 2020 at 12:46:12PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Wed, Aug 19, 2020 at 12:00:37AM +0200, Andreas Rheinhardt wrote: > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> The memleak can be reproduced with e.g. the first 163 bytes of > >> https://sample

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: RtmpSampleAccess no longer breaks stream detection

On Thu, Aug 20, 2020 at 05:14:12PM +0200, Peter van der Spek wrote: > I suppose that’s okay. It’s in the input stream as well after all. well, then the patch is probably ok, but ill wait a few days before applyng so we dont miss something. dont hesitate to remind me to apply this in a few days th

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: keep tabs on layout in sniff_channel_order

On Tue, Aug 18, 2020 at 10:25 PM Jan Ekström wrote: > > This way the layout set at various points can be checked instead > of only having the layout at the end. > --- > libavcodec/aacdec_template.c | 53 ++-- > 1 file changed, 32 insertions(+), 21 deletions(-) > >

[FFmpeg-devel] Curly braces around single statements (was avformat/avidec: Fix memleak when error) happens after creating DV stream

On 2020-08-20 22:32 +0200, Michael Niedermayer wrote: > On Thu, Aug 20, 2020 at 12:46:12PM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > On Wed, Aug 19, 2020 at 12:00:37AM +0200, Andreas Rheinhardt wrote: > > >> Signed-off-by: Andreas Rheinhardt > > >> --- > > >> The memleak can

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add disable_all_auto_conversion_filters option.

On 2020-08-20 19:49 +0200, Nicolas George wrote: > Alexander Strasser (12020-08-17): > > I think the pendulum can swing in both direction here. So the overall > > effect is not clear to me. E.g. one developer may think > > > > "hey what's this -> i need to fix it" > > > > another might think >

[FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

In addition to "no", also allow "no_", "disable" and "disable_". --- On 20/08/2020 18:49, Nicolas George wrote: Alexander Strasser (12020-08-17): Here are some suggestions in no particular order: * auto_conversion_filters (from Marton) I can be ok with this one. I really dislike boolean optio

Re: [FFmpeg-devel] [PATCH 3/5] lavc/libkvazaar: export encoded frame stats

On 15/08/2020 09:48, myp...@gmail.com wrote: On Sun, Aug 9, 2020 at 6:07 AM Mark Thompson wrote: On 26/07/2020 13:26, Jun Zhao wrote: From: Jun Zhao Export choosen pict_type and qp. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 30 ++ 1 file change

Re: [FFmpeg-devel] Curly braces around single statements (was avformat/avidec: Fix memleak when error) happens after creating DV stream

On 20/08/2020 22:20, Alexander Strasser wrote: Please pardon me for bringing this up in the context of this patch. No objections or particular opinion regarding this instance of the problem. Though thinking more globally, I believe it would have a beneficial impact to add the curly braces everyw

Re: [FFmpeg-devel] [PATCH 3/5] lavc/libkvazaar: export encoded frame stats

On 8/15/2020 5:48 AM, myp...@gmail.com wrote: > On Sun, Aug 9, 2020 at 6:07 AM Mark Thompson wrote: >> >> On 26/07/2020 13:26, Jun Zhao wrote: >>> From: Jun Zhao >>> >>> Export choosen pict_type and qp. >>> >>> Signed-off-by: Jun Zhao >>> --- >>> libavcodec/libkvazaar.c | 30 ++

Re: [FFmpeg-devel] [PATCH] fix memory leak in qsvenc.c

Thanks for fixing the memory leak in qsv, it looks good to me. Regards Haihao > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-deve

Re: [FFmpeg-devel] [PATCH V4] dnn_backend_openvino.c: parse options in openvino backend

> -Original Message- > From: ffmpeg-devel On Behalf Of > Alexander Strasser > Sent: 2020年8月21日 0:58 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V4] dnn_backend_openvino.c: parse options > in openvino backend > > On 2020-08-20 01:10 +, Guo,

[FFmpeg-devel] [PATCH V3 1/2] dnn/native: unify error return to DNN_ERROR

Unify all error return as DNN_ERROR, in order to cease model executing when return error in ff_dnn_execute_model_native layer_func.pf_exec Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_native_layer_avgpool.c | 2 +- libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 4 ++-- li

[FFmpeg-devel] [PATCH V3 2/2] dnn/native: add log error message

Signed-off-by: Ting Fu --- V3: 1. modify log_ctx of NativeModel to non-pointer 2. modify log_ctx of NativeModel to ctx 3. delete empty line libavfilter/dnn/dnn_backend_native.c | 67 ++- libavfilter/dnn/dnn_backend_native.h | 5 ++ .../dnn/dnn_backe

[FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load user plugin since libmfx 1.28

MFXVideoUSER_Load call is redundant since libmfx 1.28 --- Fixed merge conflict when applying this patch by 'git am' libavcodec/qsv.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index 17720070f1..56a30ad642 100644 --- a/libavcodec

Re: [FFmpeg-devel] [PATCH v2] libavfilter/vf_libvmaf: document log_fmt = csv

On 20-08-2020 10:09 pm, Harry Mallon wrote: Signed-off-by: Harry Mallon --- doc/filters.texi | 2 +- libavfilter/vf_libvmaf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Pushed as 412d63fe72d4398d0ffd271a9bd30c6ac9fc0deb Thanks, Gyan

[FFmpeg-devel] [PATCH 1/2] avcodec: add av1 hardware acceleration decoder

This av1 decoder is now only used for av1 hardware acceleration decoder. Consider it can be extend to a local decoder like hevc or vp9 in the future, so define its name as "av1" and put it into external libraries codec list. Signed-off-by: Fei Wang --- Changelog | 1 + configure

[FFmpeg-devel] [PATCH 2/2] avcodec: add av1 VAAPI decoder

Example cmdline: ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -v verbose \ -c:v av1 -i input.ivf -pix_fmt yuv420p -vsync passthrough -f md5 \ -y out.md5 Signed-off-by: Fei Wang --- Changelog | 1 + configure | 3 + libavcodec/Makefile |

[FFmpeg-devel] [PATCH V2] dnn: move output name from DNNModel.set_input_output to DNNModule.execute_model

currently, output is set both at DNNModel.set_input_output and DNNModule.execute_model, it makes sense that the output name is provided at model inference time so all the output info is set at a single place. and so DNNModel.set_input_output is renamed to DNNModel.set_input Signed-off-by: Guo, Ye

Re: [FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load user plugin since libmfx 1.28

> -Original Message- > From: ffmpeg-devel On Behalf Of > Haihao Xiang > Sent: Friday, August 21, 2020 7:23 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Haihao Xiang > Subject: [FFmpeg-devel] [PATCH v2 1/2] qsv: needn't load user plugin since > libmfx 1.28 > > MFXVideoUSER_Load call is redund

Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

On Thu, Aug 20, 2020 at 22:49:16 +0100, Mark Thompson wrote: > With this patch, -disable_auto_conversion_filters does what you want. [...] > +if (!po->name) { > +/* Try to match a boolean option with a negative prefix. */ > +for (int i = 0; i < FF_ARRAY_ELEMS(negative_prefixes)

Re: [FFmpeg-devel] [PATCH 4/4] lavfi/buffersink: remove redundant channel layouts.

On Thu, Aug 20, 2020 at 04:50:05PM +0200, Nicolas George wrote: > The channel_layouts and channel_counts options set what buffersink > is supposed to accept. If channel_counts contains 2, then stereo is > already accepted, there is no point in having it in channel_layouts > too. This was not proper

[FFmpeg-devel] [PATCH] Set AVSTREAM_PARSE_HEADERS flag for AV1 MP4 streams

Updated patch as per recommendation. It help initialize chroma format and other info properly Chroma format wasn't correct if I use below code: avformat_find_stream_info(fmtc, NULL); iVideoStream = av_find_best_stream(fmtc, AVMEDIA_TYPE_VIDEO, -1, -1, NULL, 0); eChromaForma