On Wed, Aug 19, 2020 at 03:51:02PM -0700, Thierry Foucu wrote: > While reading the filename tag, it mays return a EOF and we are still > copying the file with uninitialized value. > --- > libavformat/r3d.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavformat/r3d.c b/libavformat/r3d.c > index 7aa0c5a2c3..d013b8c30e 100644 > --- a/libavformat/r3d.c > +++ b/libavformat/r3d.c > @@ -56,6 +56,7 @@ static int r3d_read_red1(AVFormatContext *s) > R3DContext *r3d = s->priv_data; > char filename[258]; > int tmp; > + int ret; > int av_unused tmp2; > AVRational framerate; > > @@ -97,7 +98,9 @@ static int r3d_read_red1(AVFormatContext *s) > r3d->audio_channels = avio_r8(s->pb); // audio channels > av_log(s, AV_LOG_TRACE, "audio channels %d\n", tmp); > > - avio_read(s->pb, filename, 257); > + ret = avio_read(s->pb, filename, 257); > + if (ret < 257) > + return AVERROR_EOF;
will apply with a modification so the error code is not lost if theres is one thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
