[FFmpeg-devel] How to improve GPU command to improve picture quality is the same as CPU transcoding quality

2020-04-16 Thread 陈军
Hi: I use this command # ffmpeg -r 24 -i vbox4071__B4I0335_211922.JPG -pix_fmt yuv444p -r 24 -f yuv4mpegpipe - 2>/dev/null|x265 --crf 16 -o 265-1/vbox4071__B4I0335_211922.265 - --y4m Then i want to use gpu command ffmpeg -r 24 -i vbox4071__B4I0335_211922.JPG -pix_fmt yuv444p

Re: [FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2020-04-16 Thread Paul B Mahol
On 4/16/20, Josh Allmann wrote: > On Tue, 14 Apr 2020 at 01:53, Josh de Kock wrote: >> >> Hi, >> >> On Mon, Apr 13, 2020, at 10:32 PM, Josh Allmann wrote: >> > Hi, >> > >> > On Sat, 24 Mar 2018 at 14:40, Josh de Kock wrote: >> > > >> > > Signed-off-by: Josh de Kock >> > > --- >> > > configure

Re: [FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2020-04-16 Thread Jean-Baptiste Kempf
On Thu, Apr 16, 2020, at 10:44, Paul B Mahol wrote: > > Thanks for the explanation Josh. For what it's worth, count me as > > being at least one API user for which out-of-tree filter capability > > would be very helpful. (And to preempt some other reactions, "use > > gstreamer" is not really helpfu

Re: [FFmpeg-devel] Query regarding codec parsers

2020-04-16 Thread Gautam Ramakrishnan
On Mon, Apr 13, 2020 at 11:00 PM Carl Eugen Hoyos wrote: > > Am Mo., 13. Apr. 2020 um 17:27 Uhr schrieb Gautam Ramakrishnan > : > > > > On Sun, Mar 29, 2020 at 8:34 PM Carl Eugen Hoyos wrote: > > > > > > Am So., 29. März 2020 um 16:45 Uhr schrieb Gautam Ramakrishnan > > > : > > > > > > > > > What

Re: [FFmpeg-devel] How to improve GPU command to improve picture quality is the same as CPU transcoding quality

2020-04-16 Thread Timo Rothenpieler
Please ask user questions on the respective user mailing list. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] [GSOC] libavfilter/vf_colorconstancy.c : Adding weighted greyedge

2020-04-16 Thread YATENDRA SINGH
> > As Michael noted, please resend without broken like feeds. I can't read > most of the diff the way it is now. > > Sorry but I could not understand what broken by newlines mean. Can you explain a little bit further? > Documentation update missing (and eventually changelog). > Is this documenta

[FFmpeg-devel] [PATCH v9 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-16 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 293 +++ libavformat/version.h| 2 +- 5 files changed, 297 insertions(+), 1 deletion(-) cr

[FFmpeg-devel] [PATCH v9 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-16 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 34 ++ libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v9 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-16 Thread Zane van Iperen
Adds support for the soundbank files used by the Pro Pinball series of games. v9: [6] - Rebase after codec_id.h changes - style fixes - Fix an uninitialised variable read v8: [5] - change "goto done" to a return + "goto fail" - Handle truncated files - Fix potential byte counter desyn

[FFmpeg-devel] [PATCH] avfilter/af_astats: measure noise floor

2020-04-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 5 +++ libavfilter/af_astats.c | 80 - 2 files changed, 84 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 856d8ae6ac..985f9b7970 100644 --- a/doc/filters.texi +

[FFmpeg-devel] [PATCH 3/3] lavc/pgs_frame_split_bsf: add bsf to split PGS segments

2020-04-16 Thread John Stebbins
Requried to remux mkv to m2ts --- libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/pgs_frame_split_bsf.c | 176 +++ 3 files changed, 178 insertions(+) create mode 100644 libavcodec/pgs_frame_split_bsf.c diff --git a/libavc

[FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-16 Thread John Stebbins
Required to remux m2ts to mkv --- libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/pgs_frame_merge_bsf.c | 152 +++ 3 files changed, 154 insertions(+) create mode 100644 libavcodec/pgs_frame_merge_bsf.c diff --git a/libavc

[FFmpeg-devel] [PATCH 2/3] lavf/matroskaenc: add PGS merge to auto bsf list

2020-04-16 Thread John Stebbins
PGS segments must be merged to one packet for muxing to mkv --- libavformat/matroskaenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 060e8b7816..6d88fcd784 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-16 Thread Nicolas George
Sorry, forgot to reply to that. Limin Wang (12020-04-04): > the md5 framecrc is generated by libavformat/tests/movenc.c, I have no > clue how the movenc testing work and how to get the real input to check why > the frame isn't bitexact as I haven't see any subtitle track. Well, check: re-run the

[FFmpeg-devel] [PATCH 1/4] lavfi/formats: add ff_formats_pixdesc_filter().

2020-04-16 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/formats.c | 41 + libavfilter/formats.h | 10 ++ 2 files changed, 51 insertions(+) I need it in new code. diff --git a/libavfilter/formats.c b/libavfilter/formats.c index 33c64668a0..784f604483 10064

[FFmpeg-devel] [PATCH 2/4] lavfi/vf_crop: use ff_formats_pixdesc_filter().

2020-04-16 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/vf_crop.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 502defd0a5..3d5cb95f78 100644 --- a/libavfilter/vf_crop.c +++ b/libavfilter/vf_crop.c @@ -94,24 +9

[FFmpeg-devel] [PATCH 4/4] lavfi/tests/formats: reindent.

2020-04-16 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/tests/formats.c | 136 ++-- 1 file changed, 68 insertions(+), 68 deletions(-) diff --git a/libavfilter/tests/formats.c b/libavfilter/tests/formats.c index d8b8079ef6..ee497f3b90 100644 --- a/libavfilter/tests/formats.c

[FFmpeg-devel] [PATCH 3/4] lavfi/formats: remove dead code.

2020-04-16 Thread Nicolas George
Move the contents of all_channel_layouts.inc directly into libavfilter/tests/formats.c. Signed-off-by: Nicolas George --- libavfilter/all_channel_layouts.inc | 68 --- libavfilter/formats.c | 10 libavfilter/tests/formats.c | 72

Re: [FFmpeg-devel] [PATCH] avfilter/af_astats: measure noise floor

2020-04-16 Thread Paul B Mahol
On 4/16/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi| 5 +++ > libavfilter/af_astats.c | 80 - > 2 files changed, 84 insertions(+), 1 deletion(-) > Will apply. ___ ffmp

Re: [FFmpeg-devel] [PATCH] avfilter: add maskedthreshold filter

2020-04-16 Thread Paul B Mahol
On 4/15/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 15 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_maskedthreshold.c | 298 +++ > 4 files changed, 31

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-16 Thread Paul B Mahol
On 4/13/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 19 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_xmedian.c | 108 +-- > 4 files changed, 124 insertions(+), 5

Re: [FFmpeg-devel] [PATCH] avfilter/af_astats: measure noise floor

2020-04-16 Thread Derek Buitenhuis
On 16/04/2020 17:11, Paul B Mahol wrote: > Will apply. Please wait more than an hour and a half. Timezones exist. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH 1/4] lavfi/formats: add ff_formats_pixdesc_filter().

2020-04-16 Thread Derek Buitenhuis
On 16/04/2020 16:28, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/formats.c | 41 + > libavfilter/formats.h | 10 ++ > 2 files changed, 51 insertions(+) (Just a commnt out of curiosity.) Are there more filters than vf_

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-04-16 Thread Philip Langdale
On Tue, 10 Mar 2020 16:33:41 -0300 James Almer wrote: > > I can withdraw this patch (And remove the relevant chunks from the > following two) if this function was effectively not meant for > encoders. Also maybe poke Timo regarding nvenc flushing, to see why > it is needed and if there's an alter

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-16 Thread Derek Buitenhuis
On 16/04/2020 17:10, Paul B Mahol wrote: > Will apply. Your behavior here is still unacceptable. You have dismissed or ignore both comments without any given reason. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailma

Re: [FFmpeg-devel] [PATCH 1/4] lavfi/formats: add ff_formats_pixdesc_filter().

2020-04-16 Thread Nicolas George
Derek Buitenhuis (12020-04-16): > (Just a commnt out of curiosity.) > > Are there more filters than vf_crop that this is intended to be used on? I said: >> I need it in new code. It is to be a filter that has constraints similar to vf_crop. But also, ff_all_formats() can be implemented in term

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-16 Thread Paul B Mahol
On 4/16/20, Derek Buitenhuis wrote: > On 16/04/2020 17:10, Paul B Mahol wrote: >> Will apply. > > Your behavior here is still unacceptable. You have dismissed or ignore > both comments without any given reason. I gave reason. They are either complicated or very slow. _

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-04-16 Thread James Almer
On 4/16/2020 1:26 PM, Philip Langdale wrote: > On Tue, 10 Mar 2020 16:33:41 -0300 > James Almer wrote: >> >> I can withdraw this patch (And remove the relevant chunks from the >> following two) if this function was effectively not meant for >> encoders. Also maybe poke Timo regarding nvenc flushin

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-16 Thread Nicolas George
Paul B Mahol (12020-04-16): > I gave reason. They are either complicated or very slow. I am sorry, but re-reading your answers, I do not see reasons, I see terse answers that show you can't be bothered to even consider the suggestion. This is not how a collaboration project works. If there are re

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-16 Thread Paul B Mahol
On 4/16/20, Nicolas George wrote: > Paul B Mahol (12020-04-16): >> I gave reason. They are either complicated or very slow. > > I am sorry, but re-reading your answers, I do not see reasons, I see > terse answers that show you can't be bothered to even consider the > suggestion. > > This is not ho

Re: [FFmpeg-devel] [PATCH] avcodec: add a WebP parser

2020-04-16 Thread James Zern
On Mon, Apr 13, 2020 at 5:58 PM James Almer wrote: > > Based on code from the BMP parser. > > Addresses ticket #8574 > > Signed-off-by: James Almer > --- > libavcodec/Makefile | 1 + > libavcodec/parsers.c | 1 + > libavcodec/webp_parser.c | 112 +

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mv30: remove unused table elements

2020-04-16 Thread Paul B Mahol
ok, please apply. On 4/12/20, Peter Ross wrote: > --- > libavcodec/mv30.c | 16 > 1 file changed, 16 deletions(-) > > diff --git a/libavcodec/mv30.c b/libavcodec/mv30.c > index ffa04ac493..6e25ed647b 100644 > --- a/libavcodec/mv30.c > +++ b/libavcodec/mv30.c > @@ -86,14 +86,6 @@

Re: [FFmpeg-devel] [PATCH] avcodec: add a WebP parser

2020-04-16 Thread James Almer
On 4/16/2020 2:29 PM, James Zern wrote: > On Mon, Apr 13, 2020 at 5:58 PM James Almer wrote: >> >> Based on code from the BMP parser. >> >> Addresses ticket #8574 >> >> Signed-off-by: James Almer >> --- >> libavcodec/Makefile | 1 + >> libavcodec/parsers.c | 1 + >> libavcodec/webp_

Re: [FFmpeg-devel] [PATCH v2] ffmpeg: allow full range of dts_delta_threshold

2020-04-16 Thread Michael Niedermayer
On Wed, Apr 15, 2020 at 11:07:05PM +0530, Gyan Doshi wrote: > > > On 15-04-2020 10:39 pm, Michael Niedermayer wrote: > >On Wed, Apr 15, 2020 at 05:29:06PM +0530, Gyan Doshi wrote: > >> > >>On 15-04-2020 05:03 pm, Michael Niedermayer wrote: > >>>On Wed, Apr 15, 2020 at 10:55:47AM +0530, Gyan Doshi

Re: [FFmpeg-devel] [PATCH 1/4] lavfi/formats: add ff_formats_pixdesc_filter().

2020-04-16 Thread Derek Buitenhuis
On 16/04/2020 17:48, Nicolas George wrote: > Derek Buitenhuis (12020-04-16): >> (Just a commnt out of curiosity.) >> >> Are there more filters than vf_crop that this is intended to be used on? > > I said: > >>> I need it in new code. It wasn't clear to me what 'new code' entailed here, at the ti

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-16 Thread Derek Buitenhuis
On 16/04/2020 18:23, Paul B Mahol wrote: > Why we should listen to your requests? Who you are to demand changes to code? > > I'm not bypassing comments, I just state that they are immature, like yours. That the FFmpeg community continues to put up with this sort of behavior, more often than no re

Re: [FFmpeg-devel] [PATCH] avfilter: add tmedian filter

2020-04-16 Thread Paul B Mahol
On 4/16/20, Derek Buitenhuis wrote: > On 16/04/2020 18:23, Paul B Mahol wrote: >> Why we should listen to your requests? Who you are to demand changes to >> code? >> >> I'm not bypassing comments, I just state that they are immature, like >> yours. > > That the FFmpeg community continues to put up

Re: [FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2020-04-16 Thread Michael Niedermayer
On Wed, Apr 15, 2020 at 03:00:32PM -0700, Josh Allmann wrote: > On Tue, 14 Apr 2020 at 01:53, Josh de Kock wrote: > > > > Hi, > > > > On Mon, Apr 13, 2020, at 10:32 PM, Josh Allmann wrote: > > > Hi, > > > > > > On Sat, 24 Mar 2018 at 14:40, Josh de Kock wrote: > > > > > > > > Signed-off-by: Josh

Re: [FFmpeg-devel] [PATCH v8 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-16 Thread Michael Niedermayer
On Thu, Apr 16, 2020 at 03:54:01AM +, Zane van Iperen wrote: > On Wed, 15 Apr 2020 19:31:44 +0200 > "Michael Niedermayer" wrote: > > > On Tue, Apr 07, 2020 at 10:48:58AM +, Zane van Iperen wrote: > > > Signed-off-by: Zane van Iperen > > > --- > > > Changelog | 1 + > > >

[FFmpeg-devel] [PATCH 1/2] lavu: add av_gcd_q().

2020-04-16 Thread Nicolas George
TODO APIchanges and minor bump. Signed-off-by: Nicolas George --- libavutil/rational.c | 9 + libavutil/rational.h | 6 ++ 2 files changed, 15 insertions(+) This one too, I need for the code I am writing. And lavfi/avf_concat could use it too to choose a better time base. diff --

[FFmpeg-devel] [PATCH 2/2] lavfi/framesync: use av_gcd_q().

2020-04-16 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/framesync.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c index bc95f7d904..26e5219d1b 100644 --- a/libavfilter/framesync.c +++ b/libavfilter/framesync.c @@ -142,17

Re: [FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2020-04-16 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Apr 15, 2020 at 03:00:32PM -0700, Josh Allmann wrote: >> On Tue, 14 Apr 2020 at 01:53, Josh de Kock wrote: >>> >>> Hi, >>> >>> On Mon, Apr 13, 2020, at 10:32 PM, Josh Allmann wrote: Hi, On Sat, 24 Mar 2018 at 14:40, Josh de Kock wrote: > > Sig

Re: [FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2020-04-16 Thread Nicolas George
Andreas Rheinhardt (12020-04-16): > How would one create these out-of-tree filters without using internal > API and without extending the public API for this (thereby hindering > development generally)? E.g. all those function pointers in AVFilter > (and lots of other similar structures) are intern

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/framesync: use av_gcd_q().

2020-04-16 Thread Andreas Rheinhardt
Nicolas George: > Signed-off-by: Nicolas George > --- > libavfilter/framesync.c | 13 ++--- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c > index bc95f7d904..26e5219d1b 100644 > --- a/libavfilter/framesync.c > +++ b/

Re: [FFmpeg-devel] [PATCH v3] avformat/mux: Make uncoded frames av_packet_unref() compatible

2020-04-16 Thread Marton Balint
On Tue, 14 Apr 2020, Nicolas George wrote: Andreas Rheinhardt (12020-04-12): Currently uncoded frames (i.e. packets whose data actually points to an AVFrame) are not refcounted. As a consequence, calling av_packet_unref() on them will not free them, but may simply make sure that they leak by

Re: [FFmpeg-devel] [PATCH v3] avformat/mux: Make uncoded frames av_packet_unref() compatible

2020-04-16 Thread Nicolas George
Marton Balint (12020-04-16): > Yes, but full removal can only happen at the next bump, so until that this > should be fixed. Also this patchset has been delayed for a very long time > now, I really like to see it applied as soon as possible, even if we further > change uncoded_frames support later

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/framesync: use av_gcd_q().

2020-04-16 Thread Nicolas George
Andreas Rheinhardt (12020-04-16): > lcm is now unused, so should be removed with this commit. > (I'm not commenting on the actual merits of the patch.) Indeed. I updated the patch, it now contains an extra hunk: @@ -117,7 +117,6 @@ static void framesync_sync_level_update(FFFrameSync *fs) int ff_

[FFmpeg-devel] [PATCH] lavfi: add untile filter.

2020-04-16 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/filters.texi | 34 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_untile.c | 198 +++ tests/fate/filter-video.mak | 3 + tests/ref/fate/filter-untile | 13

Re: [FFmpeg-devel] [PATCH 5/6] avformat/mux: Don't modify packets we don't own

2020-04-16 Thread Marton Balint
On Sat, 11 Apr 2020, Andreas Rheinhardt wrote: The documentation of av_write_frame() explicitly states that the function doesn't take ownership of the packets sent to it; while av_write_frame() does not directly unreference the packets after having written them, it nevertheless modifies the pa

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-16 Thread Andreas Rheinhardt
John Stebbins: > Required to remux m2ts to mkv > --- > libavcodec/Makefile | 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/pgs_frame_merge_bsf.c | 152 +++ Missing version bump. > 3 files changed, 154 insertions(+) > create mode 100644

Re: [FFmpeg-devel] [PATCH v2] avutil/log: update text requesting samples

2020-04-16 Thread Marton Balint
On Mon, 13 Apr 2020, Marton Balint wrote: On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: Am Mo., 13. Apr. 2020 um 02:19 Uhr schrieb Marton Balint : On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint : >> >> Signed-off-by: Marton Ba

Re: [FFmpeg-devel] [PATCH v3] avformat/mux: Make uncoded frames av_packet_unref() compatible

2020-04-16 Thread Andreas Rheinhardt
Marton Balint: > > > On Tue, 14 Apr 2020, Nicolas George wrote: > >> Andreas Rheinhardt (12020-04-12): >>> Currently uncoded frames (i.e. packets whose data actually points to an >>> AVFrame) are not refcounted. As a consequence, calling av_packet_unref() >>> on them will not free them, but may

Re: [FFmpeg-devel] [PATCH 5/6] avformat/mux: Don't modify packets we don't own

2020-04-16 Thread Andreas Rheinhardt
Marton Balint: > > > On Sat, 11 Apr 2020, Andreas Rheinhardt wrote: > >> The documentation of av_write_frame() explicitly states that the function >> doesn't take ownership of the packets sent to it; while av_write_frame() >> does not directly unreference the packets after having written them, i

Re: [FFmpeg-devel] [PATCH v2] avutil/log: update text requesting samples

2020-04-16 Thread Carl Eugen Hoyos
Am Mo., 13. Apr. 2020 um 11:03 Uhr schrieb Marton Balint : > > > > On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > > > Am Mo., 13. Apr. 2020 um 02:19 Uhr schrieb Marton Balint : > >> > >> > >> > >> On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > >> > >> > Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Ma

Re: [FFmpeg-devel] [PATCH 5/6] avformat/mux: Don't modify packets we don't own

2020-04-16 Thread Marton Balint
On Thu, 16 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: On Sat, 11 Apr 2020, Andreas Rheinhardt wrote: The documentation of av_write_frame() explicitly states that the function doesn't take ownership of the packets sent to it; while av_write_frame() does not directly unreference the

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mpegtsenc: use standard pids for m2ts

2020-04-16 Thread Marton Balint
On Mon, 13 Apr 2020, Petri Hintukainen wrote: pe, 2020-04-10 kello 21:44 +0200, Marton Balint kirjoitti: Signed-off-by: Marton Balint --- doc/muxers.texi | 6 -- libavformat/mpegts.h| 10 ++ libavformat/mpegtsenc.c | 44 +++-

[FFmpeg-devel] [PATCH v2 1/4] avformat/mpegtsenc: use standard pids for m2ts

2020-04-16 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/muxers.texi | 6 -- libavformat/mpegts.h| 10 ++ libavformat/mpegtsenc.c | 44 +++- 3 files changed, 57 insertions(+), 3 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index e5b8deb

Re: [FFmpeg-devel] Query regarding codec parsers

2020-04-16 Thread Carl Eugen Hoyos
Am Do., 16. Apr. 2020 um 12:24 Uhr schrieb Gautam Ramakrishnan : > > On Mon, Apr 13, 2020 at 11:00 PM Carl Eugen Hoyos wrote: > > > > Am Mo., 13. Apr. 2020 um 17:27 Uhr schrieb Gautam Ramakrishnan > > : > > > > > > On Sun, Mar 29, 2020 at 8:34 PM Carl Eugen Hoyos > > > wrote: > > > > > > > > Am

Re: [FFmpeg-devel] [PATCH v2 2/3] avdevice/opengl: add support of wrapped avframe codec

2020-04-16 Thread Marton Balint
On Tue, 14 Apr 2020, Nicolas George wrote: Marton Balint (12020-04-11): Also change the default to that. Signed-off-by: Marton Balint --- libavdevice/opengl_enc.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) No objection. Thanks. Thanks, applied. Regards, M

Re: [FFmpeg-devel] [PATCH v2 1/3] avdevice/xv: add support of wrapped avframe codec

2020-04-16 Thread Marton Balint
On Tue, 14 Apr 2020, Nicolas George wrote: Marton Balint (12020-04-11): Also change the default to that. Signed-off-by: Marton Balint --- libavdevice/xv.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) No objection. Thanks. Thanks, applied. Regards, Mart

Re: [FFmpeg-devel] [PATCH v2] avutil/log: update text requesting samples

2020-04-16 Thread Marton Balint
On Thu, 16 Apr 2020, Carl Eugen Hoyos wrote: Am Mo., 13. Apr. 2020 um 11:03 Uhr schrieb Marton Balint : On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > Am Mo., 13. Apr. 2020 um 02:19 Uhr schrieb Marton Balint : >> >> >> >> On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: >> >> > Am Mo., 13. Ap

Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/log: update text requesting samples

2020-04-16 Thread Carl Eugen Hoyos
Am Fr., 17. Apr. 2020 um 00:14 Uhr schrieb Marton Balint : > > ffmpeg | branch: master | Marton Balint | Fri Apr 17 > 00:04:47 2020 +0200| [d1e52e396b8aa778bd8d12bf25864beca0937d0a] | committer: > Marton Balint > > avutil/log: update text requesting samples > > Signed-off-by: Marton Balint > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf: use simplified algorithm for bsf_list chained filtering

2020-04-16 Thread Marton Balint
On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: On Thu, 9 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: Based on the one in ffmpeg.c and it is not using an extra flush_idx variable. Signed-off-by: Marton Balint ---  libavcodec/bsf.c | 64 ++---

Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/log: update text requesting samples

2020-04-16 Thread James Almer
On 4/16/2020 7:15 PM, Carl Eugen Hoyos wrote: > Am Fr., 17. Apr. 2020 um 00:14 Uhr schrieb Marton Balint : >> >> ffmpeg | branch: master | Marton Balint | Fri Apr 17 >> 00:04:47 2020 +0200| [d1e52e396b8aa778bd8d12bf25864beca0937d0a] | committer: >> Marton Balint >> >> avutil/log: update text req

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: Check attachment filesize

2020-04-16 Thread Michael Niedermayer
On Wed, Apr 15, 2020 at 11:06:13PM +0200, Andreas Rheinhardt wrote: > The data of an attachment file is put into an AVCodecParameter's > extradata. The corresponding size field has type int, yet there was no > check for the size to fit into an int. As a consequence, it was possible > to create extr

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-16 Thread John Stebbins
On Thu, 2020-04-16 at 22:39 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > Required to remux m2ts to mkv > > --- > > libavcodec/Makefile | 1 + > > libavcodec/bitstream_filters.c | 1 + > > libavcodec/pgs_frame_merge_bsf.c | 152 > > +++ > > Mi

[FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-16 Thread John Stebbins
Required to remux m2ts to mkv --- libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/pgs_frame_merge_bsf.c | 164 +++ 3 files changed, 166 insertions(+) create mode 100644 libavcodec/pgs_frame_merge_bsf.c diff --git a/libavc

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-16 Thread John Stebbins
On Thu, 2020-04-16 at 16:57 -0600, John Stebbins wrote: > Required to remux m2ts to mkv > --- > libavcodec/Makefile | 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/pgs_frame_merge_bsf.c | 164 > +++ > 3 files changed, 166 insertions(+) >

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-16 Thread John Stebbins
On Thu, 2020-04-16 at 15:59 -0700, John Stebbins wrote: > On Thu, 2020-04-16 at 16:57 -0600, John Stebbins wrote: > > Required to remux m2ts to mkv > > --- > > libavcodec/Makefile | 1 + > > libavcodec/bitstream_filters.c | 1 + > > libavcodec/pgs_frame_merge_bsf.c | 164 > > +++

[FFmpeg-devel] [PATCH] libavcodec/libx264: fix reference frame computation based on level

2020-04-16 Thread josh . brewster
Hell, can someone please review this patch? It fixes a wrong reference frame computation problem when using parameters such as "-level 31" instead of "-level 3.1". From 9f9dcb3cceebb360468fea762b01780f65764a47 Mon Sep 17 00:00:00 2001 From: Josh Brewster Date: Thu, 16 Apr 2020 22:50:29 +0200 Sub

Re: [FFmpeg-devel] [PATCH v8 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-16 Thread Zane van Iperen
On Thu, 16 Apr 2020 21:37:54 +0200 "Michael Niedermayer" wrote: > > > > @@ -1304,6 +1329,13 @@ static int > > > > adpcm_decode_frame(AVCodecContext *avctx, void *data, samples > > > > += avctx->channels; } > > > > break; > > > > +case AV_CODEC_ID_ADPCM_IMA_CUNNING: > > > > +w

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: Check attachment filesize

2020-04-16 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Apr 15, 2020 at 11:06:13PM +0200, Andreas Rheinhardt wrote: >> The data of an attachment file is put into an AVCodecParameter's >> extradata. The corresponding size field has type int, yet there was no >> check for the size to fit into an int. As a consequence, it was

[FFmpeg-devel] [PATCH 5/5] avformat/matroskaenc: Remove limit on the number of tracks

2020-04-16 Thread Andreas Rheinhardt
The Matroska file format has practically no limit on the number of tracks (the current limit is 2^56 - 1); yet because they are encoded in a variable length format in (Simple)Blocks this muxer has simply imposed a limit on the number of tracks in order to ensure that they can always be written on o

[FFmpeg-devel] [PATCH 3/5] avformat/matroskaenc: Rename functions to better reflect what they do

2020-04-16 Thread Andreas Rheinhardt
EBML uses variable length integers both for the EBML IDs as well as for the EBML lengths; Matroska also uses them for the TrackNumber in (Simple)Blocks and for the lengths of laces when EBML lacing is used. When encoding EBML lengths, certain encodings have a special meaning, namely that the eleme

[FFmpeg-devel] [PATCH 4/5] avformat/matroskaenc: Refactor writing EBML lengths

2020-04-16 Thread Andreas Rheinhardt
This commit factors the ability to write ordinary EBML numbers out of the functions for writing EBML lengths. This is in preparation for future commits. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 36 ++-- 1 file changed, 26 insertions(+), 10

[FFmpeg-devel] [PATCH] avcodec/ass: explicitly set ScaledBorderAndShadow

2020-04-16 Thread Oneric
Patch attached. Currently ffmpeg does not set the 'ScaledBorderAndShadow' header for ASS subtitles. This currently leads to inconsistent behaviour depending on the renderer(see https://github.com/libass/libass/issues/287#issuecomment-338654103) Although libass will probably change the default t

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flacenc: Only update streaminfo if it has changed

2020-04-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > An AVStream's codecpar is supposed to be filled by the caller before > avformat_write_header(); if the CodecParameters change, the caller > should signal this via packet side data, but not touch the AVStream's > codecpar. > > The FLAC muxer checks for packet side data contain

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-16 Thread James Almer
On 4/16/2020 8:06 PM, John Stebbins wrote: > On Thu, 2020-04-16 at 15:59 -0700, John Stebbins wrote: >> On Thu, 2020-04-16 at 16:57 -0600, John Stebbins wrote: >>> Required to remux m2ts to mkv >>> --- >>> libavcodec/Makefile | 1 + >>> libavcodec/bitstream_filters.c | 1 + >>>

Re: [FFmpeg-devel] [PATCH] avcodec/ass: explicitly set ScaledBorderAndShadow

2020-04-16 Thread oneric
On Fri, Apr 17, 2020 at 02:15:17 +0200, Oneric wrote: > From 51deab727958c5d64ae526f67063cdf141a01d46 Mon Sep 17 00:00:00 2001 > From: Oneric > Date: Fri, 17 Apr 2020 00:38:53 +0200 > Subject: [PATCH] avcodec/ass: explicitly set ScaledBorderAndShadow Sorry for the inconvenience, I missed a warnin

[FFmpeg-devel] [PATCH] avformat/webvttdec: Remove write-only variable

2020-04-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/webvttdec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/webvttdec.c b/libavformat/webvttdec.c index 52579c5ed2..6c4d5f6736 100644 --- a/libavformat/webvttdec.c +++ b/libavformat/webvttdec.c @@ -60,7 +60,7 @@

[FFmpeg-devel] [PATCH] avformat/r3d: Remove write-only array

2020-04-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/r3d.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/libavformat/r3d.c b/libavformat/r3d.c index 224bcf780d..7aa0c5a2c3 100644 --- a/libavformat/r3d.c +++ b/libavformat/r3d.c @@ -27,7 +27,6 @@ typedef

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: move avcodec_flush_buffers from decode.c to utils.c

2020-04-16 Thread Philip Langdale
On Thu, 16 Apr 2020 14:07:49 -0300 James Almer wrote: > On 4/16/2020 1:26 PM, Philip Langdale wrote: > > On Tue, 10 Mar 2020 16:33:41 -0300 > > James Almer wrote: > >> > >> I can withdraw this patch (And remove the relevant chunks from the > >> following two) if this function was effectively n

[FFmpeg-devel] [PATCH 1/3] avcodec/qpeg: remove an unnecessary intermediary AVFrame

2020-04-16 Thread James Almer
Decoding can be handled directly in the output frame. Signed-off-by: James Almer --- libavcodec/qpeg.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/libavcodec/qpeg.c b/libavcodec/qpeg.c index d4195c5f0b..3fde6381f2 100644 --- a/libavcodec/qpeg.c +++

[FFmpeg-devel] [PATCH 2/3] avcodec/qpeg: export missing frame properties

2020-04-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/qpeg.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/qpeg.c b/libavcodec/qpeg.c index 3fde6381f2..22afd9fa81 100644 --- a/libavcodec/qpeg.c +++ b/libavcodec/qpeg.c @@ -270,7 +270,7 @@ static int decode_frame(AVCode

[FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe

2020-04-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/qpeg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/qpeg.c b/libavcodec/qpeg.c index 22afd9fa81..cc3bfda4aa 100644 --- a/libavcodec/qpeg.c +++ b/libavcodec/qpeg.c @@ -366,4 +366,5 @@ AVCodec ff_qpeg_decoder = { .decode = dec

Re: [FFmpeg-devel] Query regarding codec parsers

2020-04-16 Thread Gautam Ramakrishnan
On Fri, Apr 17, 2020 at 3:28 AM Carl Eugen Hoyos wrote: > > Am Do., 16. Apr. 2020 um 12:24 Uhr schrieb Gautam Ramakrishnan > : > > > > On Mon, Apr 13, 2020 at 11:00 PM Carl Eugen Hoyos > > wrote: > > > > > > Am Mo., 13. Apr. 2020 um 17:27 Uhr schrieb Gautam Ramakrishnan > > > : > > > > > > > > O

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-16 Thread Limin Wang
On Thu, Apr 16, 2020 at 05:16:35PM +0200, Nicolas George wrote: > Sorry, forgot to reply to that. > > Limin Wang (12020-04-04): > > the md5 framecrc is generated by libavformat/tests/movenc.c, I have no > > clue how the movenc testing work and how to get the real input to check why > > the frame i

Re: [FFmpeg-devel] [PATCH] libavcodec/libx264: fix reference frame computation based on level

2020-04-16 Thread Fu, Linjie
Hi, > From: ffmpeg-devel On Behalf Of > josh.brews...@protonmail.com > Sent: Friday, April 17, 2020 07:05 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] libavcodec/libx264: fix reference frame > computation based on level > > Hell, can someone please review this patch? It fixes