[FFmpeg-devel] FLIF Encoder & Decoder Project for GSOC 2020

2020-02-23 Thread Kartik Khullar
I am 2nd year Computer Engineering Student at TIET, Patiala. I am interested in FLIF Encoder and Decoder Project. I am informing so as to prevent clash between other potential applicants. I will be working on its Qualification Task. I have previously studied theory and mathematics behind JPEG Compr

Re: [FFmpeg-devel] FLIF Encoder & Decoder Project for GSOC 2020

2020-02-23 Thread Jai Luthra
On Sun, Feb 23, 2020 at 02:54:42PM +0530, Kartik Khullar wrote: I am 2nd year Computer Engineering Student at TIET, Patiala. I am interested in FLIF Encoder and Decoder Project. I am informing so as to prevent clash between other potential applicants. I will be working on its Qualification Task.

Re: [FFmpeg-devel] [PATCH] ffprobe: show stream id in packets and frames

2020-02-23 Thread Nicolas George
Gyan Doshi (12020-02-23): > > It saves some steps in shell scripts,  avoiding having to correlate > > stream index with id. > Any more comments? I find this somewhat feeble. How does it justify including the stream id (something that few formats support) more than any other field of the stream? If

Re: [FFmpeg-devel] [PATCH] ffprobe: show stream id in packets and frames

2020-02-23 Thread Gyan Doshi
On 23-02-2020 03:53 pm, Nicolas George wrote: Gyan Doshi (12020-02-23): It saves some steps in shell scripts,  avoiding having to correlate stream index with id. Any more comments? I find this somewhat feeble. How does it justify including the stream id (something that few formats support) m

Re: [FFmpeg-devel] [PATCH] ffprobe: show stream id in packets and frames

2020-02-23 Thread Nicolas George
Gyan Doshi (12020-02-23): > stream_index isn't fixed in fftools for a given live MPEG-TS input across > instances so can't be reliably used to id streams. This field can.  Same > can't be said for other fields. Yes, but “identifying across instances” is a specific need. Why is it more important th

Re: [FFmpeg-devel] [PATCH] ffprobe: show stream id in packets and frames

2020-02-23 Thread Gyan Doshi
On 23-02-2020 04:22 pm, Nicolas George wrote: Gyan Doshi (12020-02-23): stream_index isn't fixed in fftools for a given live MPEG-TS input across instances so can't be reliably used to id streams. This field can.  Same can't be said for other fields. Yes, but “identifying across instances” is

Re: [FFmpeg-devel] [PATCH] ffprobe: show stream id in packets and frames

2020-02-23 Thread Nicolas George
Gyan Doshi (12020-02-23): > If one needs to map a specific stream from a multi program TS input in > another instance, based on packet/frames analysis,  then this helps with > making a quick and direct id. And if one needs to map a specific stream from a Matroska to its codec, something else is ne

[FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Michael Niedermayer
From: Parker Ernest <@> commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II Signed-off-by: Michael Niedermayer --- libswscale/x86/yuv2rgb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libswscale/x86/yuv2rgb.c b/libsws

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread James Darnley
On 2020-02-23 13:22, Michael Niedermayer wrote: > From: Parker Ernest <@> > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on > x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II > > Signed-off-by: Michael Niedermayer > --- > libswscale/x86/yuv2rgb.c | 2 ++ > 1 file change

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Paul B Mahol
lgtm On 2/23/20, Michael Niedermayer wrote: > From: Parker Ernest <@> > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on > x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II > > Signed-off-by: Michael Niedermayer > --- > libswscale/x86/yuv2rgb.c | 2 ++ > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH] ffprobe: show stream id in packets and frames

2020-02-23 Thread Jan Ekström
On Sun, Feb 23, 2020 at 8:15 AM Gyan Doshi wrote: > > > > On 20-02-2020 10:05 am, Gyan Doshi wrote: > > > > > > On 20-02-2020 04:52 am, Jan Ekström wrote: > >> Hi, > >> > >> On Wed, Feb 19, 2020 at 8:31 AM Gyan Doshi wrote: > >>> Required for reliably identifying streams in MPEGTS-like live input

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread Jean-Baptiste Kempf
Yo, On Sat, Feb 22, 2020, at 22:18, Josh de Kock wrote: > This allows for easy shortlog/log parsing, useful in determining > eligible members of the general assembly for the new FFmpeg voting > system. I think this is a good idea. But are you sure all of those are in the right order? (aka preferr

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread Josh de Kock
On Sun, Feb 23, 2020, at 2:12 PM, Jean-Baptiste Kempf wrote: > [...] > > I think this is a good idea. > But are you sure all of those are in the right order? (aka preferred > email is shown) It looks mostly right to me, of course individuals will need to manually verify it for themselves (but it

Re: [FFmpeg-devel] [PATCH] avcodec/ac3_parser: recognize LE bitstream variant

2020-02-23 Thread Paul B Mahol
will apply On 2/21/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/ac3_parser.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/ac3_parser.c b/libavcodec/ac3_parser.c > index 1e203ae6ac..ba171653ef 100644 > --- a/libavcodec/ac3_parser.c > +++ b

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread James Darnley
On 2020-02-23 15:12, Jean-Baptiste Kempf wrote: > Yo, > > On Sat, Feb 22, 2020, at 22:18, Josh de Kock wrote: >> This allows for easy shortlog/log parsing, useful in determining >> eligible members of the general assembly for the new FFmpeg voting >> system. > > I think this is a good idea. > But

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread Josh de Kock
On Sun, Feb 23, 2020, at 2:36 PM, James Darnley wrote: > [...] > > What is "preferred email" when you have 2 roles? My commits on the job > get obe.tv (or are supposed to) and ones made in my own time get > gmail.com (or are supposed to). > > Is it: when you screw up what email should you be sho

Re: [FFmpeg-devel] [PATCH] avformat: Add AMQP version 0-9-1 protocol support

2020-02-23 Thread Andriy Gelman
On Sun, 09. Feb 17:30, Andriy Gelman wrote: > On Sun, 09. Feb 14:32, Timo Rothenpieler wrote: > > On 01.02.2020 20:02, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > > > Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. The > > > broker can redistribute content to other cli

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread Thilo Borgmann
Am 22.02.20 um 22:18 schrieb Josh de Kock: > This allows for easy shortlog/log parsing, useful in determining > eligible members of the general assembly for the new FFmpeg voting > system. > > Signed-off-by: Josh de Kock > --- > > This list was automatically generated based off of commits from >

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Carl Eugen Hoyos
Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer : > > From: Parker Ernest <@> > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on > x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II Does the commit break build on specific CPUs or specific toolchains? Carl Euge

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread James Almer
On 2/23/2020 9:33 AM, Paul B Mahol wrote: > lgtm No, it's not ok. The EXTERNAL_SSSE3() macro should be enough to prevent any of these functions from running on old CPUs. It would help actually knowing what kind of failure is the user getting. > > On 2/23/20, Michael Niedermayer wrote: >> From:

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Paul B Mahol
On 2/23/20, James Almer wrote: > On 2/23/2020 9:33 AM, Paul B Mahol wrote: >> lgtm > > No, it's not ok. The EXTERNAL_SSSE3() macro should be enough to prevent > any of these functions from running on old CPUs. this is about building. > > It would help actually knowing what kind of failure is the

[FFmpeg-devel] [PATCH 1/2] tools/target_dec_fuzzer: Adjust threshold for zerocodec

2020-02-23 Thread Michael Niedermayer
Fixes: Timeout (147sec -> 1sec) Fixes: 20764/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ZEROCODEC_fuzzer-5068274603917312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c

[FFmpeg-devel] [PATCH 2/2] avformat/mvdec: Check stream numbers

2020-02-23 Thread Michael Niedermayer
Fixes: null pointer dereference Fixes: 20768/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5638648978735104.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mvdec.c | 6 ++ 1 f

[FFmpeg-devel] [PATCH] libavcodec/amfenc_hevc.c: Fix video fast forward hanging issue on HEVC AMF.

2020-02-23 Thread nyanmisaka
Change wrong gops_per_idr default value from 60 to 1 as per AMD AMF documents. https://github.com/GPUOpen-LibrariesAndSDKs/AMF/blob/master/amf/doc/AMF_Video_Encode_API.pdf Fixed: http://trac.ffmpeg.org/ticket/7272 --- libavcodec/amfenc_hevc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Hendrik Leppkes
On Sun, Feb 23, 2020 at 6:26 PM Paul B Mahol wrote: > > On 2/23/20, James Almer wrote: > > On 2/23/2020 9:33 AM, Paul B Mahol wrote: > >> lgtm > > > > No, it's not ok. The EXTERNAL_SSSE3() macro should be enough to prevent > > any of these functions from running on old CPUs. > > this is about bui

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Michael Niedermayer
On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: > Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer > : > > > > From: Parker Ernest <@> > > > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on > > x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread James Almer
On 2/23/2020 2:58 PM, Michael Niedermayer wrote: > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: >> Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer >> : >>> >>> From: Parker Ernest <@> >>> >>> commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on >>> x86

[FFmpeg-devel] [PATCH v4 1/3] avcodec/v4l2_m2m_enc: Reduce log verbosity for some params

2020-02-23 Thread Andriy Gelman
From: Andriy Gelman Currently the user gets unhelpful warnings when some default parameters are not supported by the device. The verbosity of these log messages has been changed to AV_LOG_DEBUG. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m_enc.c | 36 +--

[FFmpeg-devel] [PATCH v4 3/3] avcodec/v4l2_m2m_enc: Support changing qmin/qmax

2020-02-23 Thread Andriy Gelman
From: Andriy Gelman Hard coded parameters for qmin and qmax are currently used to initialize v4l2_m2m device. This commit uses values from avctx->{qmin,qmax} if they are set. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m_enc.c | 21 + 1 file changed, 17 insertions(+)

[FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_m2m_enc: Enable frame level rate control by default

2020-02-23 Thread Andriy Gelman
From: Andriy Gelman Without this setting, bitrate and qmin/qmax options have no affect on the s5p-mfc hardware encoder. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m_enc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c index 859

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Hendrik Leppkes
On Sun, Feb 23, 2020 at 6:58 PM Michael Niedermayer wrote: > > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: > > Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer > > : > > > > > > From: Parker Ernest <@> > > > > > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread Josh de Kock
On Sun, Feb 23, 2020, at 4:07 PM, Thilo Borgmann wrote: > [...] > > How is it automatically generated? I wrote a small script to parse author names/emails and group emails together based on names. In the future, additions should be added manually. -- Josh ___

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-23 Thread Michael Niedermayer
On Sat, Feb 22, 2020 at 09:47:20AM +0100, Clément Bœsch wrote: > On Fri, Feb 14, 2020 at 03:26:30AM +, Soft Works wrote: > > Hi, > > > > Hi, > > > I am looking for some guidance regarding future plans about processing > > subtitle streams in filter graphs. > > > > Please correct me where I

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mvdec: Check stream numbers

2020-02-23 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: null pointer dereference > Fixes: > 20768/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5638648978735104.fuzz > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > ---

[FFmpeg-devel] [PATCH] configure: Enable section_data_rel_ro for OpenBSD aarch64 / arm

2020-02-23 Thread Brad Smith
configure: Enable section_data_rel_ro for OpenBSD aarch64 / arm Signed-off-by: Brad Smith --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index ab761c7183..06e3a7b2a8 100755 --- a/configure +++ b/configure @@ -5305,6 +5305,7 @@ case $target_os in

Re: [FFmpeg-devel] [PATCH 6/7] avformat/segafilmenc: Combine several checks

2020-02-23 Thread Andreas Rheinhardt
Andreas Rheinhardt: > by moving them around. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/segafilmenc.c | 26 +- > 1 file changed, 9 insertions(+), 17 deletions(-) > > diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.c > index 4f881f4f2f..137

Re: [FFmpeg-devel] [PATCH] Escape braces in a regex, fixing warnings with newer perl

2020-02-23 Thread Martin Storsjö
On Tue, 18 Feb 2020, myp...@gmail.com wrote: On Mon, Feb 17, 2020 at 3:46 PM Martin Storsjö wrote: Perl 5.28 warns about this, saying it will be fatal in Perl 5.32. Signed-off-by: Martin Storsjö --- gas-preprocessor.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gas

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-23 Thread Nicolas George
Michael Niedermayer (12020-02-23): > really ? > just hypothetically, and playing the devils advocat here. > what would happen if one problem or set of problems is solved at a time ? Odds are a design decision made early would prove insufficient to solve a later problem. > what happens if you forb

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread James Darnley
On 2020-02-23 18:58, Michael Niedermayer wrote: > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: >> Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer >> : >>> >>> From: Parker Ernest <@> >>> >>> commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on >>> x86_

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-23 Thread Marton Balint
On Sun, 23 Feb 2020, Nicolas George wrote: Michael Niedermayer (12020-02-23): really ? just hypothetically, and playing the devils advocat here. what would happen if one problem or set of problems is solved at a time ? Odds are a design decision made early would prove insufficient to solve

Re: [FFmpeg-devel] Setting default G0 character set for teletext decoder

2020-02-23 Thread Marton Balint
On Wed, 19 Feb 2020, k.savkov wrote: I can also provide sample files, for which this option is needed, where can I upload them? No need, the why is more important, so I extended the help text and applied your patch. Thanks, Marton On 18.02.2020 23:48, Marton Balint wrote: On Tue, 18

Re: [FFmpeg-devel] [PATCH v2 1/9] avformat/libsrt: fix timeout unit confusion between milisec and microsec

2020-02-23 Thread Marton Balint
On Sat, 22 Feb 2020, Marton Balint wrote: On Mon, 17 Feb 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/libsrt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Ping for the series, will apply soon. Applied the series. Regards, Marton Regards,

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-23 Thread Nicolas George
Marton Balint (12020-02-23): > Two overlapping subtitles can be broken into 3 non-overlapping subtitles, No, they can't: being the same subtitle or not is part of the semantic. Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

2020-02-23 Thread Carl Eugen Hoyos
Am So., 23. Feb. 2020 um 23:43 Uhr schrieb James Darnley : > > On 2020-02-23 18:58, Michael Niedermayer wrote: > > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: > >> Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer > >> : > >>> > >>> From: Parker Ernest <@> > >>> >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/svq1dec: Check that there is data left after the hader

2020-02-23 Thread Moritz Barsnick
On Wed, Feb 19, 2020 at 00:59:18 +0100, Michael Niedermayer wrote: > Subject: [FFmpeg-devel] [PATCH 3/4] avcodec/svq1dec: Check that there is data > left after the hader Nit: hader -> header Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH v4 19/21] vaapi_encode_h265: Use common handling for HDR metadata

2020-02-23 Thread Mark Thompson
--- libavcodec/vaapi_encode_h265.c | 45 +- 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index 538862a9d5..443139dfdb 100644 --- a/libavcodec/vaapi_encode_h265.c +++ b/libavcodec/vaapi

[FFmpeg-devel] [PATCH v4 20/21] h264_metadata_bsf: Refactor the filter function into smaller parts

2020-02-23 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 436 ++--- 1 file changed, 237 insertions(+), 199 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index d96a50dbf7..b2304373bf 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/libavcodec/h2

[FFmpeg-devel] [PATCH v4 21/21] h264_metadata_bsf: Improve interpretation of input display matrices

2020-02-23 Thread Mark Thompson
The previous code here only worked in more limited cases. --- libavcodec/h264_metadata_bsf.c | 42 +++--- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index b2304373bf..8fc02c5f41 100644

[FFmpeg-devel] [PATCH v4 18/21] cbs_h265: Add functions to turn HDR metadata into SEI

2020-02-23 Thread Mark Thompson
--- libavcodec/Makefile | 2 +- libavcodec/cbs_h265.c | 99 +++ libavcodec/cbs_h265.h | 18 3 files changed, 118 insertions(+), 1 deletion(-) create mode 100644 libavcodec/cbs_h265.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile index

[FFmpeg-devel] [PATCH v4 01/21] cbs: Mention all codecs in unit type comment

2020-02-23 Thread Mark Thompson
--- libavcodec/cbs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h index 9ca1fbd609..cb3081e2c6 100644 --- a/libavcodec/cbs.h +++ b/libavcodec/cbs.h @@ -45,8 +45,10 @@ struct CodedBitstreamType; /** * The codec-specific type of a bitstream unit. * +

[FFmpeg-devel] [PATCH v4 05/21] cbs_h264: Use table-based alloc/free

2020-02-23 Thread Mark Thompson
--- libavcodec/cbs_h2645.c | 163 ++--- 1 file changed, 70 insertions(+), 93 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index c8347ba5fa..7e2cd4b00c 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -443,52 +443,

[FFmpeg-devel] [PATCH v4 16/21] cbs_h264: Add a function to turn stereo 3D metadata into SEI

2020-02-23 Thread Mark Thompson
--- libavcodec/cbs_h264.c | 47 +++ libavcodec/cbs_h264.h | 8 2 files changed, 55 insertions(+) diff --git a/libavcodec/cbs_h264.c b/libavcodec/cbs_h264.c index 75759c7f25..cc52f68550 100644 --- a/libavcodec/cbs_h264.c +++ b/libavcodec/cbs_h264.c

[FFmpeg-devel] [PATCH v4 11/21] cbs_av1: Use table-based alloc/free

2020-02-23 Thread Mark Thompson
--- libavcodec/cbs_av1.c | 85 1 file changed, 39 insertions(+), 46 deletions(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index 16eb7143b6..34b2634ece 100644 --- a/libavcodec/cbs_av1.c +++ b/libavcodec/cbs_av1.c @@ -812,50 +812,6 @@ fai

[FFmpeg-devel] [PATCH v4 09/21] cbs_h265: Use table-based alloc/free

2020-02-23 Thread Mark Thompson
--- libavcodec/cbs_h2645.c | 198 +++-- 1 file changed, 94 insertions(+), 104 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 84cb70b863..62d253d042 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -443,71 +443

[FFmpeg-devel] [PATCH v4 07/21] cbs_h2645: Ensure that non-refcounted parameter sets are fully copied

2020-02-23 Thread Mark Thompson
Only copying the main structure is not necessarily sufficient - there could be references to substructures. --- libavcodec/cbs_h2645.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 7e2cd4b00c..84cb70b863 100644

[FFmpeg-devel] [PATCH v4 13/21] cbs: Expose the function to insert a new empty unit into a fragment

2020-02-23 Thread Mark Thompson
This will be helpful when adding new SEI to an existing access unit. --- libavcodec/cbs.c | 10 +- libavcodec/cbs.h | 7 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index 91788f6dfb..12a742b40a 100644 --- a/libavcodec/cbs.c +

[FFmpeg-devel] [PATCH v4 08/21] h264_redundant_pps: Make it reference-compatible

2020-02-23 Thread Mark Thompson
From: Andreas Rheinhardt Since c6a63e11092c975b89d824f08682fe31948d3686, the parameter sets modified as content of PPS units were references shared with the CodedBitstreamH264Context, so modifying them alters the parsing process of future access units which meant that frames often got discarded b

[FFmpeg-devel] [PATCH v4 04/21] cbs: Add macros to support defining unit type tables

2020-02-23 Thread Mark Thompson
--- libavcodec/cbs_internal.h | 24 1 file changed, 24 insertions(+) diff --git a/libavcodec/cbs_internal.h b/libavcodec/cbs_internal.h index 615f514a85..2922878ed0 100644 --- a/libavcodec/cbs_internal.h +++ b/libavcodec/cbs_internal.h @@ -166,6 +166,30 @@ int ff_cbs_writ

[FFmpeg-devel] [PATCH v4 10/21] cbs_vp9: Use table-based alloc/free

2020-02-23 Thread Mark Thompson
--- libavcodec/cbs_vp9.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/libavcodec/cbs_vp9.c b/libavcodec/cbs_vp9.c index ec82f11c76..343bf51275 100644 --- a/libavcodec/cbs_vp9.c +++ b/libavcodec/cbs_vp9.c @@ -480,13 +480,6 @@ static int cbs_vp9_split_fragmen

[FFmpeg-devel] [PATCH v4 02/21] cbs: Ensure that reference fields always follow the associated pointer

2020-02-23 Thread Mark Thompson
Hvaing these together allows us to find both pointers given the address of only one of them. --- libavcodec/cbs_av1.h | 6 +++--- libavcodec/cbs_h264.h | 18 +- libavcodec/cbs_h265.h | 16 libavcodec/cbs_jpeg.h | 2 +- libavcodec/cbs_mpeg2.h | 10 +-

[FFmpeg-devel] [PATCH v4 14/21] cbs_h264: Simplify SEI addition

2020-02-23 Thread Mark Thompson
At the same time, move the H.264 SEI functions to a new file - the combined H.26[45] CBS file is already very large, and these functions do not require any of the common read/write elements. --- libavcodec/Makefile| 2 +- libavcodec/cbs_h264.c | 106 +

[FFmpeg-devel] [PATCH v4 06/21] cbs: Add support functions for handling unit content references

2020-02-23 Thread Mark Thompson
Use the unit type table to determine what we need to do to clone the internals of the unit content when making copies for refcounting or writeability. (This will still fail for units with complex content if they do not have a defined clone function.) Setup and naming from a patch by Andreas Rhein

[FFmpeg-devel] [PATCH v4 15/21] cbs_h264: Add support for frame packing arrangement SEI messages

2020-02-23 Thread Mark Thompson
--- libavcodec/cbs_h264.h | 24 libavcodec/cbs_h2645.c| 1 + libavcodec/cbs_h264_syntax_template.c | 40 +++ 3 files changed, 65 insertions(+) diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h index abc0c1b732..512

[FFmpeg-devel] [PATCH v4 17/21] vaapi_encode_h264: Support stereo 3D metadata

2020-02-23 Thread Mark Thompson
Insert frame packing arrangement messages into the stream when input frames have associated stereo 3D side-data. --- doc/encoders.texi | 3 +++ libavcodec/vaapi_encode_h264.c | 25 - 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/doc/encoders.t

[FFmpeg-devel] [PATCH v4 12/21] cbs_mpeg2: Use table-based alloc/free

2020-02-23 Thread Mark Thompson
--- libavcodec/cbs_mpeg2.c | 70 +- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c index 0e5d08ecbf..fabf8f7412 100644 --- a/libavcodec/cbs_mpeg2.c +++ b/libavcodec/cbs_mpeg2.c @@ -140,28 +140,

Re: [FFmpeg-devel] [PATCH v4 20/21] h264_metadata_bsf: Refactor the filter function into smaller parts

2020-02-23 Thread Andreas Rheinhardt
Mark Thompson: > +// If an AUD is present, it must be the first NAL unit. > +if (au->units[0].type == H264_NAL_AUD) { > +if (ctx->aud == REMOVE) > +ff_cbs_delete_unit(ctx->cbc, au, 0); > +} else { > +if (ctx->aud == INSERT) > +h264_metadata_insert

[FFmpeg-devel] [PATCH v4 03/21] cbs: Describe allocate/free methods in tabular form

2020-02-23 Thread Mark Thompson
Unit types are split into three categories, depending on how their content is managed: * POD structure - these require no special treatment. * Structure containing references to refcounted buffers - these can use a common free function when the offsets of all the internal references are known.

Re: [FFmpeg-devel] [PATCH] hwcontext_vaapi: Only accept a render node when deriving from DRM device

2020-02-23 Thread Mark Thompson
On 18/02/2020 14:23, Anton Khirnov wrote: > Quoting Mark Thompson (2020-02-16 21:59:54) >> If we are given a non-render node, try to find the matching render node and >> fail if that isn't possible. >> >> libva will not accept a non-render device which is not DRM master, because >> it requires lega

Re: [FFmpeg-devel] [PATCH 8/9] lavc/hevcdec: add 4:2:2 8-bit/10-bit VAAPI decode support

2020-02-23 Thread Mark Thompson
On 15/01/2020 07:02, Linjie Fu wrote: > Add decode support for 4:2:2 8-bt and 10-bit HEVC Range Extension clips. > > Signed-off-by: Linjie Fu > --- > libavcodec/hevcdec.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c > index 19b0cd8..

Re: [FFmpeg-devel] [PATCH 8/9] lavc/hevcdec: add 4:2:2 8-bit/10-bit VAAPI decode support

2020-02-23 Thread Carl Eugen Hoyos
Am Mo., 24. Feb. 2020 um 01:25 Uhr schrieb Mark Thompson : > We seem to have agreement that the Y210 / wider YUYV is fine Why do you think so? I was under the impression that we have agreement that this has to be discussed further. Carl Eugen ___ ffmpe

Re: [FFmpeg-devel] [PATCH 8/9] lavc/hevcdec: add 4:2:2 8-bit/10-bit VAAPI decode support

2020-02-23 Thread Mark Thompson
On 24/02/2020 00:37, Carl Eugen Hoyos wrote: > Am Mo., 24. Feb. 2020 um 01:25 Uhr schrieb Mark Thompson : > >> We seem to have agreement that the Y210 / wider YUYV is fine > > Why do you think so? > I was under the impression that we have agreement that this > has to be discussed further. All of

Re: [FFmpeg-devel] [PATCH 8/9] lavc/hevcdec: add 4:2:2 8-bit/10-bit VAAPI decode support

2020-02-23 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Monday, February 24, 2020 08:25 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 8/9] lavc/hevcdec: add 4:2:2 8-bit/10-bit > VAAPI decode support > > On 15/01/2020 07:02, Linjie Fu wrote: > >

Re: [FFmpeg-devel] [PATCH v4 06/21] cbs: Add support functions for handling unit content references

2020-02-23 Thread Andreas Rheinhardt
Mark Thompson: > Use the unit type table to determine what we need to do to clone the > internals of the unit content when making copies for refcounting or > writeability. (This will still fail for units with complex content > if they do not have a defined clone function.) > > Setup and naming fr

Re: [FFmpeg-devel] [PATCH v4 16/21] cbs_h264: Add a function to turn stereo 3D metadata into SEI

2020-02-23 Thread Andreas Rheinhardt
Mark Thompson: > --- > libavcodec/cbs_h264.c | 47 +++ > libavcodec/cbs_h264.h | 8 > 2 files changed, 55 insertions(+) > > diff --git a/libavcodec/cbs_h264.c b/libavcodec/cbs_h264.c > index 75759c7f25..cc52f68550 100644 > --- a/libavcodec/cbs_h26

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread Steven Liu
> 2020年2月24日 上午4:40,Josh de Kock 写道: > > On Sun, Feb 23, 2020, at 4:07 PM, Thilo Borgmann wrote: >> [...] >> >> How is it automatically generated? > > I wrote a small script to parse author names/emails and group > emails together based on names. In the future, additions should > be added man