On Sun, Feb 23, 2020 at 6:58 PM Michael Niedermayer <michae...@gmx.at> wrote: > > On Sun, Feb 23, 2020 at 05:03:36PM +0100, Carl Eugen Hoyos wrote: > > Am So., 23. Feb. 2020 um 13:30 Uhr schrieb Michael Niedermayer > > <mich...@niedermayer.cc>: > > > > > > From: Parker Ernest <@> > > > > > > commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on > > > x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II > > > > Does the commit break build on specific CPUs or specific toolchains? > > I dont know what the testcase was the author encountered, i just posted > this here as the author wanted me to post it for him. > but a simple > make distclean ; ./configure --disable-ssse3 && make -j32 > replicates the build failure here (see below for the errors) > > We do have the > extern void RENAME(ff_yuv_420_rgb32)(x86_reg index, uint8_t *image, const > uint8_t *pu_index, > const uint8_t *pv_index, const uint64_t > *pointer_c_dither, > const uint8_t *py_2index); > ... > > under #if HAVE_SSSE3 > > so i think either that needs to be changed or the code using it needs to be > similarly protected.
The extern declaration should be removed from that guard then, like other SIMD code in the codebase. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
