Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mlpdsp: Fix a invalid shift in ff_mlp_rematrix_channel()

2020-02-02 Thread Jai Luthra
On Sun, Feb 02, 2020 at 01:16:38AM +0100, Michael Niedermayer wrote: Fixes: left shift of negative value -2 Fixes: 20305/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-5677196618498048 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-02 Thread Asaf Kave
On Tue, Jan 28, 2020 at 11:44 PM Asaf Kave wrote: > > > On Sun, Jan 26, 2020, 12:31 Asaf Kave wrote: > >> >> >> On Wed, Jan 22, 2020 at 1:09 PM Asaf Kave wrote: >> >>> >>> >>> On Tue, Jan 21, 2020 at 8:17 PM Lynne wrote: >>> Jan 20, 2020, 08:42 by kavea...@gmail.com: > Ping

Re: [FFmpeg-devel] [PATCH V2] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-02-02 Thread Carl Eugen Hoyos
> Am 02.02.2020 um 05:37 schrieb Guo, Yejun : > > And, if a system does not setup SAMPLES > correctly, all the tests needing the SAMPLES will fail, not just this test. No. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm_argo: simplify and move duplicated logic into a function

2020-02-02 Thread Michael Niedermayer
On Sat, Feb 01, 2020 at 11:27:47PM +, Zane van Iperen wrote: > 2/2/20 4:04 am, Michael Niedermayer пишет: > > > > On Sat, Feb 01, 2020 at 06:59:59AM +, Zane van Iperen wrote: > >> Signed-off-by: Zane van Iperen > >> --- > >> libavcodec/adpcm.c | 40 ++

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-02 Thread Nicolas George
Paul B Mahol (12020-02-01): > Fixes picking time base when all input time bases are same and for example > 20833/50. > > Signed-off-by: Paul B Mahol > --- > libavfilter/framesync.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/framesync.c b/libavfilter

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-02 Thread Paul B Mahol
On 2/2/20, Nicolas George wrote: > Paul B Mahol (12020-02-01): >> Fixes picking time base when all input time bases are same and for >> example >> 20833/50. >> >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/framesync.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-02 Thread Nicolas George
Paul B Mahol (12020-02-02): > Changing time base when all inputs have same time base seems strange > and excessive to me. This is true when the denominator is 50, when it's 49 and when it's 51. Expending efforts just for 50 is not efficient, especially since this one does not lead

[FFmpeg-devel] [PATCH] avutil/log: Add av_log_once() for printing a message just once with a high log level

2020-02-02 Thread Michael Niedermayer
Compared to ad-hoc if(printed) ... code this allows the user to disable it by adjusting the log level TODO: APIChanges & version bump Signed-off-by: Michael Niedermayer --- libavutil/log.c | 9 + libavutil/log.h | 21 + 2 files changed, 30 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH V2] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-02-02 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Carl Eugen Hoyos > Sent: Sunday, February 02, 2020 5:43 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2] fate/filter-video.mak: do not use > bit-e

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-02 Thread Paul B Mahol
On 2/2/20, Nicolas George wrote: > Paul B Mahol (12020-02-02): >> Changing time base when all inputs have same time base seems strange >> and excessive to me. > > This is true when the denominator is 50, when it's 49 and when > it's 51. Expending efforts just for 50 is not efficien

Re: [FFmpeg-devel] [PATCH v2] avcodec/v4l2_m2m_enc: Support changing qmin/qmax

2020-02-02 Thread Mark Thompson
On 02/02/2020 01:33, Andriy Gelman wrote: > On Sat, 01. Feb 22:38, Mark Thompson wrote: >> On 19/01/2020 19:54, Andriy Gelman wrote: >>> From: Andriy Gelman >>> >>> Hard coded parameters for qmin and qmax are currently used to initialize >>> v4l2_m2m device. This commit uses values from avctx->{qm

[FFmpeg-devel] [PATCH 2/2] avformat/tty: add seeking support

2020-02-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/tty.c b/libavformat/tty.c index 61e9f3e95c..2065fc0a53 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -150,6 +150,8 @@ static int read_packet(AVFormatContext *avctx, AVP

[FFmpeg-devel] [PATCH 1/2] avformat/tty: make probing strict for first 8 bytes

2020-02-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/tty.c b/libavformat/tty.c index 60f7e9f87e..61e9f3e95c 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -53,7 +53,13 @@ static int read_probe(const AVP

Re: [FFmpeg-devel] [PLEASE IGNORE] [PATCH] avfilter: add xfade opencl filter

2020-02-02 Thread Paul B Mahol
Will apply soon. On 2/1/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure | 1 + > doc/filters.texi | 97 > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/opencl/xfade.cl | 145 ++

Re: [FFmpeg-devel] [PATCH 2/2] avformat/tty: add seeking support

2020-02-02 Thread Andreas Rheinhardt
Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > libavformat/tty.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/tty.c b/libavformat/tty.c > index 61e9f3e95c..2065fc0a53 100644 > --- a/libavformat/tty.c > +++ b/libavformat/tty.c > @@ -150,6 +150,8 @@ static int read_

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mlpdsp: Fix a invalid shift in ff_mlp_rematrix_channel()

2020-02-02 Thread Michael Niedermayer
On Sun, Feb 02, 2020 at 02:07:14PM +0530, Jai Luthra wrote: > On Sun, Feb 02, 2020 at 01:16:38AM +0100, Michael Niedermayer wrote: > >Fixes: left shift of negative value -2 > >Fixes: > >20305/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-5677196618498048 > > > >Found-by: continuo

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm_argo: simplify and move duplicated logic into a function

2020-02-02 Thread Michael Niedermayer
On Sat, Feb 01, 2020 at 11:27:47PM +, Zane van Iperen wrote: > 2/2/20 4:04 am, Michael Niedermayer пишет: > > > > On Sat, Feb 01, 2020 at 06:59:59AM +, Zane van Iperen wrote: > >> Signed-off-by: Zane van Iperen > >> --- > >> libavcodec/adpcm.c | 40 ++

Re: [FFmpeg-devel] [PATCH 1/2] lavc/dvdsubdec: Move palette parsing to new function

2020-02-02 Thread Michael Niedermayer
On Sat, Feb 01, 2020 at 11:43:08PM +0100, Michael Kuron wrote: > Signed-off-by: Michael Kuron > --- > doc/decoders.texi | 2 +- > libavcodec/Makefile| 1 + > libavcodec/dvdsub.c| 33 + > libavcodec/dvdsubdec.c | 22 ++ > libavcode

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-02-02 Thread Lynne
Jan 22, 2020, 16:44 by an...@khirnov.net: > Quoting Lynne (2020-01-21 21:52:52) > >> Jan 21, 2020, 18:22 by an...@khirnov.net: >> >> Its size too? Didn't know that. >> >> I do think its a good idea to be able to append fields to it, so I've >> >> added a av_vk_frame_alloc() function. I've followed

Re: [FFmpeg-devel] [PATCH 1/2] avformat/udp: remove setting cancel state from the TX thread

2020-02-02 Thread Marton Balint
On Sat, 1 Feb 2020, Marton Balint wrote: On Sun, 26 Jan 2020, Marton Balint wrote: Write mode does not use cancellation. Ping, will apply the series soon. Applied. Regards, Marton Signed-off-by: Marton Balint --- libavformat/udp.c | 4 1 file changed, 4 deletions(-) diff --gi

[FFmpeg-devel] [PATCH 7/7] mlp: check huff_lsbs only when codebook is used

2020-02-02 Thread Jai Luthra
When no codebook is used, huff_lsbs can be more than 24 and still decode to original values once filters are applied. Signed-off-by: Jai Luthra --- libavcodec/mlpdec.c | 2 +- libavcodec/mlpenc.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) Fixes lossless check failures caused with

[FFmpeg-devel] [PATCH 6/7] mlpenc: fix -fsanitize=integer errors

2020-02-02 Thread Jai Luthra
Signed-off-by: Jai Luthra --- libavcodec/mlpenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Thanks to Paul for the original pastebin patch diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c index 347a43248c..af04648097 100644 --- a/libavcodec/mlpenc.c +++ b/libavcode

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-02 Thread Nicolas George
Paul B Mahol (12020-02-02): > What about special code that checks all time-bases are same and > keeping it? > > Changing time-base is far from ideal solution in such scenario for any > usecase. I consider any code or effort for time bases larger than, say, 1E5, to be a complete waste. Regards,

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-02 Thread Paul B Mahol
On 2/2/20, Nicolas George wrote: > Paul B Mahol (12020-02-02): >> What about special code that checks all time-bases are same and >> keeping it? >> >> Changing time-base is far from ideal solution in such scenario for any >> usecase. > > I consider any code or effort for time bases larger than, sa

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-02 Thread Nicolas George
Paul B Mahol (12020-02-02): > I will repeat my last question once again, is it ok for you to check that all > input time-bases are same and that not AV_TIME_BASE is used in such case? Already told you: waste of time. -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-02 Thread Paul B Mahol
On 2/2/20, Nicolas George wrote: > Paul B Mahol (12020-02-02): >> I will repeat my last question once again, is it ok for you to check that >> all >> input time-bases are same and that not AV_TIME_BASE is used in such case? > > Already told you: waste of time. How so?

[FFmpeg-devel] [PATCH 3/5] avutil/log: fix detecting console mode on Win32

2020-02-02 Thread Marton Balint
A redirected stderr can still have a valid handle. Signed-off-by: Marton Balint --- libavutil/log.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/log.c b/libavutil/log.c index 64950016e8..6374050770 100644 --- a/libavutil/log.c +++ b/libavutil/log.c @@ -124,7 +124,10 @@ static

[FFmpeg-devel] [PATCH 2/5] avutil/log: factorize ansi_fputs

2020-02-02 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/log.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/libavutil/log.c b/libavutil/log.c index 6d87c718a8..64950016e8 100644 --- a/libavutil/log.c +++ b/libavutil/log.c @@ -143,25 +143,8 @@ s

[FFmpeg-devel] [PATCH 4/5] avutil/log: add support for forced ANSI colors on win32

2020-02-02 Thread Marton Balint
To make behavior the same as non-win32 code when the standard error is redirected. Also restructure the code a bit. Signed-off-by: Marton Balint --- libavutil/log.c | 41 +++-- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/libavutil/log.c b/l

[FFmpeg-devel] [PATCH 1/5] avutil/log: drop support for NO_COLOR environment variable

2020-02-02 Thread Marton Balint
Deprecated for more than 9 years now. Signed-off-by: Marton Balint --- doc/fftools-common-opts.texi | 4 +--- libavutil/log.c | 8 +++- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 31cf424823..f3

[FFmpeg-devel] [PATCH 5/5] avutil/log: add support for multibyte console log for win32

2020-02-02 Thread Marton Balint
Fixes ticket #5398. Signed-off-by: Marton Balint --- libavutil/log.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/libavutil/log.c b/libavutil/log.c index 213594c2a5..78e703b9e9 100644 --- a/libavutil/log.c +++ b/libavutil/log.c @@ -120,6 +120,31

[FFmpeg-devel] [PATCH 2/2] avcodec/rv40dsp: Fix integer overflows in rv40_weight_func_*()

2020-02-02 Thread Michael Niedermayer
Fixes: signed integer overflow: 40550400 * 128 cannot be represented in type 'int' Fixes: 20331/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV40_fuzzer-5676685725007872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [PATCH 1/2] avcodec/audiodsp: Fix integer overflow in scalarproduct_int16_c()

2020-02-02 Thread Michael Niedermayer
Fixes: signed integer overflow: 2145417478 + 76702564 cannot be represented in type 'int' Fixes: 20313/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RA_144_fuzzer-5734487724130304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-

[FFmpeg-devel] [PATCH] avformat/dashenc: use AV_OPT_TYPE_DICT for http_opts

2020-02-02 Thread Marton Balint
This changes the separator character from comma to colon, but since this option was only added recently I think it should be done for consistency with other similar options. Signed-off-by: Marton Balint --- doc/muxers.texi | 3 ++- libavformat/dashenc.c | 7 +++ 2 files changed, 5 inse

Re: [FFmpeg-devel] [PATCH v2] avcodec/v4l2_m2m_enc: Support changing qmin/qmax

2020-02-02 Thread Andriy Gelman
On Sun, 02. Feb 12:30, Mark Thompson wrote: > On 02/02/2020 01:33, Andriy Gelman wrote: > > On Sat, 01. Feb 22:38, Mark Thompson wrote: > >> On 19/01/2020 19:54, Andriy Gelman wrote: > >>> From: Andriy Gelman > >>> > >>> Hard coded parameters for qmin and qmax are currently used to initialize > >>

[FFmpeg-devel] [PATCH 2/3] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-02-02 Thread James Almer
Signed-off-by: James Almer --- TODO: Version bump and APIChanges entry. libavcodec/avcodec.h | 8 +++- libavcodec/options_table.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index edd22f3cbe..ba3d756fa7 100644 --- a/l

[FFmpeg-devel] [PATCH 1/3] avcodec: add an AVCodecContext field to signal types of packet, frame, and coded stream side data to export

2020-02-02 Thread James Almer
Deprecate flags2's export_mvs and add a replacement for it in export_side_data. Signed-off-by: James Almer --- TODO: Version bump and APIChanges entry. libavcodec/avcodec.h | 24 +++- libavcodec/mpegpicture.c | 2 +- libavcodec/mpegutils.c | 2 +- libavcodec/op

[FFmpeg-devel] [PATCH 3/3] avcodec/libx264: add a check for the export_prft AVCodecContext flag

2020-02-02 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libx264.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index ca8f6c0873..a08fe0ce76 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -322,7 +322,9 @@ static int X264_fram

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: use AV_OPT_TYPE_DICT for http_opts

2020-02-02 Thread James Almer
On 2/2/2020 7:01 PM, Marton Balint wrote: > This changes the separator character from comma to colon, but since this > option > was only added recently I think it should be done for consistency with other > similar options. > > Signed-off-by: Marton Balint > --- > doc/muxers.texi | 3 ++-

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ralf: Fix integer overflow in apply_lpc()

2020-02-02 Thread Michael Niedermayer
On Fri, Jan 10, 2020 at 11:03:51PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147482897 + 2048 cannot be represented in > type 'int' > Fixes: > 19240/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5743240326414336 > Fixes: > 19869/clusterfuzz-testcase-min

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dca_lbr: Fix some error codes and error passing

2020-02-02 Thread Michael Niedermayer
On Sun, Jan 05, 2020 at 12:04:39AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/dca_lbr.c | 162 +-- > 1 file changed, 93 insertions(+), 69 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF21

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/8svx: Use av_assert1(0) instead of error message in unreachable code

2020-02-02 Thread Michael Niedermayer
On Sun, Dec 29, 2019 at 08:23:36PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/8svx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the S

Re: [FFmpeg-devel] [PATCH] avcodec/wmavoice: sanity check block_align

2020-02-02 Thread Michael Niedermayer
On Sun, Dec 22, 2019 at 04:06:36PM +0100, Michael Niedermayer wrote: > This limit is roughly based on the bitreader limit, its likely a much tighter > limit > could be used > > Fixes: left shift of 1965039647 by 1 places cannot be represented in type > 'int' > Fixes: > 19545/clusterfuzz-testcas

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wmavoice: Fix rounding and integer anomalies in calc_input_response()

2020-02-02 Thread Michael Niedermayer
On Sat, Dec 14, 2019 at 06:43:25PM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: inf is outside the range of representable values of type 'int' > Fixes: signed integer overflow: -9223372036854775808 - 1 cannot be > represented in type 'long' > Fixes: > 19316/clusterfuzz-

Re: [FFmpeg-devel] [PATCH] avcodec/snappy: Sanity check bytestream2_get_levarint()

2020-02-02 Thread Michael Niedermayer
On Mon, Jan 20, 2020 at 01:07:46AM +0100, Michael Niedermayer wrote: > Fixes: left shift of 79 by 28 places cannot be represented in type 'int' > Fixes: > 20202/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HAP_fuzzer-5719004081815552 > Fixes: > 20219/clusterfuzz-testcase-minimized-ffmpeg_AV_

Re: [FFmpeg-devel] [PATCH] avcodec/pcm: Fix invalid shift in pcm_decode_frame for LXF

2020-02-02 Thread Michael Niedermayer
On Wed, Dec 18, 2019 at 12:47:21AM +0100, Michael Niedermayer wrote: > Fixes: left shift of 32 by 28 places cannot be represented in type 'int' > Fixes: > 19472/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PCM_LXF_fuzzer-5704364320096256 > > Found-by: continuous fuzzing process > https://gi

Re: [FFmpeg-devel] [PATCH v1] avformat/sdp, rtsp: add rtcp attribute to sdp file

2020-02-02 Thread Carl Eugen Hoyos
> Am 02.02.2020 um 04:48 schrieb Jun Li : > > 1. write rtcpport to sdp file when rtpport is specified in url > 2. apply rtcpport when sdp file contains rtcp attribute Please split in two self-contained patches. Thank you, Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as mxf* maintainer

2020-02-02 Thread Tomas Härdin
lör 2020-02-01 klockan 21:07 +0100 skrev Paul B Mahol: > On 2/1/20, Marton Balint wrote: > > > > On Sat, 1 Feb 2020, Carl Eugen Hoyos wrote: > > > > > > > > > Am 01.02.2020 um 16:22 schrieb Paul B Mahol : > > > > > > > > > On 2/1/20, Tomas Härdin wrote: > > > > > Hi > > > > > > > > > > I've