[FFmpeg-devel] [PATCH] avfilter/swaprect: correct assignment of VAR_POS

Revert regression introduced in 6af050d7d0 --- libavfilter/vf_swaprect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_swaprect.c b/libavfilter/vf_swaprect.c index f1fab1e36d..cf9c298f2f 100644 --- a/libavfilter/vf_swaprect.c +++ b/libavfilter/vf_swaprect.c @@

Re: [FFmpeg-devel] [PATCH] avfilter/swaprect: correct assignment of VAR_POS

LGTM On 1/15/20, Gyan Doshi wrote: > Revert regression introduced in 6af050d7d0 > --- > libavfilter/vf_swaprect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_swaprect.c b/libavfilter/vf_swaprect.c > index f1fab1e36d..cf9c298f2f 100644 > --- a/libavfilt

Re: [FFmpeg-devel] [PATCH] avfilter/swaprect: correct assignment of VAR_POS

On 15-01-2020 02:18 pm, Paul B Mahol wrote: LGTM Pushed to 0777b197c57eebb4e2367932fa44021577ab5237 Thanks, Gyan On 1/15/20, Gyan Doshi wrote: Revert regression introduced in 6af050d7d0 --- libavfilter/vf_swaprect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

--- libavcodec/hevc_refs.c | 15 libavcodec/hevcdec.c | 179 - libavcodec/hevcdec.h | 13 +++ 3 files changed, 206 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevc_refs.c b/libavcodec/hevc_refs.c index 7870a72fd6..20f028fa73 100644 --- a

[FFmpeg-devel] [PATCH v2 0/8] avformat: Use s337m subdemux inside wav

Many things have been reviewed. Updates : patch 2 : tomas : updated copyright, moved s337m_read_packet to static patch 3 : tomas : revised 3 cases checking of container_word_bits vs word_bits patch 4 : carl : removed av_log during probing fix 2nd sample check (robustness) requires 3 sample

[FFmpeg-devel] [PATCH v2 8/8] avformat/wavdec: Test s337m

Test s337m probing in wav container. Test dolby_e decoding for 24 bits with program config '5.1+2' --- tests/Makefile | 1 + tests/fate/audio.mak | 5 + 2 files changed, 6 insertions(+) diff --git a/tests/Makefile b/tests/Makefile index e5f41008d4..65cccac312 100644 --- a/tests/Makefile

[FFmpeg-devel] [PATCH v2 7/8] avformat/wavdec: fix s337m/spdif probing beyond data_end

--- libavformat/wavdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index 3571733817..d8a27c79cf 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c @@ -77,7 +77,7 @@ static void set_spdif_s337m(AVFormatContext *s, WAVD

[FFmpeg-devel] [PATCH v2 5/8] avformat/wavdec: s337m support

Add s337m probing/reading similarly to spdif. --- libavformat/wavdec.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index 575c667452..d030ed9f9d 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c

[FFmpeg-devel] [PATCH v2 1/8] avformat/s337m: Use base AVClass for av_log usage

s337m_get_offset_and_codec does not make use of AVFormatContext: AVClass is enough for logging. Will facilitate further use from outside --- libavformat/s337m.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/s337m.c b/libavformat/s337m.c index 48ab66a6da

[FFmpeg-devel] [PATCH v2 2/8] avformat/s337m: Split read_packet/get_packet

Prepare use of s337m_get_packet from outside. --- libavformat/s337m.c | 26 -- libavformat/s337m.h | 37 + 2 files changed, 57 insertions(+), 6 deletions(-) create mode 100644 libavformat/s337m.h diff --git a/libavformat/s337m.c b/libav

[FFmpeg-devel] [PATCH v2 3/8] avformat/s337m: Consider container bit resolution

Prepare the support of s337m in muxers other than raw (ex: wav). For example, this forbids reading 16 bits DolbyE stream from a 24 bit wav file. --- libavformat/s337m.c | 20 ++-- libavformat/s337m.h | 3 ++- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/libavfor

[FFmpeg-devel] [PATCH v2 6/8] avformat/wavdec.c: Reindent after last commit

--- libavformat/wavdec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index d030ed9f9d..3571733817 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c @@ -713,14 +713,14 @@ smv_out: size = FFMIN(S

[FFmpeg-devel] [PATCH v2 4/8] avformat/s337m: New ff_s337m_probe()

Similar to ff_spdif_probe() with just an additional checking of the bit resolution of the container as it may be 16 or 24 for s337m. --- libavformat/s337m.c | 32 libavformat/s337m.h | 16 2 files changed, 48 insertions(+) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wmalosslessdec: move channel check up

On Wed, Jan 15, 2020 at 02:33:28AM +0100, Andreas Rheinhardt wrote: > On Wed, Jan 15, 2020 at 1:25 AM Michael Niedermayer > wrote: > > > Fixes: out of array access > > Fixes: 2nd part of > > 18429/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-6210814364614656 > > > > Found-

Re: [FFmpeg-devel] [PATCH v2 5/8] avformat/wavdec: s337m support

Am Mi., 15. Jan. 2020 um 11:57 Uhr schrieb Nicolas Gaullier : > > Add s337m probing/reading similarly to spdif. > --- > libavformat/wavdec.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c > index 575c667

Re: [FFmpeg-devel] [PATCH v2 7/8] avformat/wavdec: fix s337m/spdif probing beyond data_end

Am Mi., 15. Jan. 2020 um 11:56 Uhr schrieb Nicolas Gaullier : > > --- > libavformat/wavdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c > index 3571733817..d8a27c79cf 100644 > --- a/libavformat/wavdec.c > +++ b/libavformat/w

[FFmpeg-devel] [PATCH]ffmpeg: Do not exit if alleged error was only worth a debug information

Hi! Attached patch fixes hard-to-understand behaviour of ffmpeg for some mp4 input files, a hard exit following a debug message. Please comment, Carl Eugen From b4b6d426fadacef4b1e912e8be6d06520093a955 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 15 Jan 2020 14:48:02 +0100 Subject:

Re: [FFmpeg-devel] [PATCH v2 7/8] avformat/wavdec: fix s337m/spdif probing beyond data_end

>> >> --- >> libavformat/wavdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index >> 3571733817..d8a27c79cf 100644 >> --- a/libavformat/wavdec.c >> +++ b/libavformat/wavdec.c >> @@ -77,7 +77,7 @@ static void set_spdif_s

Re: [FFmpeg-devel] [PATCH v2 7/8] avformat/wavdec: fix s337m/spdif probing beyond data_end

Am Mi., 15. Jan. 2020 um 16:07 Uhr schrieb Gaullier Nicolas : > > >> > >> --- > >> libavformat/wavdec.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index > >> 3571733817..d8a27c79cf 100644 > >> --- a/libavformat/wavd

[FFmpeg-devel] [PATCH] avfilter/pad: improve error check for w and h

Target dimensions have to cover entire input. --- libavfilter/vf_pad.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_pad.c b/libavfilter/vf_pad.c index 186d3f028d..e86292eaa2 100644 --- a/libavfilter/vf_pad.c +++ b/libavfilter/vf_pad.c @@ -178,14 +178,1

Re: [FFmpeg-devel] [PATCH]ffmpeg: Do not exit if alleged error was only worth a debug information

On Wed, 15 Jan 2020, Carl Eugen Hoyos wrote: Hi! Attached patch fixes hard-to-understand behaviour of ffmpeg for some mp4 input files, a hard exit following a debug message. I don't think such an mp4 file is strictly valid, therefore the behavior of the program should remain the same, it s

[FFmpeg-devel] [PATCH] lavf/libsrt: nonblock enabling correction

As written in https://github.com/Haivision/srt/blob/v1.4.1/docs/API.md, the nonblock mode is activated if SRTO_SNDSYN and SRTO_RCVSYN, for sending and receiving respectively, are set to 0. --- libavformat/libsrt.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libav

Re: [FFmpeg-devel] [PATCH v2 5/8] avformat/wavdec: s337m support

>> Add s337m probing/reading similarly to spdif. >> --- >> libavformat/wavdec.c | 23 +++ >> 1 file changed, 19 insertions(+), 4 deletions(-) >> >> diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index >> 575c667452..d030ed9f9d 100644 >> --- a/libavformat/wavdec.c >>

Re: [FFmpeg-devel] [PATCH v2 5/8] avformat/wavdec: s337m support

Am Mi., 15. Jan. 2020 um 19:16 Uhr schrieb Gaullier Nicolas : > > >> Add s337m probing/reading similarly to spdif. > >> --- > >> libavformat/wavdec.c | 23 +++ > >> 1 file changed, 19 insertions(+), 4 deletions(-) > >> > >> diff --git a/libavformat/wavdec.c b/libavformat/wavdec

Re: [FFmpeg-devel] [PATCH 2/9] swscale: Add swscale input support for Y210LE

Am Mi., 15. Jan. 2020 um 07:59 Uhr schrieb Linjie Fu : > > Add swscale input support for Y210LE, output support and fate > test could be added later if there is requirement for software > CSC to this packed format. Please confirm that this works as expected on big-endian hardware. Thank you, Carl

Re: [FFmpeg-devel] [PATCH] lavf/libsrt: nonblock enabling correction

On Wed, 15 Jan 2020, Anthony Delannoy wrote: As written in https://github.com/Haivision/srt/blob/v1.4.1/docs/API.md, the nonblock mode is activated if SRTO_SNDSYN and SRTO_RCVSYN, for sending and receiving respectively, are set to 0. --- libavformat/libsrt.c | 10 +- 1 file changed, 5 i

Re: [FFmpeg-devel] [PATCHv2 8/8] avformat/img2enc: add support for specifying protocol options

On Thu, 9 Jan 2020, Michael Niedermayer wrote: On Wed, Jan 01, 2020 at 08:10:06PM +0100, Marton Balint wrote: On Tue, 31 Dec 2019, Michael Niedermayer wrote: On Tue, Dec 31, 2019 at 12:37:02PM +0100, Nicolas George wrote: Marton Balint (12019-12-28): v2: simplified example Signed-off-b

Re: [FFmpeg-devel] [PATCH 01/13] avformat/mux: Move packet references

On Tue, Oct 8, 2019 at 12:42 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Andreas Rheinhardt: > > Andreas Rheinhardt: > >> In the common case that the input packet was already refcounted, > >> ff_interleave_add_packet would allocate a new AVPacketList, use > >> av_packet_ref to c

[FFmpeg-devel] [PATCH] avcodec/mvha: Check remaining bits in VLC decode loop

Fixes: timeout (252sec -> 170msec) Fixes: 20023/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVHA_fuzzer-5681192565473280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mvha.c | 2 ++ 1

[FFmpeg-devel] [PATCH 2/4] avformat/udp: properly use return value of pthread_cond_timedwait

Signed-off-by: Marton Balint --- libavformat/udp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index e42a069b24..c92fcc49a1 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -978,9 +978,10 @@ static int udp_read(URLContext

[FFmpeg-devel] [PATCH 3/4] avformat/udp: increase the default buffer size of a receiving socket to 384K

It is a common mistake that people only increase fifo_size when they experience drops, unfortunately this does not help for higher bitrate (> 100 Mbps) streams when the reader thread simply might not receive the packets in time (especially under high CPU load) if the default 64 KB of kernel buffer

[FFmpeg-devel] [PATCH 1/4] avformat/udp: add newline after warning

Signed-off-by: Marton Balint --- libavformat/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index f4ec148a2f..e42a069b24 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -861,7 +861,7 @@ static int udp_open(URLContext *h, c

[FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

It is not supported by every threading implementation, and the only thing we gain with it is an immediate shutdown of receiving packets on close and avoiding the poll call before reading the data. I don't think it is a big issue if it takes 0.1 sec of delay to close an udp stream. Back when this w

Re: [FFmpeg-devel] [PATCH v4 1/1] avdevice/gdigrab add use_captureblt option

On 2020/1/15 上午3:01, Calvin Walton wrote: On Sat, 2020-01-11 at 17:18 +0800, fgodt...@hotmail.com wrote: From: FgoDt Add use_captureblt option for disable or use CAPTUREBLT flag, when useing the bitblt function with CAPTUREBLT may caused the Windows mouse cursor flicker. most time we don't ne

Re: [FFmpeg-devel] [PATCH v4 1/1] avdevice/gdigrab add use_captureblt option

On 2020/1/14 上午7:24, Carl Eugen Hoyos wrote: Am Mo., 13. Jan. 2020 um 17:10 Uhr schrieb Derek Buitenhuis : On 11/01/2020 09:18, fgodt...@hotmail.com wrote: From: FgoDt Add use_captureblt option for disable or use CAPTUREBLT flag, when useing the bitblt function with CAPTUREBLT may caused th

[FFmpeg-devel] [PATCH] avutil/avcodec: expanded on channel configurations for spatial audio

--- Changelog | 1 + libavcodec/aacenc.h| 16 libavutil/channel_layout.c | 8 ++ libavutil/channel_layout.h | 64 ++ 4 files changed, 61 insertions(+), 28 deletions(-) diff --git a/Changelog b/Changelog index

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

HI, My comments are in-line. On Tue, Jan 14, 2020 at 8:55 PM James Zern wrote: > On Tue, Jan 14, 2020 at 11:07 AM Wonkap Jang > wrote: > > > > This commit reuses the configuration options for VP8 that enables > > temporal scalability for VP9. It also adds a way to enable three > > preset tempor

[FFmpeg-devel] [PATCH v2] doc/v4l2_m2m: Add documentation

From: Andriy Gelman Signed-off-by: Andriy Gelman --- doc/decoders.texi | 27 +++ doc/encoders.texi | 42 ++ 2 files changed, 69 insertions(+) diff --git a/doc/decoders.texi b/doc/decoders.texi index f18226b3504..7827a055408 100644

[FFmpeg-devel] [PATCH 1/2] avformat/movenc, segafilmenc: Remove unnecessary avio_tell()

When the faststart option for the mov/mp4 muxer is used, the current position (i.e. the size of the already written data pre-shifting) was evaluated twice: First in an initialization and then again later, overwriting the first value without having ever touched it. So remove the initialization. Als

[FFmpeg-devel] [PATCH 2/2] avformat/flvenc: Avoid unnecessary seek

When shifting the already written data in order to write the keyframe index, the flv muxer would first store the pre-shift size, then calculate how big the index will be eventually, then perform some seeks to update some size fields, then seek back to the end of the file to get the new position, fo

Re: [FFmpeg-devel] [PATCH v2] doc/v4l2_m2m: Add documentation

On 16-01-2020 09:44 am, Andriy Gelman wrote: From: Andriy Gelman Signed-off-by: Andriy Gelman --- doc/decoders.texi | 27 +++ doc/encoders.texi | 42 ++ 2 files changed, 69 insertions(+) diff --git a/doc/decoders.texi b/doc

Re: [FFmpeg-devel] [PATCH 2/9] swscale: Add swscale input support for Y210LE

> -Original Message- > From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Thursday, January 16, 2020 02:30 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/9] swscale: Add swscale input support > for Y210LE > > Am Mi., 15.

Re: [FFmpeg-devel] [PATCH V7 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Wednesday, January 15, 2020 05:55 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V7 1/2] libswscale/x86/yuv2rgb: Change > inline assembly into nasm code > > On

Re: [FFmpeg-devel] [PATCH v6] avformat/mov: Memory optimization with QuickTime/MP4

Hi, is there anything I can do to get this patch applied? Cheers, Jörg > -Ursprüngliche Nachricht- > Von: ffmpeg-devel Im Auftrag von Jörg > Beckmann > Gesendet: Mittwoch, 8. Januar 2020 15:49 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] [PATCH v6] avf