Many things have been reviewed. Updates : patch 2 : tomas : updated copyright, moved s337m_read_packet to static patch 3 : tomas : revised 3 cases checking of container_word_bits vs word_bits patch 4 : carl : removed av_log during probing fix 2nd sample check (robustness) requires 3 samples instead of 2, checks container s337 word alignment patch 5 : tomas : merged with "fix 337m last packet parsing" carl : removed the AVOption
I will still have 2 more patchs to do : - a second test asked by Tomas - a global AVOption to disable all codecs autodetection mechanism as discussed with Carl Eugen If possible, I would like to continue this review, but when time will come to apply, I would like to postpone it a little bit to wait for the global AVOption, this is to make sure that users will be able to disable the wav s337m probing if they need to. Thank you all Nicolas Gaullier (8): avformat/s337m: Use base AVClass for av_log usage avformat/s337m: Split read_packet/get_packet avformat/s337m: Consider container bit resolution avformat/s337m: New ff_s337m_probe() avformat/wavdec: s337m support avformat/wavdec.c: Reindent after last commit avformat/wavdec: fix s337m/spdif probing beyond data_end avformat/wavdec: Test s337m libavformat/s337m.c | 82 +++++++++++++++++++++++++++++++++++++++++++--------- libavformat/s337m.h | 54 ++++++++++++++++++++++++++++++++++ libavformat/wavdec.c | 39 +++++++++++++++++-------- tests/Makefile | 1 + tests/fate/audio.mak | 5 ++++ 5 files changed, 155 insertions(+), 26 deletions(-) create mode 100644 libavformat/s337m.h -- 2.14.1.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".