[FFmpeg-devel] [PATCH v2] avutil/eval: add function to track variable use

2019-11-16 Thread Gyan
As suggested by Michael in the review for the vf_scale patch, new eval function tracks count of all variables in a parsed expression in an array. Thanks, Gyan From 6d4d8ab2b582991ccb787d18d14be31256a785aa Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 2 Nov 2019 20:16:42 +0530 Subject: [P

Re: [FFmpeg-devel] [PATCH] avfilter/scale: allow dynamic output via expressions

2019-11-16 Thread Michael Niedermayer
On Fri, Nov 15, 2019 at 11:10:26AM +0530, Gyan wrote: > > > On 15-11-2019 04:01 am, Michael Niedermayer wrote: > >On Thu, Nov 14, 2019 at 11:12:23PM +0530, Gyan wrote: > >> > >>On 14-11-2019 01:12 am, Michael Niedermayer wrote: > >>>Moving and changing code at the same time makes it hard to see t

Re: [FFmpeg-devel] [PATCH v1 4/4] fate/filter-video: add 10bit test for unsharp filter

2019-11-16 Thread Michael Niedermayer
On Fri, Nov 15, 2019 at 11:03:35PM +0800, Limin Wang wrote: > On Mon, Oct 21, 2019 at 08:33:07PM +0200, Michael Niedermayer wrote: > > On Mon, Oct 21, 2019 at 03:55:50PM +0800, Limin Wang wrote: > > > On Tue, Oct 15, 2019 at 04:41:36PM +0200, Michael Niedermayer wrote: > > > > On Mon, Oct 14, 2019

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/mjpeg_parser: Make parser a bit more robust with unclean input

2019-11-16 Thread Paul B Mahol
So you gonna commit this or not? Are there obvious drawbacks? On 10/11/19, Michael Niedermayer wrote: > Helps: test_roman.mjpeg (note this is not really just mjpeg) > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mjpeg_parser.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletion

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mp3dec: Check for occurances of headers within frames during probing

2019-11-16 Thread Paul B Mahol
lgtm On 11/7/19, Michael Niedermayer wrote: > From: Limin Wang > > Fixes misdetection of zYLx.wav > > Co-Author: Michael Niedermayer > Signed-off-by: Michael Niedermayer > --- > libavformat/mp3dec.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH v2] avutil/eval: add function to track variable use

2019-11-16 Thread Michael Niedermayer
On Sat, Nov 16, 2019 at 05:39:56PM +0530, Gyan wrote: > As suggested by Michael in the review for the vf_scale patch, new eval > function tracks count of all variables in a parsed > expression in an array. > > Thanks, > Gyan > doc/APIchanges |3 +++ > libavutil/eval.c| 16

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: fix reading reference order hint in skip_mode_params()

2019-11-16 Thread Ronald S. Bultje
Hi, On Fri, Nov 15, 2019 at 1:44 PM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_av1_syntax_template.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/cbs_av1_syntax_template.c > b/libavcodec/cbs_av1_syntax_template.c > index 80

Re: [FFmpeg-devel] [PATCH v2] avutil/eval: add function to track variable use

2019-11-16 Thread Gyan
On 16-11-2019 08:12 pm, Michael Niedermayer wrote: On Sat, Nov 16, 2019 at 05:39:56PM +0530, Gyan wrote: As suggested by Michael in the review for the vf_scale patch, new eval function tracks count of all variables in a parsed expression in an array. Thanks, Gyan doc/APIchanges |3

[FFmpeg-devel] [PATCH] avfilter/Makefile: add missing dependency for scale_cuda

2019-11-16 Thread Gyan
Was missing since initial commit. Gyan From 470dfb6bcbe3ff1341a3aca77ebc92b5c7acbdbe Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 16 Nov 2019 20:48:10 +0530 Subject: [PATCH] avfilter/Makefile: add missing dependency for scale_cuda scale_cuda includes scale.h --- libavfilter/Makefile |

Re: [FFmpeg-devel] [PATCH v3 2/2] FATE: add a test for colorbalance

2019-11-16 Thread Michael Niedermayer
On Fri, Nov 15, 2019 at 11:12:49PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 12 > tests/ref/fate/filter-colorbalance | 8 > tests/ref/fate/filter-colorbalance-gbrap

[FFmpeg-devel] [PATCH] avfilter: add axcorrelate filter

2019-11-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 32 +++ libavfilter/Makefile | 1 + libavfilter/af_axcorrelate.c | 378 +++ libavfilter/allfilters.c | 1 + 4 files changed, 412 insertions(+) create mode 100644 libavfilter/af_axcorre

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: fix reading reference order hint in skip_mode_params()

2019-11-16 Thread James Almer
On 11/16/2019 11:56 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Nov 15, 2019 at 1:44 PM James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_av1_syntax_template.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/cbs_av1_syntax_

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpeg: Remove secondary packet for reading VobSub

2019-11-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> When vobsub_read_packet() reads a packet, it uses a dedicated AVPacket >> to get the subtitle timing and position from an FFDemuxSubtitlesQueue >> (which has been filled with this data during reading the idx file in >> vobsub_read_header); afterwards the

Re: [FFmpeg-devel] [PATCH] lavf/rtmpproto: fix the playpath truncation if the len > 512

2019-11-16 Thread Michael Niedermayer
On Fri, Nov 15, 2019 at 07:46:33PM +0800, Jun Zhao wrote: > From: Jun Zhao > > fix the playpath truncation if the len > 512 > > Found-by: liuwenhuang > Signed-off-by: Jun Zhao > --- > libavformat/rtmpproto.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) LGTM thx [...]

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/put_bits: Relax requirements to rebase PutBitContext

2019-11-16 Thread Michael Niedermayer
On Sat, Nov 16, 2019 at 06:24:29AM +0100, Andreas Rheinhardt wrote: > The earlier requirement was for the new buffer to be bigger than the old > one. This has been relaxed to only demand that the new buffer can hold > all the data written so far. This is in preparation for further commits. > > Sig

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix typo in help text

2019-11-16 Thread Michael Niedermayer
On Sat, Nov 16, 2019 at 12:33:59AM +0800, Zhao Zhili wrote: > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies dege

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/mjpeg_parser: Make parser a bit more robust with unclean input

2019-11-16 Thread Michael Niedermayer
On Fri, Oct 11, 2019 at 12:40:11AM +0200, Michael Niedermayer wrote: > Helps: test_roman.mjpeg (note this is not really just mjpeg) > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mjpeg_parser.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) will apply [...] -- Michae

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mp3dec: Check for occurances of headers within frames during probing

2019-11-16 Thread Michael Niedermayer
On Sat, Nov 16, 2019 at 02:57:47PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyrant has disposed of foreign enemies by conquest or treaty, and there is nothing more to fear from them, then he is al

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mp3dec: Check that the frame fits within the probe buffer

2019-11-16 Thread Michael Niedermayer
On Thu, Nov 07, 2019 at 10:25:31PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mp3dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not

Re: [FFmpeg-devel] [PATCH] [PATCH] avcodec: Add more kCVImageBufferColorPrimaries to videotoolboxenc

2019-11-16 Thread Nomis101
Thanks for reviewing. Would be nice, if somebody could push to master then. I can't. Am 15.11.19 um 15:58 schrieb Limin Wang: > On Sun, Nov 03, 2019 at 01:20:38AM +0100, Nomis101 wrote: >> --- >> libavcodec/videotoolboxenc.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/l

Re: [FFmpeg-devel] [PATCH] [PATCH] avcodec: Add more kCVImageBufferColorPrimaries to videotoolboxenc

2019-11-16 Thread Richard Kern
> On Nov 16, 2019, at 7:03 PM, Nomis101 wrote: > > Thanks for reviewing. Would be nice, if somebody could push to master then. > I can't. > > I’ll test it out tomorrow and push. > >> Am 15.11.19 um 15:58 schrieb Limin Wang: >>> On Sun, Nov 03, 2019 at 01:20:38AM +0100, Nomis101 wrote: >>

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Async the encoding and output procedure of encoder

2019-11-16 Thread Dennis Mungai
On Sun, 17 Nov 2019, 06:36 Dennis Mungai, wrote: > > > On Thu, 14 Nov 2019, 18:29 Fu, Linjie, wrote: > >> > -Original Message- >> > From: ffmpeg-devel On Behalf Of Fu, >> > Linjie >> > Sent: Monday, November 11, 2019 17:43 >> > To: ffmpeg-devel@ffmpeg.org >> > Subject: Re: [FFmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Async the encoding and output procedure of encoder

2019-11-16 Thread Dennis Mungai
On Thu, 14 Nov 2019, 18:29 Fu, Linjie, wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of Fu, > > Linjie > > Sent: Monday, November 11, 2019 17:43 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Async the > > encoding and output p

[FFmpeg-devel] [PATCH v2 0/6] Improve writing units

2019-11-16 Thread Andreas Rheinhardt
This patchset supersedes my earlier patches [1], [2], [3]. The main difference between the earlier version is that I have avoided the repetition in [2] by factoring out the common parts of writing units into a single function in cbs.c. This does not hinder the efforts of reducing memcpy in any way:

[FFmpeg-devel] [PATCH v2 3/6] avcodec/cbs_vp9: Write frame data directly

2019-11-16 Thread Andreas Rheinhardt
Writing a unit (always a frame) in cbs_vp9 used an intermediate buffer to write the frame header followed by the frame data that was copied into said buffer. Afterwards, the final buffer for the frame was allocated and everything copied into this buffer. But it is trivial to compute the needed size

[FFmpeg-devel] [PATCH v2 2/6] avcodec/cbs: Fix potential overflow

2019-11-16 Thread Andreas Rheinhardt
The number of bits in a PutBitContext must fit into an int, yet nothing guaranteed the size argument cbs_write_unit_data() uses in init_put_bits() to be in the range 0..INT_MAX / 8. This has been changed. Furthermore, the check 8 * data_size > data_bit_start that there is data beyond the initial p

[FFmpeg-devel] [PATCH v2 4/6] avcodec/cbs_h2645: Write slice data directly

2019-11-16 Thread Andreas Rheinhardt
Up until now, writing the data of a slice uses an intermediate buffer into which the unit (both header as well as the rest) is assembled before being copied into a freshly allocated buffer. But given that one has a very good upper bound on the size needed before one starts copying the slice data, o

[FFmpeg-devel] [PATCH v2 6/6] avcodec/cbs_jpeg: Write scan data directly

2019-11-16 Thread Andreas Rheinhardt
Writing the scan element in cbs_jpeg used an intermediate buffer to write the scan header followed by the scan data that was copied into said buffer. Afterwards, the final buffer for the element was allocated and everything copied into this buffer. But it is trivial to compute the needed size of th

[FFmpeg-devel] [PATCH v2 1/6] avcodec/cbs: Factor out common code for writing units

2019-11-16 Thread Andreas Rheinhardt
All cbs-functions to write units share a common pattern: 1. They check whether they have a write buffer (that is used to store the unit's data until the needed size becomes known after writing the unit when a dedicated buffer will be allocated). 2. They use this buffer for a PutBitContext. 3. The (

[FFmpeg-devel] [PATCH v2 5/6] avcodec/cbs_jpeg: Use memcpy when writing pictures

2019-11-16 Thread Andreas Rheinhardt
This is possible because the size of a scan header is always a multiple of a byte. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_jpeg.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/cbs_jpeg.c b/libavcodec/cbs_jpeg.c index b189cbd9b7..64fe70beab