[FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq

2019-09-18 Thread Ting Fu
Signed-off-by: Ting Fu --- libavfilter/vf_eq.c | 13 --- libavfilter/vf_eq.h | 1 + tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + tests/checkasm/vf_eq.c| 79 +++ tests/fate/checkasm.m

[FFmpeg-devel] [PATCH V2 3/3] avfilter/x86/vf_eq: add SSE2 version

2019-09-18 Thread Ting Fu
Signed-off-by: Ting Fu --- libavfilter/x86/vf_eq.asm| 12 ++-- libavfilter/x86/vf_eq_init.c | 19 +++ 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/libavfilter/x86/vf_eq.asm b/libavfilter/x86/vf_eq.asm index 8460342896..a30a287029 100644 --- a/libavfi

[FFmpeg-devel] [PATCH V2 2/3] avfilter/x86/vf_eq: Change inline assembly into nasm code

2019-09-18 Thread Ting Fu
Signed-off-by: Ting Fu --- libavfilter/x86/Makefile | 3 +- libavfilter/x86/vf_eq.asm| 82 ++ libavfilter/x86/vf_eq.c | 96 libavfilter/x86/vf_eq_init.c | 55 + 4 files changed, 139 insertions(+), 9

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Paul B Mahol
On 9/18/19, Hyun Yoo wrote: > According to wiki, g.722.1 is not variants of G.722 and > they use different patented compression technologies. > > There is a reference code in ITU-T > https://www.itu.int/rec/T-REC-G.722.1-200505-I/en > and the freeswitch version is a wrapper with cleaner api. > (I

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/x86/vf_eq: add SSE2 version

2019-09-18 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > James Almer > Sent: Tuesday, September 17, 2019 09:56 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 3/3] avfilter/x86/vf_eq: add SSE2 version > > On 9/17/2019 10:39 A

Re: [FFmpeg-devel] [PATCH] lavf/vf_deinterlace_vaapi: flush queued frame in field mode

2019-09-18 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Wednesday, August 21, 2019 04:49 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavf/vf_deinterlace_vaapi: flush > queued frame in field mode > > On

[FFmpeg-devel] [PATCH, v2 3/3] swscale: Add swscale input support for Y210

2019-09-18 Thread Linjie Fu
Add swscale input support for Y210, output support and fate test could be added later if there is requirement for software CSC to this packed format. Signed-off-by: Linjie Fu --- libswscale/input.c | 48 libswscale/utils.c | 2 ++ 2 files changed

[FFmpeg-devel] [PATCH, v2] lavf/vf_deinterlace_vaapi: flush queued frame for field in DeinterlacingBob

2019-09-18 Thread Linjie Fu
For DeinterlacingBob mode with rate=field, the frame number of output should equal 2x input total since only intra deinterlace is used. Currently for "backward_ref = 0, rate = field", extra_delay is introduced. Due to the async without flush, frame number of output is [expected_number - 2]. Speci

Re: [FFmpeg-devel] [PATCH, v2 3/3] swscale: Add swscale input support for Y210

2019-09-18 Thread Carl Eugen Hoyos
> Am 18.09.2019 um 10:20 schrieb Linjie Fu : > > Add swscale input support for Y210, output support and fate > test could be added later if there is requirement for software > CSC to this packed format. Is the patch missing support for 16bit output or does the infrastructure not allow this? C

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Carl Eugen Hoyos
> Am 18.09.2019 um 07:34 schrieb Hyun Yoo : > > How can I mark the new external codec as “nonfree” in configure? Search for “NONFREE” in configure. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Paul B Mahol
On 9/18/19, Carl Eugen Hoyos wrote: > > > >> Am 18.09.2019 um 07:34 schrieb Hyun Yoo : >> >> How can I mark the new external codec as “nonfree” in configure? > > Search for “NONFREE” in configure. Not needed. NONFREE decoders are not alowed in out codebase. > > Carl Eugen >

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Carl Eugen Hoyos
> Am 18.09.2019 um 10:52 schrieb Paul B Mahol : > >> On 9/18/19, Carl Eugen Hoyos wrote: >> >> >> >>> Am 18.09.2019 um 07:34 schrieb Hyun Yoo : >>> >>> How can I mark the new external codec as “nonfree” in configure? >> >> Search for “NONFREE” in configure. > > > Not needed. NONFREE deco

Re: [FFmpeg-devel] [PATCH, v2 3/3] swscale: Add swscale input support for Y210

2019-09-18 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Wednesday, September 18, 2019 16:44 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2 3/3] swscale: Add swsca

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Hendrik Leppkes
On Wed, Sep 18, 2019 at 11:00 AM Carl Eugen Hoyos wrote: > > > > > Am 18.09.2019 um 10:52 schrieb Paul B Mahol : > > > >> On 9/18/19, Carl Eugen Hoyos wrote: > >> > >> > >> > >>> Am 18.09.2019 um 07:34 schrieb Hyun Yoo : > >>> > >>> How can I mark the new external codec as “nonfree” in configure?

[FFmpeg-devel] Adding ICC profile support to MOV decode/encode

2019-09-18 Thread Hello Vectronic
Hello, I need to implement support for reading and writing ICC profiles which can be stored in MOV/MP4 sample descriptor colour information. The relevant extract from the ISO standard is: class ColourInformationBox extends Box('colr'){ unsigned int(32) colour_type; if (colour_type == 'n

Re: [FFmpeg-devel] Adding ICC profile support to MOV decode/encode

2019-09-18 Thread Hendrik Leppkes
On Wed, Sep 18, 2019 at 11:37 AM Hello Vectronic wrote: > > Hello, > > I need to implement support for reading and writing ICC profiles which can be > stored in MOV/MP4 sample descriptor colour information. > > The relevant extract from the ISO standard is: > > class ColourInformationBox extends

Re: [FFmpeg-devel] Adding ICC profile support to MOV decode/encode

2019-09-18 Thread Hello Vectronic
> On 18 Sep 2019, at 11:09, Hendrik Leppkes wrote: > > On Wed, Sep 18, 2019 at 11:37 AM Hello Vectronic > wrote: >> >> Hello, >> >> I need to implement support for reading and writing ICC profiles which can >> be stored in MOV/MP4 sample descriptor colour information. >> >> The relevant ex

Re: [FFmpeg-devel] [PATCH v2] Add option to log timing

2019-09-18 Thread Moritz Barsnick
On Wed, Sep 18, 2019 at 00:38:13 +, Soft Works wrote: > You're correct, It's a superset. I found it more convenient to do it like > this because: > - It would make little sense printing only the date for each line > - I wanted to avoid requiring a user to specify two separate flags to get > b

Re: [FFmpeg-devel] [PATCH v3 0/3] avformat/hashenc: add streamhash muxer

2019-09-18 Thread Moritz Barsnick
On Thu, Sep 12, 2019 at 11:23:03 +0200, Moritz Barsnick wrote: > Moritz Barsnick (3): > avformat/hashenc: rearrange options definition > avformat/hashenc: use an array of hashes > avformat/hashenc: add streamhash muxer Friendly ping for the patch set. Moritz

Re: [FFmpeg-devel] [PATCH v1 1/4] avcodec/lcldec: remove the unnecessary type conversion

2019-09-18 Thread Limin Wang
On Thu, Sep 12, 2019 at 12:55:09PM +0200, Carl Eugen Hoyos wrote: > Am Do., 12. Sept. 2019 um 11:24 Uhr schrieb : > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/lcldec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/l

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter/vf_scale: change filter_frame interface to activate interface

2019-09-18 Thread Limin Wang
ping, patchset 1 is merged already. On Sat, Sep 07, 2019 at 11:11:26PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_scale.c | 36 +++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff -

Re: [FFmpeg-devel] [PATCH v1 1/3] avfilter/f_sidedata: try to fix warning: comparison of constant -1 with expression of type 'enum AVFrameSideDataType'

2019-09-18 Thread Limin Wang
ping for this patch, other patchset are merged. On Sun, Aug 25, 2019 at 12:17:58AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/f_sidedata.c | 10 +- > libavutil/frame.h| 10 ++ > 2 files changed, 15 insertio

Re: [FFmpeg-devel] Adding ICC profile support to MOV decode/encode

2019-09-18 Thread Derek Buitenhuis
On 18/09/2019 10:30, Hello Vectronic wrote: > The relevant extract from the ISO standard is: Where is the relevant extract for MOV mode? The QTFF docs literally say[1]: If the color parameter type is 'prof', then this field is followed by an ICC profile. This is the color model used by A

Re: [FFmpeg-devel] Adding ICC profile support to MOV decode/encode

2019-09-18 Thread Derek Buitenhuis
On 18/09/2019 10:30, Hello Vectronic wrote: > I need to implement support for reading and writing ICC profiles which can be > stored in MOV/MP4 sample descriptor colour information. Does anything exist that can even consume or produce these sorts of files? I looked a while back, and found litera

Re: [FFmpeg-devel] [PATCH] libavcodec/libx264 and libx265: add a flag to output ROI warnings only once.

2019-09-18 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Guo, Yejun > Sent: Wednesday, September 11, 2019 8:55 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/libx264 and libx265: add a flag > to output ROI warning

Re: [FFmpeg-devel] [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9

2019-09-18 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: Thursday, September 12, 2019 6:25 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for > VP8/VP9 > > example command line to verify it: > ./ffmpeg -i input.stream -vf

Re: [FFmpeg-devel] Adding ICC profile support to MOV decode/encode

2019-09-18 Thread Hello Vectronic
> On 18 Sep 2019, at 15:27, Derek Buitenhuis wrote: > > On 18/09/2019 10:30, Hello Vectronic wrote: >> I need to implement support for reading and writing ICC profiles which can >> be stored in MOV/MP4 sample descriptor colour information. > > Does anything exist that can even consume or produc

Re: [FFmpeg-devel] Adding ICC profile support to MOV decode/encode

2019-09-18 Thread Derek Buitenhuis
On 18/09/2019 17:29, Hello Vectronic wrote: > And here is an example file: http://vectronic.io/icc-profile/icc-profile.mov > > And here is the relevant standard: > https://standards.iso.org/ittf/PubliclyAvailableStandards/c068960_ISO_IEC_14496-12_2015.zip > Of note, the example file is not ISOB

Re: [FFmpeg-devel] [PATCH] avutil/encryption_info: Don't pass NULL to memcpy

2019-09-18 Thread Tomas Härdin
ons 2019-09-18 klockan 02:03 +0200 skrev Andreas Rheinhardt: > The pointer arguments to memcpy (and several other functions of the > C standard library) are not allowed to be NULL, not even when the number > of bytes to copy is zero. An AVEncryptionInitInfo's data pointer is > explicitly allowed to

Re: [FFmpeg-devel] [PATCH v1 1/3] avfilter/f_sidedata: try to fix warning: comparison of constant -1 with expression of type 'enum AVFrameSideDataType'

2019-09-18 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 12:17:58AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/f_sidedata.c | 10 +- > libavutil/frame.h| 10 ++ > 2 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/libavfilte

Re: [FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-18 Thread Marton Balint
On Wed, 18 Sep 2019, Limin Wang wrote: On Tue, Sep 17, 2019 at 06:22:39PM +0200, Marton Balint wrote: On Mon, 16 Sep 2019, Tomas Härdin wrote: >mån 2019-09-16 klockan 09:03 +0800 skrev lance.lmw...@gmail.com: >>From: Limin Wang >> >>Signed-off-by: Limin Wang >>--- >> libavutil/avstring.c

Re: [FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-18 Thread Tomas Härdin
ons 2019-09-18 klockan 06:41 +0800 skrev Limin Wang: > On Tue, Sep 17, 2019 at 06:22:39PM +0200, Marton Balint wrote: > > > > On Mon, 16 Sep 2019, Tomas Härdin wrote: > > > > > mån 2019-09-16 klockan 09:03 +0800 skrev lance.lmw...@gmail.com: > > > > From: Limin Wang > > > > > > > > Signed-off-b

Re: [FFmpeg-devel] [PATCH] Delete unused branch in libaomenc

2019-09-18 Thread James Zern
On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky wrote: > > --- > libavcodec/libaomenc.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > lgtm. This is leftover from libvpxenc, only vp8 can hit the path there. > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaome

Re: [FFmpeg-devel] [PATCH] Delete unused branch in libaomenc

2019-09-18 Thread James Zern
On Wed, Sep 18, 2019 at 11:42 AM James Zern wrote: > > On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky > wrote: > > > > --- > > libavcodec/libaomenc.c | 14 +- > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > lgtm. This is leftover from libvpxenc, only vp8 can hit the

Re: [FFmpeg-devel] [PATCH v3 0/3] avformat/hashenc: add streamhash muxer

2019-09-18 Thread James Almer
On 9/18/2019 10:47 AM, Moritz Barsnick wrote: > On Thu, Sep 12, 2019 at 11:23:03 +0200, Moritz Barsnick wrote: >> Moritz Barsnick (3): >> avformat/hashenc: rearrange options definition >> avformat/hashenc: use an array of hashes >> avformat/hashenc: add streamhash muxer > > Friendly ping for

Re: [FFmpeg-devel] [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9

2019-09-18 Thread James Zern
On Wed, Sep 18, 2019 at 7:54 AM Guo, Yejun wrote: > > > > > -Original Message- > > From: Guo, Yejun > > Sent: Thursday, September 12, 2019 6:25 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Guo, Yejun > > Subject: [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for > > VP8/VP9 >

[FFmpeg-devel] [PATCH v4 4/4] hevc_mp4toannexb: Parse extradata directly from HVCC format

2019-09-18 Thread Andriy Gelman
From: Andriy Gelman Since the original extradata is in HVCC format, there is no need to segment the output extradata into nal units. --- libavcodec/hevc_mp4toannexb_bsf.c | 66 --- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/libavcodec/hevc_mp4toan

[FFmpeg-devel] [PATCH v4 3/4] fate: Add tests for hevc_mp4annexb bsf

2019-09-18 Thread Andriy Gelman
From: Andriy Gelman Test hevc-mp4annexb-pps: Test contains 63 PPS that are signalled in extradata. Different PPS are referenced by the VCL nal units during the mp4 to annexb conversion. Test hevc-mp4annexb-sps: Access units contain PPS that reference different cached SPS nal units. --- tests/fa

[FFmpeg-devel] [PATCH v4 1/4] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-09-18 Thread Andriy Gelman
From: Andriy Gelman Fixes #7799 Currently, the mp4toannexb filter always inserts the same extradata at the start of the first IRAP unit. As in ticket #7799, this can lead to decoding errors if modified parameter sets are signalled in-band. This commit keeps track of the VPS/SPS/PPS parameter se

[FFmpeg-devel] [PATCH v4 2/4] fate: Overwrite output file in hevc-bsf-mp4toannexb test

2019-09-18 Thread Andriy Gelman
From: Andriy Gelman Overwrite tests/data/fate/hevc-bsf-mp4toannexb.out in case it exists. --- tests/fate/hevc.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 4f812b0834..b11e209be0 100644 --- a/tests/fate/hevc.mak +++ b/test

[FFmpeg-devel] [PATCH v4 0/4] hevc_mp4toannexb: Insert correct parameter sets

2019-09-18 Thread Andriy Gelman
Changes in v4: - Always insert SEI from extradata before IRAP (same approach as original code). New SEIs are inserted before IRAP, or forwarded after the nal unit. - Before writing each VCL, I check whether the PPS has already been signalled in the CVS. If it hasn't been signall

Re: [FFmpeg-devel] [PATCH v2] libavformat/rtsp: return error if rtsp_hd_out is null instead of crash

2019-09-18 Thread Michael Niedermayer
On Wed, Sep 18, 2019 at 07:54:27AM +0100, phunkyfish wrote: > --- > libavformat/rtsp.c | 3 +++ > 1 file changed, 3 insertions(+) The Author lacks your name "From: phunkyfish " is that intended ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State

Re: [FFmpeg-devel] [PATCH v2] Fix printing integer option defaults

2019-09-18 Thread Michael Niedermayer
On Tue, Sep 17, 2019 at 01:36:33AM +, Soft Works wrote: > Integer values should not be printed using format specifier '%g' which leads > to inexact display in case of higher values. > > Before this patch: > -trans_color .D.V. color value [...] (default > 1.67772e+07) > >

Re: [FFmpeg-devel] [PATCH v2] libavformat/rtsp: return error if rtsp_hd_out is null instead of crash

2019-09-18 Thread Ross Nicholson
Sorry, my name is Ross Nicholson. But the alias is fine too. > On 18 Sep 2019, at 21:14, Michael Niedermayer wrote: > >> On Wed, Sep 18, 2019 at 07:54:27AM +0100, phunkyfish wrote: >> --- >> libavformat/rtsp.c | 3 +++ >> 1 file changed, 3 insertions(+) > > The Author lacks your name > "From: ph

Re: [FFmpeg-devel] [PATCH v4 2/4] fate: Overwrite output file in hevc-bsf-mp4toannexb test

2019-09-18 Thread Carl Eugen Hoyos
Am Mi., 18. Sept. 2019 um 21:38 Uhr schrieb Andriy Gelman : > > From: Andriy Gelman > > Overwrite tests/data/fate/hevc-bsf-mp4toannexb.out in case it exists. > --- > tests/fate/hevc.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.

[FFmpeg-devel] [PATCH v3] libavformat/rtsp: return error if rtsp_hd_out is null instead of crash

2019-09-18 Thread phunkyfish
--- libavformat/rtsp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index c153cac88b..5e8adfaf3c 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1318,6 +1318,9 @@ static int rtsp_send_cmd_with_content_async(AVFormatContext *s, ch

Re: [FFmpeg-devel] [PATCH v3] libavformat/rtsp: return error if rtsp_hd_out is null instead of crash

2019-09-18 Thread Ross Nicholson
Technically this function should also return an error is rt is NULL. Which error code would apply for this? On Wed, 18 Sep 2019 at 21:42, phunkyfish wrote: > --- > libavformat/rtsp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index c153

Re: [FFmpeg-devel] [PATCH v3] libavformat/rtsp: return error if rtsp_hd_out is null instead of crash

2019-09-18 Thread Ross Nicholson
Checking other functions I don't see this checked for so I guess latest patch is fine. On Wed, 18 Sep 2019 at 21:51, Ross Nicholson wrote: > Technically this function should also return an error is rt is NULL. Which > error code would apply for this? > > On Wed, 18 Sep 2019 at 21:42, phunkyfish

Re: [FFmpeg-devel] [PATCH v2 2/8] avformat/internal: Improve documentation of ff_packet_list_get

2019-09-18 Thread Michael Niedermayer
On Mon, Aug 19, 2019 at 11:56:18PM +0200, Andreas Rheinhardt wrote: > The documentation of ff_packet_list_get currently didn't match the > actual usage: > 1. It said that the destination packet is supposed to be initialized. > But this makes no sense given that it will be overwritten completely and

Re: [FFmpeg-devel] [PATCH v2 3/8] avformat/utils: Preserve integrity of linked list

2019-09-18 Thread Michael Niedermayer
On Mon, Aug 19, 2019 at 11:56:19PM +0200, Andreas Rheinhardt wrote: > 1. Instead of relying on ff_packet_list_get to get the oldest element in > an AVPacketList, ff_read_packet used its own ad-hoc code. Said code > forgot to set the end of the list to NULL if the last element of the > list has been

Re: [FFmpeg-devel] [PATCH 02/10] avcodec/mjpegdec: Unify switch statements

2019-09-18 Thread Michael Niedermayer
On Wed, Sep 18, 2019 at 05:25:59AM +0200, Andreas Rheinhardt wrote: > This has been forgotten in d5a3a20d. > > Found via PVS-Studio (see ticket #8156). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mjpegdec.c | 5 - > 1 file changed, 5 deletions(-) will apply thx [...] -- Mic

Re: [FFmpeg-devel] [PATCH v2] Fix printing integer option defaults

2019-09-18 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Wednesday, September 18, 2019 10:28 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] Fix printing integer option defaults > > On Tue, Sep 17,

Re: [FFmpeg-devel] [PATCH 08/10] avcodec/avpacket: Improve allocating packets

2019-09-18 Thread Michael Niedermayer
On Wed, Sep 18, 2019 at 05:26:05AM +0200, Andreas Rheinhardt wrote: > av_mallocz + av_init_packet leads to the same result as av_mallocz + > av_packet_unref, but faster. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/avpacket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) w

Re: [FFmpeg-devel] [PATCH 10/10] avutil/common: Fix undefined shift

2019-09-18 Thread Michael Niedermayer
On Wed, Sep 18, 2019 at 05:26:07AM +0200, Andreas Rheinhardt wrote: > av_mod_uintp2_c uses a bitwise AND with (1 << p) - 1 to clear the high > bits of an unsigned int. But this is undefined if p == 31, because 1 is > an int and 2^31 is not representable in an int. So make 1 unsigned. > > Signed-of

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/v210enc: add depth parameter for WRITE_PIXELS and CLIP

2019-09-18 Thread Michael Niedermayer
On Tue, Sep 17, 2019 at 11:42:26AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/v210enc.c | 83 +++- > 1 file changed, 36 insertions(+), 47 deletions(-) will apply the patchset thx [...] -- M

Re: [FFmpeg-devel] [PATCH v4 2/4] fate: Overwrite output file in hevc-bsf-mp4toannexb test

2019-09-18 Thread Andriy Gelman
On Wed, 18. Sep 22:34, Carl Eugen Hoyos wrote: > Am Mi., 18. Sept. 2019 um 21:38 Uhr schrieb Andriy Gelman > : > > > > From: Andriy Gelman > > > > Overwrite tests/data/fate/hevc-bsf-mp4toannexb.out in case it exists. > > --- > > tests/fate/hevc.mak | 2 +- > > 1 file changed, 1 insertion(+), 1 de

Re: [FFmpeg-devel] [PATCH v4 2/4] fate: Overwrite output file in hevc-bsf-mp4toannexb test

2019-09-18 Thread Carl Eugen Hoyos
Am Mi., 18. Sept. 2019 um 23:15 Uhr schrieb Andriy Gelman : > > On Wed, 18. Sep 22:34, Carl Eugen Hoyos wrote: > > Am Mi., 18. Sept. 2019 um 21:38 Uhr schrieb Andriy Gelman > > : > > > > > > From: Andriy Gelman > > > > > > Overwrite tests/data/fate/hevc-bsf-mp4toannexb.out in case it exists. > > >

Re: [FFmpeg-devel] [PATCH v4 2/4] fate: Overwrite output file in hevc-bsf-mp4toannexb test

2019-09-18 Thread Andriy Gelman
On Wed, 18. Sep 23:39, Carl Eugen Hoyos wrote: > Am Mi., 18. Sept. 2019 um 23:15 Uhr schrieb Andriy Gelman > : > > > > On Wed, 18. Sep 22:34, Carl Eugen Hoyos wrote: > > > Am Mi., 18. Sept. 2019 um 21:38 Uhr schrieb Andriy Gelman > > > : > > > > > > > > From: Andriy Gelman > > > > > > > > Overwrit

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Carl Eugen Hoyos
Am Di., 17. Sept. 2019 um 10:14 Uhr schrieb Andrey Semashev : > > On 2019-09-17 03:29, Hyun Yoo wrote: > > I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 > > as external lib like libilbc, libspeex(ex. configure --enable-libg722_1) > > (https://github.com/traviscross/freeswitch/tr

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Carl Eugen Hoyos
Am Di., 17. Sept. 2019 um 02:37 Uhr schrieb Hyun Yoo : > > I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 > as external lib like libilbc, libspeex(ex. configure --enable-libg722_1) > (https://github.com/traviscross/freeswitch/tree/master/libs/libg722_1) Please provide your patch

Re: [FFmpeg-devel] [PATCH 05/10] avformat/asfdec_o: Unify switch cases

2019-09-18 Thread Carl Eugen Hoyos
Am Mi., 18. Sept. 2019 um 05:33 Uhr schrieb Andreas Rheinhardt : > > Found via PVS-Studio (see ticket #8156). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/asfdec_o.c | 4 +--- Instead please remove this demuxer, it cannot be used for any testing. Carl Eugen _

Re: [FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

2019-09-18 Thread Limin Wang
On Wed, Sep 18, 2019 at 08:25:40PM +0200, Marton Balint wrote: > > > On Wed, 18 Sep 2019, Limin Wang wrote: > > >On Tue, Sep 17, 2019 at 06:22:39PM +0200, Marton Balint wrote: > >> > >> > >>On Mon, 16 Sep 2019, Tomas Härdin wrote: > >> > >>>mån 2019-09-16 klockan 09:03 +0800 skrev lance.lmw...@g

Re: [FFmpeg-devel] [PATCH v1 1/3] avfilter/f_sidedata: try to fix warning: comparison of constant -1 with expression of type 'enum AVFrameSideDataType'

2019-09-18 Thread Limin Wang
On Wed, Sep 18, 2019 at 08:23:46PM +0200, Michael Niedermayer wrote: > On Sun, Aug 25, 2019 at 12:17:58AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/f_sidedata.c | 10 +- > > libavutil/frame.h| 10 +

Re: [FFmpeg-devel] [PATCH 4/4] FATE/dnn: add unit test for dnn depth_to_space layer

2019-09-18 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: Thursday, September 05, 2019 2:01 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH 4/4] FATE/dnn: add unit test for dnn depth_to_space layer > > 'make fate-dnn-layer-depth2space' to run the test > > Signed-off-by: Guo,

[FFmpeg-devel] [PATCH v2] avfilter/f_sidedata: try to fix warning: comparison of constant -1 with expression of type 'enum AVFrameSideDataType'

2019-09-18 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/f_sidedata.c | 10 +- libavutil/frame.h| 10 ++ libavutil/version.h | 2 +- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/libavfilter/f_sidedata.c b/libavfilter/f_sidedata.c index 381da5a0

Re: [FFmpeg-devel] [PATCH v4 1/4] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-09-18 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Andriy Gelman > Sent: Thursday, September 19, 2019 03:32 > To: ffmpeg-devel@ffmpeg.org > Cc: Andriy Gelman > Subject: [FFmpeg-devel] [PATCH v4 1/4] hevc_mp4toannexb: Insert correct > parameter

[FFmpeg-devel] [PATCH] avformat/utils: unref packet on AVInputFormat.read_packet() failure

2019-09-18 Thread James Almer
Demuxers may have allocated a packet before encountering an error and aborting. Fixes ticket #8150 Signed-off-by: James Almer --- It may also fix other tickets as well, since i recall seeing other reports about leaks in ff_read_packet() on malformed input in the past, but i can't remember which.

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Hyun Yoo
On Thu, Sep 19, 2019 at 7:28 AM Carl Eugen Hoyos wrote: > > Am Di., 17. Sept. 2019 um 02:37 Uhr schrieb Hyun Yoo : > > > > I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 > > as external lib like libilbc, libspeex(ex. configure --enable-libg722_1) > > (https://github.com/traviscr

[FFmpeg-devel] [PATCH v1] doc/filters: add 4x4 layout example for xstack filter

2019-09-18 Thread lance . lmwang
From: Limin Wang In additon, I have added details of each input position to help understand how to write the layout parameters. Signed-off-by: Limin Wang --- doc/filters.texi | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/doc/filters.tex