On Wed, 18. Sep 22:34, Carl Eugen Hoyos wrote: > Am Mi., 18. Sept. 2019 um 21:38 Uhr schrieb Andriy Gelman > <andriy.gel...@gmail.com>: > > > > From: Andriy Gelman <andriy.gel...@gmail.com> > > > > Overwrite tests/data/fate/hevc-bsf-mp4toannexb.out in case it exists. > > --- > > tests/fate/hevc.mak | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak > > index 4f812b0834..b11e209be0 100644 > > --- a/tests/fate/hevc.mak > > +++ b/tests/fate/hevc.mak > > @@ -236,7 +236,7 @@ tests/data/hevc-mp4.mov: ffmpeg$(PROGSSUF)$(EXESUF) | > > tests/data > > > > FATE_HEVC-$(call ALLYES, HEVC_DEMUXER MOV_DEMUXER HEVC_MP4TOANNEXB_BSF > > MOV_MUXER HEVC_MUXER) += fate-hevc-bsf-mp4toannexb > > fate-hevc-bsf-mp4toannexb: tests/data/hevc-mp4.mov > > -fate-hevc-bsf-mp4toannexb: CMD = md5 -i > > $(TARGET_PATH)/tests/data/hevc-mp4.mov -c:v copy -fflags +bitexact -f hevc > > +fate-hevc-bsf-mp4toannexb: CMD = md5 -y -i > > $(TARGET_PATH)/tests/data/hevc-mp4.mov -c:v copy -fflags +bitexact -f hevc > > What is this supposed to fix / how can I reproduce this issue?
If you run fate-hevc-bsf-mp4toannexb and it fails, this leaves an output file that's not cleaned up in tests/data/fate/hevc-bsf-mp4toannexb.out. Any subsequent fate-hevc-bsf-mp4toannexb tests will always fail (even if the underlying issue is solved) because this file cannot be overwritten in the ffmpeg call. Adding -y solves this. To replicate: $ touch tests/data/fate/hevc-bsf-mp4toannexb.out $ make fate-hevc-bsf-mp4toannexb GEN tests/data/hevc-mp4.mov TEST hevc-bsf-mp4toannexb --- - 2019-09-18 17:06:23.377605151 -0400 +++ tests/data/fate/hevc-bsf-mp4toannexb 2019-09-18 17:06:23.371120950 -0400 @@ -1 +1 @@ -1873662a3af1848c37e4eb25722c8df9 +d41d8cd98f00b204e9800998ecf8427e Test hevc-bsf-mp4toannexb failed. Look at tests/data/fate/hevc-bsf-mp4toannexb.err for details. make: *** [tests/Makefile:241: fate-hevc-bsf-mp4toannexb] Error 1 > > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Andriy _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
