[FFmpeg-devel] Request for a resource

2019-08-12 Thread Abhinav Rao
Hello, everyone. I'm Abhinav Rao, a second-year undergrad from India. I have some experience in working with C and Assembly, and would like to contribute to FFmpeg. It would be great if someone could guide me to any resource(s) that would help me get acquainted with the codebase. Thank you, Abhinav

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-12 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 11 de August de 2019 22:14, Marton Balint wrote: > > > +/* For VBR we select the highest multiple of frame duration > > > which is less than 100 ms. */ > > > > Don't you think it's a good idea to use the parameter "pcr_period"

Re: [FFmpeg-devel] [PATCH V3] fate: add a case for ticket #3229

2019-08-12 Thread Thilo Borgmann
Am 12.08.19 um 08:13 schrieb Zhong Li: > Signed-off-by: Zhong Li > --- > https://patchwork.ffmpeg.org/patch/13725/ introduces a regression but not > found by fate, so add it. > Test clip produced by: > ffmpeg -i tickets/3229/bad.avi -vframes 3 -c:v copy > /fate-suite/mjpeg/mjpeg_field_order.avi

[FFmpeg-devel] [PATCHv2 1/3] avformat/avio: add avio_print_string_array and avio_print

2019-08-12 Thread Marton Balint
These functions can be used to print a variable number of strings consecutively to the IO context. Unlike av_bprintf, no temporary buffer is necessary. Signed-off-by: Marton Balint --- doc/APIchanges| 3 +++ libavformat/avio.h| 17 + libavformat/aviobuf.c | 6 ++

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/4xm: Check for end of input in decode_p_block()

2019-08-12 Thread Paul B Mahol
LGTM On Mon, Aug 12, 2019 at 2:19 AM Michael Niedermayer wrote: > Fixes: Timeout (81sec -> 0.2sec) > Fixes: > 16169/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5662570416963584 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

Re: [FFmpeg-devel] [PATCH v2] libavcodec/amfenc: Vulkan initialization support for encoder.

2019-08-12 Thread Дмитрий Овчинников
Yes, it is possible, but it is required to implement separate patch with selector dx9, dx11, vulkan. We could do it when this one is committed. I will double check with opencl interop and will comeback. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vp56: Consider the alpha start as end of the prior header

2019-08-12 Thread Peter Ross
On Sun, Aug 11, 2019 at 05:02:47PM +0200, Michael Niedermayer wrote: > On Sun, Aug 11, 2019 at 09:29:14AM +1000, Peter Ross wrote: > > On Tue, Aug 06, 2019 at 11:30:02PM +0200, Michael Niedermayer wrote: > > > Fixes: Timeout (23sec -> 71ms) > > > Fixes: > > > 15661/clusterfuzz-testcase-minimized-f

[FFmpeg-devel] [PATCH v1 2/2] FATE: add a test for freeezedetect

2019-08-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 4 + tests/ref/fate/filter-metadata-freezedetect | 251 2 files changed, 255 insertions(+) create mode 100644 tests/ref/fate/filter-metadata-freezedetect diff --git a/tests/fate

[FFmpeg-devel] [PATCH v1 1/2] avfilter/vsrc_mptestsrc: add option to set the max number frames generated for each tests

2019-08-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 3 +++ libavfilter/vsrc_mptestsrc.c | 27 +++ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index e081cdc7bc..d3d468b445 100644 --- a/doc

[FFmpeg-devel] [PATCH] avfilter: add sierpinski video source filter

2019-08-12 Thread Paul B Mahol
Hi, patch attached. 0001-avfilter-add-sierpinski-video-source.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] libavcodec/amfenc: Vulkan initialization support for encoder.

2019-08-12 Thread Timo Rothenpieler
On 12/08/2019 12:35, Дмитрий Овчинников wrote: Yes, it is possible, but it is required to implement separate patch with selector dx9, dx11, vulkan. We could do it when this one is committed. I will double check with opencl interop and will comeback. There is no standardized OpenCL/Vulkan Intero

Re: [FFmpeg-devel] [PATCH] mov: Support fake moov boxes disguised as hoov

2019-08-12 Thread Vittorio Giovara
On Thu, Aug 8, 2019 at 10:28 PM Vittorio Giovara wrote: > Some broken apps generate files that have a fake box named 'hoov' > instead of a proper 'moov' one. This is speculation but it seems like > this box contains data to be modified later (eg as file grows in size, > data gets re-written) and

Re: [FFmpeg-devel] [PATCH V1 1/2] lavf/avio: add a ffio_realloc_buf API for AVIO buffer realloc

2019-08-12 Thread myp...@gmail.com
On Sun, Aug 11, 2019 at 4:43 PM Steven Liu wrote: > > > > > 在 2019年8月8日,19:32,Jun Zhao 写道: > > > > From: tomajsjiang > > > > Add new API ffio_realloc_buf for AVIO buffer realloc. > > > > Signed-off-by: Zhongxing Jiang > > --- > > libavformat/avio_internal.h |9 + > > libavformat/avio

Re: [FFmpeg-devel] [PATCH 1/4] avformat/hashenc: use an array of hashes

2019-08-12 Thread Moritz Barsnick
On Sun, Aug 11, 2019 at 15:57:46 +0200, Nicolas George wrote: > > +c->hashes = av_malloc_array(1, sizeof(c->hashes)); > > +if (!c->hashes) > > +return AVERROR(ENOMEM); > > +res = av_hash_alloc(&c->hashes[0], c->hash_name); > > +if (res < 0) { > > +av_freep(&c->hashes

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vsrc_mptestsrc: add option to set the max number frames generated for each tests

2019-08-12 Thread Moritz Barsnick
On Mon, Aug 12, 2019 at 19:21:45 +0800, lance.lmw...@gmail.com wrote: > +Set the max number frames generated for each tests: Grammar nit: Set the maximum number of frames generated for each test (Note: - use the complete word maximum - "test", "not tests", when using "for each" singular - *o

Re: [FFmpeg-devel] [PATCH 1/4] avformat/hashenc: use an array of hashes

2019-08-12 Thread Paul B Mahol
On Mon, Aug 12, 2019 at 2:56 PM Moritz Barsnick wrote: > On Sun, Aug 11, 2019 at 15:57:46 +0200, Nicolas George wrote: > > > +c->hashes = av_malloc_array(1, sizeof(c->hashes)); > > > +if (!c->hashes) > > > +return AVERROR(ENOMEM); > > > +res = av_hash_alloc(&c->hashes[0], c->h

[FFmpeg-devel] [PATCH] libavfilter/vf_scale: Ensure scaled video is divisible by n

2019-08-12 Thread Lars Kiesow
This patch adds a new option to the scale filter which ensures that the output resolution is divisible by the given integer when used together with `force_original_aspect_ratio`. This works similar to using `-n` in the `w` and `h` options. This option respects the value set for `force_original_asp

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_scale: Ensure scaled video is divisible by n

2019-08-12 Thread Lars Kiesow
Hi Michael, > > + if (scale->force_divisible_by > 1) { > > + w = ceil(w / (float)scale->force_divisible_by) * > > scale->force_divisible_by; > > + h = ceil(h / (float)scale->force_divisible_by) * > > scale->force_divisible_by; > > you dont need float

Re: [FFmpeg-devel] [PATCH V2] Fixes compiler bug - replace vec_lvsl/vec_perm with vec_xl

2019-08-12 Thread ckerchne
How do I get someone to look at this patch? A bug exist with the gcc compilers for Power in versions 6.x and 7.x (verified with 6.3 and 7.4). It was fixed in version 8.x (verified with 8.3). I was using a Power 9 ppc64le machine for building and testing. This is to address ticket #7124. It appe

Re: [FFmpeg-devel] [PATCH V2] Fixes compiler bug - replace vec_lvsl/vec_perm with vec_xl

2019-08-12 Thread Carl Eugen Hoyos
> Am 12.08.2019 um 16:21 schrieb ckerchne : > > How do I get someone to look at this patch? > >> A bug exist with the gcc compilers for Power in versions 6.x and 7.x >> (verified with 6.3 and 7.4). It was fixed in version 8.x (verified >> with 8.3). I was using a Power 9 ppc64le machine for bui

[FFmpeg-devel] [PATCH v2 1/3] avfilter/vsrc_mptestsrc: add options to set the maximum number of frames

2019-08-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 3 +++ libavfilter/vsrc_mptestsrc.c | 29 + 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index e081cdc..902e5bf 100644 --- a/doc/fil

[FFmpeg-devel] [PATCH v2 3/3] FATE: add a test for freeezedetect

2019-08-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 4 + tests/ref/fate/filter-metadata-freezedetect | 251 2 files changed, 255 insertions(+) create mode 100644 tests/ref/fate/filter-metadata-freezedetect diff --git a/te

[FFmpeg-devel] [PATCH V3] swscale/ppc/yuv2rgb_altivec: Fixes compiler bug - replace vec_lvsl/vec_perm with vec_xl

2019-08-12 Thread ckerchne
A bug exist with the gcc compilers for Power in versions 6.x and 7.x (verified with 6.3 and 7.4). It was fixed in version 8.x (verified with 8.3). I was using a Power 9 ppc64le machine for building and testing. It appears the compiler is generating the wrong code for little endian machines for

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vsrc_mptestsrc: add option to set the max number frames generated for each tests

2019-08-12 Thread Limin Wang
On Mon, Aug 12, 2019 at 03:05:32PM +0200, Moritz Barsnick wrote: > On Mon, Aug 12, 2019 at 19:21:45 +0800, lance.lmw...@gmail.com wrote: > > +Set the max number frames generated for each tests: > > Grammar nit: > Set the maximum number of frames generated for each test > > (Note: > - use the c

[FFmpeg-devel] [PATCH v2 2/3] avfilter/vsrc_mptestsrc: simplify the code and change the type of frame

2019-08-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vsrc_mptestsrc.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/libavfilter/vsrc_mptestsrc.c b/libavfilter/vsrc_mptestsrc.c index 4a2db18..14e66fd 100644 --- a/libavfilter/vsrc_mptestsr

Re: [FFmpeg-devel] [REQUEST] ffmpeg-security subscription

2019-08-12 Thread Michael Niedermayer
Hi Paul On Mon, Aug 05, 2019 at 11:50:04AM +0200, Paul B Mahol wrote: > Hi, > > I here hereby request from lead FFmpeg entity to give me subscription to > ffmpeg-security mailing list. I am not sure who or what a "lead FFmpeg entity" is, But as iam being highlighted on IRC by you in relation t

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures

2019-08-12 Thread Juan De León
Pinging, Any other opinions? On Sat, Aug 10, 2019 at 2:22 AM Nicolas George wrote: > Lynne (12019-08-10): > > >> +typedef struct AVEncodeInfoBlock{ > > >> +/** > > >> + * Distance in luma pixels from the top-left corner of the > visible frame > > >> + * to the top-left corner of the

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/qtrle: return last frame even if unchanged

2019-08-12 Thread Michael Niedermayer
On Fri, May 31, 2019 at 10:28:15PM +0200, Marton Balint wrote: > > > On Thu, 30 May 2019, Michael Niedermayer wrote: > > >Fixes: Ticket7880 > > > >Signed-off-by: Michael Niedermayer > >--- > >libavcodec/qtrle.c| 42 +++ > >tests/ref/fate/qtrle-8bit |

[FFmpeg-devel] [PATCH 3/8] tools/target_dec_fuzzer: adjust pixel threshold for SANM, as it allows coding gigantic images on tiny input

2019-08-12 Thread Michael Niedermayer
Fixes: Timeout (13sec ->1sec) Fixes: 16122/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SANM_fuzzer-5724944247291904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH 6/8] avcodec/decode: Do not overwrite AVFrame.pkt_pos if its already set

2019-08-12 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 6c31166ec2..09a509d659 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -435,7 +435,7 @@ static int decode_si

[FFmpeg-devel] [PATCH 2/8] tools/target_dec_fuzzer: adjust pixel threshold for MSRLE, as it allows coding gigantic images on tiny input

2019-08-12 Thread Michael Niedermayer
Fixes: Timeout (12sec ->2sec) Fixes: 16125/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSRLE_fuzzer-5650846364205056 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH 1/8] avcodec/cinepak: Require 1 bit per 4x4 block as minimum input

2019-08-12 Thread Michael Niedermayer
Fixes: Timeout (12sec -> 32ms) Fixes: 16078/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5695832885559296 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cinepak.c | 3 +++

[FFmpeg-devel] [PATCH 5/8] avcodec/flicvideo: Optimize and Simplify FLI_COPY in flic_decode_frame_24BPP() by using bytestream2_get_buffer()

2019-08-12 Thread Michael Niedermayer
Fixes: Timeout (31sec -> 22sec) Fixes: 16217/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5658084189405184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/flicvideo.c | 9 +--

[FFmpeg-devel] [PATCH 7/8] avcodec/qtrle: return last frame even if unchanged

2019-08-12 Thread Michael Niedermayer
Fixes: Ticket7880 Signed-off-by: Michael Niedermayer --- libavcodec/qtrle.c| 44 +++ tests/ref/fate/qtrle-8bit | 1 + 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/libavcodec/qtrle.c b/libavcodec/qtrle.c index 2c29547e5a..ab620cdb55

[FFmpeg-devel] [PATCH 8/8] avcodec/nuv: Avoid duplicating frames

2019-08-12 Thread Michael Niedermayer
Fixes: Timeout (14sec -> 133ms) Fixes: 14843/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5661969614372864 Fixes: 16257/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5769175464673280 (35sec ->0.5sec) Found-by: continuous fuzzing process https://github.com/google/

Re: [FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: Print max_pixels and iterations at the end

2019-08-12 Thread Michael Niedermayer
On Wed, Jul 31, 2019 at 10:52:34AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 2 ++ > 1 file changed, 2 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freed

[FFmpeg-devel] [PATCH 4/8] avcodec/loco: Check left column value

2019-08-12 Thread Michael Niedermayer
Fixes: Timeout (42sec -> 379 ms) Fixes: 16323/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5679178099195904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/loco.c | 2 ++ 1 fi

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/decode: Do not overwrite AVFrame.pkt_pos if its already set

2019-08-12 Thread Vittorio Giovara
On Mon, Aug 12, 2019 at 9:19 PM Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/decode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 6c31166ec2..09a509d659 100644 > --- a/libavcodec

Re: [FFmpeg-devel] [PATCH] libavutil: AVEncodeInfo data structures

2019-08-12 Thread Michael Niedermayer
On Mon, Aug 12, 2019 at 11:25:59AM -0700, Juan De León wrote: > Pinging, > Any other opinions? About adding a reserved[128] ? i think storing the size somewhere is probably better (less memory, and not having an arbitrary limit which could theoretically be hit one day) thx [...] -- Michael

Re: [FFmpeg-devel] [PATCH] mov: Support fake moov boxes disguised as hoov

2019-08-12 Thread Michael Niedermayer
On Mon, Aug 12, 2019 at 01:46:55PM +0200, Vittorio Giovara wrote: > On Thu, Aug 8, 2019 at 10:28 PM Vittorio Giovara > wrote: > > > Some broken apps generate files that have a fake box named 'hoov' > > instead of a proper 'moov' one. This is speculation but it seems like > > this box contains dat

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-12 Thread Michael Niedermayer
On Sun, Aug 11, 2019 at 08:30:51PM +0200, Reimar Döffinger wrote: > On 08.08.2019, at 10:36, Michael Niedermayer wrote: > > > This provides an alternative to retry counters. > > Useful if there is no reasonable maximum number of iterations and > > no ordering that naturally avoids loops. > > Goi

Re: [FFmpeg-devel] Request for a resource

2019-08-12 Thread Michael Niedermayer
On Mon, Aug 12, 2019 at 12:48:51PM +0530, Abhinav Rao wrote: > Hello, everyone. I'm Abhinav Rao, a second-year undergrad from India. I > have some experience in working with C and Assembly, and would like to > contribute to FFmpeg. It would be great if someone could guide me to any > resource(s) th

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/decode: Do not overwrite AVFrame.pkt_pos if its already set

2019-08-12 Thread Michael Niedermayer
On Mon, Aug 12, 2019 at 09:21:59PM +0200, Vittorio Giovara wrote: > On Mon, Aug 12, 2019 at 9:19 PM Michael Niedermayer > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/decode.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/dec

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/qtrle: return last frame even if unchanged

2019-08-12 Thread Marton Balint
On Mon, 12 Aug 2019, Michael Niedermayer wrote: On Fri, May 31, 2019 at 10:28:15PM +0200, Marton Balint wrote: On Thu, 30 May 2019, Michael Niedermayer wrote: Fixes: Ticket7880 Signed-off-by: Michael Niedermayer --- libavcodec/qtrle.c| 42 +++

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/ffwavesynth: Fixes invalid shift with pink noise seeking

2019-08-12 Thread Nicolas George
Michael Niedermayer (12019-08-10): > Fixes: left shift of negative value -961533698048 > Fixes: > 16242/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5738550670131200 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH v2] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-12 Thread Marton Balint
On Mon, 12 Aug 2019, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/f_select.c | 3 ++- tests/ref/fate/filter-metadata-scenedetect | 16 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/libavfilter/

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-12 Thread Michael Niedermayer
On Mon, Aug 12, 2019 at 02:40:02PM +0800, Guo, Yejun wrote: > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 177 >

Re: [FFmpeg-devel] [PATCH 1/2] fftools: Use right function signature and pointers

2019-08-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The option tables of the various fftools (in particular ffprobe) are > arrays of OptionDef; said type contains a union of a pointer to void and > a function pointer of type int (*)(void *, const char *, const char *) > as well as a size_t. Some entries (namely the common entry

Re: [FFmpeg-devel] [PATCH V1 1/2] lavf/avio: add a ffio_realloc_buf API for AVIO buffer realloc

2019-08-12 Thread Steven Liu
> 在 2019年8月12日,20:29,myp...@gmail.com 写道: > > On Sun, Aug 11, 2019 at 4:43 PM Steven Liu wrote: >> >> >> >>> 在 2019年8月8日,19:32,Jun Zhao 写道: >>> >>> From: tomajsjiang >>> >>> Add new API ffio_realloc_buf for AVIO buffer realloc. >>> >>> Signed-off-by: Zhongxing Jiang >>> --- >>> libavfo

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/decode: Do not overwrite AVFrame.pkt_pos if its already set

2019-08-12 Thread James Almer
On 8/12/2019 5:31 PM, Michael Niedermayer wrote: > On Mon, Aug 12, 2019 at 09:21:59PM +0200, Vittorio Giovara wrote: >> On Mon, Aug 12, 2019 at 9:19 PM Michael Niedermayer >> wrote: >> >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/decode.c | 2 +- >>> 1 file changed, 1 insertion(

Re: [FFmpeg-devel] [PATCH V2] Fixes compiler bug - replace vec_lvsl/vec_perm with vec_xl

2019-08-12 Thread Carl Eugen Hoyos
Am Fr., 2. Aug. 2019 um 17:24 Uhr schrieb ckerchne : > > A bug exist with the gcc compilers for Power in versions 6.x and 7.x > (verified with 6.3 and 7.4). It was fixed in version 8.x (verified with > 8.3). I was using a Power 9 ppc64le machine for building and testing. > This is to address ticket

[FFmpeg-devel] [PATCH 2/2] vaapi_encode: work-around VBR driver bug in Intel Broxton/CherryView

2019-08-12 Thread Aman Gupta
From: Aman Gupta The hardware encoder on these chipsets produces very low bitrates in VBR mode if it receives VAEncMiscParameterTypeRateControl more than once. /cc intel/intel-vaapi-driver#480 Signed-off-by: Aman Gupta --- libavcodec/vaapi_encode.c | 8 +++- libavutil/hwcontext_vaapi.c

[FFmpeg-devel] [PATCH 1/2] vaapi_encode: ensure correct VBR bitrate is used in h264 SPS

2019-08-12 Thread Aman Gupta
From: Aman Gupta This is a regression from 2562dd9e7831743ba6dc5680501fb7d26a2ec62c which surfaces a pathological bug in the Intel Broxton/CherryView hardware encoders, causing very low bitrates to be generated whenever VBR mode is used. /cc intel/intel-vaapi-driver#480 Signed-off-by: Aman Gupt

Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: Fix build failures

2019-08-12 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Andreas Rheinhardt > Sent: Monday, August 12, 2019 9:15 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: Fix build failures

Re: [FFmpeg-devel] [PATCH 0/7] Import some x264asm patches from x264

2019-08-12 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Darnley > Sent: Monday, August 5, 2019 9:39 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 0/7] Import some x264asm patches from > x264 > > Here are a few easy-to-impo

[FFmpeg-devel] [PATCH v2 2/2] vaapi_encode: fix VBR mode generating low bitrates

2019-08-12 Thread Aman Gupta
From: Aman Gupta On some Intel chips, sending VAEncMiscParameterTypeRateControl multiple times causes the encoder to produce very low bitrates that do not match the requested rate controls. This is a regression as of af532c921575eb8ee805cc2c64a914f6302442e1. Prior to that global params were sent

[FFmpeg-devel] [PATCH v2 1/2] vaapi_encode: ensure correct VBR bitrate is used in h264 SPS

2019-08-12 Thread Aman Gupta
From: Aman Gupta This is a regression from 2562dd9e7831743ba6dc5680501fb7d26a2ec62c which surfaces a pathological bug in some Intel hardware encoders, causing very low bitrates to be generated whenever VBR mode is used. /cc intel/intel-vaapi-driver#480 Signed-off-by: Aman Gupta --- libavcodec

[FFmpeg-devel] [PATCH v3] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/f_select.c | 5 - tests/ref/fate/filter-metadata-scenedetect | 16 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c index 5c7372c97

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-12 Thread Reimar Döffinger
On 12.08.2019, at 21:53, Michael Niedermayer wrote: > On Sun, Aug 11, 2019 at 08:30:51PM +0200, Reimar Döffinger wrote: >> On 08.08.2019, at 10:36, Michael Niedermayer wrote: >> >>> This provides an alternative to retry counters. >>> Useful if there is no reasonable maximum number of iterations

[FFmpeg-devel] [PATCH v3] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/f_select.c | 5 - tests/ref/fate/filter-metadata-scenedetect | 16 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c index 5c7372c97

[FFmpeg-devel] [PATCH v3] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-12 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/f_select.c | 6 +- tests/ref/fate/filter-metadata-scenedetect | 16 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c index 5c7372c9

Re: [FFmpeg-devel] [PATCH v2] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-12 Thread Limin Wang
On Mon, Aug 12, 2019 at 11:03:24PM +0200, Marton Balint wrote: > > > On Mon, 12 Aug 2019, lance.lmw...@gmail.com wrote: > > >From: Limin Wang > > > >Signed-off-by: Limin Wang > >--- > >libavfilter/f_select.c | 3 ++- > >tests/ref/fate/filter-metadata-scenedetect | 16 ++

Re: [FFmpeg-devel] [PATCH v2 2/2] vaapi_encode: fix VBR mode generating low bitrates

2019-08-12 Thread Fu, Linjie
> -Original Message- > From: Aman Gupta [mailto:a...@tmm1.net] On Behalf Of Aman Gupta > Sent: Tuesday, August 13, 2019 09:05 > To: ffmpeg-devel@ffmpeg.org > Cc: s...@jkqxz.net; Fu, Linjie ; Aman Gupta > > Subject: [PATCH v2 2/2] vaapi_encode: fix VBR mode generating low bitrates > > From

[FFmpeg-devel] [PATCH 01/13] avformat/mux: Move packet references

2019-08-12 Thread Andreas Rheinhardt
In the common case that the input packet was already refcounted, ff_interleave_add_packet would allocate a new AVPacketList, use av_packet_ref to create a new reference to the buffer for the AVPacketList's packet, interleave the packet and finally unreference the original input packet. This commit

[FFmpeg-devel] [PATCH 04/13] avformat/mux: Cosmetics

2019-08-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/mux.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index 2728c62de5..4089382ffd 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -921,13 +921,13 @@ int ff_i

[FFmpeg-devel] [PATCH 03/13] avformat/mux: Use const AVPacket * in compare functions

2019-08-12 Thread Andreas Rheinhardt
There is no reason for these functions to modify the given packets at all. Signed-off-by: Andreas Rheinhardt --- libavformat/audiointerleave.c | 2 +- libavformat/audiointerleave.h | 2 +- libavformat/gxfenc.c | 5 +++-- libavformat/internal.h| 2 +- libavformat/mux.c

[FFmpeg-devel] [PATCH 11/13] avformat/mux: Fix memleaks on errors II, improve documentation

2019-08-12 Thread Andreas Rheinhardt
1. When an error happened in ff_interleave_add_packet during interleaving a packet for output, said packet would not be unreferenced in ff_interleave_add_packet, but would be zeroed in av_interleaved_write_frame, which results in a memleak. 2. When no error happened in ff_interleave_add_packet duri

[FFmpeg-devel] [PATCH 02/13] avformat/mux: Don't unnecessarily zero-initialize AVPacketList

2019-08-12 Thread Andreas Rheinhardt
If no error occurs and this AVPacketList is used at all, its packet substructure will be overwritten and its next pointer explicitly set, so every field will still be initialized even when using av_malloc. Signed-off-by: Andreas Rheinhardt --- libavformat/mux.c | 2 +- 1 file changed, 1 insertio

[FFmpeg-devel] [PATCH 05/13] avformat/mux: Only prepare input packet if there is a packet

2019-08-12 Thread Andreas Rheinhardt
It is unnecessary to call prepare_input_packet if there is no packet as it doesn't do anything, except when the currently inactive code guarded by !FF_API_COMPUTE_PKT_FIELDS2 || !FF_API_LAVF_AVCTX becomes active: Then attempting to access pkt->stream_index will crash. Signed-off-by: Andreas Rheinh

[FFmpeg-devel] [PATCH 07/13] avformat/audiointerleave: Fix memleak

2019-08-12 Thread Andreas Rheinhardt
If ff_interleave_add_packet failed, the content of the newly created packet new_pkt would leak. Also, it is unnecessary to zero-initialize a packet that will be put into av_new_packet lateron as the latter already initializes the packet. Therefore this has been removed, too. Signed-off-by: Andrea

[FFmpeg-devel] [PATCH 08/13] avformat/avformat.h: Correct some comments

2019-08-12 Thread Andreas Rheinhardt
1. When set_parameters was removed from AVOutputFormat in 2fb75019, it was forgotten to remove the comment pertaining to it. Said comment now appeared to apply to interleave_packet; it is of course nonsense and has been replaced by an accurate description. 2. The description of av_write_uncoded_fra

[FFmpeg-devel] [PATCH 09/13] avformat/mux: Don't use av_ prefix for static functions

2019-08-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/mux.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index efe2e94f40..5b67a793ac 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -1330,8 +1330,8 @@ int ff_write_chained(

Re: [FFmpeg-devel] [PATCH V3] fate: add a case for ticket #3229

2019-08-12 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Thilo Borgmann > Sent: Monday, August 12, 2019 3:55 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V3] fate: add a case for ticket #3229 > > Am 12.08.19 um 08:13 schrieb Zhong Li: > > Signed-off-by:

[FFmpeg-devel] [PATCH 13/13] avformat/mux: Remove pointless timestamp backups

2019-08-12 Thread Andreas Rheinhardt
write_packet currently saves the original timestamps of the packet it got and restores them in case writing fails. This is unnecessary as none of write_packet's callers make any use of these timestamps at all. So remove this and add a general comment to the function that timestamps may be modified;

[FFmpeg-devel] [PATCH 06/13] avformat/mux: Use av_packet_rescale_ts

2019-08-12 Thread Andreas Rheinhardt
ff_write_chained essentially duplicated the functionality of av_packet_rescale_ts. This has been changed. Signed-off-by: Andreas Rheinhardt --- libavformat/mux.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index 44ce

[FFmpeg-devel] [PATCH 10/13] avformat/mux: Fix memleaks on errors I

2019-08-12 Thread Andreas Rheinhardt
If writing an uncoded frame fails at the preparatory steps of av_[interleaved_]write_frame, the frame would be either not freed at all in case of av_write_frame or would leak when the fake packet would be unreferenced like an ordinary packet. There is also a memleak when the output format is not su

[FFmpeg-devel] [PATCH 12/13] avformat/mux: Don't modify packets we don't own

2019-08-12 Thread Andreas Rheinhardt
The documentation of av_write_frame explicitly states that the function does not take ownership of the packets sent to it; while av_write_frame does not directly unreference the packets after having written them, it nevertheless modifies the packet in various ways: 1. The timestamps might be modifi

Re: [FFmpeg-devel] [PATCH] hevc_mp4toannexb: Do not duplicate parameter sets

2019-08-12 Thread Andriy Gelman
Andreas, On Sun, 21. Jul 10:47, Andreas Rheinhardt wrote: > Andriy Gelman: > > From: Andriy Gelman > > > > Fixes #7799 > > > > Currently, the mp4toannexb filter always inserts extradata at the start > > of each IRAP unit. This can lead to duplication of parameter sets if the > > demuxed packet

[FFmpeg-devel] [PATCH 1/6] lavc/qsvdec: add function ff_qsv_map_picstruct()

2019-08-12 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/qsv.c | 18 ++ libavcodec/qsv_internal.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index 986d4f6..437ef7c 100644 --- a/libavcodec/qsv.c +++ b/libavcodec/qsv.c @@ -245,6 +245,24 @@ in

[FFmpeg-devel] [PATCH 2/6] lavc/qsv: make function qsv_map_fourcc() can be called externally

2019-08-12 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/qsv.c | 4 ++-- libavcodec/qsv_internal.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index 437ef7c..533804a 100644 --- a/libavcodec/qsv.c +++ b/libavcodec/qsv.c @@ -207,7 +207,7 @@ int

[FFmpeg-devel] [PATCH 3/6] lavc/qsvdec: Replace current parser with MFXVideoDECODE_DecodeHeader()

2019-08-12 Thread Zhong Li
Using MSDK parser can improve qsv decoder pass rate in some cases (E.g: sps declares a wrong level_idc, smaller than it should be). And it is necessary for adding new qsv decoders such as MJPEG and VP9 since current parser can't provide enough information. Actually using MFXVideoDECODE_DecodeHeader

[FFmpeg-devel] [PATCH 6/6] lavc/qsvdec: Add VP9 decoder support

2019-08-12 Thread Zhong Li
VP9 decoder is support on Intel kabyLake+ platforms with MSDK Version 1.19+ Signed-off-by: Zhong Li --- Changelog | 1 + configure | 1 + libavcodec/allcodecs.c| 1 + libavcodec/qsv.c | 5 + libavcodec/qsvdec_other.c | 46 +

[FFmpeg-devel] [PATCH 5/6] lavc/qsvdec: Add mjpeg decoder support

2019-08-12 Thread Zhong Li
Signed-off-by: Zhong Li --- Changelog | 3 +++ configure | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/qsvdec_other.c | 28 +++- 5 files changed, 33 insertions(+), 1 deletion(-) diff --git a/Changel

[FFmpeg-devel] [PATCH 4/6] lavc/qsvdec: remove orignal parser code since not needed now

2019-08-12 Thread Zhong Li
Signed-off-by: Zhong Li --- configure | 10 +- libavcodec/qsvdec.c | 28 +--- libavcodec/qsvdec.h | 3 --- 3 files changed, 6 insertions(+), 35 deletions(-) diff --git a/configure b/configure index 3fb8f35..ddaaf80 100755 --- a/configure +++ b/configure

Re: [FFmpeg-devel] [PATCH] hevc_mp4toannexb: Do not duplicate parameter sets

2019-08-12 Thread Andreas Rheinhardt
Andriy Gelman: > Andreas, > > On Sun, 21. Jul 10:47, Andreas Rheinhardt wrote: >> Andriy Gelman: >>> From: Andriy Gelman >>> >>> Fixes #7799 >>> >>> Currently, the mp4toannexb filter always inserts extradata at the start >>> of each IRAP unit. This can lead to duplication of parameter sets if the

[FFmpeg-devel] avcodec/videotoolboxenc: fix encoding frame crash on iOS 11

2019-08-12 Thread sharpbai
On iOS 11, encoding a frame may return error with log "Error encoding frame 0", which means vtenc_output_callback is called with status=0 and sample_buffer=NULL. Then the encoding session will be crashed on next callback wether or not closing the codec context. Let us look through the link below i

[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: fix encoding frame crash on iOS 11

2019-08-12 Thread sharpbai
On iOS 11, encoding a frame may return error with log "Error encoding frame 0", which means vtenc_output_callback is called with status=0 and sample_buffer=NULL. Then the encoding session will be crashed on next callback wether or not closing the codec context. Let us look through the link below i